Commit Graph

80509 Commits

Author SHA1 Message Date
hjk
20400b263e ProjectExplorer: Code cosmetics
Namespaces, white space in jsonwizard.

Change-Id: I92f724d170380cb27f478a7e43d2ea9e6b35c03b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-08-23 15:19:08 +00:00
Christian Stenger
275f2a3db8 Tests: Do not use config mode when searching for Eigen3
Change-Id: I144481821267b80404473d821ac1048ff3adeac3
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-08-23 13:54:07 +00:00
Christian Kandeler
ca00b874a7 CPlusPlus: Support structured bindings
While we do recommend clangd for modern code bases, we should still be
able to parse basic language constructs.

Fixes: QTCREATORBUG-27975
Change-Id: I189b991685a5cd5f62f2afce77878b60c895e8f9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-08-23 13:52:11 +00:00
Cristian Adam
9102452272 clangd: Use QtC system environment for environment variables
Users would set QTC_CLANGD_COMPLETION_RESULTS in the Qt Creator
system environment variable dialog and expect that clangd would
the be configured with the corresponding --limit-results value.

Task-number: QTCREATORBUG-28071
Change-Id: Ia7a9b6a96fabe7ba16906c547a15716f0b83f0ec
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-08-23 13:41:11 +00:00
Marcus Tillmanns
5fab54d95a SSH Device: Add SSH port to Device wizard
Change-Id: Ia4cc3b7bb0074930f32d58393651f6c961c69b28
Reviewed-by: hjk <hjk@qt.io>
2022-08-23 10:55:37 +00:00
Marcus Tillmanns
42e1714ea1 debugger: Fix dumper for std::string and unordered_multiset
Moves mac specific dumpers to separate file
Creates android dumpers for stdtypes

Change-Id: I33d28198e1a2f24fb7707313845db81e283686cd
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-08-23 10:49:43 +00:00
Thomas Hartmann
6a3933c87a StudioWelcome: Fix QTC_ASSERT
Deleting QtcProcess instance directly from
one of its signal handlers will lead to crash!

I cannot confirm this crash actually happened, but we should play save
and delete the archive from the event loop.

Change-Id: Ie27291c9ac8b300478ed8396d25a76b343f238be
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-08-23 10:35:10 +00:00
Marco Bubke
84c1d6572b Utils: Remove variant.h
Since we are now requiring macOS 10.14 we can remove our local copy of
std::variant and use for macOS std::variant too.

Change-Id: I589d03b35fc56878b7392ffa7047a439e588fe43
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-08-23 09:51:43 +00:00
Artem Sokolovskii
17693bc415 ClangFormat: Fix list declaration
Fixed list declaration indentation.
Fixed function declaration with parameters on the new line.
Added tests for both cases.

Fixes: QTCREATORBUG-25011
Change-Id: Ida4f6ec4f407c5e5b015dc2c0afff110262d9645
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-08-23 09:07:59 +00:00
Christian Kandeler
5817bdf87d CppEditor: Consider selection when requesting quickfixes
If the user has a token selected, prefer that to the actual cursor
position.

Fixes: QTCREATORBUG-27886
Change-Id: Ib32e24676510bff42292fe23e4962720fcbac4ed
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-08-23 08:37:07 +00:00
Thomas Hartmann
4bfdf9fc46 QmlDesigner: Do not assume that the active state group is the root node
Change-Id: Ifd315a7e1d8c833f612e305127911634174a8e5b
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2022-08-23 08:01:07 +00:00
Thomas Hartmann
1fa2af4c87 QmlDesigner: use stateGroup() instead of hard coding the root node
Change-Id: I502c51f252fb8584c36a2bbd31faa7a130d19f5e
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2022-08-23 08:00:59 +00:00
Thomas Hartmann
3682ff76d2 QmlDesigner: Do not require visual node for states
StateGroup is no visual node.

Change-Id: Ia0ff297efe2b73f42eb24e193d8e832250d77237
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2022-08-23 08:00:51 +00:00
Thomas Hartmann
179713ed5c QmlDesigner: Use QmlObjectNode instead of QmlVisualNode
StateGroups are no visual items.

Change-Id: Ia081c303aea6c79c750b44388a81f4b10cc1837d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2022-08-23 08:00:35 +00:00
Thomas Hartmann
f4c6bf0179 QmlDesigner: Move QmlVisualNode::states to QmlObjectNode
This is required for StateGroup support.

Change-Id: I25d8f94c2a0fa9140ce8af3032bc92a7b858b9d8
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2022-08-23 08:00:28 +00:00
Christian Stenger
56638b69a8 Fix compile
Change-Id: I462623e1bee638f7544ec0d7ff91343059cc321e
Reviewed-by: hjk <hjk@qt.io>
2022-08-23 07:43:39 +00:00
Leena Miettinen
bddac59a95 Doc: Fix arguments to start debugging Qt Quick applications
A dash was missing.

Fixes: QTCREATORBUG-28093
Change-Id: Ic7fbf8fda8d23fdc1eabf98b53240824a24aacc5
Reviewed-by: hjk <hjk@qt.io>
2022-08-23 07:14:22 +00:00
Leena Miettinen
cd87abf3fa Doc: Add commas and fix style issues
Change-Id: I10d1e11c5981704b5ae5e7690f3df036af9873b3
Reviewed-by: hjk <hjk@qt.io>
2022-08-23 07:14:08 +00:00
Christian Stenger
635865dac4 QmlDesigner: Fix compile
Change-Id: Iab57aa9b78c73773ccdb66490ff2536b2a5465fd
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-08-23 06:27:46 +00:00
Christian Stenger
13a9f6663b ResourceEditor: Fix include and Qbs build
Amends bc19a26c06.

Change-Id: I1c370c982cbb9e4b5aa7887043d097b1cce76d5e
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-08-23 05:09:35 +00:00
Alessandro Portale
d0f134aa49 Help: inline .ui files
bookmarkdialog.ui
topicchooser.ui

Change-Id: Ic5c36db648a56546ecf12ce2cb31a593732e7990
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-08-22 19:49:58 +00:00
David Schulz
95a278760a Doc: update remote CDB setup instructions
Mention the dependencies of the cdbextension and instruct to copy the
full folder instead of just the dll.

Fixes: QTCREATORBUG-27914
Change-Id: If14d331af66437bc8723fc16fc72354cccd4e0d6
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-08-22 18:13:48 +00:00
Piotr Mućko
fe9de4e205 McuSupport: Evaluate cmake variables in paths
Change-Id: I04dd77bd5420e57903afe281e6e2601782795909
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-08-22 17:36:18 +00:00
Piotr Mućko
e31016ccc3 McuSupport: Move global toolchain type mapping to function
Change-Id: Ibe11c574d3427fa7f38f1e4df30400ec3d11294b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-08-22 17:35:59 +00:00
hjk
bc19a26c06 ResourceEditor: Convert to using Tr::tr
Change-Id: Ia9a04dc76bf84e9e9078894be3459fe65fcd5fff
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-08-22 16:05:33 +00:00
Alessandro Portale
708df011b4 ResourceEditor: inline qrceditor.ui
Change-Id: Ie8ec4a7c333287c1ad6e94691ca2d988547d419c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-08-22 14:33:35 +00:00
Knud Dollereder
aea64ca1fa Add zoom slider to the curve editors toolbar
Removed the "Set Default" button from the toolbar since
it does the same as the "linear interpolation" button
and space is rare in the toolbar.

Fixes: QDS-6951
Change-Id: Ifdbf20af2e5365e9bf9b592783b872394cabb7eb
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Aleksei German <aleksei.german@qt.io>
2022-08-22 14:31:08 +00:00
Marcus Tillmanns
62bb8b9686 CppEditorOutline: Fix warning
Change-Id: I7b3d212fb2b8c8a2b9f6af9a5445ac48e6e51b9c
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-08-22 13:52:23 +00:00
Ivan Komissarov
395e0560d4 Update qbs submodule to HEAD of 1.23 branch
Change-Id: I053b24ae7b03226de7bf1ffaf9d5424f123c620e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-08-22 13:46:38 +00:00
hjk
3c9aa364ec Utils: Make LayoutBuilder::Setter a LayoutItem
Weird, but makes GroupBox implementation less special and allows
several setters without resorting to using extra {...} there,
which would be needed e.g. for title _and_ toolTip.

Change-Id: Ie0e64a7bae15825292a473a1e973817be5c27fc4
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-08-22 13:32:01 +00:00
hjk
11648298c8 Utils: Port some FilePath part accessors to QStringView
Change-Id: Ib5cc262e44c73880b6538eed714365e3d685870a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-08-22 13:27:56 +00:00
hjk
66a9301bd9 Move changes-8.0.1.md closer to its siblings
Change-Id: Iae9ce187c600032bfd5f4daf84079b63ea8ac184
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-08-22 13:27:38 +00:00
Mahmoud Badri
fc4ebb0cab QmlDesigner: Create a context menu for the 3D Editor
For now only 1 action is implemented (edit material), more actions are
coming next.

Task-number: QDS-7414
Task-number: QDS-7398
Change-Id: Id8e36c23d9a4d35ee94d55d3d6b15df78241a05d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-08-22 13:26:18 +00:00
hjk
266adf7b1d Debugger: Delay template argument retrieval from native types
For performance reasons. They are often not needed.

Change-Id: I8a7bb03583b3ec2479a3691486c9c02f70ad014e
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-08-22 13:26:02 +00:00
Mahmoud Badri
86d1526564 QmlDesigner: Fix propertyGroups.json warning for 2D projects
Load property groups file only if Quick3D import exists

Change-Id: Idf7b95cb4efa34dde6196964e5e2cbad54341193
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-08-22 13:23:27 +00:00
Christian Stenger
cd071e299a Debugger: Export BreakpointManager and some icons
Allow retrieving of breakpoint information without
the need to create a debugger engine.
Export some icons for re-use.

Change-Id: Ic3d5f22840c1b67e8b3e4e0892c204da3ab1af9e
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-08-22 12:25:32 +00:00
Marcus Tillmanns
7e37899565 Dumper-tests: Adds Logging Category for easy debug msg suppression
Change-Id: Ic871558f7ef82489030e574e8997277221e0b63d
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-08-22 11:26:39 +00:00
Christian Stenger
3b73b27862 ScxmlEditor: Fix build with Qt5
Change-Id: I09609ac62604885f7800088619cbe1f4ea510d83
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-08-22 11:17:56 +00:00
Jarek Kobus
71f0597e49 ClangFormatConfigWidget: Avoid using sender()
Use Utils::Guard instead of Utils::ExecuteOnDestruction.

Change-Id: I7f2be9c3864d9cac31423353d46dfa98660dd0af
Reviewed-by: hjk <hjk@qt.io>
2022-08-22 10:11:01 +00:00
hjk
70089a8701 QmlDesigner: Fix compile fix
Amends 82a010f67a.

Turns out that 04dc959d49e5e3 in Qt 6.4 introduces a source
incompatibility intentionally.

Use 'auto' to cover old and new behavior.

Change-Id: I4cf69393e0c1a483261b3f283b6bce97f664e3ce
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-08-22 09:26:24 +00:00
Jarek Kobus
c30a695784 Drop Qt5: AdvancedDockingSystem: Remove code below Qt 6.0.0
Change-Id: If2ebc32c8057d1f614fd8d3749be97c923453585
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-08-22 08:59:30 +00:00
Jarek Kobus
024dbd18b6 DockWidget: Avoid using sender()
The toggleView() was used as a signal handler for
m_toggleViewAction and as a public method. In the latter
case checking the sender doesn't make any sense.
Add a lambda as a direct signal handler for m_toggleViewAction
and perform a custom modification of the open arg before
calling toggleView().

Simplify setToggleViewActionChecked() implementation.

Change-Id: If3799110b3f1dcf6fe0c653ebcfd23f9716cb2f3
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-08-22 08:59:23 +00:00
Eike Ziller
765f632b29 StudioWelcome: Move plugin to "Utilities" category
People regularly report that they somehow got this plugin enabled in Qt
Creator, and one reason could be that they just enabled all plugins in
the "Qt Quick" category (e.g. by clicking the checkbox for that
category). Separate this plugin from the group.

Task-number: QDS-7449
Change-Id: I0a6e7ee7bc1a59cb2cd2fc28bc037fc62e184315
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-08-22 08:17:15 +00:00
Eike Ziller
60f2945f08 FilePath: Remove unused include
Change-Id: I0ad971a65d25bcecf19c2094225f7f95f9121385
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-08-22 08:16:37 +00:00
hjk
82a010f67a QmlDesigner: Compile fix
Amends 2d86c290ce.

Change-Id: I26fc5871193b600ed4576b14dd1aa141140f30d0
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-08-22 08:16:17 +00:00
Eike Ziller
74a986b350 FileUtils: Fix sdktool build against 5.15
Change-Id: Ieb9cc8baa684008a5ad1db28648870715f8db0d7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-08-22 08:11:01 +00:00
Jarek Kobus
5e6ad51e97 ScxmlEditor: Fix a crash when closing scxml editor
Don't iterate on m_overlappedItems inside d'tor, as every
iteration calls removeOverlappingItem() and it modifies
the container being iterated. Do the same for m_outputTransitions
and m_inputTransitions.

Amends 8b444f88eb

Fixes: QTCREATORBUG-28027
Change-Id: I78fe67b5ea584c969e4850a2db3f00d981296865
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-08-22 08:03:43 +00:00
hjk
c02af3dd0e Utils: Introduce a Layouting::WithFormAlignment AttachType
Useful for layouts that should appear as forms but are using
QGridLayout for further alignment in the fields as e.g.
the Kit settings does.

Change-Id: Iec3195b1528dfe052eed5a34379a946db6bf8e54
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-08-22 07:18:22 +00:00
Christian Stenger
c490ffacd7 QmlDesigner: Fix compile
Change-Id: I247fe6b962f0b67055e797189626752d51484b71
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-08-22 05:22:13 +00:00
David Schulz
8031460734 LanguageClient: avoid creating a QTextDocument for every contents change
clone the document when it is opened and adjust it after each contents
change

Change-Id: I4fd511a3b142b1875f1da7d241ab5cddf49322e8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-08-22 04:38:08 +00:00