Commit Graph

80509 Commits

Author SHA1 Message Date
hjk
824de3046c CppCheck: Rework settings handling
Change-Id: Id9c9b316c5e0d39bc5fcba14951664e72d947a71
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-05-16 16:03:37 +00:00
hjk
77c19ae213 Utils: Add minimal Flow layout support to layout builder
It will be used in the CppCheck option page.

The de-facto copy of utils/flowlayout.{cpp,h} is intentional
to keep the layout builder usable stand-alone.

Change-Id: Ibda3ece2aeb3cbb1badaf6083b52ebb63b6524ac
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-05-16 15:03:41 +00:00
Marcus Tillmanns
7e5ba6c993 Terminal: Fix CellIterator again
The updateChar() was only called when m_pos == 0. It needs to be called
unless m_state == End though.

Change-Id: I2c9a7c151420395d18f2846705d57129d7afc5f3
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-05-16 13:37:20 +00:00
hjk
671621d79b Utils: Introduce a FilePathAspect
A shallow wrapper around a StringAspect with a suitable operator().

Change-Id: I0a5e121565d03573faa5c3f4085d72db2b9c3774
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-05-16 12:59:44 +00:00
Cristian Adam
1e595c6afe Terminal: Fix exiting of conpty terminals
QMetaObject would complain about not knowing about the HANDLE type.

Change-Id: Iae240bed37c892561eaacdc1d22cf4ae0173df29
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-05-16 12:57:07 +00:00
hjk
d6111f2e1d ProjectExplorer: Remove some pointerage around KitOptionsPage
Change-Id: Ib1736a80739c6052372896bac03aa324fd807151
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-05-16 12:45:24 +00:00
Marcus Tillmanns
3416ccd7ec Terminal: Fix selection
When moving the mouse left or right out of the viewport
the selection would grow into the previous/next line
without the bounding.

Change-Id: Ica38eac3b306338ef24aa4abace66f110edb2aef
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-05-16 11:50:18 +00:00
hjk
22fa5f2d3a Haskell: More compact settings/manager setup
Use PagedSettings, move related parts Manager interface there, too.

Change-Id: I079dad8bbbea39d2424a25867b08c34ab0234ad5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-05-16 11:19:14 +00:00
hjk
21cb45e665 App: Remove workaround for crash in regexp jitting in Rosetta
The relevant Qt bug was fixed upstream.

This effectively reverts ab16f2984b

Task-number: QTBUG-97085
Change-Id: I2ccf50f83b42111bbeaa26dfd95b1eb69a62c3bf
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-05-16 11:08:26 +00:00
Christian Stenger
39f27a8eb8 Squish: Fix layout of server settings dialog
Broke with the overhaul of the layout builder.

Change-Id: I94da9c8f6b2a67b43b8bfe08e838dbd38400c2f4
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-05-16 10:53:56 +00:00
hjk
b91f234c7d ExtensionSystem: Start reworking initialization order system
Allow specifying object creation without immediate creation
(but create them nevetheless very soon).

Change-Id: I01b91f7cf753ced61705d3f26352548b268be6b5
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-05-16 10:51:14 +00:00
Christian Kandeler
7869c4e810 CppEditor: Add quickfix for creating a member function from use
Fixes: QTCREATORBUG-10356
Change-Id: If7376e766f2817949259591560c74bd6fb0e0cd6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-05-16 10:32:04 +00:00
David Schulz
9758e71458 Utils: add tests for Position::fromPositionInDocument
Change-Id: I2b530cf62a4defe0292c51834b1e5093a7d5e55f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-05-16 10:30:15 +00:00
Jarek Kobus
00d8e9d717 SpotlightLocatorFilter: Remove no-op call to setConfigurable(true)
Change-Id: Iafc9b1f3f7e0e5e214b44ab29bbd2537a0bbb569
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-05-16 10:12:24 +00:00
Jarek Kobus
b8a56abb22 LocatorWidget: Drop Utils namespace qualifier
Change-Id: Ife0fb3a5908326136531801c6d8e372ed10827a4
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-05-16 10:11:34 +00:00
Orgad Shaneh
1512aaa0cd Build: Avoid passing unsupported flag to MSVC linker
Change-Id: Ia73aeccb824bca10ce928cb82d5ad77033521527
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-05-16 09:45:46 +00:00
Christian Stenger
2bf5cc81b5 Haskell: Build with Qbs as well
Change-Id: Ia8f9fd3c22acc50c149594859a0471b0e58fc027
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-05-16 09:25:37 +00:00
David Schulz
479d7e3732 Utils: remove duplicated test
Change-Id: I0391feb848af09295afd9d3e84e25337023c24b6
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-05-16 08:55:21 +00:00
Marco Bubke
8b2d7977ca Utils: Make CTAD work with std::unexpected
Aliases are not working with CTAD before C++ 20. Instead of aliasing
some types we simply importing the namespace tl into the namespace
Utils. This enables some not aliased things too.

Change-Id: Ic61a50bedbbf7253ecb5bb1f6dc0624dcc704aa0
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-05-16 08:45:43 +00:00
Jarek Kobus
4195b4e7e2 ILocatorFilter: Remove calls to setDefaultIncludedByDefault(false)
By default, setDefaultIncludedByDefault() is set to false, so
no need to repeat it now in direct subclasses.
Leave it only inside the AllProjectFilesFilter,
as the DirectoryFilter superclass sets it to true.

Change-Id: Ib66d112a3bfeed52315663f6898148cf5c5d88b1
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-05-16 08:34:02 +00:00
Jarek Kobus
c8c48d899f Locator: Fix style and reuse LocatorFilterEntries
Fix names of private members of LocatorModel to have
one common style.

Reuse LocatorFilterEntries where possible.

Change-Id: Icca1e396b9fafd165adf35939dd7859032f90c0c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-05-16 08:33:36 +00:00
Jarek Kobus
23f7352834 ILocatorFilter: Remove prepareSearch() and matchesFor()
Implement matchers() instead.
Make matchers() a pure virtual method.

Change-Id: I931cb9a5787bc796968cd2123e14d33002169588
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-05-16 08:32:39 +00:00
David Schulz
b4734ff727 Utils: add tests for Position::fromFileName
Change-Id: I321b91567e47e08883c7b991cd24d02bb8a9b9c6
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-05-16 08:24:28 +00:00
Jarek Kobus
e2df60abc2 BaseFileFilter: Remove me - I'm not needed anymore
Change-Id: I19effcb846f57838b47352c19aec0d521e1c3ecd
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-05-16 08:13:02 +00:00
hjk
318ac76339 QMakeProject: Use PagedSettings page for options
Also adapt to a few recent usage changes.

Change-Id: I33f45fe7c2b8738280a7c81ddb9110cb8714c45a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-05-16 08:10:08 +00:00
Jarek Kobus
bc11440256 RunConfigurationFilter: Remove the old matchesFor() implementation
Since the base class vanished, rename the filters so that they have
the common prefix now.

Change-Id: I21c8d1f3ea3c3ad22063d7db8be72e66d449e701
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-05-16 07:57:06 +00:00
Jarek Kobus
ef0cc8a1d9 ExecuteFilter: Remove the old matchesFor() implementation
Change-Id: Ib1f001f366ef78f359d7c04cf8861ae59b9d22a9
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-05-16 07:56:54 +00:00
Eike Ziller
8bd5c67ea8 German translation: CVS
Change-Id: Iac295e700edf365b06b01bbb3a20c2f2f190a5ab
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
2023-05-16 07:17:50 +00:00
Marcus Tillmanns
a3e9fc37ba Terminal: Fix assert
Trying to fetch a cell outside the valid range did trigger an
assert.

Change-Id: I5ac3d78aa2249d1559e7603c9e4a9bcea4d0b563
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-05-16 05:01:49 +00:00
Cristian Adam
9ff0cf7306 CMakePM: Add action to reload CMake Presets
The CMake presets will be reloaded. The preset kits will get the CMake
configuration cleared (no more CMakeCache.txt)

All the kits will be removed from the project, so that the Kit
configuration wizard will be displayed at the end.

If a normal Qt Kit was configured, the user will get the chance to
import the existing configuration (the initial configuration will be
lost though).

Change-Id: Ieda83098d7716913d7870b67ab522705da4ed93b
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2023-05-15 15:13:23 +00:00
Robert Löhning
e719a2b47a SquishTests: Update tst_create_proj_wizard
Change-Id: Id17f5d1a68da7fe7c9f45dc5b62ab3fe1039f753
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-05-15 14:13:41 +00:00
Robert Löhning
0b241f42f1 SquishTests: Make suite_tools Python3 compatible
Except for tst_designer_edit which needs a bigger update.

Change-Id: I8300a9491ec34b4d8deeed39f02fc59281cc20c9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-05-15 14:12:17 +00:00
Robert Löhning
a820b5490c SquishTests: Fix using invalid paste IDs
Change-Id: Ibc48506ff1632cbfe8d662cd00ed057af7d16a6a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-05-15 14:12:01 +00:00
hjk
ce7ee677d8 Vcs: Use PagedSettings for all plugin settings
Hopefully the last structural change for a while.

Settings lifetime is again tied to the plugin private.

Change-Id: I221e8b8baa69422306191b48a9f034ef5b1a0dc2
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-05-15 13:11:05 +00:00
hjk
1697ff8748 Mercurial: Follow the Fossil settings setup
Change-Id: I3261669991d55c6da5c80c116c2a66c8b7b0d577
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-05-15 13:10:34 +00:00
hjk
8bdb528f86 Cvs: Follow the Fossil settings setup
Change-Id: I3cd949fa8dad71531c54392de0402783fb314c19
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-05-15 13:10:25 +00:00
hjk
d301ddabc7 Subversion: Follow the Fossil settings setup
Change-Id: I967396073abbcbc3058a016d5d37fa3fc5645f8a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-05-15 13:10:13 +00:00
hjk
f6c995cdd0 Bazaar: Follow the Fossil settings setup
Change-Id: If711f8a43a6579c72cad1bc98ef24c3fdd83993b
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-05-15 13:09:58 +00:00
hjk
545a105634 Git: Also use the latest settings setup approach
Change-Id: I34a210575d02d18927c1e0f6d8ea6cb9924c563d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-05-15 13:09:47 +00:00
Marcus Tillmanns
c82d7ccdcd Utils: Delay close signal in pty process
The close signal of the conpty process needs to be delayed
as it otherwise might arrive before the last output of
the process.

This should be fixed in the future by using overlapped io
for the pipes.

Change-Id: I49fe4863672a0b14f5766bbe5ee7b1d8894594ca
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-05-15 12:12:20 +00:00
hjk
9dad4ab9d4 CMakeProjectManager: Rework CMakeFormatter
Use PagedSettings, make setup more local, remove Q_OBJECT

Change-Id: I9e91f9e63ed8ad15749323bd039d118562dba1a6
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-05-15 11:21:45 +00:00
Jarek Kobus
72d9decb87 QEventLoop: Remove unused includes
Change-Id: Ic278aa9b204a3caa17e38125d07a0176a8281422
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-05-15 10:35:29 +00:00
Artem Sokolovskii
948dc6b37e ClangFormat: Fix clangformat ignores configuration file
Fixes: QTCREATORBUG-29145
Change-Id: I6950151aaab9df51cfdd0af0ad9cf3c7b35c0636
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-05-15 10:08:38 +00:00
Marcus Tillmanns
c158921af3 ProjectExplorer: Don't allow remote run in terminal
Currently the process stub does not support starting / debugging
processes on remote devices. To reflect this the "Run In Terminal"
aspect is disabled for remote targets.

Fixes: QTCREATORBUG-29058
Change-Id: I9b3bcd65d4db468c683f2743a49227bfbecaf3d3
Reviewed-by: hjk <hjk@qt.io>
2023-05-15 10:05:54 +00:00
hjk
12f788179e Fossil: Make settings more directly accessible
I am still not sure how the final pattern may ideally look like
but it looks like some kind of singleton access to a plugin's
settings helps with clarity.

Change-Id: I6a6a5f5b7cfdfb062f5b5231a79086f34e09487f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-05-15 10:05:52 +00:00
hjk
ef4fa870fc Fossil: Make operator== fro RepositorySettings a hidden friend
Change-Id: I82091ddec03ea10ef0fbd5ec2767a8219a2a3a76
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-05-15 09:54:50 +00:00
hjk
e6d574ee77 Fossil: Consolidate optionpage/apply further
Change-Id: I345c6f38421864630d99a45fd2176ba0836536e9
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-05-15 09:54:44 +00:00
David Schulz
fe74e6d43b FakeVim: only block suggestion when fakevim is in use
This fixes the issue that no copilot suggestion were shown after
switching documents.

Change-Id: Ic81bfbe266877964eeaf688d9915a7937607118b
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-05-15 09:28:40 +00:00
Christian Kandeler
63b2934a62 ProjectExplorer: Do not override application cursor in TaskView
Change-Id: Ia8c332ee4d736c74fd773ecc5aecf8ee1c8345df
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-05-15 09:16:04 +00:00
Eike Ziller
c6a69023c9 German translation: VcsBase
Change-Id: I7b9dc7a2e6868481ab900b56acce2a084b203bd9
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
2023-05-15 08:52:23 +00:00