It is specifically PureActionInterface pointer that is getting deleted,
and it is subclassed, so its destructor needs to virtual for delete to
work properly.
Fixes: QDS-9221
Change-Id: Iba3b9d944de521d7e115b0d85f5a0f107b703fc1
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
A "locking" mechanism was implemented to prevent multiple textures from
being downloaded at the same time. However, there was a mistake made,
which made it so that when a texture that had already been downloaded
was clicked again, this locking would be enforced and not released.
Also, fixed minor issues:
* The download button now has a black outline, so as to better
distinguish it inside black-and-white textures
* Canceling the download of a texture no longer marks the download as
failed -- it should show it as if the download was never attempted.
* Fixed tooltips not showing the texture size for downloaded textures
- and now we also update the tooltip text after the real texture has been
downloaded.
* Always creating the "target path" in the FileExtractor, if it does not
exist -- this is different from the "target folder" name, which is an
folder that can optionally be created inside this "target path"
Task-number: QDS-8664
Change-Id: Ieac0e81a5595a8bff3d1aa7ff6252e16c2509c2e
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
The cancel button of the search result widget gets visible when a search
is currently ongoing in other states it is hidden. Showing and hiding
the cancel button changes the height of the replace tool bar. In the
case of clangd a search is started whenever the replacement text changes
to update the results. So if the results are received shortly after
requesting them the cancel button is only shown briefly resulting in the
flickering. Avoid this by setting a fixed minimum height to the label
containing the cancel button.
Change-Id: I6fb7a4cfe256c7612a902be621fa9ad971681ee7
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This way one can do certain things knowing that CMake is being run in Qt
Creator.
Change-Id: If3ac8a52f30f9fa73a756212199a25632c757dcd
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Adding the data as pointers allow casting the data to the actual derived
class
Change-Id: Id1b421c2729c6da8bf17054e39b4f1e8d8ff2cfa
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Separate command and argurments with a space in the log output.
Change-Id: Iaa486ce668ed268cb2a85e1267ca54aa42b07c20
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
...for cdb when we have no nativeValue. This is the case whenever we
have a container like std::vector, QList or a c array to the base class.
Fixes: QTCREATORBUG-28337
Change-Id: I18c63dfbc207d76bf41d85d5da83f7f4603504f9
Reviewed-by: hjk <hjk@qt.io>
Task-number: QTCREATORBUG-28721
Change-Id: I18aa6a624038543fd7a2e9b78e4678dd617cffce
Reviewed-by: Philip Van Hoof <philip@codeminded.be>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Item orders for 3D toolbar is modified
* ParticleSeeker is available as an action, and also an Edit3DAction
Task-number: QDS-9082
Change-Id: I210feaa416934c3e287a1a177720db69138ffab3
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Otherwise, launching with "-noload all -load QmlDesigner" fails.
Change-Id: Icae219fd90aad799257384bccc4bb4ab60cf5e2a
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
The min-width does not play nicely in all cases.
Change-Id: Ic60d602aee02ea7e924ebed9b43d753665028c3a
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Qt::SplashScreen prevents the widget from getting any keyboard focus.
Using TextEdit for neutral styling.
Change-Id: I56b9a3ac10d68aebdef4064fed4dd2e31bf82b8e
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Do not rebuild the complete list of editors every time anything changes.
Handle the incremental update via the DocumentModel::model() signals
(while ignoring the "<no document>" item at the top).
Fix a bug that DocumentModel sent a dataChanged signal from
disambiguateDisplayNames for an index before the corresponding
rowsInserted signal was sent (by endInsertRows).
Change-Id: If9c02fef94e9c744b859db7a07c8464c4e06a73b
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Also refactored Asset class a bit to optimize cases where multiple type
checks are done against same asset by resolving type at constructor
instead of on demand. Pretty much all cases where Asset instance
is needed also require resolving the type, so this makes sense.
Refactored the remaining cases to not create Asset instance
unnecessarily.
Fixes: QDS-9128
Change-Id: If9d518c9dcfcc70962e5d4e9881889c6ac243c97
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
The dmg size for QtDesignStudio can be much bigger
then the default size which is enough for QtCreator.
Change-Id: I2a7cbe01ca05fc32bb3b6b5a82c1670f9703ae50
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Using QtConcurrent API.
Adapt asynctask tests according to new API.
The old API in going to be removed, soon.
Change-Id: I3cf163e9492526f0b49bd162c27e6c55a98ace7a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
We already had some bugs because warnings were ignored. So we generate
errors now for the qml desinger plugins.
Task-number: QDS-9135
Change-Id: I9276a1b5cdbec554bc33c0c6ed3706817518f39c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
* Add padding on the left to account for close button.
* Set minimum size of 80px for tab
* Use different colors for hover
Change-Id: I87dd98aa939c85278bd2312de50117f1f32fb274
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
