Commit Graph

80509 Commits

Author SHA1 Message Date
Alessandro Portale
4d8a18c07d ProjectExplorer: Fix build
Change-Id: I0f74162cf52173b26e06082ace4b55e68e18ea49
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-08 08:43:30 +00:00
Marco Bubke
ff3d4b44f1 QmlDesigner: Use Qt6_VERSION instead of Qt5_VERSION
Change-Id: I346f5d256468696076299f964022c0a2ec2d190d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-02-08 08:42:47 +00:00
David Schulz
c651a1e290 ClangTools: remove arrow from analyze current file button
This is now in line with the other menu buttons in the editor toolbar
like the language client button or the python interpreter and repl
buttons.

Change-Id: If22d3e9c87274eee2fefe8e30f6b0648be5d60c9
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-02-08 08:40:35 +00:00
Alessandro Portale
9db70d8810 Translations: Fix stray QApplication::translate() calls
For references to the module-own context, use Tr::tr().
For references to other modules, use the right context name (with "::"
prefix).

Change-Id: I6dce8f1ceccb23c44d93f1826402cd3be8e98e5a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-02-08 08:32:42 +00:00
Alessandro Portale
2356f28647 Translations: Add missing "::" prefixes to QT_TRANSLATE_NOOP
Change-Id: I7589a2d4003394e38e58c095b510f8eff33263b8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-02-08 08:32:31 +00:00
hjk
8a8b50e8b5 ProjectExplorer: Proliferate Utils::FilePath use
Move the .toString() uses into  DeploymentData::addFilesFromDeploymentFile

Change-Id: Ic9ef22da1918ca105c92f0231960dab27b0d80bb
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-02-08 08:21:29 +00:00
Eike Ziller
5728f09fac Editors: Fix message box when opening broken code style file
The file name is not supposed to be the button label.

Fixes: QTCREATORBUG-28746
Change-Id: I45ee2a860da8f7ffefc6d72c0d85b7f6a261489c
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-02-08 08:06:02 +00:00
hjk
432d918329 TextEditor: Use FilePath in Command
Change-Id: I0916204eefb49713f241dd43da662f258f8c99f7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-08 07:34:30 +00:00
Eike Ziller
012a2a6cd8 Fix build on Windows / MSVC 2019
Change-Id: I265cd316426c76c76bfe18a62a9e5f35fbca3da9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-02-08 07:28:59 +00:00
Orgad Shaneh
f94b41313b Utils: Fix MSVC size_t -> int warning
Change-Id: I2732f7b9ad3c7ae96d2d213822f05f37dfcac0aa
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-02-08 06:46:30 +00:00
Marco Bubke
d2bb27731d QmlDesigner: Add direct dependency on QmlDomPrivate
It adds an indirect dipendency to QmlCompilerPrivate too. We stick to Qt
6.5 because the private API changed.

Task-number: QDS-9049
Change-Id: Icb0b406fc47759763384e167c0cabbffc1c9e186
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-02-07 17:43:57 +00:00
Marco Bubke
befb49bbce QmlDesigner: Fix missing adaption
Change-Id: I307c9f236ee8ebd36d62b3fe9b0d4bbaea5699e8
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-02-07 17:43:43 +00:00
Marco Bubke
ef3e45da8d QmlDesigner: Share QmlPuppetPaths
It removes the workaround in QmlProjectRunConfiguration.

Task-number: QDS-8915
Change-Id: I319cdf976980b616eb28cabb40dd63416d7e27fa
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-02-07 17:43:34 +00:00
Marco Bubke
3a1bbd51eb QmlDesigner: Move DesignerSettings to DesignerBase
To share code with other plugins we add a support plugin.

Task-number: QDS-8915
Change-Id: I3d5b892a93145e04c90d3a3f07db41b55c041ae9
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-07 17:43:16 +00:00
Alessandro Portale
3a87b45831 Fossil: Tr::Tr()
Change-Id: Ifdfe75dc916b6d87cae985bbe5682f1e72541864
Reviewed-by: hjk <hjk@qt.io>
2023-02-07 16:21:19 +00:00
Alessandro Portale
521a23df6e Fossil: Inline revertdialog.ui
Change-Id: I2585c705fce03e3278ec344b0078b50144485d22
Reviewed-by: hjk <hjk@qt.io>
2023-02-07 16:21:13 +00:00
Alessandro Portale
d14c561cf6 Fossil: Inline pullorpushdialog.ui
Change-Id: Idd279a2ed2cc2b14e573aae588a309ae808b008f
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-07 16:21:07 +00:00
Brook Cronin
8127f9d2d5 QmlDesigner: Add medium size 3d primatives to icon font
Change-Id: Ia421e47a3b98e2d83a1bdb0b529f22ec93dc4dce
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-07 15:52:26 +00:00
Mahmoud Badri
23c6698b15 QmlDesigner: Add "Show in explorer" option to assets context menu
Fixes: QDS-9061
Change-Id: Id91336819f6836a98c8fd34562c0f8672c11a288
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-02-07 15:37:31 +00:00
Thomas Hartmann
830ea50334 QmlDesigner: Add basic install command to application template
Task-number: QDS-9047
Change-Id: I6bf0c3cf68148eeef3b8debd942180e05fd2d1a5
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-02-07 15:35:08 +00:00
Miikka Heikkinen
a5949543b6 QmlDesigner: Fix condition chains in 3D import options
When an import option conditionally depends on another option that
depends on a third option, toggling the third option needs to change
the enabled state of the first option controls as well as the second
option controls.

For example, consider this set of options (actual case with options
for generating mesh levels of detail in Qt 6.5):

optA
  optB, enabled when optA is true
    optC, enabled when optB is true
    optD, enabled when optB is true

If optA is false, optC and optD controls need to be disabled even if
optB is true, because of the chained conditions.

Fixes: QDS-9055
Change-Id: I10aeb7596cf9c8a9053c7d08ec9ebb7a46db2cd2
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-02-07 14:55:18 +00:00
Thomas Hartmann
980a9044f9 QmlDesigner: Add 'the' to feedback dialog
Task-number: QDS-8870
Change-Id: Ic5aab691d4ed1714ebc078fc5c985e39640d2ba8
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Pranta Ghosh Dastider <pranta.dastider@qt.io>
2023-02-07 14:32:15 +00:00
Pranta Dastider
21649188ca QmlDesigner: Fix the user feedback dialog
This patch changes the user feedback dialog box.
It update messages.

Fixes: QDS-8870
Change-Id: I16b98f1cec1c7cd2c84172bb39d2ede2d4f966e2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
2023-02-07 14:12:04 +00:00
hjk
89880907f2 Debugger: Simplify paramenter setup on Windows
Change-Id: Iec44dd33287ac23d2b51ef32483eae831d2ce4bd
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-07 14:07:52 +00:00
hjk
cbf2b23787 QmlDesigner: Remove unused global static
Building CXX object src/plugins/qmlde...dir/components/componentcore/designericons.cpp.o
/data/dev/creator-out/src/plugins/qmldesigner/components/componentcore/designericons.cpp:84:21: warning: ‘const QStringList& {anonymous}::iconFontMandatoryKeys()’ defined but not used [-Wunused-function]
   84 | const QStringList & iconFontMandatoryKeys()
      |                     ^~~~~~~~~~~~~~~~~~~~~

Change-Id: I978d6a52cf4030fe07352d6ee89c2db3d0433c05
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-07 14:01:42 +00:00
Christian Stenger
d2656c60e6 AutoTest: Widen scope for run under cursor
..and debug under cursor for QtTest and GTest.

Depending on the information coming from the code model
we may be able to get a correct scope even when standing
inside the function that is defining the test.
This makes more sense than the original behavior which
made it a hard requirement to stand on a literal to
run or debug a test under cursor.
But as the codemodel does not provide usable information
for all frameworks keep the original behavior as fallback.

Task-number: QTCREATORBUG-28752
Change-Id: I13ea7b0ad1e8207da6cb884d212667c4c657957c
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-07 13:56:07 +00:00
Christian Stenger
9277bb5111 AutoTest: Extract function to get active frameworks
For later re-use.

Change-Id: I87cf6db4de861b626e4669351df3f5119952328f
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-07 13:56:01 +00:00
Marcus Tillmanns
96185ca4f1 Utils: Use QtcProcess in FilePath::fileContents
Change-Id: Ia7236632c6d9b887d054a3254762b7e3592e73e1
Reviewed-by: hjk <hjk@qt.io>
2023-02-07 13:55:31 +00:00
Christian Kandeler
8096b9f524 Update qbs submodule to HEAD of 2.0 branch
Change-Id: If53431a0cf8bf412a28e606b0712e0acb26e07f5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-02-07 13:48:59 +00:00
Mahmoud Badri
435dfda150 QmlDesigner: Fix assets view wrong scrolling after drag-n-drop
Change-Id: I3904beb63441d1cf9a0d577fc6c96bbecc8e2ebf
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-02-07 13:34:49 +00:00
Marcus Tillmanns
78cf3eb671 Docker: Check writeData
Previously only the process mode was checked to decide
whether we need an interactive docker session when starting
a process.

Change-Id: Ia80c78d861107239d0c86c405e06f30e7770ff8e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-02-07 13:06:56 +00:00
Jarek Kobus
84ba73be8c RunExtenstions: Remove StackSizeInBytes
It's currently not used.

Change-Id: I223a2e8add92a107b85518bcaf44bbd8a5e3fb9a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-02-07 12:56:43 +00:00
David Schulz
fbcf0fb3bf ClangCodeModel: Fix initial processor state
It is expected that the processor that is created by the provider is not
running.

Fixes: QTCREATORBUG-28769
Change-Id: Icef270c5f9255b97aa04fc3d0ea0cf872787bd24
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-02-07 12:54:47 +00:00
Mahmoud Badri
6291ee4e79 QmlDesigner: Fix Components lib wrong scrolling after drag-n-drop
Change-Id: Ibd3f3c155496443eac0accf468280a15cad51351
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-02-07 12:52:38 +00:00
Thomas Hartmann
51864d0808 QmlJS: Allow string::arg() in ui.qml files
Task-number: QDS-9037
Change-Id: Ie91e745ae4d20e0fd96df1d767fc875475a0be7a
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-02-07 12:31:55 +00:00
Marcus Tillmanns
96ebe93ecb Debugger: Rebuild AttachCoreDialog
The old dialog was based on local vs. remote file paths.
These days we can simply treat them the same.

If the selected files are not on the same device as the
debuggger they will be copied first.

Change-Id: If5ec93d1e1e49c51b3032fec8384682d2a5e35b4
Reviewed-by: hjk <hjk@qt.io>
2023-02-07 12:31:40 +00:00
Thomas Hartmann
e151db2796 QmlDesigner: Bump QDS version in template
Change-Id: I5f50c3ab85f5439ae7c43bf0149ce1cfa0a1ab39
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-02-07 12:18:55 +00:00
Christian Kandeler
cc52478a93 LanguageClient: Export LanguageClientOutlineItem
To enable more customizations by specialized clients.

Change-Id: I0ad92e248e931389c3fa239df424df8883e1d86e
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-07 12:01:31 +00:00
Mahmoud Badri
ce1092ea50 QmlDesigner: Fix content library autoscrolls after drag-n-drop
Fixes: QDS-8711
Change-Id: I1ca399928a299d4917814bf651a8291b981f0f32
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-02-07 11:56:26 +00:00
Christian Stenger
1e92039dc1 Utils: Fix build of sdktool
Amends d829d9ff33.

Change-Id: Ib2c7543f04444b30c389346eb910861957e19b8d
Reviewed-by: hjk <hjk@qt.io>
2023-02-07 11:26:44 +00:00
Marcus Tillmanns
e780ca991c Docker: Use rootPath() for Shell
Change-Id: Ie2578b768d8fcb91c55a33b4eb62e43c127ccee2
Reviewed-by: hjk <hjk@qt.io>
2023-02-07 11:16:02 +00:00
Marcus Tillmanns
9d6b3b4cb4 Utils: Remove status= when using dd
Some versions of dd don't support the status= option.
(e.g. the dd version in boot2qt)

Change-Id: I22aa6571b223b7707e962bd2df9abdd11b438d69
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-02-07 11:15:49 +00:00
Henning Gruendl
cffd91e012 QmlDesigner: Cleanup status and tool bar
Change-Id: Idccd79ff34591e6beb7f79f3c16285bf7bacbb40
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-02-07 10:31:19 +00:00
Alessandro Portale
5342fa5757 Fossil: Register wizards path only once
Change-Id: I5b3d6bfb035dc364d4ec8c379b8b3214541c2ff8
Reviewed-by: hjk <hjk@qt.io>
2023-02-07 10:29:02 +00:00
hjk
a459a70ed3 Haskell: Convert to SPDX-style copyright headers
Change-Id: I9b31b209a4c43617d2a7a02880b10a573e3d8540
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-02-07 10:20:14 +00:00
Eike Ziller
541aafecbb QML: Fix crash when opening context menu
The AssistInterface changed to unique_ptr, but the internals of how the
QmlJSEditor looked for quick fixes still wrapped it into a
QSharedPointer, which then deleted the assist interface in addition to
the unique_ptr.

Amends 0e4b0a26d3

Fixes: QTCREATORBUG-28742
Change-Id: If685dbb2c49b09d529d0dcb3677dc90b03a039f0
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-07 10:12:25 +00:00
Leena Miettinen
8512aba9eb Doc: Add a short overview of what debuggers do
Change-Id: I07062ea6e046ce51a9d3091e9d86071415706e6c
Reviewed-by: hjk <hjk@qt.io>
2023-02-07 09:54:10 +00:00
Thomas Hartmann
c51320b3ad ADS: Fix crash when loading worksapaces
The formeditor workspace did exist twice.

Change-Id: If3ecd5918df46975a15bab2330246d338a5cea51
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-02-07 09:52:14 +00:00
David Schulz
2293488536 ClangCodeModel: prevent accessing nullptr
There is a certain amount of time between resetting the processor to
nullptr in ClangdFollowSymbol::VirtualFunctionAssistProcessor::cancel
and the destruction of the ClangdFollowSymbol sentinel. So we also need
to check the processor before calling update.

Task-number: QTCREATORBUG-28769
Change-Id: Idec7c9dd7648285ecf2360c309d9751303f6209c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-02-07 09:44:01 +00:00
Mahmoud Badri
cae28d82d3 QmlDesigner: Fix material browser wrong scrolling after drag-n-drop
The actual bug is somewhere deep in the Qml ScrollBar's implementation.
The workaround is to disable the scrollbar while dragging is on.

Fixes: QDS-7849
Change-Id: I9bedd8a8f0947c0e3d1a01e6d6e9962e9826d460
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-02-07 09:40:06 +00:00