Commit Graph

53197 Commits

Author SHA1 Message Date
Thiago Macieira
80bdcb95de Add unnecessary break to switch statements that don't fall through
GCC 7 can't tell that it's unnecessary, so it complained.

 registerhandler.cpp:528:13: warning: this statement may fall through [-Wimplicit-fallthrough=]

Change-Id: Ia3e896da908f42939148fffd14c6a15f3ec05524
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-06-12 16:19:49 +00:00
Christian Kandeler
cbc5b21110 QbsProjectManager: Introduce QbsBuildInfo
We will need to pass additional build info data in order to
support importing builds.

Change-Id: Ic62d0da246f5a19b53632ef3dc61b1f4fc434e5b
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2017-06-12 15:10:55 +00:00
Alessandro Portale
d023014a5c ProjectExplorer: Remove unused cesdkhandler.h/.cpp
Must have been unused since a while.

Change-Id: I33adfe26d084f4990eef0b68371cf100e7e47e3e
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2017-06-12 14:48:44 +00:00
Robert Loehning
6c6c4c72c6 Squish: Add expected project tree for cmake >= 3.7
Change-Id: I5a47e5c3da4bfd9db531957212b0f29815b1eb1a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-06-12 12:16:40 +00:00
Tim Jenssen
c63494217d fix infinite loop on environment modify()
Task-number: QTCREATORBUG-18335
Change-Id: I9d92f4e85a86a7b498e80d206c5b9ef2d36a17f3
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-06-12 11:48:32 +00:00
Orgad Shaneh
a9145e67ba Debugger: Prettify values for enum bitfields
Change-Id: I55329bba1864c9ebbbcb3b3bf1b940346507f8cd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-06-12 10:40:46 +00:00
hjk
4c29a31930 Ios: Convert to RunWorkers
This moves all of the RunControl implementation into a single
RunWorker, not yet splitting it up into separate RunWorkers
which is the final goal of this series.

Done-with: Vikas Pachdha
Change-Id: I9deaef48735c1c63c41dfae39d67f59387295273
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-06-12 10:37:12 +00:00
Robert Loehning
a3735eada4 BaseQtVersion: Check return value of QFile::open
Change-Id: Iba199ec29e4e8f4e74ffe6e76262eac0538c65ea
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-06-12 09:58:48 +00:00
Nikolai Kosjar
1f7403797a Snippets: Add struct snippet
Change-Id: I8c1e486d752ac0eaddbb1d7909a0e9b50382cc87
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-06-12 09:36:57 +00:00
Tobias Hunger
90c7427b15 ProjectExplorer: Make settingsaccessor more clear
Do not hide two strings getting concatenated inside long string lists,
use nullptr instead of 0.

Change-Id: I9b873295a24c1f5b0a9ce2c43ace050e3ff2329c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 09:33:36 +00:00
Tobias Hunger
623a9fc694 ProjectExplorer: Use member initialization in BuildStepsPage
Change-Id: I2834d3825b2737d036912e0d4b72fb57a926d139
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 09:33:12 +00:00
Tobias Hunger
f86ea447c3 ProjectExplorer: Use member initialization in CustomWizardParameters
Change-Id: Id461feb771990756adcaea98ac2f27f87f1b7ce9
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 09:32:55 +00:00
Tobias Hunger
5e0d4e65db VcsManager: Remove dead code
Change-Id: If23eadb7368824cf1cf6f77602ef056d6d0bcb88
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 09:32:35 +00:00
Tobias Hunger
5662f721e3 ProjectExplorer: Use member initialization in ToolChain test
Fixes a coverity warning.

Change-Id: Idac478b61abc1ac8e99e748fe5e6ee845c6312ff
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 09:31:56 +00:00
Eike Ziller
d21dde3b3c Merge "Merge remote-tracking branch 'origin/4.3' into master" 2017-06-12 09:00:10 +00:00
Tobias Hunger
aa0c2a5ef8 ProjectExplorer: Remove unused pointer member from EnvironmentAspectsWidget
Change-Id: I61ffc4e7f003212c8b0b4d2dfc187724ac4aabc8
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 08:50:23 +00:00
Tobias Hunger
ef72327495 Qmake: Use member initialization for GuiAppParameters
Change-Id: Ib438f41eb2e8c376fc1605046f416cd26f3503da
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 08:50:12 +00:00
Tobias Hunger
1c91bcb2a8 MSVC: Use member initialization
Change-Id: I1d9e7f71f807857c8955a3876dcbf775cd69b693
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 08:50:05 +00:00
Tobias Hunger
00cb9ee986 Kit: Use member initialization
All users did initialize m_priority with a call to setPriority in
their constructors, but we should not rely on that.

Change-Id: I707aaaf117e2680ba0bb1f2849e66c426b4fb8b4
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 08:49:59 +00:00
Tobias Hunger
5058f269ef ProjectExplorer: Use member initialization in BuildSettingsWidget
Change-Id: I5949dee22fa6b4d152a65edd55cfc184bec82ab2
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 08:49:53 +00:00
Tobias Hunger
dabda7966f WinDebugInterface: Use member initialization
Use member initialization to make sure everything is properly initialized,
even when not on windows.

Change-Id: I585476556fd83f493a68b26dcecd26dd772122e2
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 08:49:48 +00:00
Orgad Shaneh
6b0e1bc5f8 Merge remote-tracking branch 'origin/4.3' into master
Change-Id: I83af635dcac98e4fd78b21d8dd9dc3a27a4fdf94
2017-06-12 10:01:16 +03:00
hjk
1d921ae044 Android: Convert into a RunWorker based setup
This moves all of the RunControl implementation into a single
RunWorker, not yet splitting it up into separate RunWorkers
which is the final goal of this series.

Change-Id: I7373105603505aa4fffd7fe5ff0145f0128b34bc
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-06-12 06:38:40 +00:00
hjk
1a82bedc8b QmlProfiler: Merge LocalQmlProfilerRunner and QmlProfilerRunner
Also streamline code paths in the result.

Change-Id: Id7d96343a8f778ba8f415b1a850cc78576afa475
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-06-12 06:24:36 +00:00
Orgad Shaneh
8116cb39e1 Debugger: Add missing breaks in switch statements
Detected by GCC7

Change-Id: Ic4a1f0adac486d3f6d0f7da15b24e983c17225f3
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
2017-06-10 20:40:31 +00:00
Ivan Donchevskii
48392fac9e Clang: Show full completion match first
If prefix is equal to some completion then show it
before anything else.

Task-number: QTCREATORBUG-15445
Change-Id: I976da4a829b818e843d31a76d2818eb5bbedda93
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2017-06-09 14:28:51 +00:00
Ivan Donchevskii
8922fbf4be Clang: change global completions order
Give CamelCase completions lower priority

Task-number: QTCREATORBUG-18319
Change-Id: I812d22616e8ab0e3d186bcf7a6a569de22be2a07
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2017-06-09 14:28:16 +00:00
Christian Kandeler
98c35d6cd9 Update qbs submodule
To HEAD of 1.8 branch.

Change-Id: Ie184929f8e99cab21c4fa6f605e66060bb22d560
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2017-06-09 12:16:07 +00:00
Jesus Fernandez
f3cd5cdb7e Add a ShowContextMenu action
Allow users without physical MenuKey to open the context menu

Change-Id: Id886a5614e26d614cba6ceb3b08a9df6148e9655
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-09 10:30:35 +00:00
Robert Loehning
78ab3c61f5 Squish: Don't try building with cmake < 3.7
Task-number: QTCREATORBUG-18290
Change-Id: I5b14d781e7e5382605d7e931d0461efa1b317397
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-06-09 10:18:34 +00:00
Ivan Donchevskii
9a0eca15c5 Clang: fix completion after forward-declared class
Do not complete -> and . with global completions if
foo is a ptr/ref to forward-declared class.

Change-Id: I41e6745ffb07be1d973fe6a8132824f1b3bf7fb1
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2017-06-09 07:05:25 +00:00
Nikolai Kosjar
821a2ad665 Clang: Fix uninitialized values warnings
...from coverity scan.

Change-Id: Id669dd5de9a92bfec76e1aff3b8462caf9baa968
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-06-09 06:22:10 +00:00
Marco Benelli
7a940febbe QmlJs: initialize qmlDumpEnvironment
Task-number: QTCREATORBUG-18335
Change-Id: I4f70da8062fde5aadef978f73351d8938d2267eb
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-08 15:47:40 +00:00
Alessandro Portale
df8e126641 Core: Set template list ScrollMode in "New Dialog" to ScrollPerPixel
With the new big icons, the default ScrollMode = ScrollPerItem behavior
seems a bit unsmooth. ScrollPerPixel fixes that.

Change-Id: If4deb0f1323f70231af44a17d0b50eea9e37f10e
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-08 15:19:12 +00:00
Sergey Belyashov
08ae312dce Update Russian translation
Task-number: QTCREATORBUG-18305
Change-Id: Ie6cb90054b2d562c0c73a3fc7307d7835cd78853
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
2017-06-08 12:06:25 +00:00
Ivan Donchevskii
78db7d7ed2 Clang: turn off delayed template parsing
Fix templates highlight and completion on Windows
Add UI to turn on/off delayed parsing (off by default)

Task-number: QTCREATORBUG-17222
Change-Id: I0cd5e0bcfff2789cd938e4096829f777ff15957a
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2017-06-08 10:53:31 +00:00
Robert Loehning
7a068e494e Squish: Update speedcrunch's tree in tst_openqt_creator
Change-Id: I8f834a807f2dd10bed87829bf41c02e40913cd74
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-06-08 10:48:29 +00:00
J-P Nurmi
67b460b6cf qt5QtQuick2-bundle.json: add missing modules and versions
Change-Id: Ic101cda0a4b17557a8c04590fec22812331b189b
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
2017-06-08 09:51:31 +00:00
Leena Miettinen
0fe55f3b80 Doc: Add build system selection step to wizard instructions
This was still missing from the Qt Quick Application wizard docs.

Change-Id: I8e94d61080dc7877eb354c9342f49cdc1a6b01ed
Reviewed-by: Tarja Sundqvist <tarja.sundqvist@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-06-08 09:16:03 +00:00
Orgad Shaneh
95f49a3c8c Gerrit: Do not refresh the gerrit dialog when it is invisible
Change-Id: Icd4387f69b616f275b46b3b12e8db90b4b280554
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-06-08 09:13:13 +00:00
Nikolai Kosjar
c801965b58 CodeAssist: Fix leaking proposal model
The model is not owned by the proposal.

For corner cases, we leaked here already for ages. Starting with

  commit fab4dd068e
  CodeAssist: Fix auto completion if function signature is shown

leaks happened also for a hot path: code completion results that does
not match any so far typed prefix. Due to auto completion turned on,
this triggers frequently when typing text.

Task-number: QTCREATORBUG-17752
Task-number: QTCREATORBUG-18326
Change-Id: I9df177723b31cf3df36e73ef1e7920d9aa5e16e5
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-06-08 08:07:07 +00:00
Jake Petroules
0784dd20fe Refactor iOS toolchain handling
This significantly simplifies the implementation, properly handles
C vs C++ compilers, and defaults to 64-bit architectures for iOS devices
and simulators.

LLVM-GCC support has been removed, as the last version to support it was
4.6.3, which is far below the version of Xcode we still intend to
support. The toolchains are also given more sensible names
("Apple Clang") instead of iphonesimulator-clang and iphoneos-clang, as
the there is now only one compiler for all Apple platform targets, and
there is one entry of the Apple Clang compiler per supported
architecture.

The different to the end user is minimal except that the compilers are
named better. The number of kits and their configurations remain the
same, but this patch paves the way for tvOS and watchOS support.

Change-Id: I6e2b17f8c17d9dd504f0ad540e08782f291b73c0
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2017-06-07 15:59:45 +00:00
Robert Loehning
232f6a1096 QmlJs: Remove unused members
Change-Id: I2656bafe9f22652a3e80e6581a41296dfb144564
Reviewed-by: Christian Kamm <mail@ckamm.de>
2017-06-07 14:58:36 +00:00
Robert Loehning
600dd3a585 Squish: Update expected project trees when opening qtcreator
- Update Creator's sources to v4.2.2
- Update project trees to what Creator 4.3 shows

If needed, two separate changes are in codereview.

Change-Id: I16ee341653c8b916b15208f16699c0d4cbf6df05
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-06-07 13:27:24 +00:00
Leena Miettinen
98237b5176 Doc: Update deployment settings for B2Qt devices
Deploy step names have changed in Qt 5.9 and the generic Linux
steps can now be used.

Change-Id: I409cd2d7b289a22a3c958be32b78d6936074a535
Reviewed-by: Kari Oikarinen <kari.oikarinen@qt.io>
Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
2017-06-07 12:26:03 +00:00
Robert Loehning
feaff29b78 Squish: Use cdb with Creator's bitness
Normal builds of Creator can only use cdb with the same bitness.
In the official packages this is being solved by sharing
qtcreatorcdbextXX between 32- and 64-bit builds.

Change-Id: Ib31e4d71789065bef908bf13569de4284ae20de9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-06-07 10:20:57 +00:00
Eike Ziller
87d6706e34 Fix compiler path for MSVC 2017 installations
The folder layout has changed, so the sanity check if cl.exe is actually
from a Visual Studio installation failed.

Task-number: QTCREATORBUG-17925
Change-Id: I19bc0ca93ee529643f271b6e61b5afda27fdf446
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-06-07 10:19:09 +00:00
Robert Loehning
d12dc00a79 QmlDesigner: Remove unused member
Change-Id: I646ebaed1179fd679b67ec8c942d7b8a592e9900
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2017-06-07 10:13:58 +00:00
Tim Jenssen
78ed88552c reduce strange code to what it does
- no behavior change

Change-Id: If8ef04b9f99c976cb5fb69936e5fd02600940b2c
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-06-07 08:57:00 +00:00
Vikas Pachdha
3a9f9d5eac iOS: Fix stack overflow issue
Change-Id: Ic71e2af2cff41c61c85f4798f06144b36e459448
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-06-07 08:53:26 +00:00