When ADB signals a change about the list of connected devices, the whole build/run steps tree gets deleted and recreated.
The AndroidBuildApkStep is a part of that tree and starts one or more
"keytool" processes on creation/init. They were started with their own
event loop. Those synthetic event loops caused a change in order of
deletion which led to crashes with obscure backtraces.
This change removes the event loop creation from "keytool" calls. The
crash is avoided.
The calls take ~0.5 seconds. The short UI freeze should be an acceptable
hotfix trade-off for a crash in QtC13. If 0.5 seconds freeze seem too
much, a better fix could be done in QtC 14.
Fixes: QTCREATORBUG-30645
Fixes: QTCREATORBUG-30770
Change-Id: I8842dc87023142ae75572bf255c7f1ec808d9bab
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Before calling clickOnTab we used explicit waitForObject calls
sometimes.
Move these waitForObject calls into clickOnTab as the workaround
inside clickOnTab lets assume that the call of waitForObject
beforehand could fail.
Change-Id: Iba3bd952bfeec3738417ab6e2ea735665acb504d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
... and use it to register the InsertVirtualMethods quickfix.
The resulting registration pattern encourages the presence of tests and
easily allows minimal visibility of the classes involved.
Change-Id: I85fba0b983b51d84b6fae1f6fe51b63eed0ee336
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This patch creates a new document for Qt Design Studio
Property Effects.
Fixes: QDS-11087
Change-Id: I53287ae9635161a5a48c9cdaed045977944f34c0
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
We'd like to split up the monster files cppquickfixes.cpp and
cppquickfix_test.cpp by moving non-trivial quickfixes into dedicated files.
Since there will be many of them, we want to have them in a separate
directory. This patch prepares that.
Change-Id: I1e78fab5cce25151662297482582c8043618332e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The plugin adds a new tab to Navigation Widget. The tab contains
two charts CPU consumption and Memory consumption for started
applications in QtC. There is a combobox by which a monitored
application can be chosen.
Change-Id: I0747c90e73a289d65aabd31672f3accf74f00749
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Combine "Find settings files" with the FAQ question about
resetting settings and add the related CLI commands.
Change-Id: I544e863407c6eb925772f00527b1ebb9edee47ed
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Group boxes are book style and don't have colon
Change-Id: I8e5f1dcc1ac451a3324dc37240cc589431c7057b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
tracing_qmltyperegistrations.cpp:11:10: fatal error: theme.h: No such file or directory
That comes from src/libs/utils/meta_types/qt6utils_custom_metatypes.json:
{
"classes": [
{
"className": "Theme",
...
],
"inputFile": "theme.h",
"outputRevision": 68
},
That file is probably wrong but I don't know how to fix it.
Change-Id: If05cb740b64f42eba21efffd17cf1c207c139d7e
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Also remove the experimental restriction on the content lib user section
Fixes: QDS-12637
Change-Id: Ice2ac3f32a934d7c65ea7f406a2b5f8c4b5fed0c
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Consistently use book style for refactoring actions (which appear as
items in drop downs and menus).
Change-Id: I31cfd40dfc5d4d14a5949072168682a12cf566ac
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Better solution to ask for overriding or not is for the future.
Fixes: QDS-12626
Change-Id: Ib147121d3b9cb783f45a79a96fa432d371750a0e
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Update the screenshot also in the "Open a project" topic.
Fixes: QTCREATORBUG-30799
Change-Id: I1967907843f792671a665d15b343669f353d4a9f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
- Make sure search is working
- Hide sections with no items
- Other tweaks
Fixes: QDS-12682
Fixes: QDS-12625
Change-Id: Ia304743323c0459dd314752dba0cf1dc5e4c4889
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Also update user materials model to have the improvements
done to the 3D model. Also trying to make the 2 mdoels
as similar as possible to make it easy for further
future refactoring.
Change-Id: I5a32e1dcd7919bdf3cb638b068b0cdb5d4afecd9
Fixes: QDS-12736
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
By default, the kits view now displays only active kits
relevant to the current project. To access additional kits,
users can now use the "Show All Kits" option.
Change-Id: I41ecd7cbe7e220d564692b3cb16ea176add2b201
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
The class is used for generating a unique name anywhere in QmlDesigner
codebase. The role of this class is generation of next candidate name
when name is not unique. Actual checking of name uniqueness is provided
as a function param.
Also applied the new UniqueName on 1 usecase in
ContentLibraryUserModel::getUniqueLib3DQmlName
Change-Id: I777aeef7c269bed7d999695cf5fcee6a5576222b
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Also some relevant tweaks.
Change-Id: I7bace9ce6bd7b45951cc18f7175b4646251196f0
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
If there is more than one editor view, i.e. if the view is split or an
additional editor window open, paint a small line in the highlight color
below the editor tool bar to indicate which view is "current", and
therefore the target for opening files, and keystrokes (if it also has
focus).
Fixes: QTCREATORBUG-23654
Change-Id: I9950c133a6633c6e68943c038669895dce1dd7ef
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
The code that handled the MinGW case of libFoo.a -> libFoo.dll
broke the case of libFoo.dll.a -> libFoo.dll that is handled
by the code before that.
Amends 0d8a542b4f
Amends 8713919f31
Fixes: QTCREATORBUG-30556
Change-Id: I76f60c5e646bce97169b205860babf6a0d3b08b6
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Keyframes were always added on the selected model node
instead of the modelnode belonging to the property.
Task-number: QDS-12622
Change-Id: Iae44cfecd862d79b14c062854d5f329da595f729
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
More replacements of QString with Utils::FilePath and removal of
QFileInfo and QDir will follow.
Change-Id: Iceec1c009c562bd9a05f9ab1d1a9f83ad48a4467
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
