If directory is empty, buttons remains NULL, which leads to a crash
To reproduce, open Branches dialog then close all editors
and projects and click Log for a branch
Change-Id: Icf06b76c58585c0dd6062017e94e07dad016c275
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
If you had typed "filename.cpp:142" in the Locator field, Creator
would offer "Column 142" the first option. At the very least, that's
confusing because the user intended to select line 142, not column --
for a while I thought someone had typed the wrong word in the source
code.
But even worse, this selection was the first entry, so instead of
jumping to filename.cpp on line 142, the user ended up still on the
same file and line, but on a different column.
Instead, simply validate that the parts before and after the colon are
actually numbers.
Change-Id: I1f1fbd33d702ae26c41fd2485aa99fae800e1410
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
... when the symbol was added as an expression.
It seems that calling GetSymbolTypeName somehow destroys the red-black tree,
so moved the call before creating the tree.
Change-Id: Iefb187df4e7f99cfd95195a6ac9a4d8c64fa2365
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
When a second project was opened the snapshot was reset. That resulted
in all kinds of problems since from then on the code model effectively
was not aware of the files of the first project.
The regression was introduced by commit a0d6df7b.
Change-Id: I1ccc9de68177205b49a4ba8ead2bc8abe4592b32
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@digia.com>
The Info.plist.in files are actually handled by static.pro.
The projects should only be compiled from the deployed sources in the
build tree.
This reverts commit 30c602f458.
Change-Id: Ib63fb9e4db1c249817e59239029db7dd220ba5b3
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
When qml(2)puppet is built as part of Qt Creator, we need to generate
the Info.plist from Info.plist.in. When it is deployed as source into
the Qt Creator build, we need to do that too.
Change-Id: I83aa446f19984a51822c46df2ab7f41e78002ad4
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
In debugger.pro, take path that checks and sets
QMAKE_CHK_EXISTS_GLUE if QMAKE_SH isn't empty.
Change-Id: I7c37acc5867c1ac3ab6da33db3eb2479c1d4213c
Reviewed-by: Alexey Pavlov <alexey.pawlow@gmail.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
The ::run method is run in a separate thread, yet the owner of the
buildstep is the gui thread. As such we need to use a DirectConnection
to ensure that the slot is called in the right thread.
Task-number: QTCREATORBUG-9660
Change-Id: Ia206f3256a23f70f50d31c739359ff24b952fe46
Reviewed-by: Paul Olav Tvete <paul.tvete@digia.com>
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@digia.com>
* targetOS for mac is "osx"
* targetOS and toolchain are lists
Change-Id: I53d6c0d3669570c5c35f42a358727128d4d9d827
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
The debug token could be (re)moved outside of QtCreator.
The current patch:
- Checks the debug token path in the device wizard configuration
before uploading into device.
- Adds a new ReturnStatus if the file does not exist (for further use).
Task-number: QTCREATORBUG-9103
Change-Id: I5f48014072e4e807cd637a91f76e80c74195fee6
Reviewed-by: Rafael Roquetto <rafael.roquetto@kdab.com>
Required when ptrace_scope is set to 1 (default on recent debian and
ubuntu)
Change-Id: I47c4da5b5f01ae41b5a2b01cc3d35e4615d78288
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>
Linguist seems to escape the escaped HTML twice.
This breaks translations.
Task-number: QTCREATORBUG-8923
Change-Id: I820b89d7c8e140115dc8b2cf8ef28db49cfb7102
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
One or more commandline parameters -pluginpath allows to add custom search paths
for plugins to PluginManager::pluginPaths
Change-Id: I6d2702f1713b99000679ae577ce0978b3de51354
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
The slot CPPEditorWidget::onContentsChanged() was still connected to the
initial QTextDocument of BaseTextEditorWidgetPrivate and not to the via
BaseTextEditorWidget::duplicateFrom() updated QTextDocument.
This fixes the visual appearance when renaming. The actual renaming
is/was not affected.
Task-number: QTCREATORBUG-9651
Change-Id: Id26dc11627c253bbf89904be3f3df21a45041d01
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
QCompleter doesn't close its popup if there's a application wide
'escape' shortcut.
This commit adds the necessary shortcut overrides for CompletingTextEdit
and FancyLineEdit, which fixes the issue at least for find tool bar,
advanced search, gerrit dialog and description field of submit editor.
Task-number: QTCREATORBUG-9453
Change-Id: Ib1df218ab6b9a54fbf19d6132c6edd8e83ace46c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
This reverts commit 94011a12f1. It was a
hot fix which is not needed anymore.
Change-Id: I64ad1d6be54982ddd9b0ef790508a15bd0f73f72
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
- Use sub-projects.
- Move the main application and the application header products
into dedicated files.
As a result, qtcreator.qbs becomes much simpler to understand,
consisting now of just a bunch of global properties and a few sub-project
references.
Change-Id: Ic7300d489d3982394be5ad1d12a79a2914320298
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
...and not only the current one as fallback.
E.g. if the projects qtcreator and qtbase are open and you navigate into
qdir.h of your include path from the qtcreator project and trigger
"Switch Header/Source", then "qdir.cpp" will be found in the qtbase
source dir.
Task-number: QTCREATORBUG-3789
Change-Id: Ibd73c37bb626f8f7ee80cd8be3ef1244883ccf5e
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
This is already done in Master and 2.8 branches.
Task-number: QTCREATORBUG-9455
Change-Id: I8ae9e5a14ba561640d3389e08cb74a5ec856d335
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
