Matching \n in a QByteArray is wrong. For example, it detects Ċ (U+010A)
and ਛ (U+0A1B) as end-of-line
Change-Id: I9c03d0b19da3d328e706ff2c89f09713be870f34
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
The list always contains a single entry (or none) anyway
Take 2. This time it actually compiles ;-)
Change-Id: I71a9822360a9b569ba79afa0f575e27918bb2e03
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
For the input "git am" is "git amend" a better match than "git blame".
Change-Id: Id0cf91b62dac8b6c54f6de7c0698a375765e936d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
And use it where appropriate
Change-Id: I0f37b8aada6eaa9be6743724b91a59173a01cb0c
Reviewed-by: hjk <hjk121@nokiamail.com>
Reviewed-by: David Schulz <david.schulz@digia.com>
Depends on a commit that broke compilation
This reverts commit a53cc559be
Change-Id: I7b697be1c97bd25f15e2a97927dbc7d03dc456e7
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
The list always contains a single entry (or none) anyway
Change-Id: I567b622efd42dd6f676bebb92fbf1c8774bd80ff
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
If the path() set on that node can not be opened, then the editor
is 0 and thus there is a crash.
Task-number: QBS-367
Change-Id: I8887a3bb84e19292d97357df49ef988d74bf6739
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
The local variable output of unsigned __int64 differ between 6.11
and 6.2
6.11: 0x222`23456789
6.2: 0x00000222`23456789
So we must iterate over the value to find and remove the 64bit separator
(`) instead of just expect it at the 10th character.
Change-Id: I8017c83707b29fa0a510bf621e57e9da6895b63a
Reviewed-by: hjk <hjk121@nokiamail.com>
We can parse the .qmlproject files without using the declarative module.
Change-Id: I78a910c9ec9477f5c6fbcdca23f62ab841ca4368
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
Fix MSVC warning C4189: 'em' : local variable is initialized but not referenced
Change-Id: I8b86dc95c1e05302909bb35c22949931db774c2a
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>
blackberry-connect tool requires to have public key with no comment
or comment with 'usename@hostname' format
QSsh::SshKeyGenerator creates comments in 'QtCreator/TIMEZONE' format
there we are stripping them out
This issue has been introduced by commit:
bd064d50e6
Task-number: QTCREATORBUG-9888
Change-Id: Ied96720b004cfe4f5bb95adec3401b6b6d30db5c
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Replaces \r\n? with \n.
Some console applications (e.g. git-push, git-rebase) use \r alone to
move the cursor to the line's beginning. This should be replaced by \n
rather than just be erased.
Change-Id: I8d614d2b471e59decdbfa7f173ffa7fbdb11759b
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
ModelNode::isComponent() is throwing an exception if the node is
not valid.
Change-Id: I4b34b9a583108923d584a73585f3001df68a741d
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
This function did nothing but call EditorManager::openEditor(), so we can
call it directly instead. It was not used consistently anyway.
Change-Id: I639ef346164be9260e887faac5dc6651ccfd92c5
Reviewed-by: Marco Bubke <marco.bubke@digia.com>
This function is highly confusing as a member of DesignDocument
and the logic can be implemented directly in the ShortcutManager.
Change-Id: Id722dcb71b542b4780614c9f895f06150ccb67ca
Reviewed-by: Marco Bubke <marco.bubke@digia.com>
Use QTextDocument::onContentsChanged() to monitor text inserted and
removed in insert mode for dot command (or just repeat with 2i, 3o etc.)
to re-insert same text.
Works even if auto-completion is replacing '.' with '->' for pointers.
Change-Id: Ie39edcdc9ec60bcf6c7d10f021248c3a0aee76b6
Reviewed-by: hjk <hjk121@nokiamail.com>
Move ComponentUtils::goIntoComponent() to DocumentManager.
Change-Id: I038f4c56cb1745455613a1dbdeeb8bcb927da7f3
Reviewed-by: Marco Bubke <marco.bubke@digia.com>
The ModelNodeOperations are an implementation detail of our
DesignerActions and should not be used in other places.
Change-Id: I495bfd043a6b1dd89952b0e7d2318e429678640b
Reviewed-by: Marco Bubke <marco.bubke@digia.com>
Resolve which qmake qtchooser will forward too, as that qmake will put
it's path into the makefile.
Task-number: QTCREATORBUG-9841
Change-Id: Ib7a17c7683550ce3bb9172c7428a0efc328652f5
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
This function checks if the ModelNode is a Component or has a delegate
which is a Component.
Change-Id: I6bc92c3246b58eb04a5d37722e821dbed52147e5
Reviewed-by: Marco Bubke <marco.bubke@digia.com>
Moving the CrumbleBar and the ComponentAction out of the FormEditor
into the DesignModeWidget.
These widgets are about document navigation and do not belong to
the FormEditor.
Change-Id: I5cd177d70f7c8f9cc2913c8c3c640d62fefd718d
Reviewed-by: Marco Bubke <marco.bubke@digia.com>
