src/libs/cplusplus/MatchingText.cpp(64): warning #161: unrecognized #pragma
# pragma GCC diagnostic ignored "-Wstrict-overflow"
^
This pragma is recognised in GCC only, so don't enable it for when ICC
fakes to be GCC.
Change-Id: I3d9830dc2b12632dd08d8c8961219bd253ad8c1d
Reviewed-by: hjk <qthjk@ovi.com>
QML property values could be set in the inspector.
Regression introduced by 7f09d0b756.
This patch is a partial fix. Only values can be assigned currently.
For expressions, use the console.
Change-Id: I945b11109cd7788dd0f5277af206bf9658844aee
Reviewed-by: Christiaan Janssen <christiaan.janssen@nokia.com>
Reviewed-by: hjk <qthjk@ovi.com>
Try to use the watchHandler for referring to the object tree
instead of caching the object tree locally.
Change-Id: I68624771ef49d50f2cf0d6d580b1b34d57483178
Reviewed-by: Christiaan Janssen <christiaan.janssen@nokia.com>
Do not run the process every time the user presses 'Ok' or 'Apply'
in the settings page, do it only if the gerrit parameters actually
changed. Also check for empty binary.
Change-Id: I934616e5d9b20404278f1fd9fc751ff161030cd8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Fixes a spinning cursor in case the page was not fully
loaded and we where closing it at the same time.
Change-Id: Iae6efac70c0c8be2f84e6b1551275bbdf9c5aab3
Reviewed-by: Niels Weber <niels.2.weber@nokia.com>
Reviewed-by: Karsten Heimrich <karsten.heimrich@nokia.com>
This makes possible to scan such things as doxygen \todo, @todo
entries where colons cannot be added after a keyword.
Change-Id: I13c757294c94a1f4758e7dc9634a79ea6e91c68f
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
It's one model for all locals, watch, return, tooltip and inspector
data. This allows more streamlined code paths and better isolation
of the model data from the WatchHandler. WatchItems are now registered
in a hash indexed by iname, so inames can be used as the primary
handle to watch data in the WatchHandler interface.
Change-Id: Idac0a808b5d785307496d1de4198a1f2e9ce3880
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
Completion in the "Description" field of the commit editor was
broken with the Subversion plugin.
Change-Id: I82045b96b5f987dce849265abb169cdfbbed45be
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
Corrected the warning message shown when changes are made for
JavaScript when "Apply on Save" is active.
Change-Id: I5ed839ee0bc3926b93a02c66ea50868062e7cadf
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
The difference check/comparison to saved document by preview
is done only if the file was changed in the editor.
Change-Id: I086fa5f5948a15a449d25ea85921551766f7b62a
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
Due to latest changes the macro arguments were no longer being tracked.
Then they were no available in the document's macro uses. The patch also
makes sure that the preprocessor condition to be expanded is spelled
exactly as in the source code (this guarantees that offsets will be
properly calculated).
Change-Id: I8aff0c3aca0c528ef2c4bcfa56ff1c3da2961060
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
showSyncWarning would print the line and column using QString::number,
so instead of a -1 (which was probably the author's intent), it would
show 4294967295. A zero is probably better.
Change-Id: Iff663be1a98d4d934755447e34a5dc8f9149047f
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
ICC complained:
src/plugins/qmldesigner/designercore/include/propertycontainer.h(52): warning #1098: the qualifier on this friend declaration is ignored
friend CORESHARED_EXPORT QDataStream &QmlDesigner::operator<<(QDataStream &stream, const PropertyContainer &propertyContainer);
^
The solution is to simply remove the namespace qualifier when the
class is already inside that namespace.
Change-Id: I2256ebe072b3f8db5288f72acb1388eabcb8325c
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@nokia.com>
The ttl argument to ServiceGaterer::txtFieldReply is uint32_t.
Change-Id: I7df624eb04d5ffea1b281ed06d38d5e66b7a7319
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@nokia.com>
The tree view shows the fancy special characters for the modifier keys,
so it's not possible to filter for them.
Change-Id: I3f0cab24afe8ccb9a95300e91eb1bc45a0e4313a
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
Makes more sense now, is more generic (regarding nesting level), and
even is shorter.
Change-Id: I77ce34aa25655f6b2690964107f4cab018e1d66f
Reviewed-by: Robert Löhning <robert.loehning@nokia.com>
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
Task-number: QTCREATORBUG-2701
Task-number: QTCREATORBUG-4059
Enable plugins to support pdf, etc. files out of the box in
Qt Creator. If we still fail we try to open the link using
the desktop service, as last resort to open a page showing
some error message and hints about the error. Adjust the old
page not found message to match the new design.
Change-Id: I7fef79d27e8bc279a6169b6f3da4787ffa0d023d
Reviewed-by: Niels Weber <niels.2.weber@nokia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
Reviewed-by: Karsten Heimrich <karsten.heimrich@nokia.com>
None of these change the code in any way. The solutions applied are:
- change the type to a more appropriate one, if possible
- use ~0 instead of -1 when flags were intended
- cast a -1 to the proper type otherwise
Change-Id: Ifcc125528f32b8c8f9ab20bea103e2a693045bf8
Reviewed-by: hjk <qthjk@ovi.com>
QTC_ASSERT(false, action) would print "false" and then take that action
(the return). The other branch of the QTC_ASSERT was a constant false,
so it would never be taken. However, ICC didn't seem happy with it, so I
moved the return to after the checking.
Change-Id: Ia50e75c91fb345e6b21cd5f91df3070544b42d22
Reviewed-by: hjk <qthjk@ovi.com>
Setting the filter is now delayed to allow proper typing.
Change-Id: I9faa2b9810766b2a51bf02d4a14222a9f0a81693
Reviewed-by: Alessandro Portale <alessandro.portale@nokia.com>
We reduce load on the view by using beginResetModel()
and endResetModel() while filtering.
Change-Id: Id3caacc78cdba1c81d915dc1cbb40ada5bfda522
Reviewed-by: Alessandro Portale <alessandro.portale@nokia.com>
Because these tend to add special characters into the editor instead of
triggering the shortcut. Use Ctrl (aka Qt's Meta) instead.
Change-Id: I5866772baf4550e6d048e4d7252b2899a6d28296
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
Don't explicitly use white, use the "base" color.
Task-number: QTCREATORBUG-7435
Change-Id: I3fcfefd958857146b6f9b2ceef3376d2b582b807
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@nokia.com>
Reviewed-by: Robert Löhning <robert.loehning@nokia.com>