Commit Graph

85780 Commits

Author SHA1 Message Date
hjk
4434b09d49 EmacsKeys: Hide plugin class in .cpp
Change-Id: I5b2bb608743fad30505898bbbf0699db84866c3c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-15 10:07:25 +00:00
Jarek Kobus
02be4ac613 QnxDeployQtLibrariesDialog: Reuse TaskTreeRunner
Change-Id: Ic64bd6821991ee594e48b4fa325de262a9764784
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-15 10:00:41 +00:00
Jarek Kobus
bd83ea8b8c AutoTest: Use LoopRepeat for test scanner
In this way we don't construct a giant recipe
(~7000 tasks for Creator project) but simply repeat
the task execution many times.

Change-Id: I06758e2afa721f73e28adb42e6fccee0f955e01f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-15 09:37:02 +00:00
hjk
f3d11bf0b8 Ios: Hide plugin class in .cpp
Change-Id: I10577ed877c6038ffd714a1a414ed8ba7ec801ee
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-15 09:32:53 +00:00
hjk
1165e078fe GitLab: Hide plugin class definition in .cpp
Change-Id: I362bcbd09ef4694f0478c8982ea627cb9d8c310b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-15 09:32:31 +00:00
hjk
b52368b0de Help: Hide plugin class definition in .cpp
Change-Id: I02a96c53131e1371d7abc3ac3bd471feeec46276
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-15 09:06:14 +00:00
hjk
68f67d5a1a Debugger: Move plugin class definition to .cpp
Change-Id: I82327b20fb3bd970fe66b43228ca2f014c877f12
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-15 09:06:08 +00:00
David Schulz
640b4d530c Core: compress application icon updates
The current code updates the application icon for every task added to
the progressmanager. There are cases were we add a lot of tasks in one
go, for example when receiving diagnostics from the code model. This
might not even change the application icon (since it only updates for
errors), but we never the less create a new icon and send it to the os.

Optimization 1: Only trigger an update if the text differs from the
previous icon detail text.

Optimization 2: Do not directly update the icon but start a timer to
collect multiple updates and update the icon when the event loop is re-
entered.

This only affects Windows and Mac since the progressmanager_x11
implementation does not update the application icon.

Change-Id: I80cbb6f2520a83e79e2dba1b4079ab77fb7bf453
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-15 09:04:43 +00:00
The Qt Project
d9557e5d55 Merge "Merge remote-tracking branch 'origin/12.0'" 2024-01-15 08:46:40 +00:00
Eike Ziller
a819a2bd9f Merge remote-tracking branch 'origin/12.0'
Change-Id: I62eb6d73b3ed59d0dd9760fc1921e353c993c166
2024-01-15 09:36:58 +01:00
Jarek Kobus
9c85062432 BranchView: Reuse TaskTreeRunner
Change-Id: I86b7d799c7dc5cd941e1159caff8e630ad0fdd46
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-01-15 08:36:55 +00:00
Jarek Kobus
e4866a1667 NavigationWidget: Avoid using keys()
Instead, iterate directly over the container.

Change-Id: I393ac1d42b08b7fcf2052ba601a550f28ad84c69
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-15 08:31:46 +00:00
Jarek Kobus
b653dc3e80 NavigationWidget: Move statics outside of class
Change-Id: Ibbdb867b52eff75000fbdbc5e15694ab5b5f5646
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-15 08:31:38 +00:00
Jarek Kobus
d8663701ab TaskTreeRunner: Introduce aboutToStart(TaskTree *) signal
It enables the access to the internal TaskTree.
Emitted by TaskTreeRunner::start(), after the task tree
is instantiated and before it is started.

The lifetime of the passed task tree is controlled by the
TaskTreeRunner and is limited to the one particular execution.
Don't store pointer to the passed task tree.
If unvoidable, store the QPointer instead.

It may be used e.g. for connecting to the TaskProgress.

Change-Id: If0af11eb136c9cbff2e4c6e91f8b18a114880f74
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-15 08:30:51 +00:00
Jarek Kobus
781ca08207 FileStreamer: Reuse TaskTreeRunner
Change-Id: I3ea6f07f18fa8a326325d41bf771b85e7e8165ee
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-15 08:30:37 +00:00
Jarek Kobus
7e7318d47d TaskTree: Introduce TaskTreeRunner
This addresses the 30th point in the bugreport below.

Task-number: QTCREATORBUG-28741
Change-Id: Ifa157311b3aae413b19075d36e11c75e6066881d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-15 08:30:28 +00:00
Jarek Kobus
14f6954026 TaskTree: Disconnect from task's done() signal on destruction
If a task or task's adapter sends done() signal directly
from the destructor (which isn't really desired),
ensure we disconnect from this signal beforehand,
otherwise this may start invoking normal handling of task done()
and interfere with the destruction.

Fix NetworkQuery d'tor.

Add a test for it.

Add some TODO items.

Fixes: QTCREATORBUG-30204
Change-Id: I56a34d0f00c961c15bd1bcffef45520a4be5bce0
Reviewed-by: hjk <hjk@qt.io>
2024-01-15 08:29:57 +00:00
hjk
0dd9d9a327 Core: Move VcsManager test class definition closer to tested code
Change-Id: Ibc97d4874eca871d7d283dc97bf61235e9ea5539
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-15 07:57:26 +00:00
Eike Ziller
28a8d6949b iOS: Implement deployment via devicectl
For devices that that supports. The goal is that iostool will be
unneeded in the end for these.

Call `devicectl device install app` with the right device id and bundle
path and parse its output.

This doesn't use our custom provisioning check, but relies solely on the
errors that are returned by devicectl.

Task-number: QTCREATORBUG-29682
Change-Id: Ibae0908841004a12e1fc91b154bedea4b37db053
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
2024-01-15 07:31:39 +00:00
Eike Ziller
1a29b9e36c iOS: Add a "handler" property for the tool that is used for device ops
To the IosDevice. So other parts of the code know if the device can (and
should) be handled via devicectl instead of iostool.

Change-Id: I700bd1528fad505c3f4b6442d73e24b09ceba68a
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
2024-01-15 07:31:29 +00:00
Eike Ziller
b2eac9acf8 iOS: Use layout builder for details in device preference widget
In Preferences > Devices > Devices > Type Specific.
This makes it fit the style of other devices, and automatically makes it
possible to select and copy text from it.

Change-Id: I637858a939ada261504970611ffdb7eccf003c1c
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
2024-01-15 07:30:56 +00:00
Jarek Kobus
34b01f7530 BranchView: Return recipe instead of TaskTree
Change-Id: I51c6c4f7d03f264e69c637f081017d88a5ac027b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-01-13 19:49:15 +00:00
Jarek Kobus
1bf2c447d3 Process: Add a test for starting unexisting process
With different combinations of processImpl and eventLoopMode.

Change-Id: I7a066741f46bc51c1d670527e03358cd77d6b29e
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-13 13:38:59 +00:00
Jarek Kobus
7802e475ce Process: Fix EventLoopMode::On
Queue the call to start() so that it's executed after the nested
event loop is started, otherwise it fails on Windows with QProcessImpl.

Fixes: QTCREATORBUG-30066
Change-Id: Ibb17ef0f668f52c05b26a521e18c94e637992ba5
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2024-01-13 13:38:49 +00:00
Jarek Kobus
85a27b3ddd TaskTree: Implement progress reporting for LoopRepeat
When a number of repeats is known in advance,
make the progress reporting aware of it.

Add a test for it.

Change-Id: I676a4aa9eb469cfe40a2729d231c706dff3ca07c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-13 03:02:41 +00:00
Jarek Kobus
ae57346f30 TrafficLight: Undecorate strings in order to compile against Qt 6.2
Change-Id: Iac3a65cca5b07f405fb64fe4cefc7cdf3d509759
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-13 02:41:23 +00:00
Jarek Kobus
420653d3eb PluginDialog: Compile fix against Qt 6.2
Change-Id: I49a2990094d9d49f9a70f9782cfb53a3181a31dc
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-13 02:40:25 +00:00
Alessandro Portale
8a4b3c0891 Icons Svg: Bump Inkscape version from 1.1.1 to 1.3.2
Let it have its way of partially rewriting the document.

Change-Id: I4ea3d6a5ae271356fe111bd5f5e9591d0f75b532
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-12 23:29:15 +00:00
Jarek Kobus
8e84809feb TaskTree: Add a special field for Repeat case
If the number of iterations is known in advance it may
help in calculation of total task numbers for progress
reporting purposes.

Change-Id: Ie36de67a4f3271820aca539afe0816974773a152
Reviewed-by: hjk <hjk@qt.io>
2024-01-12 18:16:09 +00:00
Jarek Kobus
db43e5d679 TaskTree: Introduce LoopUntil
In order to conform better with LoopRepeat and LoopForever.

Change-Id: Ic14cd072dc04951c0b142fd7379daf5541823a9a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-12 18:16:03 +00:00
hjk
d876123ff7 Cvs: Move plugin class definition to .cpp
Change-Id: Icb1e3644498c3e3acd26d88e87425f040132687a
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 17:49:04 +00:00
hjk
14ede71d62 CtfVisualizer: Destroy CtfTool earlier again
Amends 796053d7.

After all, the defaulted destructor of the class did some actual work
via the destructors of the QScopedPointer members.

Change-Id: If6dc8a3d57961ec263fced11f9fa9f7e9f8c54cc
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 17:48:59 +00:00
hjk
eeb8bf1ddf Android: Simplify SdkManagerOutputParserTest
And add the missing empty line.

Change-Id: I73d22c4e17193e04fe2aa405d348867a3cd8545c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 17:12:23 +00:00
hjk
8d6491e6ba Android: Have test class definitions closer to tested code
Change-Id: I92fbc2285a6d3f6d6b5e891f6727d5aa9778efa8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 17:01:38 +00:00
hjk
796053d766 CtfVisualizer: Convert to new standard plugin setup
Change-Id: Iaed31278cdbaf2933b325a3424d3c64e91f48d1c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 17:01:05 +00:00
hjk
bc14d32a8c CppCheck: Hide plugin class definition in .cpp
Change-Id: I960ec6e0e4d63cf0edf7af55d191ba666f44739b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 17:00:50 +00:00
Robert Löhning
db930b3c61 SquishTests: Update expected tree in tst_opencreator_qbs
Change-Id: I0b28b49bf2351ad37daf9702aaa1386b0c3514be
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-12 16:31:58 +00:00
hjk
a3bad897af CPaster: Hide plugin and service class definitions in .cpp
Change-Id: Ie1dd6362daea0de7dc363bb22cd7790374535387
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 16:10:50 +00:00
hjk
c90908dffb BareMetal: Add missing createIarParserTest() implementation
Amends b2bed13655.

Change-Id: Id6f1d5bd2f973fdb09f99f5be6629ae34ef77f01
Reviewed-by: hjk <hjk@qt.io>
2024-01-12 15:55:42 +00:00
hjk
39fc082472 CompilationDataBase: Hide plugin class definition in .cpp
Change-Id: Ib6c5f1a10479f8c27cc448c38fb5e3546f1e2239
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 15:18:17 +00:00
hjk
b2bed13655 BareMetal: Hide plugin test classes to .cpp
Change-Id: Idea4e2402eee0b3b0a4f3beba5f56b8e8020a34c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 15:17:55 +00:00
hjk
db2cfd175b Nim: Hide plugin class implementation in .cpp
Change-Id: I7f4bf2f46f1604c07e61d34d4d254801f356751f
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 15:10:32 +00:00
hjk
4e4821cd05 Nim: Move parser test definition closer to the tested code
Change-Id: Ibc5b0ecd2258122155b72e95f4bd834897a0dbf1
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 15:10:25 +00:00
hjk
3abe587d42 BinEditor: Inline plugin and service classes in .cpp
I had to rename the BinEditor class as moc apparently
stumbles over the same-named namespace:

In file included from /data/dev/creator/src/plugins/bineditor/bineditorplugin.cpp:529:
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc: In member function 'virtual void* BinEditor::Internal::FactoryServiceImpl::qt_metacast(const char*)':
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc:227:40: error: 'FactoryService' in 'class BinEditor::Internal::BinEditor' does not name a type
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc:227:54: error: expected '>' before '*' token
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc:227:54: error: expected '(' before '*' token
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc:227:55: error: expected primary-expression before '>' token
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc:227:62: error: expected ')' before ';' token

Change-Id: I736dc89c270f4245806792b0e350d7155f027a19
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 15:09:51 +00:00
hjk
f20782a945 GlslEditor: Hide GlslCompletionAssistProcessor implementation
Change-Id: I9eeed92396b9dab4b33aa23c015c744de1aacce0
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 14:55:02 +00:00
Ali Kianian
194a34a8f1 QmlDesigner: Move CollectionEditor functions to utils
- Collection editor functions are moved to CollectionEditorUtils
  namespace
- Collection import tools functions are also moved to
  CollectionEditorUtils. Also, the former files of import tools are
  deleted since their functions are moved.

Task-number: QDS-11391
Change-Id: I1ec1b2b7568658c1637a4c267989425189f07039
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-01-12 14:51:07 +00:00
David Schulz
22989d4d82 LanguageClient: fix compile with Qt 6.2
Change-Id: Iac02d004286641b95a6729c367c339bf94e70bed
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Mathias Hasselmann <mathias@taschenorakel.de>
2024-01-12 14:28:21 +00:00
David Schulz
83d2b82eb9 LSP: fix compile with Qt 6.2
Change-Id: Ia0b83166c9b859add450ae36001f3fa30cfb4b55
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mathias Hasselmann <mathias@taschenorakel.de>
2024-01-12 14:28:16 +00:00
Christian Kandeler
1e5212aa52 Update qbs submodule to HEAD of 2.2 branch
Change-Id: I31842bafbbc1dd391f694aef43a96ff861212a7e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2024-01-12 14:19:15 +00:00
hjk
f114df2bd3 Android: Hide plugin class definition in .cpp
It's not meant to be used from the outside.

Change-Id: I94e46f95f896fa4b44e77e0196523beb8afdf8c3
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-12 13:56:41 +00:00