Commit Graph

76958 Commits

Author SHA1 Message Date
Jarek Kobus
9381429e4f Perforce: PendingChangesDialog: Use Layouting
Change-Id: I0c4ea45f89b694df89ec304171779cb1b796280f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-11-16 15:37:38 +00:00
Jarek Kobus
46183c88d1 Perforce: ChangeNumberDialog: Use Layouting
Change-Id: Ib18c4b2533b87f7afcd5f61053b487a3c35427a2
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-11-16 15:37:30 +00:00
Eike Ziller
478ce3f4a4 QmlDesigner: Fix condition for adding QMLDESIGNER_STATIC_LIBRARY define
"$<BOOL:" interprets the following string, and does not expand variables
itself.

Amends 78cf5051f5

Change-Id: I50e09e699764a00091167e8c72045a0f9055160e
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-11-16 15:37:26 +00:00
hjk
dd4c47a73a QmlDesigner: Avoid warning about unsed parameters
Change-Id: I5a61faa1e876ad31fa6d275157cf55b8549142bd
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-16 15:35:32 +00:00
Tim Jenssen
0d2cb70fd6 qml2puppet: fix broken deployqtHelper_mac.sh
The extra subdirectory "qmldesigner" was removed
in cmake build scripts by last refactoring.

For other ui helper tools in libexec is already a
working qt.conf which can be reused.

Task-number: QDS-8308
Change-Id: I7e98d0187cf2748298da263e55a64918cbb6b2c0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-11-16 15:35:01 +00:00
Jarek Kobus
28b76e50cd PluginErrorView: Use Layouting
Change-Id: I877f435e179d2c1a77085b03aab1ede06849fee9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-11-16 15:04:23 +00:00
Jarek Kobus
81a4d84194 PluginErrorOverview: Use Layouting
Change-Id: Ifacfd187b6b4bc968ca1f19a2b5444eed206b1d0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-11-16 15:04:12 +00:00
Christian Stenger
de286be2dc Valgrind: Fix plugin unit test
Amends a7956df3ca.

Change-Id: I281df7e8c8a971de6398d78c0afc09bfc3625b71
Reviewed-by: hjk <hjk@qt.io>
2022-11-16 14:42:33 +00:00
Jarek Kobus
450a67cdda PluginDetailsView: Use Layouting
Change-Id: I8a777b13596a4f690b9288d52e945aff7c354adc
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-11-16 14:37:50 +00:00
Kwangsub Kim
c39d89199e McuSupport: Avoid empty string for cmake toolchain vars
At the first run of Qt Creator after its installation, MSVC toolchain
command is set lazily after it's detected, so an empty string can be
set to cmake toolchain variable when a Qt for MCUs kit is created
automatically. It needs be avoided to keep the cmake variables valid.
Even when the command is not updated, it will work correctly with the
default variale (%{Compiler:Executable:(C,CXX)}).

Task-number: QTCREATORBUG-28457
Change-Id: I5de277831e7f1e696f67724193938d6eef7a12dd
Reviewed-by: Sivert Krøvel <sivert.krovel@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-11-16 14:27:35 +00:00
Kwangsub Kim
86c8d2166e McuSupport: Remove empty packages correctly
The effect of rehashing on removing an item from a set was not
considered, so the empty packages were not removed completely in
the packages set of McuTarget and it randomly caused an invalid
status of the McuTarget.

Task-number: QTCREATORBUG-28457
Change-Id: I964862330cf4f8d2de88647125f65c2959db417c
Reviewed-by: Sivert Krøvel <sivert.krovel@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-11-16 14:26:40 +00:00
David Schulz
c1edc1e9df ProjectExplorer: Fix starting a docker project on windows
... by mapping the executable and working directory to the target
device.

Change-Id: I0a220fe9bae980cb279fae776962f23335eac248
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-11-16 14:01:55 +00:00
Thomas Hartmann
301e7398d9 QmlDesigner: Fix ProgressParSpecifics
Task-number: QDS-8170
Change-Id: I5c9c4b1cb2751b89e7c1bb58c8f184dbbcf0623e
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-16 13:48:04 +00:00
Leena Miettinen
be1aa6abed Doc: Fix typos
Change-Id: I22b610a6dcab73867f915f877d7b7b844da5dc22
Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
2022-11-16 10:39:24 +00:00
hjk
2d8dc4c779 Debugger: Disable re-running
It's currently broken in a lot of configurations.

Change-Id: Ic948bb619c4860ba0c0d81a383412e6d0b007367
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-16 10:10:33 +00:00
Eike Ziller
ae67799eb3 Merge remote-tracking branch 'origin/9.0'
Change-Id: I2123e09f75199a63af6e8505fb8889e7f9d025d2
2022-11-16 09:40:34 +01:00
hjk
779dc52a97 Utils: Fix interrupting local processes on *nix
Change-Id: I6e722379ad62c98d1e8e6d445c1eeea171ff141b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-11-16 08:04:01 +00:00
hjk
ef658663aa Utils: Remove internal /./ relative path marker
Some creeped into settings earlier, making the paths that were
meant to be empty look non-empty.

Also add a test for FilePath::isEmpty().

Change-Id: I99e3dd673294206558f9fee9b7c7874d2441327e
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-11-16 07:23:46 +00:00
David Schulz
f297b3f1b5 Editor: always configured assistant
A code assistant is not usable without a text editor widget and is
always created as part of one, so make the dependency obvious by require
it in the construction of the code assistant. This removes a bunch of
functions and cheks.

Change-Id: I96556430082ff729d99d2ae2516599f9b8cbc704
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-16 05:24:06 +00:00
Cristian Adam
169f2c4af6 GitHub Actions / COIN: Update Qt to 6.4.1
Change-Id: Icf1600c761989914e5de5ed024d7f4c4f2f01e18
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-15 17:27:06 +00:00
Henning Gruendl
57d3af6d89 QmlDesigner: Fix state group selection
The issue was caused by a mistake during branch merging.

Task-number: QDS-8244
Task-number: QDS-8245
Change-Id: Ib88f0c5201229295c0cec45d806917156bd86d9f
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-15 16:12:17 +00:00
Jarek Kobus
f8a3a4d04e SshProcessInterface: Don't use DeviceShell for control signals
It looks like starting device shell is fragile in some
circumstances.

Fixes: QTCREATORBUG-28072
Change-Id: I1a51d1fb939bd42884a55e1492de808bee89219f
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-15 15:49:18 +00:00
Tim Jenssen
a7cf52cc89 qmldesigner: cleanup connect
Change-Id: Id19c49d7ca7d9f19acf971ae005c868e50aec44d
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-15 15:22:22 +00:00
Tim Jenssen
974c28ee77 qmldesigner: fix possible crash
Task-number: QDS-8246
Change-Id: I91cdf2887c73769adc1bb6d8965426b0ff7e6884
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-15 15:22:16 +00:00
Orgad Shaneh
be3a781581 Debugger: Exclude already-running processes on Unstarted App Debug
Change-Id: I694c627b8da6a8bf7484bf05106b486078201ddd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-15 13:52:35 +00:00
Christian Stenger
8bbeef1f98 Core: Tweak handling of scratch buffer
If a temporary file is stored by using "Save As..."
the temporary state should get lost to properly handle
other actions, like closing a modified file, putting it
into the recent files list, or similar.

Change-Id: I94b3141bad1bd476056a774756071df5f60137aa
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-11-15 13:14:41 +00:00
hjk
e3b84dca1a Revert "Debugger: Avoid some temporary containers when parsing escaped chars"
This reverts commit 19ef8e5c7a which
introduced the following regression:

FAIL!  : tst_protocol::parseCString(octal) Compared values are not the same
   Actual   (parsed)  : "abc\u00C3\u00A4\u00C3\u00A9def\u00C3\u00B1"
   Expected (expected): "abc\u00E4\u00E9def\u00F1"
   Loc: [/data/dev/creator-out/tests/auto/debugger/tst_protocol.cpp(32)]
FAIL!  : tst_protocol::parseCString(hex) Compared values are not the same
   Actual   (parsed)  : "abc\u00C3\u00A4\u00C3\u00A9def\u00C3\u00B1"
   Expected (expected): "abc\u00E4\u00E9def\u00F1"
   Loc: [/data/dev/creator-out/tests/auto/debugger/tst_protocol.cpp(32)]

Change-Id: I59509fd61a54c335ab0a34f8ca0dffb3d75da696
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-11-15 11:40:29 +00:00
Jarek Kobus
adac83367c LinuxDevice: Fix stopping remote app when run in terminal
Before, the SshProcessInterface was trying to run kill
command (on remote host) for the running processId. However,
in case of terminal process the returned processId is an id
of ssh running through creator process stub, not the id of
remote process. The fix is to redirect a call to sendControlSignal
into the internal terminal process.

Change-Id: I57509fd61a54c335ab0a34f8ca0dffb3d75da696
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-11-15 11:11:39 +00:00
Miikka Heikkinen
eae9be4218 QmlDesigner: Unify state handling on puppet reset
Form editor and 3D edit view changed state to base before issuing reset,
and form editor also changed it back to current state after issuing
reset, while all other resetPuppet calls do not change state.
Since puppet reset is asynchronous with small delay, the state changes
done by form editor did essentially nothing, and just changing to base
state in 3D edit view is wrong as we don't want reset to change the
state.

Removed state changes from puppet resets to unify the reset
functionality.

Fixes: QDS-8253
Change-Id: I33be3ec864ffb972010e25c2fb956695201db9ec
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-15 10:12:02 +00:00
Henning Gruendl
4c468e79f7 Update 3rdparty json
Change-Id: Ia6ecadac49eec73b1a3ccf8086aec42ccfea8f5e
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-11-15 09:35:43 +00:00
Eike Ziller
35a37c3450 Merge remote-tracking branch 'origin/8.0' into 9.0
Change-Id: I6a5cd79d60195579538ed8684010d295b4eea047
2022-11-15 09:50:05 +01:00
Andre Hartmann
2bcdc1ee7e QmlJsEditor: Add color preview tooltip
Fixes: QTCREATORBUG-28446
Change-Id: I650c18c0ecf2b6c8572ec3876c38eb313c434392
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-15 08:49:38 +00:00
Robert Loehning
b85183d966 SquishTests: Improve tst_memberoperator
- Update expected behavior
- Update to ClangCodeModel replacing "." with "->"
  only after selecting a completion
- Update to ClangCodeModel no longer announcing
  needed substitution in proposal widget
- Added test for unchanged lines
- Stabilize by using proper wait conditions
- Fix surplus warning

Change-Id: Ia90e0102d44fbd8abb41acaa83509657ad11bf4d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-15 08:48:16 +00:00
Eike Ziller
facb2bdb4d COIN: Adapt to changes in install_qt.py
Change-Id: Ie6acef0baafc5950fd025cc0fe9c3da9bb82a8d6
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Antti Kokko <antti.kokko@qt.io>
2022-11-15 08:42:52 +00:00
Cristian Adam
b36cc91acb Qt Creator Plugin Wizard: Update GitHub Actions yml file config
- move to only Qt6 builds since Qt Creator 9 only supports Qt6
- update the CMake Version
- update actions package versions not to get deprecated warnings
  from GitHub

Change-Id: Ief6c526ade69b4b120f614081bebfff5809101eb
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-11-15 08:38:08 +00:00
David Schulz
4b126550c1 Editor: completely repaint annotations on changed bounding rects
If the rectangle of an annotation changes we need to completely redraw
the annotation since the content might have shifted and the eliding
character is now at a different position.

Fixes: QTCREATORBUG-28411
Change-Id: I41b0f38a73b287e6a5d5318ba797aac6e2ff71b0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-11-15 06:50:59 +00:00
Robert Löhning
80885d12e0 SquishTests: Update tst_installed_languages
Change-Id: Ic06b6241df913ebcfe685936f3c509875a2897bc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-15 06:45:00 +00:00
hjk
90ee349980 Android: Use FilePath as adb pull target for the deploystep
Helpful when the build dir is not on the local host.

Change-Id: I511ed7e4389a9a4dd5b5504bb35e21aadfb20285
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-14 16:51:33 +00:00
Cristian Adam
73ba7e8f98 GitHub Actions: Remove deprecation warnings
This removes the warnings that the jobs display due to upgrades
that will be done for the internal GitHub Actions services.

Change-Id: I4865c7e61f3da04a00f14657a87ecdd63c24325c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-11-14 14:56:37 +00:00
Eike Ziller
3f0f9a63c0 Merge remote-tracking branch 'origin/9.0'
Conflicts:
	cmake/QtCreatorIDEBranding.cmake
	qbs/modules/qtc/qtc.qbs
	qtcreator_ide_branding.pri
	src/plugins/clangcodemodel/clangdcompletion.cpp

Change-Id: Iaa92bf057d7696d2da10802ff95e80863f3235d8
2022-11-14 15:26:20 +01:00
Samuel Ghinet
873ca6d391 QmlDesigner: Fix scene environment color for 3D view
There were two problems:
* When the user checked "Use Scene Environment Color", the initial
  color set as background color was not the one configured in the
  "Scene Environment" clear color. The user had to change this color
  manually.
* If the "Use Scene Environment Color" is checked, then, upon the user
  clicking "Reset View", the background color was changed to a wrong
  value.

Also, fixed an error message in QML.

Task-number: QDS-7436
Change-Id: If42ef1a4532244f3326f5a27a082371aa77d78d8
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-11-14 14:00:50 +00:00
Miikka Heikkinen
889e999f32 QmlDesigner: Clear material preview cache on detach
The previews are cached based on modelnode internal id, which can
overlap between documents, resulting in briefly showing incorrect
preview when new document is opened. Also, never clearing the cache
leads to leaking memory.

Fixed the issue by clearing the preview cache whenever all materials
are removed from browser (model detach and material library deletion).

Change-Id: Idad39fef62871c4e94f35604e643c7195ae9ec81
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-14 13:22:11 +00:00
David Schulz
09ee528c40 Editor: unify assist processor handling
Define the run type of the processor by its implementation instead of a
enum value of the provider. The execution of a processor inside the
assist now follows a unified procedure.

Change-Id: Ibe9fab324c6072e77702c2663946d7a9f562a085
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-11-14 13:02:51 +00:00
Alessandro Portale
993815cb06 ProjectExplorer: Fix build device retrieval in BuildDirectoryAspect
Change-Id: I40aeb4a775a99df7395f4c23476bae7f98201b69
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-11-14 12:46:35 +00:00
Xu Shitong
f27d5b8784 Chinese translation update for 9.0 (Test module)
Change-Id: I6c34ee286747ca0807e3208369a9e305f5c4a299
Reviewed-by: Liang Qi <liang.qi@qt.io>
2022-11-14 12:17:54 +00:00
Eike Ziller
8130494b5f Chinese translation update for 9.0
Change-Id: Ia00b2fdc7b3ea5e144cbdd49ba8e1cab80fbac79
Reviewed-by: Xu Shitong <xushitong@uniontech.com>
Reviewed-by: Liang Qi <liang.qi@qt.io>
2022-11-14 12:17:42 +00:00
Tim Jenssen
b10c135a10 qmldesigner: remove delayedResetView();
Change-Id: Ie577b6b686a10e4e3525ba858a70bea0b4077566
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-11-14 10:57:06 +00:00
Amr Essam
8c7ed5a03e QmlDesigner: Add effect placeholder icon
Placeholder icon until final icons are provided

Task-number: QDS-7713
Change-Id: Ic66f0603ed7088584ea0df6af9f977e732065d3c
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-11-14 10:56:27 +00:00
Ali Kianian
63d30351a6 QmlDesigner: Add "Select Parent" to 3d Context Menu
"Select Parent" action is added to the context menu of the
Edit3DWidget.

Task-number: QDS-8199
Change-Id: Iff6ce50eba966bea60f1b09f497632c3ff290c27
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-11-14 10:54:19 +00:00
Leena Miettinen
d44a62d588 Doc: Describe "rettype" in "putCallItem" Dumper class
Not all Dumper class members are described, so remove or modify the
leading sentences before lists of members. Add a reference to
dumper.py.

Fixes: QTCREATORBUG-28404
Change-Id: Ib681c44f8ff952d2f2ac0a37a5daf12b4b2486d6
Reviewed-by: hjk <hjk@qt.io>
2022-11-14 10:07:58 +00:00