The TODO plugin provides default values for color-coding backgrounds
based on the severity of each item. These colors are rather light, and
there is just one default with no theme awareness.
It is a bug to use a theme-aware text color on a fixed-color background
-- just switch to a dark theme such as flat-dark and observe the
unreadability.
This patch simply ensures that the default settings have reasonable
readability. These defaults are still not theme-aware, but at least they
are consistent.
Change-Id: Ibf35a241c70e0f1ea001b55f84fd2e1dd1a0a2ea
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
In most themes, the color of the warning and error icons differ from the
color of the corresponding textmarks (on the scroll bars). This patch
makes sure that they are the same.
Also the progress bar error color is now the same.
Change-Id: Ibce536bed1a9f43d242c2eddf9f94cc6277b2f64
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Change selectedBackground color to color from flat-dark theme. Now
selected text in help mode is visible.
Task-number: QTCREATORBUG-16375
Change-Id: Ifed68617784f1303bc168e783e4a73bb9da55c8c
Reviewed-by: Konstantin Shtepa
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Change selectedBackground color to color from flat-dark theme. Now
selected text in help mode is visible.
Task-number: QTCREATORBUG-16375
Change-Id: Ifed68617784f1303bc168e783e4a73bb9da55c8c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This is mostly tweaking the shades of green to provide
better constrast against the dark backgrounds. Since
the regular and flat dark themes have different back-
ground colors, the link color differ slightly as well.
Change-Id: I39b1aa82c89ff753513d203be696c64483812028
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
While we're at it, also remove all the weird borders and use standard
icons. The timeline doesn't have a "baroque" theme, it's all flat for
now. If the need arises we can add some gradients here and there.
Change-Id: Ia9ce22d7f412c4999feca2284959be4d734267ac
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
The least invasive way to do that was to chose a brighter background
color.
Task-number: QTCREATORBUG-16702
Change-Id: I4d3d129ddc197e9747079484d9faf104e1b8c3bc
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
The background color for light theme is too dark. Instead of trying hard
to deduct that color mathematically, let's add a theme role for it.
Change-Id: I6a49d43e7e11c87427242819c67988b05b87518b
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
The text should not be white, since it is dran on a bright background.
Change-Id: I1671c84946b9449539c10f7863fe85e04d4dd362
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Selected items in the navigator tree are hard to read. This patch turns
the highlight slightly darker, which makes the light gray navigator item
text easier to read.
Change-Id: Ibe1de477f44ad8dfd7b53c3d7bd92b39ad0ed1a6
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Replace some hard-coded colors with theme colors. That is required for
the Flat Light theme.
Change-Id: I2ce289fce8c2e6437148eb691484e0441975979f
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This patch adds a flag which enables the "fancy" side/tool/status bars
to use the original Window color from the application palette.
The flag is disabled for all themes by default.
Task-number: QTCREATORBUG-16331
Change-Id: I1433e865e1903012d521a2cdb7083f110086e455
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
I use the color from the flat style proposal.
This color seems to work good enough in all themes.
Change-Id: Ie543236fb578141bd3c1fb12c783597b26b12138
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
There is no reason to hardcode the mapping from theming color roles
to QPalette roles, since such a mapping can be easily defined in the
theme itself.
I added optional color roles for each QPalette role.
Themes that do not change the palette do not have to take care at
all and themes that change the palette define only the QPalette roles
they require.
Change-Id: Id195052c96117b7a1a8d7d7d6acacd44e66e22f3
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
The progress indicator does not have enough on the progress bar
background. This change increases the visibility by making the
background brighter, and conforms the success green with the run green
and error red with the stop red.
Task-number: QTCREATORBUG-16634
Change-Id: Icb1e5744b0ad59e9a11d35e6e8f8048326404cbd
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
The progress indicator does not have enough on the progress bar
background. This change increases the visibility by making the
background brighter.
Task-number: QTCREATORBUG-16634
Change-Id: I35562e794e8787b6fa6016ceadafc91ce3906d5a
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
The yellow navigation icons on gray background do not have enough
contrast. Yellow is simply too bright.
In fact, Diana specified blue as color for these icons. This change
turns thesem blue.
Task-number: QTCREATORBUG-16634
Change-Id: I4073da893486c11d4c3ba1da0b7ed3346c2bc4fc
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
We need a new Theme flag for that. And it will initially only be set for
the flat light theme.
Task-number: QTCREATORBUG-16633
Change-Id: Id723e128364eb6186fe8e28e2087a3698b1bf632
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Theme::widgetStyle with its two possible return values makes less sense
than a bool flag. Especially since we already have several separate
theme flags for ui elements which might be "flat" or not.
Change-Id: Ic521bb58c04386b735b784079de05e521bc1f45f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
In preparation od a "Flat Light" theme, where shadows under the icons
would have a negative impact.
Change-Id: I2d9d3563c90336640513c1a970a432898dd63cfc
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
So far, conflicted files were displayed like added ones.
Now they are marked obvious, as they disable the commit button.
Task-number: QTCREATORBUG-16297
Change-Id: Iedf834408a747c4fe5f2133790c5fb81e7fea265
Reviewed-by: Hugues Delorme <delorme.hugues@fougue.pro>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Transparency channel plus shadow create more artifacts than benefits.
This change removes sets the alpha to ff and changes the rgb values so,
that the icons still look exactly as before on the standard toolbar
background.
Te icons will however be better visible on other backgrounds such as
menus.
Change-Id: Idbf2c5c838bad615844ebf2eb63d104f8939b991
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
Also the defaultflat.creatortheme is renamed to flat.creatortheme.
The file name of the "Classic" theme remains default.creatortheme in
order to make sure that who previously actively switched to another theme
and back to default won't suddenly get the flat one.
Change-Id: I1a1f35aded00201a685ad221b70a9b728f2be972
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This change makes GlslCompletionAssist reuse the equivalent icons
from CPlusPlus, and adds specific ones for "Attribute", "Uniform"
and "Varying".
Change-Id: Ic8860274a9f421d28cfec86ed0d1badb7e1cf92e
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
Nothing changes, but this makes it more manageable.
Change-Id: I30879625ae8a46f86499c5f033a3cac129797568
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
Now also for Default Flat theme
Change-Id: I6d0962240b2eb19dbaecc390204c1af2de533d3c
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
Make it the same as disabled icons, so that they are clearly different
from enabled icons.
Change-Id: I8b467745a91dc94cbf2db1cb9a83c927d90ce5c1
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
It was a pure red, which is really hard to read against a dark
background. This patch makes it a pastel red; the same color as error
messages in the application output, which was implemented in f4a9eaf3.
Change-Id: If013c7215d50c3a75d62031ab19874cfb8545cad
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This change makes sure that the "UI coloring" feature respects the
original brightness of the current theme. It prevents dark themes from
getting a too light recoloring and vice versa.
Extra benefit: this allows to remove much recently introduced code.
Change-Id: Ib2c96e7ed172a4cc97520aa4b5d180cc6353c661
Reviewed-by: hjk <hjk@theqtcompany.com>
..by rounding the buttons and adding a theme color role for their background
Change-Id: Icde7bb0be178ffbe65635d336227886ffd902129
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Removing font variations, colors, roundings and gaps.
And it is now better themable.
The examlpes and tutorial selection still needs to be done.
Change-Id: I520814ba9e8ce4fa1d1ca7ec14329955e8a0609a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
And adapting darkframe.creatortheme accordingly to match Diana's
specification
Change-Id: I9e1f62869ff91d7cfd3a26f51d26225d549a0965
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
The progress bar is important and custom enough to deserve its own theme
color for the background. This change adds "ProgressBarBackgroundColor"
and also sets it for dark.cretatortheme, so that it has a good contrast
to ProgressBarColorNormal.
Change-Id: I37731d7a918a862a28940e215c913f9ade8569ca
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
