QStringRef gone.
QSharedPointer is no longer auto-converted to bool.
Small things.
Task-number: QTCREATORBUG-24098
Change-Id: I3a2a55459b905118d1ca81ec015d741ab273471d
Reviewed-by: hjk <hjk@qt.io>
If the selection foregound color is undefined do not overwrite the
already applied highlighting.
Fixes: QTCREATORBUG-24656
Change-Id: Ia125e8e6b9efba73d5a13facc2446a793d59f5c3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
QuickTests are not displayed inside the Tests tree which makes
marking them as failed or trying to run these tests from the
results pane impossible.
Work around by treating them as functions to re-run the whole
function instead of a single data tag if this happens.
Change-Id: I92f6403ff0e02302c52184d4403f0194226a9989
Reviewed-by: David Schulz <david.schulz@qt.io>
Change from QStringRef to QStringView at various places.
Task-number: QTCREATORBUG-24098
Change-Id: Ia7a634fa26464fbb2962724d5f0e188cecc68801
Reviewed-by: hjk <hjk@qt.io>
... with regards to line separator conversion.
This fixes two C++ unit test cases on Windows.
Change-Id: I79256a574221ec83076d984b8f353bc4c0e528a9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
There's no point in keeping ~2 items in a set and convert that
to a list every now and then.
Change-Id: I214b1049fb458e3d159478c47f55b97aacaac75a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
With Qt 5. Fix the bounds checking for midView by copying the complete
logic from Qt QContainerImplHelper::mid.
Fixes: QDS-2806
Task-number: QTCREATORBUG-24098
Change-Id: I0d7d414c159f81a76114b67f55aefbb81f17b034
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: hjk <hjk@qt.io>
The ModelNode has to be always valid, but not the QmlItemNode.
Change-Id: I906f2f6ec101b5d19223a3b5103c81c76f2585fe
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Also, make it possible to extend an existing layout.
Change-Id: Idcbc7ace967e575dd743c7d748f4d3b751668f7a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
... and make use of that in CppTool's "Find Usages" by assigning
different colors to read and write accesses.
Fixes: QTCREATORBUG-12734
Change-Id: I067db2c8d693bb2c5be44249931ee4f0269f7e52
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Using Catch2 on Windows with CMake lead to not having file information
as the file information was generated differently.
Change-Id: I3e0951b517a4a8a86f1ffa1009c1a2815565f3b3
Reviewed-by: David Schulz <david.schulz@qt.io>
We could simply test for the model property but this can lead to strange
behaviour.
Change-Id: I4e326890fb02d312b5210089c957dce026a09f94
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
1. Systematically check for AbstractProcessStep::init() first in
derived classes.
2. Use setupProcessParameters(processParameters()); by default in
the base implementation.
3. Drop all re-implementations that are effectively the same.
Change-Id: I0ae54dd4909b354672a63ee56d0b7c2ea0732494
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Will help to remove some of the remaining hard dependencies of Qnx and
Boot2Qt on RemoteLinux.
Change-Id: I1a327249a9b2903b5b9d869cb9cd60bb50250a5c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
We want greater compatibility for sdktool, and that rules out
QStringView. Use porting.h with Utils::StringView instead.
Change-Id: I44745f4a765c29c5e33d77d80779c79d6a5666e3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This reverts commit df696a34b5.
The commit breaks functionality of Controls in the Property Editor.
* No longer possible to go into edit mode by clicking on a SpinBox
* Drag manipulation is not working on a SpinBox
* Non editable ComboBox can't be opened by clicking on the value
Change-Id: I330fb96b4c72eba72a5a9716a211397dd0c6b8e9
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Model now uses requestModelNodePreviewImage so it's needed in mockup.
Change-Id: I9f9e43b288401de52ac010c333591c9184e10366
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Refactor done to avoid dependency to component core from model.
Change-Id: I8a44285fd41475e8ee1096976e8497b35a9e9b4d
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
* Add ComboBoxes to connection editor dialog
* Add type toggle to dialog
* Add slots and properties to ComboBoxes
* Parse connection expression and fill ComboBoxes
Task-number: QDS-2498
Task-number: QDS-2495
Task-number: QDS-2496
Change-Id: I2cca6d4c85d1508e54d4ad8863056f22ad777ae6
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Text may contain special utf characters which in turn lets
the range of the token become different if handled as normal
byte. This would end up in an assert if the QStringView tries
to access a position after the last character of the text.
Amends 242579099a.
Change-Id: Ie52c15e8729f25da850b539a6a55cca134026c3d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Do not change the current editor after hitting a breakpoint if we
already have an editor open in another split, but switch the focus to
that split.
Task-number: QTCREATORBUG-24646
Change-Id: Id85cecdfb522807bafa097e578509853326a2e31
Reviewed-by: hjk <hjk@qt.io>
Request 3D preview image for material instances from puppet
to show on tooltip.
Support for effect previews is also done, but handler for it is not
registered, as effects cannot be shared between windows due to
issue QTBUG-86616.
Also refactored the preview image support out of navigator
to make it more accessible by other components.
Change-Id: Ie08ba218f929660c2e43d39578997a5a1a883efd
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
