Commit Graph

66382 Commits

Author SHA1 Message Date
Christian Kandeler
ee96c2d9fc ProjectExplorer: Fix assert in MakeStep
... when it's part of a deploy configuration.

Change-Id: I56340ea5553a267daa04b5fd89aff382ec1d27cd
Reviewed-by: hjk <hjk@qt.io>
2020-10-29 17:02:55 +00:00
Johanna Vanhatapio
77b91fd4a9 Doc: Describe Best Practices in QDS
Project files for the example scene will be added as a separate task.

Task-number: QDS-1243
Change-Id: I0bc9bd861d2b6a3c58372cedb2395deb3c78f590
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2020-10-29 15:32:40 +00:00
Eike Ziller
bf8879ee5c TextEditor: Add missing file to dev package
The public header "textdocumentlayout.h" includes "State" from
KSyntaxHighlighting, so we need to export that.
Since it doesn't have the ".h" extension, it doesn't get exported
automatically either. Add a generic function for adding such special
public header files.

Fixes: QTCREATORBUG-24413
Change-Id: I841e6d601df7e925f48eedcc2a28d6b43c00350e
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-10-29 12:58:52 +00:00
David Schulz
f44c447874 ClangTools: enable goto actions for a single diagnostic
Usable nowadays since the action also opens the diagnostic location.

Change-Id: I24a0df606fec5d7e84a2f3450317864f62a4e118
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-10-29 11:44:53 +00:00
Eike Ziller
d5d5068009 Bump version to 4.14 beta2
Change-Id: Ife5666e272697da19e1ba1a96d93281943deb37e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-10-29 10:24:08 +00:00
Leena Miettinen
31b792a72f Doc: Add missing steps to tutorials
Streamline terminology and make some other changes
according to reviewer comments.

Change-Id: Ice84bd55fcb0ed549693c5c471827efc10a627d5
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-29 09:30:08 +00:00
Leena Miettinen
03191936c4 Doc: Update information about using gradients
Describe setting properties for linear, radial, and conical
radients that are supported for Studio Components.

Add screenshots and a gif that illustrates adding and
removing gradient stops.

Change-Id: I9dfbee044b0ae37b217cc833c77f886c391292ba
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-29 09:28:31 +00:00
Henning Gruendl
c019860809 QmlDesigner: Update the Stack (z) context menu
* Rename arrange menu and items
* Remove the "Reset z property" item
* Add reverse item and functionality
* Fix some related typos and formatting

Task-number: QDS-2938
Change-Id: I0e706aefdaed99b28faae4b307146847a54a24ed
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-28 16:43:30 +00:00
Christian Kandeler
b30b2f481c ClangTools: Make "go to next/previous diagnostic" open an editor
It's very likely that the user will want to have the respective location
displayed in the editor.

Fixes: QTCREATORBUG-20658
Change-Id: I34128c6444208571df566725e2ad1675d4456853
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-10-28 14:28:24 +00:00
Leena Miettinen
652feacd5f Doc: Describe Positioner and Layout type properties
Move positioning to a separate topic.
The information in this topic is related not only to the
Library view, but also to the Properties and Form Editor
views.

Describe the properties of the Positioner and Layout types.


Change-Id: I9d00bc9498499f52ecf49463df7f651aaecf8f0e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-28 14:04:04 +00:00
Eike Ziller
ee1e6ca508 EditorManager: Avoid changing the editor in between when closing editors
Do not call setCurrentEditor(nullptr) since this sends a
currentEditorChanged signal which claims that no editor is active, which
can lead to unnecessary updates.
In the specific case, the git branch view was updating with the project
directory as a new repository, and then, after the actual new current
editor was set updated again with the repository of the editor.
This can be needlessly expensive if the previous and new editor are in
the same repository, but the project repository is something else, like
when having the Qt Creator super-repository open, or when editing files
unrelated to the project.

Change-Id: I515c3c40a86bfa2713ff13460ddfda974bc08c59
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-10-28 14:02:27 +00:00
Eike Ziller
30017685e7 build.py: add --add-module-path
Which prepends a path to CMAKE_MODULE_PATH which is required for branding.

Task-number: QTCREATORBUG-22488
Change-Id: I6b0015778d8ceec7183740e5b70eaafd220a3bdf
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-10-28 13:57:59 +00:00
Eike Ziller
3476b8aa67 Consolidate some options for build.py and build_plugin.py
Change-Id: Ic745231ed68296f8052e3b0897893ee8fce53b16
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-10-28 13:57:53 +00:00
David Schulz
bf2276ebde LanguageClient: do not generate diagnostics twice
Change-Id: Ib15f67fb362440fa901ae4118cb176b2bf073fdc
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-28 13:29:51 +00:00
Knud Dollereder
8ca3b557da Update locking state from external views and cleanup
Improve treeview styling related to locking/pinning
    Use font icons.
    Show implicitly locked nodes by darkening text and icon.
    Show implicitly locked curves by darkening the text.
    Show unlocked/unpined icons only when hovering the mouse above the item.
It is now possible to lock/pin multiple curves by locking/pinning the node items.
Load unselected curves into the graphicsview when pinning them.
Rename namespace DesignTools to QmlDesigner.
Remove unused function from the timeline module.
Get rid of a memory leak.

Change-Id: I2c9c0a9e1ffe79520c4869178a11cc5825d04bbe
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-28 13:13:56 +00:00
Christian Stenger
ed678000a1 Scripts: Fix deploying assetimporters on macOS
Change-Id: If990ab8f5dcf482c671d8f39655f5372f8896fd3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-10-28 13:13:07 +00:00
Christian Stenger
050f6b083c Qbs: Fix linking tests when building release with tests
Change-Id: I5df34f06b5ca107b5e85cf6319d6d08aba244e5b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-10-28 13:12:54 +00:00
Vikas Pachdha
ce413d81d0 AssetExport: Export line height value in pixels
Task-number: QDS-2597
Change-Id: I96db25b08db55c3107931ab31e4b9342be92e644
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-28 13:05:24 +00:00
Henning Gruendl
7f44ef76f1 QmlDesigner: Fix view menu constants and comments
Change-Id: If48b80fc2d928d177d59693371ba9d8f9d66bfca
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-28 13:00:50 +00:00
Henning Gruendl
2c91080502 QmlDesigner: Fix navigator root icons clickable
* Fix root item icon columns clickable
* Hide tooltip for root item icons

Task-number: QDS-3006
Change-Id: Icd6177bfce30724bb4806aeec4768232760b35e9
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-28 12:49:57 +00:00
Henning Gruendl
985f6073da QmlDesigner: Fix ColorEditor dragging
Fix ColorEditor dragging by preventing that the mouse event gets stolen
from the Flickable underneath.

Task-number: QDS-2955
Change-Id: I3950d8fce3d3b59980a01f1c96bdb55aab56f263
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-28 12:49:45 +00:00
Christian Kandeler
7b6ab79f3e ClangTools: Do not include our wrapped Qt headers
These are only necessary for the code model and can prevent clazy from
finding certain issues.

Fixes: QTCREATORBUG-24845
Change-Id: I04ba6703812918c39ebbde1dbac5af85fe18622d
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-10-28 12:44:34 +00:00
Christian Kandeler
d2ebc16b92 CppEditor: Fix "move definition" quickfix for template member functions
There are a lot more problems in this area (e.g. with nested classes),
but let's tackle them one by one.

Fixes: QTCREATORBUG-24801
Change-Id: I4b3805ea6f8b28373925693650150bbd89508096
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-28 12:41:26 +00:00
Alessandro Portale
b5e9dd006a Marketplace: Implement a little optimization
Should have been done in a previous commit.

Amends: b77318cb74

Change-Id: Ic3800ca6b6a4e799a5545aa9c68d9f7f7ccfcb20
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-28 12:39:56 +00:00
Eike Ziller
7becdf9a93 More change log for 4.14
Change-Id: I64bf5e2ea9de35180689bce078a892f93ff3d7c1
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2020-10-28 11:36:18 +00:00
Marco Bubke
80d25cdebd CppRefactoring: Disable failing tests
Has to fixed later or removed completely.

Change-Id: I3a62b4ecde60f6877164e994e664f7b015b9d3fc
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-28 11:33:29 +00:00
Friedemann Kleint
f0048ae951 shiboken2tasks.py: Fix for Windows
File names were not captured since ':' was excluded which can
appear in a file name on Windows.

Change-Id: I4bbf08c63faa12d3b76d73e927aef1457c09e02f
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
2020-10-28 09:08:53 +00:00
Eike Ziller
240fba0222 cmake build: Allow branding to change documentation file
Task-number: QTCREATORBUG-22488
Change-Id: I80a1feafa7b027dc99acdb019359037ae0259573
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-10-28 08:53:23 +00:00
Eike Ziller
4c7fd32fa0 cmake build: Add support for setting user file extension
Via QtCreatorIDEBranding.cmake

Task-number: QTCREATORBUG-22488
Change-Id: I42699732640b67672b87b2de06f10b9da57bee7e
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-10-28 08:53:09 +00:00
Marco Bubke
6ba5054c10 QmlDesigner: Simplify threading in image cache generator
Change-Id: Ib969e6dae268c4564239d11c761873092e2dbb17
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-10-27 17:21:24 +00:00
Alessandro Portale
b77318cb74 WelcomeScreen: Don't rely on image format auto-detection
The examples and marketplace pages show images that are decoded from
data buffers. This happened without specifying the encoding format,
which triggers image auto-detection.

The negligible overhead of the auto-detection is usually not a problem,
but the probing of image QImageIOHandlers that goes along with auto-
detection can emit warnings. A concrete example is a warning in the TGA
plugin which was added in Qt 5.15.1.

Task-number: QTCREATORBUG-24853
Change-Id: I596604bde7621acf92e825f45e0c23ac4e90b78d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-27 16:15:10 +00:00
Orgad Shaneh
f487e471aa BareMetal: Remove qualifiers from setting keys
They're pure noise, since there should be no conflicts between base and
derived classes, and there can't be multiple classes for the same provider.

This maintains compatibility when upgrading from earlier versions, but not
for downgrades.

Change-Id: I02655410172ff170fca4893f7b37c2fb1f316aff
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: hjk <hjk@qt.io>
2020-10-27 16:02:13 +00:00
Orgad Shaneh
0a4a1693ec Revert "BareMetal: Get rid of DefaultGdbServerProvider"
And rename it "Generic".

It *is* useful for pre-configuring a device with address, then simply
debugging with F5 instead of going through the Attach to Running Debug
Server dialog and manually choosing the address, port and ELF file.

This reverts commit 46afac5687.

Change-Id: If1e2115e38f38431d70dc8745ffe11ac1a13a7fa
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: hjk <hjk@qt.io>
2020-10-27 16:02:03 +00:00
Lukasz Ornatek
6f489a10c1 Fix predefined annotations
Task-number: QDS-3002
Change-Id: I1ccc586e19d3059a419431188bab58c84441c08c
Reviewed-by: Michael Winkelmann <michael.winkelmann@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-27 15:09:00 +00:00
Miikka Heikkinen
091fb1fc7d QmlDesigner: Fix stall at asset import icon creation
ProcessFinished signaling has changed so that sender() returns nullptr,
so changed the processFinished handling to simply remove all finished
processes.

Change-Id: I6c1d37737cf7fd15840daa1c7d73f2620fab1102
Fixes: QDS-3004
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-27 15:07:56 +00:00
Leena Miettinen
9da8a3f540 Welcome: Link to Qt Design Studio QuickTip: Interactive 3D
Change-Id: I4fd574060f9d753b1fc1279e4387cf721668431c
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-10-27 14:53:39 +00:00
Orgad Shaneh
725f8a01e8 Project: Add files in cmake directory to qmake project
Change-Id: I96a1a32ebe4914a04fd3dc64a77f98cf3a2c5a2e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-10-27 14:52:36 +00:00
Orgad Shaneh
d890534ec5 Project: Add CMakeLists.txt to qmake project
Change-Id: Ifc8246bb801c7e9350c0aabe8debd847063192ac
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-10-27 13:56:43 +00:00
Andre Hartmann
2bc736a4f7 Git: Do not refresh branch view when hidden
Change-Id: Ia2e327b6396657255f9b40b792d794a647fc5745
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-10-27 13:56:14 +00:00
Eike Ziller
7ae976a8b9 cmake build: Use qtc_add_resources for StudioWelcome
Avoids creating resource file if plugin is disabled.

Change-Id: Ia3e1a127c49cae4b03547367a78ca7dd8c3689f3
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-10-27 12:53:54 +00:00
Christian Kandeler
0ebb004d85 CppEditor: Make "Complete Switch" quickfix work with enum classes
Fixes: QTCREATORBUG-20475
Change-Id: Id21a007ab4b652dcfe49d97bfa4c9fa77bacf8c4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
v4.14.0-beta1
2020-10-27 11:40:37 +00:00
Robert Loehning
eef708192e SSH: Use Utils::PathChooser::browseButtonLabel() for button
We have not used this yet to avoid depending on Utils. Now that the
depedency is there anyway, we can use this simplification.

Change-Id: Ic3ff8174aaebc4da289daf1ab4331a10536cdf98
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-10-27 11:24:17 +00:00
Christian Kandeler
2b32b2e440 clangbackend: Provide highlighting for structured bindings
These are reported by libclang as "unexposed declarations".

Fixes: QTCREATORBUG-24769
Change-Id: I7a74b707f4203becabaa74b90758a7b396ee23bd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-27 11:07:44 +00:00
Leena Miettinen
9c0544c386 Doc: List all licenses applied to KSyntaxHighlighting
Added license files.

Fixes: QTCREATORBUG-24618
Change-Id: Ibeeb69f9f072d2c11e0c7a3839bd760986807dd8
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
2020-10-27 09:45:50 +00:00
Assam Boudjelthia
9d3c156fd3 Android: fix parsing Andorid Abis for Qt 6
Amends 4946677df4, to allow
parsing the correct supported Abis from qmake.

Fixes: QTCREATORBUG-24828
Change-Id: I20f8cbf5c0f1bcdf3debb0d9b5c47fa77de163ab
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-10-27 09:16:06 +00:00
David Schulz
061a56143c ClangTools: show all checks in clazy settings
Show all checks if no filter is selected, otherwise checks with no
categories will never be visible (qt-keywords).

Change-Id: I2809afc050c7da6386a3e01d90c8ea6bcb7cab68
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-27 08:50:20 +00:00
David Schulz
d7ab6210af ClangTools: Do not show text marks for suppressed diagnostics
Do not generate marks for automatic runs
and hide them for the explicitly invoked analyzes.

Change-Id: Ic48e7b13c424c51e7e1759c588c94bbd45e6d1bb
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-27 08:50:09 +00:00
Eike Ziller
43facbe090 Revert "cmake build: Disable clangpchmanagerbackend and refactoringbackend"
The change breaks the dev package:

The imported target "QtCreator::clangrefactoringbackend_lib" references
the file
"/home/qt/work/build/qtc_build/lib/qtcreator/libclangrefactoringbackend_lib.a"
but this file does not exist.

This reverts commit 20a6207459.

Change-Id: I68f3b6948bde611b9e5b841d1fde2b136877cbfc
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-10-27 08:37:26 +00:00
Marco Bubke
0f02fd7c87 QmlDesigner: Check if index is positive
Task-number: QDS-2999
Change-Id: I61f4aba59124e6b0eeb0089da31631e7f4e59cbf
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-27 08:26:51 +00:00
David Schulz
6e846b6606 TextEditor: skip painting annotations for disabled text marks
Change-Id: Id05bfe5bd120b2bbb2e2b70fb29a99b8c430e459
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-27 07:38:30 +00:00