Commit Graph

66760 Commits

Author SHA1 Message Date
Christian Kandeler
d2ebc16b92 CppEditor: Fix "move definition" quickfix for template member functions
There are a lot more problems in this area (e.g. with nested classes),
but let's tackle them one by one.

Fixes: QTCREATORBUG-24801
Change-Id: I4b3805ea6f8b28373925693650150bbd89508096
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-28 12:41:26 +00:00
Alessandro Portale
b5e9dd006a Marketplace: Implement a little optimization
Should have been done in a previous commit.

Amends: b77318cb74

Change-Id: Ic3800ca6b6a4e799a5545aa9c68d9f7f7ccfcb20
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-28 12:39:56 +00:00
Eike Ziller
7becdf9a93 More change log for 4.14
Change-Id: I64bf5e2ea9de35180689bce078a892f93ff3d7c1
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2020-10-28 11:36:18 +00:00
Marco Bubke
80d25cdebd CppRefactoring: Disable failing tests
Has to fixed later or removed completely.

Change-Id: I3a62b4ecde60f6877164e994e664f7b015b9d3fc
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-28 11:33:29 +00:00
Friedemann Kleint
f0048ae951 shiboken2tasks.py: Fix for Windows
File names were not captured since ':' was excluded which can
appear in a file name on Windows.

Change-Id: I4bbf08c63faa12d3b76d73e927aef1457c09e02f
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
2020-10-28 09:08:53 +00:00
Eike Ziller
240fba0222 cmake build: Allow branding to change documentation file
Task-number: QTCREATORBUG-22488
Change-Id: I80a1feafa7b027dc99acdb019359037ae0259573
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-10-28 08:53:23 +00:00
Eike Ziller
4c7fd32fa0 cmake build: Add support for setting user file extension
Via QtCreatorIDEBranding.cmake

Task-number: QTCREATORBUG-22488
Change-Id: I42699732640b67672b87b2de06f10b9da57bee7e
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-10-28 08:53:09 +00:00
Marco Bubke
6ba5054c10 QmlDesigner: Simplify threading in image cache generator
Change-Id: Ib969e6dae268c4564239d11c761873092e2dbb17
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-10-27 17:21:24 +00:00
Alessandro Portale
b77318cb74 WelcomeScreen: Don't rely on image format auto-detection
The examples and marketplace pages show images that are decoded from
data buffers. This happened without specifying the encoding format,
which triggers image auto-detection.

The negligible overhead of the auto-detection is usually not a problem,
but the probing of image QImageIOHandlers that goes along with auto-
detection can emit warnings. A concrete example is a warning in the TGA
plugin which was added in Qt 5.15.1.

Task-number: QTCREATORBUG-24853
Change-Id: I596604bde7621acf92e825f45e0c23ac4e90b78d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-27 16:15:10 +00:00
Orgad Shaneh
f487e471aa BareMetal: Remove qualifiers from setting keys
They're pure noise, since there should be no conflicts between base and
derived classes, and there can't be multiple classes for the same provider.

This maintains compatibility when upgrading from earlier versions, but not
for downgrades.

Change-Id: I02655410172ff170fca4893f7b37c2fb1f316aff
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: hjk <hjk@qt.io>
2020-10-27 16:02:13 +00:00
Orgad Shaneh
0a4a1693ec Revert "BareMetal: Get rid of DefaultGdbServerProvider"
And rename it "Generic".

It *is* useful for pre-configuring a device with address, then simply
debugging with F5 instead of going through the Attach to Running Debug
Server dialog and manually choosing the address, port and ELF file.

This reverts commit 46afac5687.

Change-Id: If1e2115e38f38431d70dc8745ffe11ac1a13a7fa
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: hjk <hjk@qt.io>
2020-10-27 16:02:03 +00:00
Lukasz Ornatek
6f489a10c1 Fix predefined annotations
Task-number: QDS-3002
Change-Id: I1ccc586e19d3059a419431188bab58c84441c08c
Reviewed-by: Michael Winkelmann <michael.winkelmann@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-27 15:09:00 +00:00
Miikka Heikkinen
091fb1fc7d QmlDesigner: Fix stall at asset import icon creation
ProcessFinished signaling has changed so that sender() returns nullptr,
so changed the processFinished handling to simply remove all finished
processes.

Change-Id: I6c1d37737cf7fd15840daa1c7d73f2620fab1102
Fixes: QDS-3004
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-27 15:07:56 +00:00
Leena Miettinen
9da8a3f540 Welcome: Link to Qt Design Studio QuickTip: Interactive 3D
Change-Id: I4fd574060f9d753b1fc1279e4387cf721668431c
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-10-27 14:53:39 +00:00
Orgad Shaneh
725f8a01e8 Project: Add files in cmake directory to qmake project
Change-Id: I96a1a32ebe4914a04fd3dc64a77f98cf3a2c5a2e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-10-27 14:52:36 +00:00
Orgad Shaneh
d890534ec5 Project: Add CMakeLists.txt to qmake project
Change-Id: Ifc8246bb801c7e9350c0aabe8debd847063192ac
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-10-27 13:56:43 +00:00
Andre Hartmann
2bc736a4f7 Git: Do not refresh branch view when hidden
Change-Id: Ia2e327b6396657255f9b40b792d794a647fc5745
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-10-27 13:56:14 +00:00
Eike Ziller
7ae976a8b9 cmake build: Use qtc_add_resources for StudioWelcome
Avoids creating resource file if plugin is disabled.

Change-Id: Ia3e1a127c49cae4b03547367a78ca7dd8c3689f3
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-10-27 12:53:54 +00:00
Christian Kandeler
0ebb004d85 CppEditor: Make "Complete Switch" quickfix work with enum classes
Fixes: QTCREATORBUG-20475
Change-Id: Id21a007ab4b652dcfe49d97bfa4c9fa77bacf8c4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
v4.14.0-beta1
2020-10-27 11:40:37 +00:00
Robert Loehning
eef708192e SSH: Use Utils::PathChooser::browseButtonLabel() for button
We have not used this yet to avoid depending on Utils. Now that the
depedency is there anyway, we can use this simplification.

Change-Id: Ic3ff8174aaebc4da289daf1ab4331a10536cdf98
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-10-27 11:24:17 +00:00
Christian Kandeler
2b32b2e440 clangbackend: Provide highlighting for structured bindings
These are reported by libclang as "unexposed declarations".

Fixes: QTCREATORBUG-24769
Change-Id: I7a74b707f4203becabaa74b90758a7b396ee23bd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-27 11:07:44 +00:00
Leena Miettinen
9c0544c386 Doc: List all licenses applied to KSyntaxHighlighting
Added license files.

Fixes: QTCREATORBUG-24618
Change-Id: Ibeeb69f9f072d2c11e0c7a3839bd760986807dd8
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
2020-10-27 09:45:50 +00:00
Assam Boudjelthia
9d3c156fd3 Android: fix parsing Andorid Abis for Qt 6
Amends 4946677df4, to allow
parsing the correct supported Abis from qmake.

Fixes: QTCREATORBUG-24828
Change-Id: I20f8cbf5c0f1bcdf3debb0d9b5c47fa77de163ab
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-10-27 09:16:06 +00:00
David Schulz
061a56143c ClangTools: show all checks in clazy settings
Show all checks if no filter is selected, otherwise checks with no
categories will never be visible (qt-keywords).

Change-Id: I2809afc050c7da6386a3e01d90c8ea6bcb7cab68
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-27 08:50:20 +00:00
David Schulz
d7ab6210af ClangTools: Do not show text marks for suppressed diagnostics
Do not generate marks for automatic runs
and hide them for the explicitly invoked analyzes.

Change-Id: Ic48e7b13c424c51e7e1759c588c94bbd45e6d1bb
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-27 08:50:09 +00:00
Eike Ziller
43facbe090 Revert "cmake build: Disable clangpchmanagerbackend and refactoringbackend"
The change breaks the dev package:

The imported target "QtCreator::clangrefactoringbackend_lib" references
the file
"/home/qt/work/build/qtc_build/lib/qtcreator/libclangrefactoringbackend_lib.a"
but this file does not exist.

This reverts commit 20a6207459.

Change-Id: I68f3b6948bde611b9e5b841d1fde2b136877cbfc
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-10-27 08:37:26 +00:00
Marco Bubke
0f02fd7c87 QmlDesigner: Check if index is positive
Task-number: QDS-2999
Change-Id: I61f4aba59124e6b0eeb0089da31631e7f4e59cbf
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-27 08:26:51 +00:00
David Schulz
6e846b6606 TextEditor: skip painting annotations for disabled text marks
Change-Id: Id05bfe5bd120b2bbb2e2b70fb29a99b8c430e459
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-27 07:38:30 +00:00
Eike Ziller
781d54249e cmake build: add qtc_add_resources to API
Adapted from qt6_add_resources. Takes a list of files and compiles these
into a resource file.

Change-Id: I375aa17b76e283b90bc0cbe8b6859520bcac7da3
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-10-27 06:45:52 +00:00
hjk
045881089f QmakeProject: Don't crash on project import
Amends fc1fc6a07a.

Fixes: QTCREATORBUG-24802
Change-Id: I62e7e0bab82ae1b025c053785b77586aa78bcd1f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-10-26 16:30:11 +00:00
Eike Ziller
20a6207459 cmake build: Disable clangpchmanagerbackend and refactoringbackend
By default. Previously only the corresponding plugins were disabled, but
not even building the backends makes more sense.

Change-Id: I36d61869a3050f37da1f480dea89e7539dda599a
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2020-10-26 15:34:22 +00:00
Christian Kandeler
7e5ec83c1b Get qbs build closer to building with Qt 6
Change-Id: Idf96a03db3b3f1aa5af07fb59f261250d7787e61
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-26 15:25:10 +00:00
Christian Kandeler
a8a6a9e774 ProjectExplorer: Make project window state persistent
Task-number: QTCREATORBUG-24690
Change-Id: Ia261fc5a98681676e8d67e6d840f2f48073cdbb2
Reviewed-by: hjk <hjk@qt.io>
2020-10-26 13:54:04 +00:00
Cristian Adam
6c841dfbd0 GitHub Actions: Update to use Clang 11.0.0
Change-Id: I015a71a4f53ff3be8609a00bdef47c93161af882
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-10-26 12:47:46 +00:00
Henning Gruendl
2c65e2323c QmlDesigner: Fix delegateMargin not used warning
Change-Id: I981607f68cad9a55e3d8f4b43e33eb14db515c47
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-26 12:45:31 +00:00
Ivan Komissarov
e062f542dd Update Qbs submodule to the top of 1.17 branch
Change-Id: Ibcd9d1b05d66038e4a9071cedc5c236cd8edb649
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-10-26 11:46:25 +00:00
Assam Boudjelthia
1f9124c976 CMake: update project templates to work with Android for Qt 6
Qt 6 introduces qt_add_executable() function, which for Android
make sure to call few Android specific functions like:
* qt_android_generate_deployment_settings()
* qt_android_add_apk_target()
* qt_android_apply_arch_suffix()

Using add_library() only the user would otherwise need to reimplement
what's already implemented in add_qt_gui_executable().

Task-number: QTCREATORBUG-24681
Change-Id: Iec3984139844fe1cbac2d9a583b3c40bdaa308a0
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-10-26 10:42:06 +00:00
Henning Gruendl
15db0bb173 QmlDesigner: Rework SpinBox dragging functionality
* Replace DragHandler with MouseArea due to the DragHandler not being
  able to accept MouseEvents
* Replace TapHandler with MouseArea due to MouseArea stealing press
  signals from TapHandler, but needed to get press events due to
  removal of DragHandler
* Add functionality to keep cursor in place while dragging
* Keep ActionIndicator visible while dragging
* Fix qsTr in RectangleSpecifics

Change-Id: I6558623287e1864359128d4194c9db78736ee3a4
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-26 10:37:47 +00:00
Henning Gruendl
fcb3fabd13 QmlDesigner: Update look and feel of navigator
Task-number: QDS-2880
Change-Id: I5e54e6c35afe8bd0149f35486ac308ce0ea0d59a
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-26 10:37:35 +00:00
Marco Bubke
553929f322 QmlDesigner: Ensure that cache directory exists
We write data to the cache directory and it is easier to ensure it at
the initialization of the plugin than in multiple different places.

Change-Id: I2b6e5d607e1b28b13ee4968842d21d4dad7aaf15
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-26 09:51:56 +00:00
Mahmoud Badri
98d7b5b6e5 QmlDesigner: Optimize deleting nodes
- remove unnecessary call to directSubModelNodes()
- replace foreach with for (avoid unnecessary copies)

Change-Id: I42721a4c4e69f320664af8364f8baa0df0d11459
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-26 09:38:11 +00:00
Mahmoud Badri
4a3bd72db8 QmlDesigner: Fix duplicate locked item entries
Fix: When selecting more than 1 ancestor of a locked item and pressing
Delete, the locked item will appear duplicate in the warning message
box as many times as the number of selected ancestors.

Change-Id: I72c5e35edb2974da3d630a87e236b58e0d7e8ab3
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-26 09:37:53 +00:00
Christian Kandeler
cc4bd3b738 TextEditor: Add "F1" hint to tooltip if and only if help is available
Note that this does not have performance implications, as we already
call HelpItem::isValid() in the same code path.

Fixes: QTCREATORBUG-24782
Change-Id: I8495099c97233e4df4b8d2a30579fb6324122e92
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-10-26 09:15:48 +00:00
Eike Ziller
5e67bc5055 Fix build with Qt6
Add missing includes for "incomplete type" issues.
Remove usage of QDesktopWidget.
Don't compile native WebKit help backend (missing native widget integration).
Add SvgWidget dependency.

Task-number: QTCREATORBUG-24098
Change-Id: I1b3afb54d385940ff283824870fa7454866212a4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-26 08:44:21 +00:00
Assam Boudjelthia
62e84f129a Android: fix "uninstall app first" checkbox placement
Change-Id: I2f79e9a5c344e5364fa377422f682f8e0c2927e2
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-10-26 07:13:30 +00:00
David Schulz
859d2edbb5 TextEditor: Always destroy old context when displaying new proposal
This makes sure that the old proposal widget is disconnected from the
finalizeProposal slot and thus prevents resetting the currently shown
proposal.

Change-Id: I80d58d9a04831d464bea69697568359990ac5260
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-10-26 05:00:49 +00:00
Kai Koehne
4d8cd5fa03 Welcome screen: Add "Get Qt" link
Change-Id: Ic3a6210a0b1600ae308bbdb43f0c50fc72d910e8
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-10-25 08:47:07 +00:00
Ivan Komissarov
28b09227e4 Update Qbs submodule to the top of 1.17 branch
Change-Id: I9551c70eaa1b5f2c3f9413f90c8c1d7b7394622f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-10-23 13:52:47 +00:00
Christian Kandeler
916db8e781 Utils: Use std::stable_sort() in Utils::sort()
Potentially makes for a more consistent user experience, and does fix
some CppTools test failures on macOS.

Change-Id: I5bfd7a2460248450ad92259956598532fb7fb8ee
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-10-23 12:11:39 +00:00
Vikas Pachdha
8848eb7d7e AssetExport: Use QFontInfo for font properties
Task-number: QDS-2867
Change-Id: I7a5d622f4f43cc8a73e29950616595a314bb6ffc
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-23 12:01:21 +00:00