Commit Graph

66760 Commits

Author SHA1 Message Date
Christian Stenger
6b62a99a8a cmake: Fix building debug with release libclang
Parts of QC cannot be linked against a release build of clangTooling
libs and vice versa when building on Windows.
Check whether the provided libs match the current build mode and
disable respective parts if necessary.
Re-use this information to decide whether unittest should be build
or not.

Change-Id: Ibc2aab0d7886e78ebbf8f15a43152efad49f1eff
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-11-23 11:07:49 +00:00
Eike Ziller
05a1b2a6e8 cmake build: Remove unused component "Dependencies"
We don't use it for packaging, nor for github anymore, it duplicates a
whole lot of logic, and that only partially (as an example fixing the
RPATH for clang tools on macOS is missing), and the Clang part only
works with CMake >= 3.14 ("file(READ_SYMLINK"), which was the final
trigger of this patch.

Change-Id: I21ff6b01297009eff15bda36963e729dea4927c8
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-11-23 10:46:39 +00:00
Assam Boudjelthia
34a7f6f9f2 Android: remove newline chars before adding output in error/warning pane
The output of androiddeployqt that is picked by QC, can contain newline
char at the start of the received line like:
"\nNote: Recompile with -Xlint:deprecation for details."
Such output is sould be only a warning
and not an error, that's we try to remove the newline from the start to
avdoid this behavior.

Fixes: QTCREATORBUG-24881
Change-Id: Iad7556917cb0f53dc691dfb316f999ad504976e9
Reviewed-by: hjk <hjk@qt.io>
2020-11-23 07:23:07 +00:00
Jarek Kobus
8cee978e55 Don't declare override when final is declared
Amends: eccebe41dc

Change-Id: I93c5be09fd47a591a5b797f529c74f76bd975b50
Reviewed-by: hjk <hjk@qt.io>
2020-11-23 07:04:00 +00:00
Leena Miettinen
50456e8a92 Doc: Add hardware and software recommendations for QDS
Fixes: QDS-3032
Change-Id: Ia11963a006141d2f53a8154faf7db6edccc5ea4a
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-11-20 17:36:40 +00:00
Christian Kandeler
f4450c4b72 MCU: Fix qbs build
Change-Id: Ie235f0242d7d67130031ad342695ae38edda79a1
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-11-20 17:27:24 +00:00
Eike Ziller
f534624fce Fix build with newest Qt 6
No implicit casts from QString to QFileInfo anymore, and a few more
QChar(int) fixes.

Task-number: QTCREATORBUG-24098
Change-Id: I3326fc0701a9259c7bdd2d8c3025de0a4774f8aa
Reviewed-by: hjk <hjk@qt.io>
2020-11-20 15:43:25 +00:00
Jarek Kobus
01331893ad Don't call virtual method from Exception c'tor
In case a static s_shouldAssert is true, we were calling
virtual description() method from the c'tor of base Exception
class, which was reimplemented in subclasses.
This could cause a crash, since reimplementations
were using not initialized yet private fields.

We fix it by de-virtualizing the description() method
and instead we pass the description in overloaded, protected
c'tors. Original c'tors still use the default description
that was used for base Exception class.

In addition we make all private fields const, and
make showException method non-virtual, as it didn't have
any overrides.

Change-Id: I7ebae1809ab423e990276e500f9c0db569d10e2d
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-11-20 15:09:48 +00:00
Leena Miettinen
2241e45891 Doc: Update some icons and move them to icons folder
Change-Id: I06867460704b6ff085cd2f06042c0dce81d26377
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-11-20 14:46:51 +00:00
Jarek Kobus
d97f663e3b Fix includes
Change-Id: I8eeade519a874df0c1dc3c2c6213c66d1df001f6
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-11-20 14:25:32 +00:00
Jarek Kobus
6b588d7227 Remove unused variables
Mark some of them with Q_UNUSED, since it looks like
sometimes the copy is done on purpose, to force detach
or used for some hack with memory management.
In one case make unused variable used again.

Change-Id: I3825cd3399fa63bf6e12173c64509287d4a125e5
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-11-20 13:58:46 +00:00
David Schulz
06bc4203cf CDB: fix signed char container dumper
"signed char" might be reported as a template type but cannot be found
when looked up, so just strip the "signed" from the typename and lookup
char.

Change-Id: I70e3b27d5c3bfd9e65da0a9f14b6a2df2c7e8dde
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-11-20 13:44:38 +00:00
Alessandro Portale
6108479040 McuSupport: Fix CMake build
Baremetal -> BareMetal

Change-Id: I083c75a03513b8b8f8635e2e60212e6f600b1a34
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-11-20 13:19:37 +00:00
Dawid Sliwa
3929917ecb McuSupport: Add support for kits with IAR compiler defined
- added IAR toolchain factory similar to ARM GCC one
- extended kitName with used compiler name
- added Unsupported toolchain type to fix crash after creating kit with not
  recognized toolchainID

Fixes: QTCREATORBUG-24898
Change-Id: I28b8376ca4bc88d3d75e17bd242ac49f0ee09845
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <christiaan.janssen@qt.io>
2020-11-20 12:50:11 +00:00
Jarek Kobus
c9f5ce51e0 Don't use iterators to temporary containers
Fix a clazy warning, like:
Don't call QVector::begin() on temporary [clazy-temporary-iterator]

Indeed, we may pass begin and end iterators for 2 different
instances of temporary vector (shared though).

In addition: use const iterators.

Change-Id: Iac1055d9fc226f1b48ca72ee4f3aab433addfe7f
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-11-20 12:25:31 +00:00
Thomas Hartmann
f7fa53d29b QmlDesigner: Track usage of graphical views
Change-Id: I0631816980178100dcd61b65d792fc38504199d5
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2020-11-20 11:36:54 +00:00
Thomas Hartmann
83036eff4c QmlDesigner: Add more trace points
Change-Id: I618e027785676de8492cd698f109579abb9b053a
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2020-11-20 11:19:45 +00:00
Alessandro Portale
7b03e0701d Utils: Fix uneditable TextEditDisplay StringAspect
Change-Id: Ia3f912021b1d4d3cd407d191f8f452149a346c69
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2020-11-20 11:18:58 +00:00
Aleksei German
181fd57cc4 QmlDesigner: Fix for rotation cursor
- Added new icons to icon font
 - Uses new drawing method for rotation cursor

Task: QDS-3131

Change-Id: Ifa8dda2630794694dd262396ca314a9b4e6675ad
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-11-20 10:49:52 +00:00
Eike Ziller
f38d7910fe Help: Make litehtml the default engine above all
If available prefer litehtml, even over QtWebEngine. But make the
default compile-time configurable with a CMake option
DEFAULT_HELPVIEWER_BACKEND.

Amends 5e73215a0a

Change-Id: I5bfadd3ec1dc21f3a94d04d0da51783223908e6d
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
2020-11-20 10:12:00 +00:00
hjk
ff3614ab5a Debugger: Don't use QApplication::alert too often
There's an ICore::raiseWindow() call already for spontaneous stops,
conditioned on boolSetting(RaiseOnInterrupt). This should be sufficient
for normal operation.

Task-number: QTCREATORBUG-12769
Change-Id: I33daad2579f9cfdb8fd121b9c9db73c05f9eccb7
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-11-20 09:47:36 +00:00
Leena Miettinen
ec6b6f3671 Doc: Add link to Qbs attributions into toplevel Readme.md
Task-number: QTCREATORBUG-24622
Change-Id: Icff751b12fc03d18f5d1fd4f8dd191a344a9981b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-11-20 09:41:48 +00:00
Eike Ziller
d981485a89 Help: Remove Qt version check
We are requiring Qt 5.14 now

Change-Id: I2deb97dec4800ab10c25f7f6223a8c440a3a9c3f
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2020-11-20 09:32:27 +00:00
Eike Ziller
1dcb7e5550 Help: Register at least one set of documentation per major Qt version
The default configuration only registers documentation files only once,
from the highest registered Qt version. This made sense within the Qt 5
series, since Qt documentation for the higher version included all items
from the lower versions.

With Qt 6 this changes - some API was removed in Qt 6. To make sure that
documentation of all Qt 5 API is still available, we have to register
the newest available documentation for Qt 5 and Qt 6, not only of Qt 6
(the overall newest available documentation).

Expands 3dfa188182

Change-Id: I8b2984b0be11dcc823ef4a206800c84887b632ca
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2020-11-20 09:18:40 +00:00
Christian Kandeler
f697a0d46c ClangCodeModel: Fix sorting of includes when auto-completing
... by treating the directory separator specially.

Fixes: QTCREATORBUG-21490
Change-Id: Iad6f51f39516a88bd14ba1eddcf2c6656490ee5b
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-11-20 08:43:41 +00:00
Jarek Kobus
b77d661152 Don't call virtual method from LocatorPopup's c'tor
Rename LocatorPopup::updateGeometry into doUpdateGeometry in order
to not clash with QWidget::updateGeometry.

Move a call to doUpdateGeometry from LocatorPopup's c'tor
into subclasses c'tors. Make subclasses final.

Change-Id: I601731e6c883631c3d484ed7f11d82a99bb1f731
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-11-20 08:23:45 +00:00
Leena Miettinen
95685898a5 Doc: Edit info about MCU support and add screenshot
The QML Types tab displays only the supported types, so
that will tell users which types are supported.

Change-Id: I49dd1f7d81401a84b8780fdc61f49870c58c3935
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-11-20 07:58:44 +00:00
Leena Miettinen
552a86f6b3 Doc: Link to Qbs licenses and attributions
Fixes: QTCREATORBUG-24622
Change-Id: Ieeb35e94f1409a849383bc88739047b3b30bbe26
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-11-20 07:57:21 +00:00
Eike Ziller
5c0ec9210c Fix initial directory when using konsole for Open Terminal Here
Fixes: QTCREATORBUG-24947
Change-Id: I14f5b47ba2ad71005653faadd5e78fda9570196e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-11-20 07:31:44 +00:00
Leander Schulten
993b614d94 CppEditor: Remove using namespace quickfix: Don't insert inline namespaces
Change-Id: If386d31de723ca928d3c50f55e32205c50937b0a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-11-19 18:35:05 +00:00
Leena Miettinen
bb9ca6227c Doc: Describe rotating items in Form Editor
Fixes: QDS-3067
Change-Id: Id97876edaccac0d567694a9fcf350701d9df926b
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-11-19 17:35:49 +00:00
Johanna Vanhatapio
253a758d89 Doc: Update Applying 3D Effects
Task-number: QDS-3087
Change-Id: I2e2f4e70f98fbb54b32d22ce64307f48a1c79832
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2020-11-19 16:34:09 +00:00
Leena Miettinen
3daf838cc3 Doc: Describe "Get Qt" option in Welcome mode
Update screenshot.

Change-Id: Ia209ba65a27f213c3248d4d2535eac6cebd03774
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-11-19 14:48:24 +00:00
Marco Bubke
9b6944086b MultiLanguage: Add image generation for excel export
Change-Id: Ied15381d94c391c86438c66fe88f755421bb3492
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-11-19 13:22:44 +00:00
Thomas Hartmann
a369c5b10c StudioWelcome: Add option for UsageStatistic plugin
Change-Id: I865d4594ca8cd40390b561731259ddb51c83641c
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-11-19 11:41:39 +00:00
Thomas Hartmann
3440baecd3 QmlDesigner: Allow building the fallback puppet in QDS
This allows supporting a puppet with Qt 6 built.
In later versions we should remove this again.

Change-Id: Ia5b0a34ab3fb071e895e88e5086749ba499ef63f
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-11-19 11:27:46 +00:00
Leena Miettinen
095970a57b Doc: Describe MCU support for types and properties
Fixes: QDS-3072
Change-Id: I3050b706b597d6f9171932c0ab5884b7d8ee094c
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2020-11-19 10:39:40 +00:00
hjk
a812bd7303 Debugger: Make qfloat16 dumper test pass with Qt 6
45.3 is represented as 45.28125 in Qt 5, but as 45.3125 in Qt 6.
Actually an improvement.

Task-number: QTCREATORBUG-24098
Change-Id: I779bfd8a2b4a2ae91f5e40dbe54ba75000531f4c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-11-19 10:23:27 +00:00
hjk
113fc9d060 Debugger: Adapt QStack dumper to Qt 6
Task-number: QTCREATORBUG-24098
Change-Id: Ibbe2f0c1faface1a1d6893eb0cb3987e5dff1b1a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-11-19 10:22:40 +00:00
Eike Ziller
bdc74ea2a0 cmake: Show errors for unsupported CMake versions
Show an error icon in the CMake settings, and instead running CMake with
unsupported parameters show an error in the Issues pane.

Arguably it should not be possible to select an unsupported CMake
version in the kit settings at all (neither manually nor automatically
when setting up kits), but this is the less intrusive change for now.

Fixes: QTCREATORBUG-24553
Change-Id: I32caa2ce93d28cbd9db90e2004d60da93d32c68c
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-11-19 09:51:27 +00:00
Jarek Kobus
36d5e328e4 Fix listening to signals after library and linkage type changes
Change-Id: I437fbbcfde4c4781bf8b5b4711a597e64410c785
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-11-19 09:49:17 +00:00
Eike Ziller
86c8c2541e Fix overlapping accelerators
With the View menu.

Fixes: QTCREATORBUG-24614
Change-Id: I2814a3ccae0f10e5c49482534bce024fab68f271
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2020-11-19 09:49:05 +00:00
Jarek Kobus
2341609719 Avoid signal overloading
Choose a different name for them.

Change-Id: Ie2cc2c85dca72b7f7ff84c95fb0abd0a0e99a63d
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2020-11-19 09:48:38 +00:00
Christian Stenger
f54784cbbe ClangSupport: Fix missing include
Amends 2ce783f96d.

Change-Id: Ib0fc37b146959ecdf9c329c45321f29cd7a18a0e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-11-19 08:17:39 +00:00
Jarek Kobus
eccebe41dc Fix a warning about calling virtual method from d'tor
Fix the following clang-tidy warning:
Call to virtual method 'IosRunner::stop' during destruction bypasses
virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall]

Remove the reimplementation of IosRunSupport::stop(), as it was
calling base implementation. Make base IosRunner::stop() a final
method.

Change-Id: I8e57a6dd6a44d2a6f00f5af96a11530f62c92429
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-11-19 07:41:56 +00:00
hjk
92cd7f3c06 Debugger: Adapt QMap and QMultiMap dumper to Qt6
Chicken out of the QStringList == QList<QString> in Qt 6 dilemma
by using QList<QString> everywhere, that's not important for the
QMap test. value/key vs first/second nevertheless needs adaptation.

Task-number: QTCREATORBUG-24098
Task-number: QTCREATORBUG-23806
Change-Id: I4bdb8222978de7e7f1596be380e0fedc8f9d1a06
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-11-19 07:24:26 +00:00
Eike Ziller
f99e46c148 cmake: Fix version information about unsupported cmake tool
When registering a CMake version without fileapi support and setting
that in a kit, the kit shows a warning about unsupported version. It
didn't show the version of the registered CMake though. Make CMake tools
without fileapi return their version number.

Change-Id: I388d3e0a17ff4145238c5c90109522665a6f6fac
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-11-19 07:06:38 +00:00
Eike Ziller
953db51a15 cmake: Remove unused variable
Change-Id: I17d373088c3f2085c52ebf9230b3ce2f0f64074a
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-11-19 07:06:31 +00:00
Christian Kandeler
7aec256087 QmlDesigner & friends: Fix various new warnings
Change-Id: Ia5e3d47e70e1881e70652f090ccc61543535df4e
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
v4.14.0-beta2
2020-11-18 17:05:51 +00:00
Alessandro Portale
a1ff9d170f CppTools: "CLANG-UPGRADE-CHECK: Update known language features macros."
Clang++ 11 has __cpp_constexpr_in_decltype

Change-Id: I450a79f2af8cd6aca51b95b11b3c06b9682c0418
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-11-18 15:40:15 +00:00