Commit Graph

608 Commits

Author SHA1 Message Date
hjk
caa9a99228 debugger: stream line acknowledgement of breakpoint property changes 2010-11-18 16:08:10 +01:00
hjk
c448ae842d debugger: fix markers for breakpoints in constructors 2010-11-18 15:48:17 +01:00
hjk
7ffa0927cf debugger: better synchronize icon selection for editor and view marker 2010-11-18 15:48:17 +01:00
hjk
4943d19907 debugger: don't replicate response.fileName as markerFileName etc. 2010-11-18 13:38:58 +01:00
hjk
bf1f351f29 debugger: first step to re-enable breakpoint location update. 2010-11-18 12:31:26 +01:00
Friedemann Kleint
8888b8f532 Debugger: Introduce common messages to engine.
Try to achieve consistency in reporting stop messages for all
engines. Report by BreakpointId if available.
2010-11-17 17:16:34 +01:00
Oswald Buddenhagen
1e362b0f8b overhaul process argument handling
get away from argument stringlists. instead, use native shell command
lines which support quoting/splitting, environment variable expansion
and redirections with well-understood semantics.

Task-number: QTCREATORBUG-542
Task-number: QTCREATORBUG-1564
2010-11-17 13:19:07 +01:00
hjk
4e1452fd59 debugger: handle disabled breakpoints on debugger startup again 2010-11-16 18:14:44 +01:00
hjk
a9a9143b5d debugger: replace BreakpointPending state with a flag in BreakpointResponse
To keep the breakpoint state machinery simple
2010-11-16 18:14:44 +01:00
hjk
fd8bf48b2b debugger: start tightening the breakpoint state machinery 2010-11-16 17:09:55 +01:00
hjk
cbc1854f7b debugger: some simplification after engine objects are no more re-used 2010-11-16 12:52:02 +01:00
hjk
38428e5feb debugger: make the command timer a direct member of GdbEngine 2010-11-16 12:46:02 +01:00
hjk
d7a75dff9e debugger: breakpoint code cosmetics 2010-11-16 12:43:17 +01:00
Friedemann Kleint
78a560a6df Debugger: Stop in case of gdb crash in InferiorStop.
Reviewed-by: hjk
Task-number: QTCREATORBUG-3099
2010-11-16 12:39:24 +01:00
Friedemann Kleint
ac51d53587 Debugger: Fix useFullPath in gdb. 2010-11-16 12:17:00 +01:00
hjk
694503cc76 debugger: looks like the BreakpointData layer is going to be unneeded. 2010-11-16 11:09:09 +01:00
hjk
76d2c58161 debugger: move marker filename and linenumber to BreakpointItem 2010-11-16 10:50:26 +01:00
Friedemann Kleint
29beabd5a4 Debugger: Handle throw/catch/main as BreakpointType enum values.
Remove BreakHandler::hasPendingBreakpoints, handle new types
in CDB and gdb. Start fixing Breakpoint-Dialog.
Add assignment of Breakpointresponse from BreakpointParameters.

Reviewed-by: hjk
2010-11-16 10:23:20 +01:00
Friedemann Kleint
9fc5970bdb Debugger: Introduce BreakpointParameters as base struct.
For Breakpoint data manipulation.

Reviewed-by: hjk
2010-11-15 17:04:29 +01:00
hjk
50dc4d8664 debugger: update display on engine exit 2010-11-15 16:58:23 +01:00
hjk
0b32820a48 debugger: work on breakpoint enabling/disabling in gdb engine 2010-11-15 16:22:51 +01:00
hjk
8ae541b36f debugger: Refactor breakpoint handling.
The breakpoints are now (fairly) tightly guarded by the BreakpointHandler.
Engines and Views are only supposed to refer to them by id. They also have
individual states now. The breakpoint data is split into a "user requested"
"fixed" part in BreakpointData and the engines' acknowledged data in a new
struct BreakpointResponse.

TODO: Move m_state and m_engine members to BreakpointResponse. Fix regressions
in the marker handling.
2010-11-15 12:09:25 +01:00
hjk
2161e0f6d9 debugger: refactoring of the plugin interface
There's  some 'external' and some 'internal' part now. Other plugins
are only supposed the external interface.
2010-11-10 12:08:23 +01:00
Friedemann Kleint
4ac2634de7 Debugger: Make Gdbmi threads parsing code re-usable.
Adapt watchutils code for new engine.

Acked-by: hjk
2010-11-08 17:15:33 +01:00
hjk
df04e57585 debugger: move more gui bit from engine to plugin 2010-11-08 15:45:37 +01:00
hjk
702e9f3fb9 debugger: cosmetics 2010-11-05 13:36:18 +01:00
Tobias Hunger
cf3a418cd8 Fix spelling in comments
Krazy was complaining about those.
2010-11-03 12:45:34 +01:00
Friedemann Kleint
6510a749b7 ProjectExplorer: Move ToolChainType enumeration into separate Header.
Acked-By: dt
2010-11-01 14:25:24 +01:00
hjk
0afb34d5eb debugger: refactor breakpoint type, add function name to resolved jsbreakpoints 2010-10-29 14:31:16 +02:00
hjk
974bfe375c debugger: remove/update some cruft 2010-10-27 15:39:25 +02:00
hjk
ab967902d8 debugger: prepare removal of plugin()->updateState(this); 2010-10-27 14:21:33 +02:00
Oswald Buddenhagen
dfee3388af Merge remote branch 'origin/2.1'
Conflicts:
	share/qtcreator/templates/qmlapp/app.pro
	src/libs/utils/filesearch.cpp
2010-10-18 20:59:12 +02:00
Arvid Ephraim Picciani
4d14920ad6 clean up WatchData
Reviewed-by: hjk
2010-10-15 15:19:11 +02:00
Arvid Ephraim Picciani
728ef58b16 clean up ThreadData
Reviewed-by: hjk
2010-10-15 12:05:13 +02:00
hjk
b576f50228 debugger: some polishing after fbe6f96869
Mac gdb does not like the idea.

Reviewed-by: Joerg Bornemann
2010-10-14 13:06:46 +02:00
hjk
fbe6f96869 debugger: Do not automatically kill gdb on internal errors.
This improves overall debugging experience after some "mostly harmless" errors.

Reviewed-by: Friedemann Kleint
Task-number: QTCREATORBUG-2004
2010-10-12 16:05:38 +02:00
hjk
14ec1b793f debugger: fix debugger state when gdb stops faster than it acknowledges the order to run.
Reviewed-by: Friedemann Kleint
2010-10-12 13:33:20 +02:00
Christiaan Janssen
24912c3f2e QmlObserver: breakpoint list is shared between engines
Reviewed by:  Kai Koehne, Andre Poenitz
2010-10-05 11:01:14 +02:00
Friedemann Kleint
d5596bf169 Debugger: Remove unused 'precise breakpoints' setting.
Remove break window menu action to toggle 'Full path'.
Remove gdb setting 'Use full path'.
Clean up break dialog:
- Set PathChooser::ExpectedKind before value (showed up in red).
- Use PathChooser::setPath()/path() instead of lineedit text
- Return thread spec
- Add validator for ignorecount as for breakcondition.ui
Remove unused fields from breakcondition.ui

Reviewed-by: hjk
Task-number: QTCREATORBUG-2593
2010-10-04 16:04:38 +02:00
hjk
2883af4bb2 debugger: properly initialize m_hasInferiorThreadList
Reviewed-by: Friedemann Kleint
2010-09-30 09:52:30 +02:00
Friedemann Kleint
bf8dedaade Debugger: Handle synchronous startup fail (Windows).
Make DebuggerRunner handle QProcess::startFailed
correctly on Windows (synchronous signal emission
within startDebugger()).
Remove debug output/warnings.

Reviewed-by: hjk
2010-09-29 10:32:41 +02:00
Friedemann Kleint
8d6f67f594 Debugger: List break on catch/throw as such and map names in engine.
Introduce special setting 'Stop on exception' for CDB.
Reviewed-by: hjk
2010-09-28 16:42:21 +02:00
hjk
ea4b64dee4 debugger: remove rarely needed "Recheck Debuggging Helper Availability"
context menu entry.

It was more a debugger debugging aid in the early days of compiled dumpers
anyway.

Reviewed-by: Friedemann Kleint
2010-09-28 13:15:42 +02:00
hjk
0f02786d16 debugger: don't mention python on Mac 2010-09-23 17:18:53 +02:00
hjk
5da888e73b debugger: don't even attempt to load the python dumpers on Mac. 2010-09-23 15:41:20 +02:00
Friedemann Kleint
13c97d652e Debugger: Fixes around watch editing.
assignValueInDebugger: Pass on WatchData as well, pass
on values as QVariant. Based on that, do more extensive
checks in CDB, preventing assignment of non-PODs.

Locals/Watch editing:
* Disable while running
* Edit pointer values as hex with validation.

CDB: Strip class types off reported pointer values and reformat
the values as short 0x-pointer values, introduce flag to
WatchData::source to do dumper expansion handling.

Windows: recognize int64 as int.

Register handler: Fix accessing uninitialized value.
2010-09-23 13:22:08 +02:00
hjk
034bb72dc4 debugger: make alphabetic sorting of struct members optional.
Task-number: QTCREATORBUG-1608
2010-09-23 11:17:01 +02:00
hjk
02283ea84d debugger: rename output window into log window 2010-09-22 16:22:57 +02:00
hjk
727c16a690 debugger: make adjustments of breakpoint markers on lines without code optional 2010-09-21 17:03:13 +02:00
Friedemann Kleint
1d978a3618 Debugger: Sanitize Datatypes, part 2: Stackframes.
Make address a quint64. Enable DisassemblerViewAgent
to match the disassembly-addresses by converting the numbers,
making it more robust. Remove the complicated formatting needed
for CDB.
2010-09-21 15:12:33 +02:00