Without this, "line in lineUnderCursor(w)" can be False
although "line == lineUnderCursor(w)" is True.
Change-Id: I7fa6be7d237957706bf1ad93d7303c55b81f24ec
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Threads are still considered joinable after their execution. So sleeping
thread have to be joinded first. Add test
Fixes: QDS-12308
Change-Id: Ie01588293e3b7ce9fe149d52a25ba03d174cca88
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
* Add QTC_CHECK for crash
* ActionAreas should not be "garbage" collected if they have no target.
* Initial ActionAreas do not have a target and ActionAreas without target make sense to a user. We do not want to delete them together with the target.
Task-number: QDS-12181
Change-Id: Ie520c47aad990a8ff07fc3346e6772226d334ce5
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
QC nowadays provides lldb on Windows which gets automatically
registered.
Beside this correct expectations for the compiler based on the
LLVM path that had been used for building the QC package and
might be the same on the machine the test runs on.
Change-Id: Ie9553b79bb0eb0012386bd71422005c184638046
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
Use an elapsed timer in the syntax highlighter to periodically return
from the highlight and push a continue highlight to the end of the event
loop.
This allows the user to interact with the editor in between those
batches. If the user modifies the document in between highlighting
batches, the area that still needs a rehighlight is increased if needed.
This also reverts 62ea85ee6a and the
related changes.
Task-number: QTCREATORBUG-28727
Change-Id: I7c394dbdff658330bb72f3b68b9928980947db75
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The documentation page "Building and Running an Example" is not listed
in "Contents" anymore.
Change-Id: I7fdc01707f63d924bf215f398b7c710e62ec41f7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Other code expects all of them to be collapsed, but Creator 13 expands
them when checking. This change makes sure they are collapsed afterwards.
The new code is backwards compatible with the old behavior.
Change-Id: Ic698fb17f3ad1573195e7e0f7bcf722beed74ffc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Deeply under the hood, the color for ther Spinner was determined by the
QApplication palette, color role "Text".
In order to run the spinner on a dark toolbar (in a non-dark theme),
though, the color needs to be bright. It is the case for the
ScreenRecorder.
This change adds a color setter to the Spinner classes, adds colored
Spinners to tst_spinner and makes use of the feature in the
ScreenRecorder.
The default color of the Spinner remains QApplication palette, color
role "Text".
Change-Id: Ia75758707f225b1f994e73c5a314478101c80f5e
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
The old sources used deprecated features.
Done by:
1. Assuming that current Creator works correctly because
it is passing the test with the old sources.
2. Replacing the .tsv's contents with what Creator
generates from the new sources on Linux.
3. Removing everything from the .tsv which is not found
in the same place on Windows.
Change-Id: I31f0f1a46c1972d8c717c216275dd453ca74fc27
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
...to decouple them from the sources used in other tests.
Change-Id: I80b3ea1478cdffdc28933e4320971f98a11d1898
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Rename process.h back to qtcprocess.h
MSVC's "threads" standard header includes <process.h>, and that ends up
including our process.h from Utils.
There already was a hacky workaround in place for a similar issue with
MINGW, but that doesn't work with MSVC because that doesn't have
Simply use a name that doesn't conflict.
Change-Id: I1159cd2096b4f2dbc4a1728d0131dd6edd30ebd3
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
(cherry picked from commit 5af531cd39)
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The model needs the project store, the path cache, the imports and the
file path. So we now use a method in the model to copy them over to the
new model.
Task-number: QDS-12102
Change-Id: I80f911d55c5a5fdf9d1a87c1f4888e498086374b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
If the project storage is activated the old API will be deprecated.
Hepefully people now stop to use the old API. You can still use it but
you have to write an implementation for the new one too.
Task-number: QDS-12102
Change-Id: Iac23da1648ff44e27a2ee7840e0d3eeb1fb8caf9
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
tst_APTW01 explicitly disables the Clang Code Model
so there is no filter category of that name.
Change-Id: I7378e11582bb0231a24404cca212a234ef7f37ed
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Seems they are not being created anymore.
Change-Id: I8b48a848793fb73ea193918c14c322d6166b2053
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The previous setting
- wastes space, leading to problems when both the function name
and the parameter (or, more likely, the argument expression)
are long-ish.
- necessitates re-formatting of the entire argument/parameter list
on function renaming.
Change-Id: Ica82e284f9a5a8f2cf244938996039a59ce0b3aa
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Some tests are failing because of QTCREATORBUG-30466
unless someone resizes Creator's windows manually.
Task-number: QTCREATORBUG-30466
Change-Id: Ibeecc2abd85839be3497691912e411862c465a89
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Rename process.h back to qtcprocess.h
MSVC's "threads" standard header includes <process.h>, and that ends up
including our process.h from Utils.
There already was a hacky workaround in place for a similar issue with
MINGW, but that doesn't work with MSVC because that doesn't have
Simply use a name that doesn't conflict.
Change-Id: I1159cd2096b4f2dbc4a1728d0131dd6edd30ebd3
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
... following an argument with an array subscript operator.
Fixes: QTCREATORBUG-29225
Change-Id: Iba38043d94be718efee30ce50f5b55aac4ba6ecd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
After encountering the namespace keyword, we have to backtrack the state
change introduced by the inline keyword.
Fixes: QTCREATORBUG-22071
Change-Id: I543976622d1a56b2c61d68da6ec3eee8b6d0d5b3
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
