panelWidget() and isInUnstyledDialogOrPopup() in ManhattanStyle.cpp
would mark the contents of this dialog as "panel widgets". In order to
evade this, we don't set the dialog type of the Crop&Trim dialog to
Qt::Windows.
The author of this dialog did not leave us a comment on why Qt::Windows
was chosen, so we can assume it was done for no particular reason.
Fixes: QTCREATORBUG-29893
Change-Id: I90f653e39cee839203b8767cb30eadab69baaf09
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
But this time ignore unhandled exceptions which were caused by the
'threads' command in certain situations.
Amends db307978bf
Change-Id: I50819306eeb392ebae8dc869694ed588739c44fb
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Use less specific #include to get EnvironmentAspect.
Change-Id: I570c6a0871c63f5857d56ff640e95f10463fce5e
Reviewed-by: Dominik Holland <dominik.holland@qt.io>
Qt Design Studio uses a specific Qt Runtime version to
run the projects. This document lists the Qt runtime
versions used for different Qt Design Studio releases.
Fixes: QDS-12052
Change-Id: Ia9411393db4d800945c85ac67e4a9872a611308c
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
It is supposed to be shown in the tool tip, so set the tool tip instead.
Fixes: QTCREATORBUG-29174
Change-Id: Ib2572b71dfccf18276e63fadb7dbe386949b0275
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
We do not go out of our way to retain the old settings value, as the
setting affects only the UI behavior in the same widget it is displayed
in.
Change-Id: Ie0d66b3909364e15a05013eddaf742b161941f67
Reviewed-by: David Schulz <david.schulz@qt.io>
Button states can have individual text tokens assigned. Depending on the
used fonts and platform-specific renderer, any of these states may have
the highest widts. Consider all of them and use the maximum.
Change-Id: I51caccef9e34c1911c2773b8836dba722ad63c47
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Seems they are not being created anymore.
Change-Id: I8b48a848793fb73ea193918c14c322d6166b2053
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
You can now activate fly mode in 3D view by pressing right mouse
button. In fly mode, cursor is hidden and mouse controls edit camera
rotation directly, and WASDQE can be used to move the camera around.
Fixes: QDS-12030
Change-Id: I52550502632af19de36a1557d9aac84ff3cb18cc
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
This is a valid path to try the unauthorized access first,
and when it fails we automatically try the authorized access.
So we shouldn't bother the user with an error on a failure
on unauthorized access to the dashboard info.
Change-Id: Ia27686f804415741da614e36802551f8d8d610ed
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Andreas Loth <andreas.loth@qt.io>
The crash in the syntax highlighter was resolved so we can switch the
default back to synchronous highlighter.
This reverts commit 0539e2a0f6.
Change-Id: I2e9cdb818420a14d01565d58def14f88cf5e895d
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
This is done by the FutureSynchronizer d'tor, so no need to call
it explicitly. Move the FutureSynchronizer as the last field of
CreateSimulatorDialog so that its d'tor is executed first.
Change-Id: I861e4c6498b63909fe52965ca16343ef82d20b42
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The SyntaxHighlighterRunner is deleted by deleteLater in the
TextDocument destructor. This makes it possible that the
SyntaxHighlighter inside the runner lives longer than the document
itself. Avoid this by making the document the parent of the
SyntaxHighlighter like before the async highlighter patch series.
Fixes: QTCREATORBUG-30494
Change-Id: I6ce9c35ab400b17f2a1a6f3c3bd98df23f41c71e
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
When using the cursors provided by QC we should scale them according
to the pixel ratio otherwise the icons appear too small.
Task-number: QTCREATORBUG-29980
Change-Id: Ia9de8a5adf4bbd457971260edc52f824ddb7564f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
It is possible that the internal signals are missed which
results in a stale cursor until it gets changed again.
Explicitly handle the hover event and set the cursor there.
This also makes the need to restart QC obsolete when toggling
the respective option.
Task-number: QTCREATORBUG-29980
Change-Id: I51dfa6fda018a325d43cddae99f395cd8c0accde
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This reverts commit 1c47a0a301.
Changing the default revealed a crash that seem to be caused by the
async syntax highlighter infra structure changes. Revert the default for
now to figure out the cause of the crash.
Task-number: QTCREATORBUG-30494
Change-Id: I1d0388c29d206cb25f2d58e4b305aa8303db2a60
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This moves the separator lines into the respective areas, so that the
lines also disappear when their area collapes. Looks cleaner (for pixel
obsessed people like me).
Change-Id: I314c2c462767666638eae57087606f2a6ca4ae4a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Limit the Deploy Configuration and the CMake step to CMake projects.
Change-Id: If198dc2e4277861f2aa9183c5eeed0cc1d40727c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
The AndroidDeviceFactory only registered the AndroidDevice creator
function if the Android SDK was correctly set up. That check occurred
only once during the Qt Creator start up sequence.
As a consequence, Qt Creator had to be restarted after an initial set up
of the Android SDK. Users are not notified of such requirement, and we
actually don't want to enforce a restart.
With this change, the AndroidDevice creator function is always
registered, and the "Add Android Device" wizard always selectable. Users
who try to add an Android device without having set up Android before
get to see an info message box.
Change-Id: I0600e36575c2dd075af9398597c3c8dab3bb243d
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The indicator was used for tab views of controls 1.
There is no current use case. We have seen
crashes related to the indicator.
Change-Id: I0466aecfd5ae598e07ebbfe8d1277ce23116e183
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Added mechanism of highlighting restart when the previous
highlighting was interrupted.
Change-Id: Ic44c06442fd9f0002fed760472d5d39903e7ef50
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
That were configured for a project.
The crash is triggered by a messy combination of the Android automatic
kit creation, project window update, and automatic creation of Qt
versions and kits by the automatic project importers, including a mess
of the listener pattern without any atomicity.
- the user removes the Qt versions
- the Android plugin updates the automatic kits and individually reports
the removed kits (*)
- that triggers an update of the project window and an update of the
target setup page (even if that is not shown, but that's yet another
issue)
- that triggers the project importers, which add Qt versions, which in
turn triggers another update of automatic kits in the Android plugin -
while that is still in the reporting loop at (*)
- that leads to the crash, because the state at this point of time is a
mess
This minimal fix of the specific crash makes the kit update reporting in
the Android plugin at (*) "more atomic", and the same for similar code
in the iOS plugin.
Fixes: QTCREATORBUG-30347
Change-Id: I2bea6fb735abcaa34469fc43f44aa37313f70429
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The previous setting
- wastes space, leading to problems when both the function name
and the parameter (or, more likely, the argument expression)
are long-ish.
- necessitates re-formatting of the entire argument/parameter list
on function renaming.
Change-Id: Ica82e284f9a5a8f2cf244938996039a59ce0b3aa
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
"threads" causes an exception in my jdb on my machine. "suspend" and
"resume" do not, and they also cause enough delay for JDB to settle.
Change-Id: I5297d720c5fdbe5ee2eaa421624491af50bc40bf
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
They are now edited in an editor next to the variable list.
Task-number: QTCREATORBUG-30209
Change-Id: I8eb46272a2b4b3b92ebf93247f4ef33ee4114b6f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Use copies of messages to avoid their reference going out of scope
Fix increment current message index for when there is only one
message
Fixes: QTCREATORBUG-30360
Change-Id: I26fac50ed171aaed7d178cc8f97ace401bf49e7c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Hide the locator docs from the QDS Manual because the
locator is not visible in the Code view.
Task-number: QTCREATORBUG-29361
Change-Id: Iecbbaece78b0cd6a496289fd9a00acfdd054d41f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
