Remove it also from aspect container.
Change-Id: I0af093bbd5654083dac581e5793ec57e1c7a7b3d
Reviewed-by: Andreas Loth <andreas.loth@qt.io>
Reviewed-by: hjk <hjk@qt.io>
3b5c377ce5 had fixed them
for GCC >= 13, but unfortunately made them no longer
compile on Windows with MSVC as reported in the Gerrit
change, error below.
Align the implementation of the custom allocator
more with the "23_containers/vector/52591.cc" [1] ones
referred to in the GCC commit [2], in particular
define ctors, so this compiles with both GCC on Linux
and MSVC on Windows.
Move the definition of that custom allocator
to a new macro "MY_ALLOCATOR" to avoid duplication.
Previous error with MSVC:
C:\Program Files\Microsoft Visual Studio\2022\Preview\VC\Tools\MSVC\14.38.33130\include\xstring(3141): error C2440: 'static_cast': cannot convert from 'myallocator<char>' to 'myallocator<_Tp1>'
with
[
_Tp1=std::_Container_proxy
]
C:\Program Files\Microsoft Visual Studio\2022\Preview\VC\Tools\MSVC\14.38.33130\include\xstring(3141): note: 'myallocator<_Tp1>::myallocator': no overloaded function could convert all the argument types
with
[
_Tp1=std::_Container_proxy
]
C:\Users\davschul\Downloads\Archive\main.cpp(8): note: could be 'myallocator<_Tp1>::myallocator(myallocator<_Tp1> &&)'
with
[
_Tp1=std::_Container_proxy
]
C:\Program Files\Microsoft Visual Studio\2022\Preview\VC\Tools\MSVC\14.38.33130\include\xstring(3141): note: 'myallocator<_Tp1>::myallocator(myallocator<_Tp1> &&)': cannot convert argument 1 from 'myallocator<char>' to 'myallocator<_Tp1> &&'
with
[
_Tp1=std::_Container_proxy
]
C:\Program Files\Microsoft Visual Studio\2022\Preview\VC\Tools\MSVC\14.38.33130\include\xstring(3141): note: Reason: cannot convert from 'myallocator<char>' to 'myallocator<_Tp1>'
with
[
_Tp1=std::_Container_proxy
]
C:\Program Files\Microsoft Visual Studio\2022\Preview\VC\Tools\MSVC\14.38.33130\include\xstring(3141): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
C:\Users\davschul\Downloads\Archive\main.cpp(8): note: or 'myallocator<_Tp1>::myallocator(const myallocator<_Tp1> &)'
with
[
_Tp1=std::_Container_proxy
]
C:\Program Files\Microsoft Visual Studio\2022\Preview\VC\Tools\MSVC\14.38.33130\include\xstring(3141): note: 'myallocator<_Tp1>::myallocator(const myallocator<_Tp1> &)': cannot convert argument 1 from 'myallocator<char>' to 'const myallocator<_Tp1> &'
with
[
_Tp1=std::_Container_proxy
]
C:\Program Files\Microsoft Visual Studio\2022\Preview\VC\Tools\MSVC\14.38.33130\include\xstring(3141): note: Reason: cannot convert from 'myallocator<char>' to 'const myallocator<_Tp1>'
with
[
_Tp1=std::_Container_proxy
]
[1] https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=libstdc%2B%2B-v3/testsuite/23_containers/vector/52591.cc;h=ea80bb277c1f49190ae21b64e738428066eba1e0;hb=64c986b49558a7
[2] https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=64c986b49558a7
Change-Id: I13a3ed226a411479ea1d24a2eda490c8f293bf8f
Reviewed-by: David Schulz <david.schulz@qt.io>
The ApiToken is stored locally safely by using QKeychain lib.
If the local store doesn't contain the ApiToken,
we show the password input dialog to the user.
If the user pressed OK, we send a network query to axivion
server to retrieve the ApiToken for the username + password.
Change-Id: I0dc19aea67750cd674ae4db9a9f469e4621c713b
Reviewed-by: hjk <hjk@qt.io>
Don't report an error on non-existing key read.
Finish with success and provide empty optional data in this case.
Change-Id: I7c4ea50c0f05e13ce793384ec57d50dfff600c9a
Reviewed-by: hjk <hjk@qt.io>
Use std::unique_ptr instead, as QScopedPointer doesn't offer release().
Change-Id: I8e885e477d1aeb8ce9462e8fd249a5196424df18
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Use sections instead of a table and move or copy text from
other topics. This is to create a place for information that
becomes homeless when I remove other topics.
Task-number: QTCREATORBUG-29361
Change-Id: Ib3fcc2c345080e05f9f7ad4ed78e049c899e0855
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Selecting a window from the Window menu didn't bring up minimized
windows from their minimized state, and resulted in two items being
checked in the window list (because the active window did not change, so
the checkmarks where not updated).
Change-Id: Ie89b87fa1273378bb99f69026a58ee92ea0b8f50
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
After a window is closed we don't only have to update the texts of the
action, but also update their visibility state and the checked item.
Fixes: QTCREATORBUG-30381
Change-Id: Id0c343b8a5930ec2e3de03f71bdc8f2628b492b3
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
When opening new editor windows, we want the _window_ to have the
EditorManager context as well as the individual window context, but the
window _actions_ (close, etc) may only be registered for the individual
window context.
Add the corresponding option to ICore::registerWindow et al.
Change-Id: I67d0a6b386603e0047a77dfb357c207e7ffe99e6
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
This does not yet fix the reported problem but at least attaches and
gives a working QML inspector in a QML-only debugging session.
Task-number: QTCREATORBUG-30263
Change-Id: Ieac517c2b7c5dde24792f3bbcffe0058073ddbd1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
- Update the screenshot of Preferences > Build & Run > General
(there is a new option that will be described in another
change)
Task-number: QTCREATORBUG-29361
Task-number: QTCREATORBUG-30209
Change-Id: I62eaeef96b2d40dfec42022a4430da15c1590050
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
- Update screenshots of kit selector and Devices preferences,
which now show the device status
- Turn running on QML and Linux into their own topics
- Remove conditions because the projects folder is excluded from
QDS Manual
Task-number: QTCREATORBUG-30209
Task-number: QTCREATORBUG-29361
Change-Id: I869f6b577016c6712c6b37170dbee2249ded1f8e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
So if the device turns out to be unresponsive, users will not be
confused about the temporary freeze.
Task-number: QTCREATORBUG-30319
Change-Id: If65d6ea2777232239c8fb324b06352d92ad451c6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Calling QToolButton::setCheckable on a button with a defaultAction
doesn't work as expected. It needs to be called on the action itself.
Amends acedf93ba3
Fixes: QTCREATORBUG-30382
Change-Id: Icbddb1d331fe6547622bf0428d890012fef0d9c5
Reviewed-by: David Schulz <david.schulz@qt.io>
- Explicitly set a shorter timeout. After the menu appears, it
should not take that long until the item is there, too.
- Warn when an item can't be found. This should not go unnoticed,
because it either means that the GUI changed or that there's a
bug in the test. Both require a fix.
Change-Id: Id7faa2b91926c392bd0d894214f498d8ba8edaa1
Reviewed-by: Jukka Nokso <jukka.nokso@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
I noticed that Creator built on Qt 6.6.0 never needed longer than
two seconds to update the documentation after adding qtcreator.qch.
The same sources of Creator built on Qt 6.6.2 needed up to four
seconds. This subtle difference can lead to the situation that the
documentation was not yet updated when clicking "Getting Started"
in tst_WELP01, which then just displays an empty page.
Change-Id: I11ab2a902825190ed8ae27dad55a847f01ba44dc
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Some effect related objects such as QQuickShaderEffectSource can be
silently removed alongside another object, so use QPointer to ensure
all objects are still valid before readding them.
Fixes: QDS-11973
Change-Id: I75ee2dc81e27774f8be87b031e149b135ec84023
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
It's the "persisted" form of the content of the original aspect's data,
calling it 'aspect' already confused me a few times.
Change-Id: I88a6f76f0ca39d3d36dde9b84287032ceecf7033
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The dragged effect is collapsed when dragging start, which helps with
large nodes. Autoscrolling content was added when dragging nodes to
the top/bottom of the scrollview.
Fixes: QDS-10857
Change-Id: I5027324918a200746356704e36a6d99cb98aa04e
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
We forgot to quit the event loop in the case of an incompatible build
graph, causing each such operation to take ten seconds instead of
fractions of a second. In directories with lots of qbs builds, this
could result in Qt Creator freezing for several minutes.
Change-Id: I9f3de2e23fd67a87e9f487eb2a1b6e45fbde6f31
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Since we were adding the parallel item unconditionally to the
tasks list, the if(tasks.isEmpty()) condition was always false.
The intention was to check whether any call to addClangTool()
added at least one task.
The fix is to add parallel item after the condition is checked.
Change-Id: Iafdf21f1ac0f8fdd547a462990313e09a2dc46fd
Reviewed-by: David Schulz <david.schulz@qt.io>
We want one-or-more debuggers enabled. This was accidentally not
done if the python debugger was the last one to unselect.
Change-Id: I1bcdb43a66dc110dc213eba0db079e6d02c00170
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This might be useful when using conditional operator.
Might also be used in place of the default c'tor for GroupItem.
Add a test for it.
Change-Id: I622e5d3d94f7020dc294cf5bca643c53a0813d8a
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Detected by memory analyzer.
When shutdown comes while pythonsFromRegistry() or
pythonsFromPath() is still running, the corresponding
QFutureWatcher is leaked.
Employ TaskTreeRunner instead. It handles the cancellation
of the running tasks automatically on its destruction.
Make pythonsFromRegistry() and pythonsFromPath() cancelable,
by providing QPromise as a parameter and check for canceled
state on every iteration.
Change-Id: Iae7c7d1ed764646b8203bd7ca8b9580cb999b80c
Reviewed-by: David Schulz <david.schulz@qt.io>
