Commit Graph

88532 Commits

Author SHA1 Message Date
Cristian Adam
45fb2c0986 CMakePM: Remove pointer check for null
The pointer contains the parent class passed with "this" and will never
be null.

Coverity-Id: 1568097 Dereference after null check (FORWARD_NULL)
Coverity-Id: 1568100 Uninitialized pointer field (UNINIT_CTOR)
Coverity-Id: 1568111 Dereference before null check (REVERSE_INULL)
Change-Id: I40e32d162689c749d498c4a63c073c0e336a3626
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-10 07:30:36 +00:00
David Schulz
6c9a710036 Utils: remove Q_ASSERT in comment detection
Change-Id: I076397ee56887c8b402d4c2b97838ceade165412
Reviewed-by: hjk <hjk@qt.io>
2023-10-10 07:11:32 +00:00
David Schulz
01dc62b019 Editor: Fix loading color schemes
When the user switched to another builtin color scheme the full paths
check do not match anymore if the user starts a Qt Creator with a
different install dir.

Change-Id: I4692c85a23a7d524497786db4dd8e1a00bb7a9fe
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-10 06:53:22 +00:00
Christian Kandeler
e607c5530e Wizards: Fix "pragma once" check
Obviously, boolean functions return a string that you need to compare to
"true" and "false" explicitly.
Amends 8e75381fce.

Fixes: QTCREATORBUG-29713
Change-Id: I19966555badd67f95f51ea1c1757d8b86e727010
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-09 15:26:08 +00:00
hjk
6620add7df Debugger: Use device env of gdb for its own use
Fixes: QTCREATORBUG-29556
Change-Id: I966d4f226c4eee08ba35e1b3dfc6fcd1d771ce6f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-09 14:58:35 +00:00
Cristian Adam
380ca70d61 CMakePM: Add manual test for code completion / navigation
Change-Id: Id7ad47babf4c6fff8e7b823805d6ccf858a3d513
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-09 14:42:03 +00:00
Cristian Adam
6010b096c1 CMakePM: Move specific manual tests to cmakeprojectmanager
Previously this folder didn't exist, but now it's better to have
them all in one place.

Change-Id: Ib8a2f24157a34e817e653929d01dfc9675f1c019
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-09 14:41:54 +00:00
Cristian Adam
a5f8214c23 CMakePM: Consider local CMAKE_PREFIX|MODULE_PATH for code completion
If projects are using a local "cmake" directory containing
Find<Package>.cmake modules the common practice is to use something like
this:

  ## Add paths to check for cmake modules:
  list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")

This commit makes sure that these packages are taken into consideration
for code completion.

Change-Id: I152ccce0c97ab2385eda93ff6bc5fc4e7cefb6c4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-09 14:41:45 +00:00
Cristian Adam
ad13144cc0 CMakePM: Search after packages in CMAKE_PREFIX|MODULE_PATH
This way code completion will have Qt6 package suggestions for
find_packages.

Change-Id: I9ab64425f850a0d990e77a559ce9f121bc9cf2d7
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-09 14:41:35 +00:00
Samuel Jose Raposo Vieira Mira
55039d6975 Update supported feature list for MCU in QDS 4.3 docs
. Connections to mention Item Qt as Call functions is not filtered
. Translations to Partially Supported but using regular Qt
. Curves to that QtForMcus 2.6 supports easing.bezierCurve

Task-number: QDS-9959
Change-Id: Ib60223609f90f108e1a029d093f9fbeda3c82b64
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
Reviewed-by: Yoann Lopes <yoann.lopes@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-10-09 14:14:39 +00:00
Marco Bubke
740e1edb98 Sqlite: Remove default constructor
Because it holds a reference it is not possible to have a default
constructor.

Change-Id: I442bedf5fb2abfd79ad64520c74636340dabf741
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-09 14:05:18 +00:00
Marco Bubke
9236b1b019 QmlDesigner: Modernize the code a little bit
Change-Id: I24dffa459ad8a948fd58d83249cb07c827a6343f
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-10-09 14:05:03 +00:00
Marcus Tillmanns
8169e233c0 CompilerExplorer: Add Toolbar button to add source
Change-Id: I0d8fb50fe1ce5305a93b524a9807997124ab119b
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-09 13:02:31 +00:00
Xavier BESSON
23908b283e Bookmarks: goto on double click + drag & drop on view
Change-Id: Iec21843fb6679d156e9839f84e56005b8eef7f32
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-09 12:47:26 +00:00
David Schulz
6adaa850e8 LSP: rename Create/Rename/DeleteFile classes
Since they clash with default windows functions and cause issues with
PCH build.

Change-Id: Ice0339c7dad14b40e172c885ffb71d923469614a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-10-09 12:30:08 +00:00
hjk
8af6d16b6c TextEditor: Hide LineNumberFilter implementation
One of the two non-standard items exposed in the TextEditorPlugin class
interface.

Change-Id: I89755c6a2b168f31b69d3904d6d043273b462ea6
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-09 12:23:25 +00:00
Jarek Kobus
d278923dd4 CMakeParser: Ensure the details list isn't empty
Amends bda5c6a228

Fixes: QTCREATORBUG-29732
Change-Id: Iac518227df42c4d22b808028958210485a9c02ff
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-10-09 12:15:22 +00:00
hjk
04ee682bcc Core: Remove SessionManager::isStartupSessionRestored() mechanism
Apparently not used anymore.

Change-Id: I0ea8f70979450799c979ca5cd3314c834560b336
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-09 12:14:38 +00:00
Jarek Kobus
222bae949f BuildSystem: Remove unused signal
Change-Id: I5d0d58f749633dd2a00448868fc6068f9866972c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-10-09 12:12:15 +00:00
Eike Ziller
3b516524e3 Fix QmlProfiler when built with Qt 6.6
qrc:/qt/qml/QtCreator/Tracing/TimelineLabels.qml:29:5: Cannot override
FINAL property
         property bool dragging: false
         ^

Flickable has a `dragging` property itself, and in Qt 6.6 that leads to
this error.

Fixes: QTCREATORBUG-29719
Change-Id: I882e944035141622c0bdf65ee4fcb3cf145aef0d
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2023-10-09 11:15:51 +00:00
Christian Stenger
d4e7dfca76 Utils: Add compatibility for older settings
Adds compatibility for older settings - likely only relevant
for settings of snapshots or development QCs.

Change-Id: Icb6a9c054dea4deac5adbc4255bc60dcd6c14ea7
Reviewed-by: hjk <hjk@qt.io>
2023-10-09 10:57:58 +00:00
Ali Kianian
d9299272bc QmlDesigner: Make collection column selectable
Task-number: QDS-10895
Change-Id: Ibf047c5d3f38f93a6a58b692974c843467873610
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-10-09 10:45:30 +00:00
Ali Kianian
df8b6310c4 QmlDesigner: Select and delete a column of the collection
Task-number: QDS-10620
Change-Id: Ieba6ab7e4bf366cffad0c020f4d786096150eb0c
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-10-09 10:45:15 +00:00
Marcus Tillmanns
fe430bebbe CompilerExplorer: Fix undo
Fixes context handling for the Editor. This allows Undo/Redo actions to
activate correctly.

Change-Id: Ieb7fa27215f5746cf5f26e8e7b3b74f44023481c
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-09 10:34:14 +00:00
Cristian Adam
399e12c973 CMakePM: Fix crash in findLinkAt
Fixes: QTCREATORBUG-29715
Change-Id: I4db919c8858631beb573789d1888b3dbee606c50
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-09 10:26:10 +00:00
Cristian Adam
ad680902b2 CMakePM: Fix condition for filtering out non CMake parameters
Coverity-Id: 1515708
Change-Id: I97de84f4db79977d7833337be87ae4877c10136b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-09 10:25:43 +00:00
Ali Kianian
6b3a278f13 QmlDesigner: Make the Collection header modifiable
Task-number: QDS-10620
Change-Id: I33c7beaf72decebe93a7e4d64d0ca6d6b3590af6
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-10-09 10:20:54 +00:00
Marco Bubke
f25413a151 QmlDesigner: Fix duplicate in .clang-format
Change-Id: I88b1a126e30894167de0e3023a957eb22b5368fb
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-10-09 09:46:48 +00:00
Knud Dollereder
e10e0b5767 Use Control or Command and mouse wheel to zoom on mac
Fixes: QDS-10791
Change-Id: Iabe9199e4d1e04b8ac2daa94f4926e66ddaf5033
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-10-09 09:43:52 +00:00
David Schulz
ac5ab71db8 LSP: add resource operations to the protocol implementation
This allows the language server to request file creation, renaming, or
deletion.

Fixes: QTCREATORBUG-29542
Change-Id: I31ab3c0b36f87d3b797b54ff4261cab85a322e2c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-09 09:33:54 +00:00
Eike Ziller
c2ba218583 Markdown: Add missing commands for show editor/preview and swap
Change-Id: I4ea63d2bd7a89a1fc8299e83a0050e4f639190c5
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-09 09:31:26 +00:00
Cristian Adam
cbeeec2dc6 CMakePM: Fix Coverity issue "Arguments in wrong order"
Coverity-Id: 1526499
Change-Id: I4b5d7c4d12eca39b9c4e60b45ea3e67bce069069
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-09 09:14:40 +00:00
Christian Kandeler
6b81c93a66 CppEditor: Add a second variant of "move def to decl" quickfix
This time with the cursor on the declaration.

Fixes: QTCREATORBUG-9515
Change-Id: I50b2ac8516f4df98e4cc9e3ffa60a9e5cf079c4e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-09 08:25:12 +00:00
Jarek Kobus
3984108c0c CMakeFileCompletionAssist: Limit the size of PerformInputData
The size should drop down to 184 (from 264) bytes.

Amends 07e758147b

Change-Id: Ia07b153f3f75b9e7b6199d857d58bffbb7b3e7d4
Reviewed-by: hjk <hjk@qt.io>
2023-10-09 08:12:41 +00:00
Christian Stenger
d4a5096c76 QtKeyChain: Improve cmake build
Do not hard require pkgconfig or QtDbus.

Change-Id: Ic989a1937ecf8d8e3e270166a363740c8a6ec3ff
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-09 07:41:46 +00:00
Marcus Tillmanns
a70ead958e Docker: Use "type" instead of "which"
"which" fails for builtin commands, while "type" finds both
builtin and executables.

Change-Id: I2e508a01e28b827ed498add50f8faa9d58551e59
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-07 07:48:11 +00:00
Cristian Adam
1d2c942360 CMakePM: Only process cmake files for include and modules
... and not for every function. Just the CMake files.

Change-Id: I6e361f4913f8334942a3135adaa0480fdc0cee31
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-06 19:41:59 +00:00
Jarek Kobus
a31287dfe1 IosToolHandler: Avoid 3 arg connect
Fix signal arg for LogTailFiles::logMessage().

Change-Id: I8d50ee954e9fff2ececfcb17766e0b0cccb98a2b
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-06 18:55:14 +00:00
Thomas Hartmann
7f2b721dbf QmlDesigner: Fix id in StackView template
Task-number: QDS-10749
Change-Id: Ic611297f9da64461351a4f29374fdac3709494d2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Peter Rohles <peter.rohles@qt.io>
2023-10-06 16:08:26 +00:00
Jarek Kobus
ee48dba19e FileApiReader: Make shutdown faster
Check more often for canceled future.

Make more functions static.

Fixes: QTCREATORBUG-27729
Change-Id: I8dd787acea6343008c7515fb6a4fdfde50b37aee
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-10-06 15:37:12 +00:00
Jarek Kobus
e4ae894c96 FileApiReader: Make stopping faster
On the session switch we are busy waiting for the running async task,
started before by the FileApiReader::endState(). This blocks the main
thread for considerable amount of time. E.g. when switching
between sessions both containing Qt project, it may block
the main thread up to 10 seconds.

Instead, we employ the future synchronizer and move the awaiting
to the shutdown phase.

The next patch is going to limit the awaiting in shutdown phase.

Task-number: QTCREATORBUG-27729
Change-Id: I956ed26edcd699d8a4e2b9309d109963f1d4bb20
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-10-06 15:37:06 +00:00
Jarek Kobus
72118e018e CompilationDbParser: Make parseProject() static
Don't operate on the same CompilationDbParser instance
in the main and the separate threads.
Pass needed data as parseProject's arguments.

Change-Id: Idf5e5d92727d5a279256673088880e6d2f48a7c1
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-06 15:27:55 +00:00
Jarek Kobus
fbe23282fc AndroidDeviceManager: Execute avd removal in main thread
Instead of executing it blocking in a separate thread.

Change-Id: I0d847f22917edc9782467f173728c13287844acb
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-06 15:27:28 +00:00
Cristian Adam
162f9f59d7 CMakePM: print newline before the message
This way we'll get:
  [cmake]
  [cmake] Elapsed time: 00:05.

And not the other way around.

Change-Id: Ica7352cd112b9017c8a39b98618be69494527be9
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-06 15:25:48 +00:00
Jarek Kobus
d6f2a73c81 CppIndexingSupport: Pass params to parse() with const ref
Change-Id: Ia54ea81907963e55047f2a5a2a283fd928fdfc2e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-06 13:55:01 +00:00
Jarek Kobus
e8da3b5119 CompilationDataBaseUtils: Pass arg via const ref
Change-Id: I6374b0064249a4574ed77e6c9ae4bca3122878c5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-06 13:54:47 +00:00
hjk
db0091e6a3 QMakeProjectManager: Use more common operator==() implementation
Change-Id: I623b49b92913e2f813554b664b3c79683c3a35cf
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-06 13:32:36 +00:00
hjk
436b215bce QmakeProjectManager: Remove unused arch detection remains
As the comment from f3418d8661 indicated.

Change-Id: I0735130b5162fc7d2bacf8ba7c5fd968f030e67e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-06 12:05:57 +00:00
Eike Ziller
ec46988fb7 Disable output view actions if they are not applicable
In Qt Creator the output views are always accessible: The status bar
shows their buttons, and if an output view is opened in a mode that
doesn't have an OutputPanePlaceHolder (which defines the location), the
edit mode is opened.

This is not the case in Design Studio: The status bar is different, and
design mode can only be opened with an open project, so e.g. after
startup in the welcome screen the output view actions should be
disabled.

Achieve that by disabling the actions when the output view buttons in
the status bar are not shown and the current mode doesn't have an
OutputPanePlaceHolder.

Amends 4642c5fd7d
and 3befa60970

Change-Id: I57b9ce3f80006fc2e842e38e93f1f7b50c5749f1
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-10-06 11:57:29 +00:00
Christian Kandeler
b09f4ac1b6 Update qbs submodule to HEAD of 2.2 branch
Change-Id: I652a2ec439f2c05eee79431cef9cbf961e94b37c
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-06 11:51:35 +00:00