QRegExp will not be available in Qt 6.
Task-number: QTCREATORBUG-24098
Change-Id: Ia1aec515615ecaf8e92ae1a3a1dad92cb999bfb1
Reviewed-by: Lukas Holecek <hluk@email.cz>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Some ranged-for and const.
Change-Id: I6ff521393166aa4c61289de88e8c31320887b1b4
Reviewed-by: Lukas Holecek <hluk@email.cz>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The problem triggering this change is that recently, C-S-s was not
handled (as "Save all") anymore when there was nothing to change,
and the keypress ended up in FakeVim. Now FakeVim filter for _exact_
C- modifier in Input::is(), letting C-S- pass as 'S-s' i.e. starting
replacement of the rest of the line.
Change-Id: I13499f5606c28fee148e410355bec7ffd6ed116a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The reasoning in 1b4766e26c did not take into account that the scope
of QT_NO_JAVA_STYLE_ITERATORS may change over time, as done with
f70905448f6 in Qt base.
Change-Id: Ib1966ff26c4d36d5f62e149d6b45baa4aecf825d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
For some reason, Q_UNUSED includes already a semicolon, adding one
on the user side creates an additional empty statement.
Change-Id: I9c5e8fac381345a60792cb75e2938fd53958d3b0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
... and re-organize surrounding code a bit.
Change-Id: I0c3af5b2a434c5088ed165fed97d562f468d16fc
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
warning: member initializer for 'm_isValid' is redundant
[modernize-use-default-member-init]
Change-Id: Icd521e7d77054512bc0ed6b95cf08440320b0ce0
Reviewed-by: hjk <hjk@qt.io>
There have been requests to easily re-use FakeVim in other projects.
To make that easy, cut the few explicit ties to libUtils in
fakevimhandler.cpp.
Change-Id: I090d50fb1fd4e62d97e9430e94a84d1f267773a4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
None of the other options yet.
Change-Id: Iabf18c1be4d228c97d2de9cb17e71c307e9ec5a2
Task-number: QTCREATORBUG-20022
Reviewed-by: Lukas Holecek <hluk@email.cz>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Note that this does not fully solve the linked issue as the
triggered GOTOPREVINHISTORY action does not have the same
behavior as :tabprevious
Task-number: QTCREATORBUG-18843
Change-Id: I26a719f77d2c1727bb18da46e13f5a0be48473bc
Reviewed-by: Lukas Holecek <hluk@email.cz>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The mapping was there, but not connected to the core actions.
Change-Id: I9faa1c47afe409caaa0462740a6865d99d959b44
Reviewed-by: Lukas Holecek <hluk@email.cz>
Reviewed-by: hjk <hjk@qt.io>
Take advantage of QT_RESTRICTED_CAST_TO_ASCII, auto, etc.
Change-Id: I4602fd6ef5f24b12cb9fe09ce39ad907e76fe259
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Some inputs can be unrecognized with some keyboard layouts
(QKeyEvent::key() will return 0).
Change-Id: If7b49330ac00a2493a956331c7bbe8ea2a4305ae
Reviewed-by: hjk <hjk@theqtcompany.com>
This fixes the bug that while recording a macrom, hitting caps lock
(scroll lock, num lock) inserts some key into the buffer (for caps '$')
so when you replay the macro you get incorrect output.
Other keys that are not in vimKeyNames may behave similarly but It is
important that macros support those three (especially caps lock).
Change-Id: I2854266f86a22e9d38fb1c6c5d923b11a56a5995
Reviewed-by: hjk <hjk@theqtcompany.com>
