Commit Graph

308 Commits

Author SHA1 Message Date
hjk
953cdb971f TextEditor: More BaseText* -> Text* renamings
*Document* and *Layout* classes, all basetext* files

Change-Id: I1c6e376733a434fcb5c7f19c6210dfa031eeafde
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
2014-09-26 10:12:51 +02:00
hjk
970264a88e Debugger: Operate tooltips on TextEditorWidgets, not TextEditor
Less indirection.

Change-Id: Ifbd7195e853d02bfd6562c817fc7f30079913faf
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-09-19 16:00:24 +02:00
hjk
b26a17f30d CppTools: Change CppModelManager implementation pattern
Replace the CppModelManagerInterface/derived CppModelManager
combo by a more common CppModelManager/CppModelManagerPrivate
pimpl pattern.

Change-Id: Ia4582845ed94d5ef60b8571bab9b2260c6290287
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>
2014-09-19 13:17:55 +02:00
Orgad Shaneh
ad957282c8 Debugger: Cleanup
Change-Id: Iaf7a3d69d920f8096763e2d8033df2d6371683a7
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-09-12 13:58:47 +02:00
Erik Verbruggen
f1b90c1e5f CDB: prevent possible nullptr deref.
Change-Id: I111b4620effc45f26f40880875a70d606c924f69
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-09-11 13:01:27 +02:00
Eike Ziller
49db3a450a Merge remote-tracking branch 'origin/3.2'
Conflicts:
	qtcreator.pri
	qtcreator.qbs
	src/plugins/coreplugin/editormanager/editormanager.cpp
	src/plugins/cppeditor/cppeditor.cpp
	src/plugins/remotelinux/remotelinuxdebugsupport.cpp
	src/plugins/texteditor/basetexteditor.cpp

Change-Id: I0da7c1cf2506b12d0563795aa8177fc45e97050f
2014-09-03 16:08:02 +02:00
Nikolai Kosjar
d4e49c088a Debugger: Don't use document with AST from indexing snapshot
...since the AST will be released at some point from another thread.

Change-Id: I71d20228ebec71e98dca3474452677ec63ffe4c6
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
2014-08-29 15:51:24 +02:00
hjk
6431ab2c79 Use Qt 5's QStringList::join(QChar)
Less typing and less cycles than join(QString) where appropriate

Change-Id: I6ebc0e17e4d7fd9845864dd95b7de4ba4dad6906
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
2014-08-25 08:21:14 +02:00
Nikolai Kosjar
b8a6a4dd4e CppTools: Move WorkingCopy to new cppworkingcopy.{h,cpp}
Change-Id: I447acf28849bffb52c1e6b6eafdde221ec0b179e
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
2014-08-20 10:26:47 +02:00
hjk
5ac407eecc Debugger: Reduce line noise
Move some function out of the DebuggerCore "namespace", to avoid one
indirection and removes clutter in the calling code.

Change-Id: I1c870d5c7eeade32fa63dedf581490fbb090cd6a
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-07-28 15:48:15 +02:00
hjk
bf5e43be94 TextEditor: Merge ITextEditor and BaseTextEditor
Adjust all callers, de-export BaseTextEditorAnimator

Change-Id: I2329d976c1398e2449844bb480a4d4ed29859506
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2014-07-25 13:45:55 +02:00
hjk
f0b2d6535e Debugger: Rework editor tooltips handling
Fix expansion and updating.

Persistence and non-locals are still lacking.

Change-Id: I74e25199d50350516afc686a05836e239bfc8acb
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-07-11 12:19:01 +02:00
hjk
dbae15684f Debugger: Simplify tooltip interface
Change-Id: I7ce688e56fb516ef6e77ee2e4f56d9b56379918b
Reviewed-by: David Schulz <david.schulz@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-07-09 13:37:45 +02:00
David Schulz
9ed5e8080d CDB: Reseting locals and watches when switching frames.
Change-Id: I9fe17a0776a839976a43c72d231658ed6271684b
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-06-05 12:37:51 +02:00
Christian Stenger
752668b5f4 CDBEngine: Fix Qt4 build
Change-Id: I4fb7136c2ec53b5545a0602c108843452599347e
Reviewed-by: David Schulz <david.schulz@digia.com>
2014-05-16 11:32:20 +02:00
David Schulz
751a61b2e4 WinRT: Enable debugging for local packages.
Change-Id: Ic04f1a471f951caf7a79c69cceecb0ebd5d09919
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-05-16 11:21:33 +02:00
David Schulz
04fdbe3d01 CDB: Handle "ambiguous symbol" messages on breakpoint inserts.
These messages usually appear when there is a lambda at the position
the breakpoint is about to be inserted.

Task-number: QTCREATORBUG-12178
Task-number: QTCREATORBUG-12016
Change-Id: I20f7b0e900147030bfd08206fab869ac22810825
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-05-16 10:52:16 +02:00
David Schulz
84790f9aef CDB: Only use codemodel breakpoint correction for old cdbs.
Since version 6.2 cdb supports setting breakpoints on non
codelines and automatically set it to the next available line.

Change-Id: I27facf4f2463bad76a20ef0abb5a5412471c296f
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
2014-05-16 10:52:07 +02:00
David Schulz
3676aaf5be CDB: Remove duplicated message box generation.
Change-Id: Ib4413a97b63a17155645dafb681a0384950270c6
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
2014-04-30 11:19:28 +02:00
David Schulz
3434420cde CDB: Using watchdata cache to highlight value changes.
Change-Id: I05a8184bb79c2907a4aa0fec13cc809237eead45
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-04-29 10:03:55 +02:00
David Schulz
72ac098a86 CDB: Do not break on initial breakpoints.
When starting cdb with the -o otion (debug child processes) it would stop
on every child initial breakpoint.

Change-Id: I9e9ae92c3c39a80d78e17cd6c6afb862bd04abe2
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
2014-04-25 06:59:47 +02:00
Christian Kandeler
eccc1198d6 Use double quotes instead of single quotes as per our guidelines.
Change-Id: Ib608bb49e26781aef1914085a5d801fcdcd5eb56
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>
2014-04-22 10:06:40 +02:00
David Schulz
51a2717f9a Debugger: Execute commandsAfterConnect also when using cdb.
Change-Id: If7147c882f3185fee98c00047fb9a182e62ef903
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
2014-03-28 09:57:51 +01:00
Sergio Ahumada
c375436847 Fix some typos
Change-Id: I3be73c2a4d256a0d28e863fd2517a4d7442b34d8
Reviewed-by: Mitch Curtis <mitch.curtis@digia.com>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>
2014-03-05 09:39:42 +01:00
Friedemann Kleint
e64fefdbc4 Add a stack window menu entry to display QML stack frame.
Add language field to stack frame.
Add virtual for loading QML stack invoked by stack window
context menu, implement for CDB, GDB.

Task-number: QTCREATORBUG-11144

Change-Id: Ic39be3978b40d96ed18cb69a8355296ec572ece7
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-02-25 16:48:06 +01:00
hjk
97d98c96e5 Utils: Compile winutils on all platform
... and simplify "user" code.

Change-Id: I2dfa402f25ab83f1ab80adc0ac508e8383c69641
Reviewed-by: David Schulz <david.schulz@digia.com>
2014-02-20 11:10:30 +01:00
Eike Ziller
236ea9efb9 Merge remote-tracking branch 'origin/3.0'
Conflicts:
	share/qtcreator/debugger/dumper.cpp
	share/qtcreator/debugger/dumper_p.h
	share/qtcreator/debugger/test/main.cpp
	src/plugins/debugger/gdb/classicgdbengine.cpp
	src/plugins/debugger/gdb/pythongdbengine.cpp
	src/plugins/debugger/lldblib/guest/lldbengineguest.cpp
	src/plugins/debugger/lldblib/guest/lldbengineguest.h
	src/plugins/debugger/lldblib/guest/main.cpp
	src/plugins/debugger/lldblib/ipcengineguest.cpp
	src/plugins/debugger/lldblib/ipcengineguest.h
	src/plugins/debugger/lldblib/ipcenginehost.cpp
	src/plugins/debugger/lldblib/ipcenginehost.h
	src/plugins/debugger/lldblib/lldbenginehost.cpp
	src/plugins/debugger/lldblib/lldboptionspage.cpp
	src/plugins/qbsprojectmanager/qbsstep.cpp
	src/plugins/qbsprojectmanager/qbsstep.h
	src/plugins/qmlprofiler/canvas/qdeclarativecanvas.cpp
	src/plugins/qmlprofiler/canvas/qdeclarativecanvas_p.h
	src/plugins/qmlprofiler/canvas/qdeclarativecontext2d.cpp
	src/plugins/qmlprofiler/canvas/qdeclarativecontext2d_p.h
	src/plugins/qmlprofiler/canvas/qmlprofilercanvas.cpp
	src/plugins/qnx/blackberrycheckdevmodestep.cpp
	src/plugins/qtsupport/debugginghelper.cpp

Change-Id: Ie9fd0a885fb6264a6a8a72daee071b75bcbd2e9d
2014-01-08 11:01:06 +01:00
Robert Loehning
746c5d8863 Incremented year in copyright info
Change-Id: Ib5423fdd064e4546f848c0b640b0ed0514c26d3a
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
2014-01-08 08:29:47 +01:00
David Schulz
78081ecb49 Debugger: Replace the cdbext prefix member...
...and replace it with a static variable.

Change-Id: Ic9f03ee9e00e7b32f66a573ef9b15225aa3f13bf
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
2013-12-02 09:08:00 +01:00
David Schulz
f3ecf032b6 Debugger: Adding functionality to create full backtrace with cdb.
Task-number: QTCREATORBUG-10916

Change-Id: Ie2675f1bdc1f31679aefac32053cd1c8dd76d2d5
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
2013-11-27 10:14:35 +01:00
Tobias Hunger
e6675d26d8 CDB: Fix warning about mixing bool and bitwise logic
Change-Id: Iaf69fd16fa9ba0a5c63b6636d183836accdfd005
Reviewed-by: hjk <hjk121@nokiamail.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
2013-11-13 16:39:40 +01:00
David Schulz
58796158a8 Debugger: Remove state check on cdb interrupt.
When breakpoints are inserted we are also calling this function,
but the state isn't set to InferiorStopRequested.

Change-Id: If448e7596c9c08cebdc8b2ed5b23df0e232fd817
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
2013-11-12 11:19:28 +01:00
David Schulz
94c10ae6cc Debugger: Interrupt inferior via signal operation on Windows.
Task-number: QTCREATORBUG-10558

Change-Id: I5a27beca4601cae3b0de8f903a2cbc08ee801149
Reviewed-by: Robert Loehning <robert.loehning@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
2013-11-05 17:07:30 +01:00
David Schulz
8f47840bca Debugger: Fixing string concatenation in cdbengine.
Change-Id: Ibdc499d74a53ddd32040f9354c14bd748662ada2
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2013-10-30 12:25:16 +01:00
Orgad Shaneh
4de3b94840 Crossify normalizePathName
Denoise usages

get{Short|Long}PathName are now static. They're not used anywhere except
in normalizePathName.

Change-Id: Ief277b6d828faadd98ec7faa39dd682bfaa8805f
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
2013-10-24 10:38:36 +02:00
hjk
b63f3f808c Debugger: Keep secondary dialogs on top of the main window
Change-Id: I1f4283a5727db976d999d4cf4c7e444de8592566
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
2013-10-17 10:27:15 +02:00
hjk
1650aaae38 Debugger: Fold GdbToolTipContext into DebuggerToolTipIndex
Change-Id: Iee9201daa8d42ee4231895b1c78387acbc7caaac
Reviewed-by: David Schulz <david.schulz@digia.com>
2013-10-14 15:42:43 +02:00
hjk
30045bee78 Debugger: Simplify Tooltip manager interface
The Editor itself is not really used.

Task-number: QTCREATORBUG-10358
Change-Id: I94620ed7b3b1d6b02c4eef2a359f991217b0a00b
Reviewed-by: David Schulz <david.schulz@digia.com>
2013-10-14 09:17:23 +02:00
Leena Miettinen
a48315ee1f Debugger: fix UI text capitalization and punctuation
Change-Id: I5f2888750164a6b3cb5ba9bf0cafb457a31a1b6e
Reviewed-by: hjk <hjk121@nokiamail.com>
2013-10-10 15:31:15 +02:00
David Schulz
668a50b775 Debugger: Raise messagebox when cdb can't be started.
Task-number: QTCREATORBUG-10180

Change-Id: Iaf672c79a95c37fba2f5243db9564305de8e76dc
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
2013-10-01 11:11:14 +02:00
Erik Verbruggen
f7c68f6baf C++: change working-copy to work on UTF-8 encoded QByteArrays.
These not only take less space than UTF-16 encoded QStrings, but due to
the caching in the CppEditorSupport also take less time to build.

This patch also fixes a number of possible encoding issues, where files
and constant strings were (falsely) assumed to be UTF-8.

Change-Id: Ib6f91c9a94ebed5b5dfbd4eb2998825c62c72784
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
2013-09-11 09:43:14 +02:00
Christian Kandeler
72d173829c Remove superfluous include paths from project files.
A lot of our build system files specify unneeded include
paths. These roughly fall into the following categories:
    a) Paths that are already set in more general files
       such as qtcreator.pri.
    b) Paths that serve no purpose at all, possibly
       left over from earlier versions of the project.
    c) Paths that act as workarounds for wrong include
       statements of the form '#include "xyz.h"', where
       xyz.h is not in the same directory as the including
      file.
This patch removes such path specifications and fixes the offending
include statements from case c).
Tested on Linux, Windows and OSX with qmake and qbs.

Change-Id: I039a8449f8a65df0d616b4c08081145c18ae4b15
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
2013-09-02 17:28:17 +02:00
hjk
99f22de6ba TaskHub: Add convenience function to add a task and clean up users
Change-Id: I5c76f8af720092d4e47b1a9fa889fb3a7010f21f
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2013-08-30 12:44:10 +02:00
Oswald Buddenhagen
c2e90c360b Merge remote-tracking branch 'origin/2.8'
Conflicts:
	src/plugins/cpptools/cppcompletion_test.cpp
	src/plugins/cpptools/cpptoolsplugin.h
	src/plugins/projectexplorer/customtoolchain.cpp
	src/plugins/vcsbase/command.cpp

Change-Id: Ie7b3c9e136c0748b41320227c757471259339b48
2013-08-21 14:39:18 +02:00
Nicolas Arnaud-Cormos
14d05eade8 Fix compilation errors
Change-Id: I6b0d4956b5dcbd13ee26c72081f77e5d8a4f219b
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2013-08-19 12:47:59 +02:00
David Schulz
01123f6adb Debugger: Fix endless loop when stopping without winXXinterrupt.exe
Change-Id: Id6f636eaca6ed04cd43a59713487cf8e4c80f1ab
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
2013-08-19 09:41:51 +02:00
hjk
b89afac9d4 Utils: Rename winQPidToPid to qPidToPid
... and make it a no-op on non-Windows. Saves #ifdefs.

Change-Id: Ie791f7b9f1a425325d0b889e73758c5f7f7e6ad2
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
2013-07-12 09:39:35 +02:00
David Schulz
327e7bdf6f Debugger: Fix exception caused by wow64exts.info.
Task-number: QTCREATORBUG-9526

Change-Id: I79d09a7e975576ee68db3645142a567b4af4c646
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
2013-06-18 11:12:02 +02:00
Kai Koehne
b57e3552d0 Debugger: Fix compiler warning about initialization order
Got introduced in 21150df910

Change-Id: I8be4a8c01b858327b2df519195c0d3b30b5816f4
Reviewed-by: hjk <hjk121@nokiamail.com>
2013-06-11 14:52:05 +02:00
David Schulz
21150df910 Debugger: Enable noisy symbol loading when verbose log is enabled.
Change-Id: I0dda7f5ef471f3cb6379e4dda2900e4c8c0f87cb
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
2013-06-11 09:47:51 +02:00