On Windows the read content will be bytes instead of str. To have
a unified code path we need to convert it to str.
Change-Id: I16004968d8fed7bb2336ad594c31b38100f773cd
Reviewed-by: David Schulz <david.schulz@qt.io>
There are now generic debuggers registered - adapt the test accordingly.
Change-Id: I102ac0ac44666c4da17ff6ea01f048abba66e6e7
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
When the view is populated and sorted it gets its items
one by one. If multiple matches for opening an example are
possible we may end up using the wrong one which in turn
makes the test error out. So, wait for an expected amount
of items.
Change-Id: If6f6abfa757ede33311a8e617ab7d570df1240a4
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
Creator still writes gitProject.pro.user after cleanup() ran.
Change-Id: I78c8247090a7032b21ee3a763fd390bb16f3d24b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
6.0.1 was released on Qt 6.2 and was the last
version which could be built on Qt 5.14.
How I got to this:
0. Verify on Linux that the test passes with qbs 2.0.2
from Creator 10 to have a combination which is known
to work correctly.
1. Upgrade sources to v6.0.1 and write the tree which
qbs 2.0.2 and Creator 11 generated from those.
2. Run the test with qbs 2.1.0 and Creator 11 and update
the expected tree. This only meant removing a couple
of lines.
3. Verify on Windows that the test passes with qbs 2.0.2
from Creator 10 to have a combination which is known
to work correctly.
4. Upgrade sources to v6.0.1 and write the tree which
qbs 2.0.2 and Creator 11 generated from those. Remove
all lines from the expected tree which were not found.
Most of those contained forward slashes instead of
backslashes.
5. Verify that the result passes with qbs 2.1.0 and
Creator 11
Change-Id: I41579feb719324cf1fc605c73fe1d7566cf82202
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Disclaimer: I don't know why all those lines disappeared from the
tree. I only removed the lines which are not being found anymore
and updated a few more.
Change-Id: I916362247022b2ea84f5fa4255c6df6585311271
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
There were multiple reasons why the tests were flacky. First
Utils::reverseCompare had a bug. Now
std::lexicographical_compare(first.rbegin(), first.rend(),
second.rbegin(), second.rend())
is used.
Second the check StorageCache::checkEntries was not const. So it would
change the vector which it was iterating. So the iterator could be an
dangling.
Fixes: QDS-10197
Change-Id: I84fca6a2b24e1cae9fb85a01b6208de7e58240df
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
If you link to the internal Sqlite library you link actually twice. That
leads to strange bugs because you have an uninitialized object file. The
static linking workaround is now moved to cmake.
Change-Id: I51d966a623a18486ce5870d898999f3ce139f092
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Build \tests\manual\debugger\simple\simple_test_plugin as shared
library. Omit `lib` prefix for shared library when building on Windows.
Change-Id: Ica0f1d098e1add34fb7860bc1dacfbd89495b031
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Especially clicking the 'Do not show again' buttons on
the info bar on the bottom seems to be problematic
when trying to click them.
Wait for the clicked button to no more exist before
continuing to process further.
Change-Id: I24c40641e38dede2a689c34f491d68d4b7df8690
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
The function is not used but triggers strange accesses to null pointer.
Task-number: QDS-10178
Change-Id: Iea51609f7b8956a98fe9391aef8edac899e14c03
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Do not warn out invalid property name if the property starts with an id
in the same component scope.
Small refactoring: Move early-return-likely elements up before any
calculations done.
Fixes: QTCREATORBUG-28468
Change-Id: I2cbdbc24af42f126db0bbd6027ebe4f96d9c199f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: hjk <hjk@qt.io>
There were problems with older google test versions which were found
instead. Now the google test version is always the same and there cannot
be "strange" compile bugs.
Change-Id: Ib3dc74d1abbe369fb37a4ee5616011d8e3696c01
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
It's only used as a return value from group's or task's
setup handler. It instructs the running task tree on
how to proceed further.
It addresses the 21th point in the bugreport below.
Task-number: QTCREATORBUG-28741
Change-Id: I25802c76b9e7bc044c6a38197935798d2da9ad02
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Make non-Continue TaskAction returned by group's start
handler take precedence over group's workflow policy.
Call the group's done handler when group's setup returns
StopWithDone and the workflow policy is FinishAddAndError.
Call the group's error handler when group's setup returns
StopWithError and the workflow policy is FinishAddAndDone.
Add tests for these cases.
Change-Id: I98210a5d522daabc0986200e65b25986a8c0c440
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Moves macro expansion before assembling the command line
to correctly quote the resulting arguments on windows.
Change-Id: I62eded9376977ec6095e8648296cd2af53eb8e82
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
