Facilitate conversion from QVariantMap to Store to allow easy
serialization via QJsonDocument::fromVariant / QJsonDocument::toVariant.
Change-Id: Icb5c764ccdfdbaf402045224f5b02e4818d7ee2f
Reviewed-by: hjk <hjk@qt.io>
With removal of unneeded files similar to the original import,
the patch in patches/0001-... generated with
git format-patch -D HEAD~1
to show just the removed files.
Change-Id: Ibfe64439bae5d1b1baa6b6bc47caf1ae030b3f9d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
for kit aspects. The widgets added to the "KitArea", including the
created labels for the kit aspects, are children of the widget itself,
not the layout, so since we do not delete the KitArea widget, we need to
explicitly delete the labels too when updating, the same as we do for
the aspects' widgets.
Fixes: QTCREATORBUG-29519
Change-Id: I605edd4969345d18064c1c00ec4d617499de8eb7
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: hjk <hjk@qt.io>
This avoids triggering the callback if we already requested a find link
at for a different position. Additionally we also cancel the request if
the document changes or the cursor moves inbetween requesting the link
and receiving the response.
Change-Id: Iffc7b08012a649397e7ca7dfc99d314a1bbf19f7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
After this one, is compiles with the opt-in macro. Not changed yet,
though.
Change-Id: I29a66ecb5daa71d0d97566b81fd9f47d92f6368a
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This fixes debugging with "Run in Terminal".
We usually do not use the disclaim tool when debugging,
because LLDB does that itself, but it looks like not having
get-task-allow prevents that in the first place.
Add that and disable-library-validation (which is needed for
get-task-allow when notarizing) to our process stub.
Fixes: QTCREATORBUG-29497
Change-Id: I86c184b2b108b62822bf89d80ea2b4ca9190f5b8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
They renamed their target from `yaml-cpp`
to `yaml-cpp::yaml-cpp`
Still support < 0.8 though.
Fixes: QTCREATORBUG-29537
Change-Id: Iafa6e75998f0120610542b4c744b205aee3392a3
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Lisandro Damián Nicanor Pérez Meyer <perezmeyer@gmail.com>
Reviewed-by: David Schulz <david.schulz@qt.io>
This will allow opening CMake files via F2 when using include statements
like: include(${CMAKE_SOURCE_DIR}/cmake/api.cmake)
CMAKE_BINARY_DIR and CMAKE_CURRENT_BINARY_DIR are also supported.
Fixes: QTCREATORBUG-29467
Change-Id: I9adb417d98e8a8fccf6cd3e5038562db02cb28c2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
When qtForMCUs is enable in the project, disables the action to open
the easing curve editor in the timeline and the actions to set an
interpolation to anything else than linear in the animation curve editor.
Shows the disabled reason in the tooltip and paint non linear curve
segments in the error color and without handles.
Fixes: QDS-10061
Change-Id: I71b2af0dd6f6c10714fceb75ff3ac16c88504adf
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
The "history of editors" is supposed to contain the order in which files/
documents were recently accessed. It is used for the "open documents
window" (the Ctrl+Tab popup). In contrast to the "navigation history" it
should contain each file/document only once.
Since 324de13b4e items for suspended
documents with the same file name were no longer removed. For suspended
documents it is necessary to check for the same file name.
This was so far not vital, but when we save the editor history in the
session, these do not have a document when restoring, which would lead
to an evergrowing editor history.
Amends 324de13b4e
Change-Id: Ia4b7848a1265024d0463afbf7c1cd69189c4be97
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
We should not only exclude children of system directories, but also the
directories themselves.
Fixes: QTCREATORBUG-29478
Change-Id: I1aa18b2faa03d241b8cc43eb157b5fa49285a12b
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
We had an import of QtLockedFile from 2008. On Windows we could see a
lot of QtLockedFile cycles for qtcreator.exe. The 2008 version was using
a semaphore.
I've tried the latest QtSolutions version from 2016, which was using
only mutexes. qtcreator.exe would still show up lots of cycles for
QtLockedFile.
Then switched to QLockFile (added in Qt 5.1), and I couldn't see any
more CPU usage!
Task-number: QTCREATORBUG-29416
Change-Id: Ibfd102f3e90de39c807ff1140e597b79a7b6ca8e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
(cherry picked from commit 1fca05959f)
This reverts commit 1fca05959f.
Reason for revert: Portale +2'ed under the assumption that this
goes into the master branch. This year old issue should definitely
be fixed, but typically not that urgently in a .3 patch release
Let's revert this and move it on master, please. I take the blame for the messy git history.
Change-Id: I8ae5a5e8e89ce38e7fe663b09cb6c2c3ab520ab0
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
We had an import of QtLockedFile from 2008. On Windows we could see a
lot of QtLockedFile cycles for qtcreator.exe. The 2008 version was using
a semaphore.
I've tried the latest QtSolutions version from 2016, which was using
only mutexes. qtcreator.exe would still show up lots of cycles for
QtLockedFile.
Then switched to QLockFile (added in Qt 5.1), and I couldn't see any
more CPU usage!
Task-number: QTCREATORBUG-29416
Change-Id: Ibfd102f3e90de39c807ff1140e597b79a7b6ca8e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Since no StudioControls ColorEditor exists, using the HelperWidgets
one and adding dummy context and backend to get it to work.
Task-number: QDS-10404
Change-Id: Ifc1506b4b1f761b6abf4144791f5b0397a90cdf0
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
This avoids the case when CMake would trigger the file watcher when
generating totally different json files.
For example switching branches and doing a build on a big project, like
Qt Creator for example.
The filewatcher would be triggered and the UI would freeze for quite a
while.
Task-number: QTCREATORBUG-29416
Change-Id: I6ff47d8c2553f7718e82d92daae99036f37aca7d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Mainly to simplify the implementation and naming.
Kind of follow-up to 862c9694.
There is some consolidation needed as followup as well as some potential
renamings. I'd leave that for separate patches to keep this here
somewhat self-contained.
Change-Id: I152e138a1d5baadec3f7542fed0894b8d4ffc8a3
Reviewed-by: David Schulz <david.schulz@qt.io>
There is already a way to programmatically set the configuration for a
client, take this into account when generating the response for a
workspace configuration response.
Change-Id: Id59b643eefc59732c856c356317764e6c54af69a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Make all actions unique pointers and members of the 3D view,
so they will get deleted once view gets deleted.
Change-Id: I20d576480a2e553d9164a51e72f9f35d9715180e
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
In case a document does not yet have a filename,
simply fall back to save as
Change-Id: I3cb30ab39e30ecba5c720d4b7d4c955f9dd4609f
Reviewed-by: David Schulz <david.schulz@qt.io>
When ctrl is pressed during move gizmo drag, the move is snapped to
configurable increment. If the drag axes are aligned to the global
axes, the snapping can be done either to absolute grid or increment
to start position, depending on snap options selected.
If drag axes are not aligned, then drag is simply snapped to
configured increment length along the drag vector regardless of
configuration.
All snapping settings are persistent and shared by all 3D scenes.
Fixes: QDS-10463
Change-Id: I9407e558aae0ad8b72d975fb6dfa15a4e78f6ee8
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
QMLDESIGNERCORE_EXPORT should be only used for core exports. It is still
a little bit messy and that is why it worked but in the long run we want
to clean it up.
Change-Id: I20e898344731fa7b36226b4c3418b336fb98dabb
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Auto is here much more secure because it prevent an accidental creation
of a shared pointer from a raw pointer.
Change-Id: I16abb623fbfaf2d4e205a302e5bbd667efa1bb2c
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
The whole small string has to be intialized for const expressions. But
because we don't want to pay for that all the time we use a C++ feature
to only do that at compile time. So now at runtime only the control
block and the string content code is generated but at compile time
everything is filled up with zeros.
So you can now write:
void foo(std::vector<Utils::SmallString> &v) {
static constexpr Utils::SmallStringLiteral foo{"Some short string"};
v.push_back(foo);
}
The advantage compared to a string_view is that it is only memory
copying the literal because it know it has to be a constant.
Change-Id: Ia0e4bac293c363ae08341d18d47ddaf78e896e6a
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Sometimes we want to have the dot properties instead of the
value(readonly) properties.
CompoundPropertyMetaInfos inflateValueProperties(PropertyMetaInfos
properties);
CompoundPropertyMetaInfos
inflateValueAndReadOnlyProperties(PropertyMetaInfos properties);
are removing the value proeprties and adding the dot properties if the
property type has properties.
Task-number: QDS-10472
Change-Id: Ia2291f77f1b38bbe62d71319bfa28cf545cbef18
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
