Since recently, the green background is used for enabled plugins and
grey is for disabled ones. With that change comes the requirement to
draw the icon for disabled icons with less intensity, to make it really
appear disabled.
I took this opportunity to unify the drawing of small/big enabled/
disabled pack/extension icon variants in a central helper function.
Change-Id: Ia68218c774ccb8e9e7ed48620ac36f4bca0724fd
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
about missing fields in initializer
jsonprojectpage.cpp:142:84: warning: missing field 'projectFile'
initializer
Change-Id: I1fe8b937100ac026eb602a65ad7ccf5077430a52
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
At least on Apple Clang there is no default constructor
For Text::Position taking two numbers.
Amends 39a448c62e
Change-Id: Ife3630f53d66be38a52ffeb8693bf7574038d083
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
... when the respective location would be in a different project.
Task-number: QTCREATORBUG-19636
Change-Id: I39a93f030b46ca2f422166ce1e4740e05ff90877
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
And de-pimpl. Smaller overall interface and less indirections.
Change-Id: If6a5c0824581a6478ad6e88410d97e23cc517a53
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
... when doing completion for header includes.
Fixes: QTCREATORBUG-31103
Change-Id: Ic2d4eb4abce4f6d0f7d08b0ff0f5e0f54669eb65
Reviewed-by: David Schulz <david.schulz@qt.io>
We want to sort by type and then alphabetically. That requires a custom
lessThan() implementation, thus a custom QSortFilterProxyModel.
Will come handy for further filtering/sorting requirements in the
future.
Change-Id: Iaacd955015d56026e41d404dcf4781a1715dc55a
Reviewed-by: hjk <hjk@qt.io>
Word arithmetic does not work across languages. Provide explicit strings
for the combinations.
Change-Id: I95399f5d528405971d630a464e67a89766351162
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Trigger a fetch from the can fetch function in order to get whether the
item has children. This information is used to show the expansion marker
for items that have children, and not for items that have not been
fetched yet.
Change-Id: Ifc20588aa805368369e72fc8501244f64bbbc91d
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The TextDocumentManipulatorInterface was introduced to decouple
modification operations from QTextDocument. But nowadays all tests and
production code usages are backed by a QTextDocument, so we can remove
this abstraction layer again. The first step is to merge the interface
and all manipulator implementations.
Change-Id: Idd1609df549d3b120dd516d5161af9aa8aa571ca
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Sometimes the mime detection returns unexpected results and defines a
textfile based on the ending as a binary file. We should at least make
it possible for the user to open those files in the plain text editor.
Fixes: QTCREATORBUG-31116
Change-Id: I3139a1013be9fa6f28654434229c62f7a8e79d21
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The fetching is postponed until the extension manager is shown.
This also adds a spinner which is shown during the fetching of the data.
Change-Id: Id24ae772bcdfdf885ecfd5341d9a8d02f398c1a0
Reviewed-by: hjk <hjk@qt.io>
- Add dots to ends of messages
- Replace "plugin" with "extension" in translatable text
- Fix capitalization of headings and button labels
- Change wording
Change-Id: I24a3ca6de6a5a0a4509bab34ad2f50cbcf40c73a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Make the code a bit more readable at the cost of verbosity.
Change-Id: If6d83a441b863a027b91e486b676183af6e5a8ea
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Link to the presets docs for version 5, so that users
won't accidentally use fields from newer versions.
Task-number: QTCREATORBUG-30604
Change-Id: Iab548df768d55408dd018e97e2f5c9c1dfc3e594
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
...in the online docs. Does not work in the helps.
Change-Id: I6391ff40be2607eb026153deec418e9389954b7d
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
The default impl of Process::startDetached() forwards
process channels. Make it optional by providing an additional
argument of DetachedChannelMode type for Process::startDetached().
Change-Id: I6cb55377c21dfedacd53117756894d07e354e0fe
Reviewed-by: hjk <hjk@qt.io>
This change sets green vs. grey background for extension icons depending
of enabled state.
Change-Id: Id99419544a00acca897aa0ad6c98d2598e4b2210
Reviewed-by: hjk <hjk@qt.io>
Didn't notice the `toStringList` member function of `Environmen`. The
code now is now also nicely indented.
Change-Id: Id570ddc48e915d9090f9975d05761aa908311f0d
Reviewed-by: hjk <hjk@qt.io>
Log the network request, incl. result and response. And how many
extensions were fetched remotely and added locally.
Change-Id: I634d72462c8076c2fa01e88a1918163f76d28aff
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
The extansion query service is currently only reachable from within the
internal network. So far, if the request failed, and if Qt Creator was
configured with WITH_TESTS, a set of test json got loaded.
That test data confuses people in the team.
This change makes loading of test data explicit, and comments it off by
default.
Change-Id: I89236064b6af32be7559bb6d36cbf0d42982085d
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
This change enables the Qt Creator Extension service data to override
data of locally installed plugins (so far it was the other way around).
We might want to add more description text, links, images or tags to
plugins. And we want to be able do that independently of Qt Creator
releases.
This change also allows for substantial simplification of the "data
merging" code.
The parsing of extension plugin dependencies from the json data needed
to be fixed. See dependenciesFromJson()
Change-Id: Ia0433f0e0c7a0f13c43e0569c0915b7d08f7370a
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
This way if we pass arguments to the Run configuration, they will reach
the inferior whilst being debugged.
Change-Id: I93d99ff0d69b4ec710887097efc643fb48c8acca
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
If the inner type is null at this point it will also be null when
assigning the same type again.
Change-Id: I4dbad41a60d4853ac016adb54c693ce19d6f65d0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Add the new options and a link to the docs to the change log
Task-number: QTCREATORBUG-30604
Change-Id: I50acab63b6d7a49c5e2dbf7ebd772f88280fb3a3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
LLDB 3.8/360.x was not working with multiple inheritance even on
the command line, but looks ok nowadays at least in this simple case.
This does not fix the linked task.
Task-number: QTCREATORBUG-31042
Change-Id: Ibc52c9aaf31513af05487657a229fc4945d7e08f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
If a class is being added to a target that has a variable resulted from
a `file(GLOB|_RECURSE)` call, we skip adding the files to the target.
Do not add the files, just run CMake which would gather the new sources
into the project.
Adding sources to a globbed target will no longer open the
CMakeLists.txt file, since nothing has changed.
CMake will be run after adding, renaming and removing of sources files.
Fixes: QTCREATORBUG-30445
Change-Id: I82e126737789f215a6400f5a43f303dcc57de005
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Amends f866b03b19
This would do what the QMake build system does on new build types, it
asks for a name and uses that name in the build directory.
Fixes: QTCREATORBUG-26066
Change-Id: Iec5b4ace1e203affad718b42ec2bcbbc87aef51f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
This instantiates PluginView in order to use setPluginsEnabled. It
enables dependencies of a plugin that is being enabled. Likewise, it
disables dependent plugins when users disable a plugin.
In both cases, the user sees the familiar info dialog.
On confirmation, a "Restart now" button is shown.
Change-Id: Ie74ed377bfdd1ce3cb06289c2aae78377475bc53
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Since we don't use the future interface for result
reporting, simplify it to be QFutureInterface<void>.
Change-Id: I4d3a2e7f87721c54996894d744e5c43cc6223d47
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
But keep experimental.
It is currently less functional than the old plugin dialog, it
misses e.g. dependency tracking when disabling plugins and the
design misses a way to restart Creator in the common case where
this is necessary.
Change-Id: Ib6c5aba762426510fc174c99ddc486d31d240484
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
(cherry picked from commit c57d70e242)
Reviewed-by: hjk <hjk@qt.io>
