Some effect related objects such as QQuickShaderEffectSource can be
silently removed alongside another object, so use QPointer to ensure
all objects are still valid before readding them.
Fixes: QDS-11973
Change-Id: I75ee2dc81e27774f8be87b031e149b135ec84023
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
It's the "persisted" form of the content of the original aspect's data,
calling it 'aspect' already confused me a few times.
Change-Id: I88a6f76f0ca39d3d36dde9b84287032ceecf7033
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The dragged effect is collapsed when dragging start, which helps with
large nodes. Autoscrolling content was added when dragging nodes to
the top/bottom of the scrollview.
Fixes: QDS-10857
Change-Id: I5027324918a200746356704e36a6d99cb98aa04e
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
We forgot to quit the event loop in the case of an incompatible build
graph, causing each such operation to take ten seconds instead of
fractions of a second. In directories with lots of qbs builds, this
could result in Qt Creator freezing for several minutes.
Change-Id: I9f3de2e23fd67a87e9f487eb2a1b6e45fbde6f31
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Since we were adding the parallel item unconditionally to the
tasks list, the if(tasks.isEmpty()) condition was always false.
The intention was to check whether any call to addClangTool()
added at least one task.
The fix is to add parallel item after the condition is checked.
Change-Id: Iafdf21f1ac0f8fdd547a462990313e09a2dc46fd
Reviewed-by: David Schulz <david.schulz@qt.io>
We want one-or-more debuggers enabled. This was accidentally not
done if the python debugger was the last one to unselect.
Change-Id: I1bcdb43a66dc110dc213eba0db079e6d02c00170
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This might be useful when using conditional operator.
Might also be used in place of the default c'tor for GroupItem.
Add a test for it.
Change-Id: I622e5d3d94f7020dc294cf5bca643c53a0813d8a
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Detected by memory analyzer.
When shutdown comes while pythonsFromRegistry() or
pythonsFromPath() is still running, the corresponding
QFutureWatcher is leaked.
Employ TaskTreeRunner instead. It handles the cancellation
of the running tasks automatically on its destruction.
Make pythonsFromRegistry() and pythonsFromPath() cancelable,
by providing QPromise as a parameter and check for canceled
state on every iteration.
Change-Id: Iae7c7d1ed764646b8203bd7ca8b9580cb999b80c
Reviewed-by: David Schulz <david.schulz@qt.io>
There is no direct support in Perfetto. It can be simulated by
asynchronous tokens but then asynchronous tokens can be used directly.
Task-number: QDS-11952
Change-Id: I62dff6e8c1e93b71ccdc7b1678817d1909afa37c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Enabling and disabling a layout does not do so for
its child components which had been assumed.
Explicitly disable or enable filters to avoid
crashes when accessing them without a project info.
Fixes: QTCREATORBUG-30371
Change-Id: I56633dad4b3ffbb1c0c7c7d154c2af5d3c3cde6b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Accompanied by CredentialQueryTask, to be used in Axivion recipes.
It wraps QKeychain::Job subclasses into one asynchronous task.
Change-Id: I78a06255d880b02cba657c822976ef09454ac261
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
For posting dto data to the server.
Change-Id: Id519c311f13e7c42c85b758f97fefd79fa2c41e9
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Fix also a case when parent iteration isn't progressive.
Add a test for it.
Amends e059b62421
Change-Id: Ic2f8c047d413ab2e2b98af4592f7cb60185bea06
Reviewed-by: hjk <hjk@qt.io>
* Consolidate and simplify behaviorSettingsChanged callbacks.
* Do not call the callbacks during initialization, they are called later.
Change-Id: Ica4b601e091de2112c7737047cbffa8a98fc9f70
Reviewed-by: hjk <hjk@qt.io>
This can be null when accessed too early. Using the function-static
global instance directly ensures initialization.
There is more simplification potential in this area, but I'd leave
that for master.
Change-Id: Ide35f4119e9fbcb392d1abac180ef46c02c16b87
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
