Commit Graph

88653 Commits

Author SHA1 Message Date
Cristian Adam
7454f84901 CMakePM: When using presets only use presets for candidates
Since the CMake presets is built upon Imports, when loading the presets
it's better to only use the candidates from preset Kits and not any
matching Kit that could handle the build directory.

This makes working with CMake Presets a bit easier.

Task-number: QTCREATORBUG-29535
Change-Id: I895e2e9162763e4cf3af5cdef5c9d5b228211fab
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-02-08 17:36:22 +00:00
Andre Hartmann
98acd22734 DiffEditor: Init some more members to nullptr
Change-Id: Ia08c0ce5d6641533fe08f0a500f7439ec79882d8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-02-08 17:35:34 +00:00
Miikka Heikkinen
99f5b8a0af EffectComposer: Clear deleted effect if it is currently open
Fixes: QDS-11787
Change-Id: Iecd177a153e88a49476dbea0241c31726d05a6a8
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-02-08 15:12:54 +00:00
Miikka Heikkinen
c673e6aa20 QmlDesigner: Update extended View3D icons
Change-Id: If1aac862a3e62e518d321e61ddf3e7c25e30efb7
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-02-08 14:57:48 +00:00
Johanna Vanhatapio
c6705be88b Doc: Describe the Effect Composer
Fixes: QDS-10528
Change-Id: I46d7ab1977acb7f0af5c0aa790de7fbf2624a449
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2024-02-08 14:38:11 +00:00
Miikka Heikkinen
b1362ddda6 QmlDesigner: Do not register Effects for item library
Fixes: QDS-11925
Change-Id: I981853d1c02d99cfb391209a9a7e568bf52401cf
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2024-02-08 14:26:41 +00:00
Miikka Heikkinen
ca6e6e4f3e QmlDesigner: Fix validation on integer spinboxes
Now spinboxes use IntValidator if decimals is set to zero.

Fixes: QDS-11922
Change-Id: Ibe8c8a18294a6764a0cd2182d09c30cdf9fb27cc
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-02-08 14:26:29 +00:00
David Schulz
0422374e04 TextEditor: remove unused function of syntax highlighter
Change-Id: I9debd22730fcf2c9423beaaa5666ce282ed0bbe0
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2024-02-08 14:24:38 +00:00
David Schulz
e3bbace665 TextEditor: fix double delete in synchronous syntax highlighter
Change-Id: Ic4b9b78e5464613b9982814d771925d41f88bb25
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2024-02-08 14:24:31 +00:00
Artem Sokolovskii
cf7f9dffd5 Android: Fix Segfault when cancelling Android SDK installation
Fixes: QTCREATORBUG-30246
Change-Id: I929779e4cd8c37c9d69bd7aaffe9ae5b9acb7435
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-02-08 13:46:04 +00:00
David Schulz
1cddc3d0b6 TextEditor: fix applying empty list of format changes
The block might have had some highlighting before the update, so compare
the new ranges against the one from the layout and update the layout if
the format ranges differ.

Change-Id: Ia6a0025e74fa8941b1cccc00baa93d3d37cb9ff9
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2024-02-08 13:32:06 +00:00
Marcus Tillmanns
7b65432688 Wizard: Allow wizards to choose remote path
Change-Id: Ia7b0184452e2c4e86d727fbc3880b2e27285ef5d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-08 13:24:47 +00:00
Marcus Tillmanns
70e013fd25 Git: Cleanup gitExecutable()
Using expected removes a bunch of handling code.

Change-Id: Id524912d82aa693fbb39c7e7fa34abd77153f92e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-02-08 13:24:38 +00:00
Orgad Shaneh
31ca46ef2f VCS: Remove trailing dot in "running" message
The command should be copyable.

Change-Id: Id44e8af81f32de3d9899293de504070011f896c2
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2024-02-08 12:36:39 +00:00
Robert Löhning
b163044648 SquishTests: Update expected output in tst_git_clone
Change-Id: Ia0a559ee8fb24d639b913dabc1b77dd4c2286fbb
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-08 12:31:51 +00:00
Jarek Kobus
ba9ecc9b85 CppEditorOutline: Remove unused method
Remove also unused include and forward declaration.

Change-Id: I67d9ea45bc1073653b17faa3433f132a5e43f924
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-02-08 10:07:20 +00:00
Jarek Kobus
6deddd15c0 ModelManagerSupport: Remove unused Ptr
Change-Id: Ibdc81d1c6fecb808cbd7ca91f56a4869b6e26dc1
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-02-08 10:07:11 +00:00
Christian Kandeler
228f77afd1 QbsProjectManager: Support completion via qbs' LSP server
Task-number: QBS-395
Change-Id: I2571dc46c9fb2867daeb3a5d00709337b12a750b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-02-08 09:52:58 +00:00
Miikka Heikkinen
c491d652ab QmlDesigner: Prioritize hiding asset_imports content in UrlChooser
If the same file is available under asset_imports and outside it,
prefer hiding the copy under asset_imports in UrlChooser when duplicate
hiding is enabled.

Fixes: QDS-11908
Change-Id: I06ac298e1ea45f6a94c66eb20cc4c0d4655103f4
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2024-02-08 08:58:36 +00:00
David Schulz
eb95794e67 Debugger: Fix std string view dumper test for msvc
Cdb always report the type name with all typedefs resolved so we have to
check the original type name for cdb.

Change-Id: Ib7166276075b18e011ea786a5d3468db0e24e9c0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-08 08:46:36 +00:00
Dominik Holland
ecc3879cf4 AppMan: Only allow Debugging/Profiling with a Linux kit
Change-Id: I196fe6cc85065c3d9965f5fbb342f377bd221d95
Reviewed-by: hjk <hjk@qt.io>
2024-02-07 15:52:22 +00:00
hjk
3b2a4fd3f2 Vcs: Remove VcsBaseEditorPrivate::m_describeFunc
Use the new copy inside m_parameters instead.

Change-Id: I85cddfd598fe8fc95af99c7c89dfdb5af49b137e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-02-07 15:29:30 +00:00
Cristian Adam
b9f546cf1b ProjectExplorer: Add kitFilterText virtual method to ProjectImporter
This way a project importer implementation can modify the filterText edit
field from the Project setup page.

Task-number: QTCREATORBUG-29535
Change-Id: I22b3d613ff84111b918c4a4447cd5656d7c593b9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-02-07 15:19:54 +00:00
Artem Sokolovskii
44c9074c0b ClangFormat: Move clangformat output to infolabel
Move clangformat output to infolabel in clangformatconfigwidget
to reduce noiziness in cli and to enhance the convenience of editing
the .clang-format file.

Fixes: QTCREATORBUG-30269
Change-Id: I78053bde9791122172f1d3d4ba712a9954ea9c4e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-02-07 15:14:02 +00:00
Artem Sokolovskii
8ee97b1e02 QuickFix: Fix add definition for templated function in namespace
- Fix add definition for templated/not templated function in templated
class inside namespace

Fixes: QTCREATORBUG-22076
Change-Id: I565cbdc8c6ab8d09727b4cd6f1c8fb45741c213f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-02-07 15:13:47 +00:00
Christian Kandeler
e2756fde8b CppEditor: Add quickfix for converting a function call
... to a Qt meta-method invocation.

Fixes: QTCREATORBUG-15972
Change-Id: Id84c83c5832cef32a877a451b0931ec47d2afe9d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-07 15:01:42 +00:00
hjk
2d37a7421f VCS: Simplify VcsEditor setup
Create the editor parameter structures in-place, and also
include the other two parameters in the struct to simplify
the signature of the c'tor.

Change-Id: Iff7d5ddf3096f4a3ed18e53265ae74806823af32
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-02-07 14:49:02 +00:00
hjk
be33c807a6 ProjectExplorer: Remove PEPlugin::finishedInitialization() signal
It was only used once in the debugger, connect more directly there.

Change-Id: I96923a308adfd343daeab6574e097f24bf0654d5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-07 14:23:46 +00:00
Christian Kandeler
91e72756fb CppEditor: Support wrapping strings in QByteArrayLiteral()
Fixes: QTCREATORBUG-12995
Change-Id: I9c0136b93fcfde0d2326bbd2bd6dbd5e75ae97a8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-07 14:21:56 +00:00
Marcus Tillmanns
5ae401b923 Aspect: Don't try to change value more than once
When our window loses focus the editingFinished signal is triggered.
This can happen multiple times (QTBUG-121983) if the result of the edit
is a modal dialog and the user clicks outside our application.

This would call editingFinished again, resulting in multiple message
boxes being opened. (Easiest to reproduce is changing the build
directory of a project which displays a message box confirming the
change)

This patch checks, via a recursion Guard, that the slot is not already
in the process of being called.

Change-Id: I5e61e1b57680f0b1f2483a81682e791bfb5c0867
Reviewed-by: hjk <hjk@qt.io>
2024-02-07 13:05:37 +00:00
Leena Miettinen
898190bd21 Doc: Add brackets and quotes that are automatically inserted
This works for single quotes, angle brackets, and square brackets, too.

Task-number: QTCREATORBUG-30209
Change-Id: Icb07d87fe95ee8779ffc29f4623a7dfbdfca9e4d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-02-07 12:52:12 +00:00
Eike Ziller
ef6f8df26d Merge remote-tracking branch 'origin/13.0'
Change-Id: Ica486867e95e4cfc98272cd34781ce770690fa17
2024-02-07 12:53:07 +01:00
hjk
738b654396 Subversion: More direct access to client singleton
Change-Id: I4263b07da9970101dbbc798dbf64359c1da5199b
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-02-07 11:42:46 +00:00
hjk
87f1114d21 Mercurial: Use more direct access to the client singleton
Change-Id: I32711a893bc5d5d655cf92637defaaf149f3f108
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-02-07 11:42:39 +00:00
David Schulz
a6eb6dd909 Debugger: try harder to find static meta object
Improves dumping of QObjects when the staticMetaObject is defined in a
different module than the object itself.

Change-Id: Ic02103016d14b4925978d8afeaf2dbcc5dcebf85
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-07 11:25:50 +00:00
Eike Ziller
2ea3f5382b Merge remote-tracking branch 'origin/12.0' into 13.0
Conflicts:
	cmake/QtCreatorIDEBranding.cmake

Change-Id: Id7ac4d8b397cc20356cfbe30abcf43f53c4d2ff4
2024-02-07 12:22:50 +01:00
Jarek Kobus
ff1aa20892 QmlDesigner: Fix remaining C++20 warnings about [=] captures
Change-Id: Ia54208e5e72016f6ca22e0b005d479aac8f49929
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2024-02-07 11:20:13 +00:00
Jarek Kobus
48bdf883dd Tasking: Fix some C++20 warnings about [=] captures
Change-Id: Ic49c9f393155acd16a2c116672fe73361f5c874d
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-02-07 11:20:04 +00:00
Thomas Hartmann
87dd0096b4 QmlDesigner: Disable share button in open source version
Task-number: QDS-11627
Change-Id: I3eb21fa84b6993aa783713ef5fa3beba1e3e030e
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-02-07 10:44:11 +00:00
Leena Miettinen
7d468a2686 Doc: Describe the Move Definition Here quick fix
Task-number: QTCREATORBUG-30209
Change-Id: I248b64ba13de61b2b1582a89f285653e02128fbc
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-02-07 10:38:08 +00:00
hjk
69caca1561 Vcs: Use const ref/copy to editor parameters instead of pointer
Will be propagated to the calling code further.

The minor inefficiency here is in my opinion outweighed by the more
common setup. The structure is small and we don't have thousands of
VcsEditors.

Change-Id: Ifc0d6e4acd5ef206d5fcadf55f9eb28bd567967c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-02-07 10:33:18 +00:00
hjk
fe251201fb ProjectExplorer: Hide a few factories behind a setup function
Change-Id: I2b688cee072d9983fbceb536063454a97dea3e60
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-02-07 10:33:03 +00:00
Marcus Tillmanns
7daee3d681 Remove unused qt-breakpad
Change-Id: I33937cc3e50d5dd03d38c64675dc3883c816290a
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2024-02-07 10:17:49 +00:00
hjk
ad2230b1e1 Vcs: Move VcsEditorFactory closer to its product
Change-Id: Iaf2e6bdb4f04f0f1314ca7725feb63394a693511
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-02-07 09:58:23 +00:00
Leena Miettinen
80fa7ca453 Doc: Describe overriding system cursor for resizing editor views
- Update the screenshot of "Interface" preferences.
- Use the term "cursor" also when describing how to make the locator
  wider.

Task-number: QTCREATORBUG-29980
Task-number: QTCREATORBUG-30209
Change-Id: I5ca0d5c57932f32871a7354a2ea69f98482a2585
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-07 09:30:22 +00:00
Eike Ziller
a8ed2c505a Update copyright year, it's 2024 now
Change-Id: I183b87bf80332c789d000c37fd08f75297031b02
Reviewed-by: hjk <hjk@qt.io>
2024-02-07 09:27:02 +00:00
Jarek Kobus
d7d6f94c86 Axivion: Optimize combobox insertion
Keep the user data outside of combo boxes.
Use addItems(), which should probably be the fastest
insertion method.

Change-Id: Iec7e3fbe551a30e6a0e477e93add9c474c7f41fc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-07 09:25:19 +00:00
David Schulz
e4191b3219 LanguageClient: correctly unassign clients documents on project close
Change-Id: I82e041e787eb7a983de28b66b6ba6589a0548e42
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-02-07 09:23:52 +00:00
Christian Stenger
0e47028565 Squish: Fix missing impl for add shared script
The action is present for some time, but so far it had been
unimplemented.

Change-Id: I75722282cbe08aad6656e193822a5cb517ba17b3
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-02-07 09:09:31 +00:00
Cristian Adam
426dbc2f94 Terminal: Escape spaces for powershell paths
For the users that have a space in their user name, the location of the
shellintegration.ps1 is a path with a space in it.

This patchset fixes the escaping of that space.

Change-Id: Iae84b2e8a8f1b4e2b7e523e28417caaeb77bc5cd
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-02-07 08:24:40 +00:00