Commit Graph

88653 Commits

Author SHA1 Message Date
Artem Sokolovskii
3208dc92d3 SyntaxHighlighter: Remove using global fontSettings
Currently, default font settings are set inside the highlighter
runner after creating a highlighter. It prevents to call
TextEditorSettings::fontSettings() from non-main threads.

Change-Id: I0c806f0f586c67749cb2964bebdf2bf3c58a5302
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-12-14 13:28:22 +00:00
Shrief Gabr
6b6f74ccad QmlDesigner: Create data type warnings for CollectionDetailsModel
Task-number: QDS-11079
Change-Id: I8cb5167d71ff96d01313bc559401e16f0925afbb
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-12-14 13:12:57 +00:00
Eike Ziller
0c9f5c99e7 FancyMainWindow: Keep collapse state when toggling dock area
When using the hide/show side bar actions/buttons, keep collapsed docks
collapsed.

Change-Id: I2c455523f8cde2acf68280799dd8735631756120
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-12-14 12:54:10 +00:00
Eike Ziller
95fc28d37b FancyMainWindow: Move collapse functions to DockWidget
Make more sense there than in the title widget, though it was first added
there, because it has the button.

Change-Id: Ia4102beec2afa43d6ba2097c7cc29009180b635b
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-12-14 12:53:47 +00:00
Johanna Vanhatapio
4d042e5b7d Doc: Update info on baking lights
Fixes: QDS-11174
Change-Id: I8f92c3cca0faaa3f4b1db11caa8825677c80121e
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-12-14 12:28:40 +00:00
Christian Kandeler
2c4261e307 Wizards: Modernize some qbs project files
The "import qbs" stanza has not been required for probably a decade now.

Change-Id: I92aadc9fd7a95c3fddd38b8a1d86e473ce421b48
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-12-14 12:04:20 +00:00
Christian Kandeler
368ad63653 ProjectExplorer: Make DeviceKitAspect mutable for all non-Desktop kits
Fixes: QTCREATORBUG-30031
Change-Id: I0b2dacb5977b0f8e81afd13a0a4af6354ea81915
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-12-14 12:03:36 +00:00
Marcus Tillmanns
3425959e21 CompilerExplorer: Add assembly => source links
When hovering over the assembly, the matching source lines
are highlighted. Links inside the assembly are now clickable.

Change-Id: I22479a2e1badcfd95e0f341b2556fc93c8469625
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-12-14 10:14:02 +00:00
Marcus Tillmanns
7b1213d9f8 Utils: Fix initial display string for StringAspect
Change-Id: Ib76a5ef4e0792509dc3062c2be244e0f4be049d3
Reviewed-by: hjk <hjk@qt.io>
2023-12-14 10:13:57 +00:00
Serg Kryvonos
650ab0841b Use C++20 compatible std::invoke_result instead of std::result_of_t
Change-Id: I52ccd82f801af64de03d9076096755c52c1d8b37
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-12-14 10:03:03 +00:00
Jarek Kobus
d6bc19e54d Qt5InformationNodeInstanceServer: Avoid using sender()
Get rid of some unused includes.

Change-Id: Ib8dd5f9672c446c5c571e79ed1f26f3f4af2b65d
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-12-14 09:55:28 +00:00
Jarek Kobus
2f4fa0b62d Qt5NodeInstanceServer: Avoid using sender()
Amends b4db8a2d84

Change-Id: I9dc446d376bce9d91eb9d7a753003e0d92e10889
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-12-14 09:45:14 +00:00
Jarek Kobus
0f2a69408b Edit3DWidget: Avoid using sender()
Amends b662c50e0a
Amends 23f12f7b42

Change-Id: I71adb71c47e90aa257158eb7e600b99860432b3e
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-12-14 09:45:04 +00:00
Mahmoud Badri
434d0faaa0 EffectMaker: Add 'assign to selected' feature
Fixes: QDS-11444
Change-Id: I17b5397b88eeccaae585e84d7ce62f4f80474f87
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-12-14 09:39:30 +00:00
Mahmoud Badri
ff03588f7e EffectMaker: Add 'save as' functunality
Also some tweaks

Change-Id: Icc4767b816d1917cd674b20283d43e33ffb36219
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-12-14 09:37:40 +00:00
Marcus Tillmanns
7cc970ce5a TextEditor: Sort extraSelections
When applied to the QPlainTextEdit, the first selection for a range wins.
We want "OtherSelection" which is used for links to win, so we "sort"
it to the beginning of the final list.

Change-Id: Idf84c92ad5bd12d9f6ad6381f7e556e51ee459a9
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-12-14 08:45:12 +00:00
hjk
348ac80f4a CompilerExplorer: Use ActionBuilder
Change-Id: Id5692fdec9194482f0276274d5d772a00eb1994c
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-12-14 08:38:02 +00:00
David Schulz
7b4c531f69 Editor: fix inserting snippet selections
Fixes: QTCREATORBUG-30071
Change-Id: Ie4156b4b123fc342ed752c7c1ff353e7fb4797db
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-12-14 08:02:29 +00:00
hjk
a39dd6d425 QmlDesigner: Deprecate the plugin
Change-Id: Ia8128f41b494a64202982d2e7be4aec842505e72
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Kimmo Leppälä <kimmo.leppala@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-12-14 07:40:30 +00:00
hjk
32193684ef SilverSearcher: Modernize plugin item setup
Change-Id: I787c28853b1e2993db008f47fe1cc71244471338
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-12-14 07:38:59 +00:00
hjk
0af4518724 SilverSearcher: Move plugin class definition to .cpp
Change-Id: Ib270a5e205cc169c32d7f6f14a6eddae5bd8c0e7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-12-14 07:38:37 +00:00
hjk
57182b7fe9 EffektMaker: Move plugin class definition to .cpp
And clean up a bit.

Change-Id: I735c5af3d2806b78564095c9ad0f748f2821e787
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Amr Elsayed <amr.elsayed@qt.io>
2023-12-14 07:38:20 +00:00
hjk
c70b051cfe ClangCodeModel: Move plugin class definition to .cpp
Change-Id: I437ca5df1981b11809cbf52efe7aa9aacc1159d7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-12-14 07:37:46 +00:00
hjk
423e6e8943 WebAssembly: Remove now empty webassemblyplugin.h
Change-Id: Icbf59e53545a823a537461ad9986510f10f5c57d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-12-14 07:37:02 +00:00
Marcus Tillmanns
f12ace565b Core: Fix Scrollbar Highlight overlay visible
Change-Id: Ib92cd592c83bc20a83dd454879f8ff97adfc6677
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-12-14 07:26:42 +00:00
David Schulz
d24e575278 LanguageClient: fix crash in completion assist
Check m_processor again after starting. There is a callback resetting
the processor and we cannot ensure that starting the processor does not
result in calling this callback.

Change-Id: I4dca31399fb5224234c81df36edcb7b75d9ceaef
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-12-14 05:38:41 +00:00
Jarek Kobus
828f78ccd3 KillAppStep: Always finish the step with success
Fixes: QTCREATORBUG-30024
Change-Id: I7f2f3167bd3620a5a313fe6359c4ee58ff0d9e03
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-12-13 18:46:06 +00:00
Jarek Kobus
86d0ff1b61 CppEditor: Fix a warning about unused arg
Amends 0e04f40fa7

Change-Id: I5acd596670bb3332f6e6d1984ec5ccb75c3e161a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-12-13 18:45:49 +00:00
David Faure
9124833a63 Fix TreeModel emitting nested QAbstractItemModel signals
This led to an assert in QSFPM because it got confused by the
nested reset signals.

Detected by adding
new QAbstractItemModelTester(this, QAbstractItemModelTester::FailureReportingMode::Fatal);
to the OutlineModel constructor, and just opening QtCreator on a small
qmake-based project.

Change-Id: I41dbc81b5a2275521ece6b865115e1428e07ecf7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-12-13 17:42:10 +00:00
hjk
81098efbe6 ClangFormat: Declare QWidget when needed
Amends 120041905.

Change-Id: I88ecd1507cb1817ea315481b9aed430889995c16
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2023-12-13 15:45:15 +00:00
Tim Jenssen
d186d9df6a Merge remote-tracking branch 'origin/12.0' into qds/dev
Change-Id: I0a598ba1b4d57be361a7a203d0c39e99b5cd5fba
2023-12-13 14:53:17 +00:00
hjk
b0d8ae6d65 ExtensionSystem: Don't forget that we are shutting down
This apparently canh be triggered from a delayed
LanguangeClientManager::deleteClient() when the Client
checks isShuttingDown in its destructor.

The triggering code path probably should change, but this
here avoids the crash.

Change-Id: Ic39640b5465bcf14645510b925e00b9977351eac
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-12-13 14:39:39 +00:00
Serg Kryvonos
c3a7279f05 Work on lambdas C++20 compatibility
Change-Id: I0d391c02ae1e1c5a1751b33ca7e83902e1cfe269
Reviewed-by: hjk <hjk@qt.io>
2023-12-13 13:24:22 +00:00
hjk
b442ca3873 Core: Rename ActionBuilder::setOn* to addOn*
There could be multiple connections.

Change-Id: I7dbca9d24599f776b7d1f1bfa11826e3eeb5640a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-12-13 13:00:00 +00:00
Christian Kandeler
3b7d29d2a1 Utils: Add formatting information to ChangeSet::EditOp
... and make use of that in TextEditor::RefactoringFile.
This allows calling code to have fine-grained control over which parts of
a refactoring should get re-formatted, while also providing sensible
default values that are "almost always" right, so things typically work
as expected out of the box.

Change-Id: I9200c2135b7477c33bc5a61c5d410b34853e4b61
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-12-13 12:29:08 +00:00
Christian Kandeler
0e04f40fa7 CppEditor: Fix "testInsertAndFormatDefsFromDecls" test
Amends 240748c106.

Change-Id: I13a4eb28737636dbb5f5f5c1c7ab771a4518a701
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-12-13 12:27:54 +00:00
David Schulz
fbe054116a Python: Avoid polluting global or virtual environments with pylsp
Install the language server into the Qt Creator resource directory
instead. Reuse the server for all interpreters with the same
version. This also reduces the amount of editor toolbars asking the user
to install a language server for a specific interpreter.

Change-Id: I48ef4ad30fe0097ee8d2b855b0f278e98be5ce57
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-12-13 11:26:16 +00:00
hjk
1200419059 ClangFormat: De-Q_OBJECT and de-pimpl ClangFormatConfigWidget
Somewhat tighter code.

Change-Id: I8fde17ac66d0b1e49eb6554800f0f40d8f214ee3
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2023-12-13 11:09:41 +00:00
Mahmoud Badri
82a0ae5caf QmlDesigner: Add 'save as' icon and update zoom and save icons
Change-Id: Id05dd67407dd8a4db0056caa94c61b459bd4ab23
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-12-13 09:38:31 +00:00
Cristian Adam
32c389a556 CMakePM: Do not reconfigure during build
On Windows upon a CMake file change and save during a build, the
reconfiguration would fail due to the inability to save the build.ninja
file.

Fixes: QTCREATORBUG-30048
Change-Id: I68bec70b0a95bc4256b736a1c4caf1b4d706e43b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-12-13 09:19:26 +00:00
Jarek Kobus
657a90ef52 CurveEditorView: Make lambda non-mutable
Change-Id: Ida58d407b3d234cd051fc21935457e7fc6bfa590
Reviewed-by: hjk <hjk@qt.io>
2023-12-13 09:06:08 +00:00
Serg Kryvonos
1865b1b989 'transform' algorithm compatibility to C++20
Change-Id: I3d2e756bb5bbc034b36fd74b2569f089949b898b
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-12-13 08:46:51 +00:00
hjk
e17f0b6164 Core: Rename ActionBuilder::setContainer to addToContainer
An action/command can be used in several places.

Change-Id: Ifa26f64f7d200d93ada13f272de0fa833f886997
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-12-13 08:37:10 +00:00
hjk
5e2bc6f398 Terminal: Restrict shortcuts
Amends a0c05cabcc. Specifically Ctrl+Shift+T conflicts with
opening the type hiearchy pane when in a C++-editor.

Change-Id: Id4da738162ad9c90d6b45c4142a207ea22511d18
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-12-13 08:27:49 +00:00
Leena Miettinen
1cea4ea42e Doc: Hide links to topics not included into QDS Manual
Move a file to a creator-only folder and add conditions.

Change-Id: I8ebe71116f926dea10fa656ef17717b946ae80e2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
2023-12-13 08:13:59 +00:00
Leena Miettinen
2e7634230e Doc: Turn "Sharing Project Settings" into a how-to topic
Change-Id: I9a2d4058acb93273fdb449e0e5e67abec0ae7a24
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-12-13 08:13:37 +00:00
hjk
72d5cc7d01 ClangFormat: Use ActionBuilder
Change-Id: Ia276db9928193781ab90d34db01447498f40f4d1
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-12-13 07:58:13 +00:00
hjk
6e41548230 Help: Use ActionBuilder for part of the Help menu
Change-Id: I10ab89afc5005433395e5bf74a49979d90eb9e6c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-12-13 07:55:23 +00:00
Christian Stenger
e79ef5d66a Git: Fix missing include
Fixes building withi qbs and Qt6.2.

Change-Id: Ic87c81883286dbf96fa62ef3818af25001683737
Reviewed-by: hjk <hjk@qt.io>
2023-12-13 07:18:04 +00:00
Alessandro Portale
0d5ec992ab ExtensionManager: Remove left over testing code
Change-Id: I23c0d9981017eec7f7bc812853647bb812a84440
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-12-12 16:00:01 +00:00