The command passed to bash as argument needs to be quoted.
Task-number: QTCREATORBUG-29981
Change-Id: I0e91ab4c088f8cd4e5a2df82604ea86cf73369fc
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
... for the MiniProjectTargetSelector.
Instead, use a maximum width relative to the main window width,
similarly to what we did for the height in
ef00a7e28b.
Fixes: QTCREATORBUG-30038
Change-Id: If3de0460ea8e9ce43bfc795d6aba9d466c141313
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The default value was not correctly converted to a QVariant.
When a LibraryAspect was de-serialized from the default variant value,
it would create q QVariant<QMap<QString, QString>> which cannot be converted
to a Store by Utils::storeFromVariant and would end in an assert therefore.
Change-Id: I6f7b14d78793a07f027a6b375bc554941ffb83de
Reviewed-by: David Schulz <david.schulz@qt.io>
We forgot to reset the state, which gave us a permanently broken run
control, preventing re-starting the application, among other things.
Change-Id: I7c168e31e015fdf7002c57aba0ed2178437a15ae
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
For plugins that are still provided, but are no longer supported.
They are disabled by default and show a "unsupported" hint in the
plugin manager (similar to "experimental" plugins).
Change-Id: I6ad72fc0043900b5aa919c225ae94850d1d7a443
Reviewed-by: hjk <hjk@qt.io>
Do a copy of future interface inside the lambda body instead.
Change-Id: If84e37c62e43b815cfea0b5f60fe7fcebca63093
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Adds a full copy of KSyntaxHighlighting::Repository class
to the Highlighter class, enabling the relocation of the
Highlighter class to a separate thread. This adjustment ensures
that all Definitions come from the copy of the repository, making
them immutable from external code.
The "reload Definition" function stays supported, as triggering
it results in the recreation of the highlighter for the document,
thereby reconstructing the Repository class.
Change-Id: Id7a4d865228c7e7e20e4770601a3fde55b8a6513
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
when there is an untitled effect composition in the effect maker.
Change-Id: I3d905202e52b1242949d72f1870d4cc06efe080b
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Speculative fix for sometimes slow load times of the Terminal
plugin on Windows
Task-number: QTCREATORBUG-29840
Change-Id: I6782db075bfaa25fbabe2bac2a8f0f3b4af4f833
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: David Schulz <david.schulz@qt.io>
Use Process::interrupt again and ignore the superfluous exceptions when
debugging qbs builds with cdb reported by QTCREATORBUG-28279.
Change-Id: I010d41e2b01721d63a3967c9c95d7b10d47a4472
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
rendercontextcore is now a public header
(qtquick3d 89ca37fb914c6539334df62b38ea8cee80dade9d)
Fixes: QTCREATORBUG-30052
Change-Id: I58ac699ed81e958c0a0fccd14385b3359be1fb08
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Change actions to use ActionBuilder and
use ToggleAspects for tool buttons.
Change-Id: I0f4a58c3a98cb2804e3d387ea02cac043bd71ae7
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
... and use it in the setup of some IOutputPane actions.
Change-Id: If4c79d4f8ae73ca320e8c35d5f1e2f30a8c7050f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
- move cancel button to the left
- rename don't save to discard changes
- update buttons sizes to match their content
- remove few useless parts and reorganize the layout
Change-Id: I08308a90082b0c73ff9a6bf34b255764e07f20df
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Explicitly chose a newer kit as the kit we would use by default
lacks some compiler features on Windows.
This patch here only fixes the test crash when trying to access
a disabled menu item due to cmake dropping out with error when
parsing the project with the active kit.
Drive by change: removed workaround for fixed bug.
Change-Id: I783626f30d27ab1852536ae0d1f936ec8323feb8
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
This initial commit is merely a mockup of a ExtensionManager concept.
Change-Id: I19b2285667678a86097c043cc27a554545559eff
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: hjk <hjk@qt.io>
As defined by the new Qt Creator design system.
Change-Id: Ib67b35ea552cf88c4b89481b72e690e04a57bbb7
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Plugins must always connect to their local action, not the command's
action.
Amends f98934ef73
Change-Id: I95394080e4446da0f11dc91bf759d032c64f3445
Reviewed-by: hjk <hjk@qt.io>
The new font design suggests a slightly less caption font. This
has a visual impact on the mode bar labels.
Change-Id: I8d0714785b1e3f5b4c73493e0c9f45fcfc69b562
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
The new design spec defines a generic palette of colors
which will first be used for the extension manager, then
the welcome Screen and eventually in all/most of QtC's
UI.
This change adds the new enum keys and the light and
dark variant as section to the respective creatorthemes.
Change-Id: Ifeb691cfe29914463b0e9f9af27b33341f316cdd
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
This change involves the relocation of SyntaxHighlighter processing
to another thread. The core idea is to create a duplicate of the
original TextDocument using SyntaxHighlighterRunnerPrivate::cloneDocument.
A new SyntaxHighlighter is then instantiated by SyntaxHighLighterCreator
for the cloned document. The entire SyntaxHighLighterCreator class is
moved to a new thread, where it performs highlighting on the cloned
document. Upon completion of the highlighting process, the resultsReady
signal is emitted, and the updated highlighting data is applied to the
original document.
This shift of SyntaxHighlighter to another thread enhances the user
experience by preventing UI slowdowns during the highlighting process.
- Introduction of BaseSyntaxHighlighterRunner as an interface class for
future *SyntaxHighlighterRunner.
- Inclusion of DirectSyntaxHighlighterRunner class for performing
highlighting in the main thread, suitable for syntax highlighters
that cannot be moved to another thread.
- Introduction of ThreadedSyntaxHighlighterRunner class for highlighting
in a separate thread, preventing UI blocking during the process.
- Addition of Result data to the SyntaxHighlighter class to facilitate
data exchange between threads.
Task-number: QTCREATORBUG-28727
Change-Id: I4b6a38d15f5ec9b8828055d38d2a0c6f21a657b4
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Loading .pyprojects file now doesnt add a target for the default kit but
results in showing the target setup page which is filtered for usable
kits.
Change-Id: I4c407960a90a27457314281b79dc8878510eca80
Reviewed-by: Christian Stenger <christian.stenger@qt.io>