Commit Graph

88653 Commits

Author SHA1 Message Date
hjk
3a8314f793 WebAssembly: Support emsdk path with spaces on Linux/macOS
The command passed to bash as argument needs to be quoted.

Task-number: QTCREATORBUG-29981
Change-Id: I0e91ab4c088f8cd4e5a2df82604ea86cf73369fc
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-12-12 15:19:54 +00:00
Christian Kandeler
5e996ca11e ProjectExplorer: Do not use a fixed maximum width
... for the MiniProjectTargetSelector.
Instead, use a maximum width relative to the main window width,
similarly to what we did for the height in
ef00a7e28b.

Fixes: QTCREATORBUG-30038
Change-Id: If3de0460ea8e9ce43bfc795d6aba9d466c141313
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-12-12 14:33:22 +00:00
Marcus Tillmanns
e037bb0621 CompilerExplorer: Fix assert
The default value was not correctly converted to a QVariant.
When a LibraryAspect was de-serialized from the default variant value,
it would create q QVariant<QMap<QString, QString>> which cannot be converted
to a Store by Utils::storeFromVariant and would end in an assert therefore.

Change-Id: I6f7b14d78793a07f027a6b375bc554941ffb83de
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-12-12 14:31:00 +00:00
Christian Kandeler
cf16ef3139 RemoteLinux: Shut down an unresponsive SSH master connection
Otherwise, all subsequent ssh operations will silently fail.

Fixes: QTCREATORBUG-29982
Change-Id: I781aafcf408a9cb216f632e2beef92ec38652f57
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-12-12 14:27:57 +00:00
Christian Kandeler
f8cdcfd70c ProjectExplorer: Fix shutting down unreachable remote processes
We forgot to reset the state, which gave us a permanently broken run
control, preventing re-starting the application, among other things.

Change-Id: I7c168e31e015fdf7002c57aba0ed2178437a15ae
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-12-12 14:26:54 +00:00
Eike Ziller
a047ebba50 PluginManager: Add documentation for "SoftLoadable"
Change-Id: I542ffe892490ef796ad76a0afeac103a0c1e12f0
Reviewed-by: hjk <hjk@qt.io>
2023-12-12 14:03:55 +00:00
Eike Ziller
39927ff44d PluginManager: Add an "Deprecated" flag for plugins
For plugins that are still provided, but are no longer supported.
They are disabled by default and show a "unsupported" hint in the
plugin manager (similar to "experimental" plugins).

Change-Id: I6ad72fc0043900b5aa919c225ae94850d1d7a443
Reviewed-by: hjk <hjk@qt.io>
2023-12-12 14:03:47 +00:00
Jarek Kobus
3211fd1e43 GitClient: Make lambda non-mutable
Do a copy of future interface inside the lambda body instead.

Change-Id: If84e37c62e43b815cfea0b5f60fe7fcebca63093
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-12-12 13:53:26 +00:00
Mahmoud Badri
d9774e7faf EffectMaker: confirm save changes before opening an composition
Change-Id: I05659e4cdeba5dc5f437d2fb99bc3768c6a1522d
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-12-12 13:49:43 +00:00
Andreas Loth
b60c438f34 Axivion: Remove orphaned function declaration
Change-Id: I519713c9b47ce4d94758dc46f2c9b49450419c45
Reviewed-by: hjk <hjk@qt.io>
2023-12-12 13:32:23 +00:00
Jarek Kobus
327659e81a CppQuickFixes: Make lambda non-mutable
Change-Id: I13a1aadfab05e18d833f3b21240be49fdf4ce06d
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-12-12 13:06:40 +00:00
Artem Sokolovskii
e396f84d10 SyntaxHighlighter: Move generic highlighter to separate thread
Adds a full copy of KSyntaxHighlighting::Repository class
to the Highlighter class, enabling the relocation of the
Highlighter class to a separate thread. This adjustment ensures
that all Definitions come from the copy of the repository, making
them immutable from external code.

The "reload Definition" function stays supported, as triggering
it results in the recreation of the highlighter for the document,
thereby reconstructing the Repository class.

Change-Id: Id7a4d865228c7e7e20e4770601a3fde55b8a6513
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-12-12 13:03:59 +00:00
Mahmoud Badri
9d8aa76b4c EffectMaker: Show save popup when adding a new effect
when there is an untitled effect composition in the effect maker.

Change-Id: I3d905202e52b1242949d72f1870d4cc06efe080b
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-12-12 12:16:04 +00:00
Marcus Tillmanns
5f3950c620 Terminal: Defer shell model init
Speculative fix for sometimes slow load times of the Terminal
plugin on Windows

Task-number: QTCREATORBUG-29840
Change-Id: I6782db075bfaa25fbabe2bac2a8f0f3b4af4f833
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-12-12 12:05:25 +00:00
David Schulz
c622601db5 Debugger: simplify interrupting on windows
Use Process::interrupt again and ignore the superfluous exceptions when
debugging qbs builds with cdb reported by QTCREATORBUG-28279.

Change-Id: I010d41e2b01721d63a3967c9c95d7b10d47a4472
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-12-12 11:53:30 +00:00
Eike Ziller
a374588604 QmlDesigner/editor3d: Fix build with Qt 6.7
rendercontextcore is now a public header

(qtquick3d 89ca37fb914c6539334df62b38ea8cee80dade9d)

Fixes: QTCREATORBUG-30052
Change-Id: I58ac699ed81e958c0a0fccd14385b3359be1fb08
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-12-12 11:52:45 +00:00
Jarek Kobus
d1d573ad16 Aspects: Make lambda non-mutable
Amends 16f7652717

Change-Id: Id01ce3f7f0b5c9911097fa3ef2836015a009ed2b
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-12-12 11:51:24 +00:00
Jarek Kobus
24397509d4 Libs: Cleanup lambdas
Change-Id: I715a124dd73f23c735dde27d3205ac7613ae04c6
Reviewed-by: hjk <hjk@qt.io>
2023-12-12 11:28:30 +00:00
hjk
d81b4c3aff ScxmlEditor: Remove some unused includes
Change-Id: Ie6b4beb57eaf56bcfef1027c400ea20765e36aaf
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-12-12 10:56:06 +00:00
hjk
016936a450 Clean up some lambdas
Change-Id: Id947c0935b1aa4579e1c64d3e510db41103fbe27
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-12-12 10:55:32 +00:00
Mahmoud Badri
e984536b6f QmlDesigner: Fix opening the new effect maker
Change-Id: I23d278dfaa430df09cd31aa63e8034a7787bac7a
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-12-12 10:37:37 +00:00
Jarek Kobus
8d2cee31e4 TerminalWidget: Fix a warning about no return value
Amends a0c05cabcc

Change-Id: Ieb969f7a6c61469f69e8503089e4985fa8380e3c
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-12-12 09:34:12 +00:00
The Qt Project
83778b5ef5 Merge "Merge remote-tracking branch 'origin/12.0'" 2023-12-12 09:24:04 +00:00
Marcus Tillmanns
b6ee23d218 ProjectExplorer: Use SyncronizedValue instead
Protect sshParameters with SyncronizedValue instead of
manual QReadWrite lock.

Change-Id: Ib164eb34aa1b8167d00c02ce49fd5bfc9fba6c15
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-12-12 09:18:12 +00:00
Eike Ziller
10e5a27c27 Merge remote-tracking branch 'origin/12.0'
Conflicts:
	src/plugins/cmakeprojectmanager/cmakeprojectmanager.cpp

Change-Id: If96d0f0a3d48c2581e765e4afb8b23924c48bdd6
2023-12-12 10:17:39 +01:00
Cristián Maureira-Fredes
c4464eb072 Add logo and title to PySide install dialog
Change-Id: I7888ee906334de2c93c24c5da2394c9e73101a28
Fixes: QTCREATORBUG-30041
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-12-12 08:51:44 +00:00
hjk
27ef041d28 ProjectExplorer: Some more ToolChain->Toolchain renamings
Change-Id: I5cb2adf544a846f45f7fe7ce60f67b10ad100d91
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-12-12 08:14:59 +00:00
Marcus Tillmanns
a0c05cabcc Terminal: Refactor actions
Change actions to use ActionBuilder and
use ToggleAspects for tool buttons.

Change-Id: I0f4a58c3a98cb2804e3d387ea02cac043bd71ae7
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-12-12 05:46:33 +00:00
hjk
daa85c3166 Core: Add a ActionBuilder::setOnToggled function
... and use it in the setup of some IOutputPane actions.

Change-Id: If4c79d4f8ae73ca320e8c35d5f1e2f30a8c7050f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-12-11 15:08:55 +00:00
Christian Kandeler
1365ee7cb2 CppEditor: Add assertions to CppRefactoringFile::{start,end}Of(AST *)
I've seen this crash once with a null pointer.

Change-Id: I162e36155f030712f697da0bbf39ea5fef849db3
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-12-11 15:06:14 +00:00
Christian Kandeler
8594a7f114 QbsProjectManager: Make use of QbsProjectParser::m_parsing
This was apparently forgotten in
6913947986.

Change-Id: I237d21ecde898a2c9206aaeae74b2d05372cce2e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-12-11 15:01:27 +00:00
Christian Kandeler
c7f88ced89 ProjectExplorer: Fix FilePath construction for git paths
Change-Id: If29c0afcd41789ded5eccc6e098b3fadb390287d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2023-12-11 14:59:58 +00:00
Mahmoud Badri
2af5ce7fa9 EffectMaker: Generate unique effect name when saving
Change-Id: Ib602b778d810fe0d6c0d70879b1002c1749fe196
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-12-11 14:59:24 +00:00
Shrief Gabr
8f51c7a75d QmlDesigner: Modify model export functions
Task-number: QDS-11298
Change-Id: I919c8cd4ecac4bad7dab4d4fdf2d1cf3548cd95b
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-12-11 14:51:19 +00:00
Eike Ziller
d3c805630a CMake Debugging: Do not build/deploy
Fixes: QTCREATORBUG-30045
Change-Id: I478abaf29462d9413f3285527459a98b1cae899d
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-12-11 14:50:17 +00:00
hjk
6c22a3ec8c Boot2Qt: Fix menu insertion of qdb flash to device action
Change-Id: I359b4ae398337ae3edb138cca1b3bdaf5cc86424
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-12-11 14:22:11 +00:00
Mahmoud Badri
fba2fda788 EffectMaker: improve save changes dialog
- move cancel button to the left
- rename don't save to discard changes
- update buttons sizes to match their content
- remove few useless parts and reorganize the layout

Change-Id: I08308a90082b0c73ff9a6bf34b255764e07f20df
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-12-11 14:09:20 +00:00
Christian Stenger
1633d76b76 SquishTests: Allow designer test to progress further
Explicitly chose a newer kit as the kit we would use by default
lacks some compiler features on Windows.
This patch here only fixes the test crash when trying to access
a disabled menu item due to cmake dropping out with error when
parsing the project with the active kit.
Drive by change: removed workaround for fixed bug.

Change-Id: I783626f30d27ab1852536ae0d1f936ec8323feb8
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
2023-12-11 14:03:13 +00:00
Jarek Kobus
a9721c5f34 ExtensionManagerWidget: Fix warning about unused arg
Amends f97fd83fc9

Change-Id: I540a3a8916bb7de363aacf309ca2474b221add78
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-12-11 13:35:07 +00:00
Eike Ziller
049ac852a6 Change log: Add some more items, convert bug numbers to links
Change-Id: Ic9b3d3f9a7441fd6bec0ffee4fee7082e91d5a95
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-12-11 12:37:33 +00:00
hjk
f97fd83fc9 Plugins: Add skeleton for new ExtensionManager plugin
This initial commit is merely a mockup of a ExtensionManager concept.

Change-Id: I19b2285667678a86097c043cc27a554545559eff
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2023-12-11 12:10:36 +00:00
Alessandro Portale
fb28890eb2 Utils: Introduce H5, H6 and "H6 Capital" Ui fonts
As defined by the new Qt Creator design system.

Change-Id: Ib67b35ea552cf88c4b89481b72e690e04a57bbb7
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-12-11 12:03:44 +00:00
hjk
2becddf704 ActionBuilder: Rename private action member to contextAction
Closer to what it's called in the API.

Change-Id: I88e7ab3cff33b5e59262510abcb01a6b46a6aece
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-12-11 11:39:39 +00:00
David Schulz
f4bf7c5b00 Python: show warnings if pip or venv is missing
Change-Id: Ib38c1eb3b0f31d6988d3a5f084ac6eda08ec0619
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-12-11 11:39:11 +00:00
Eike Ziller
67b7835c25 Fix Find Next button and other actions
Plugins must always connect to their local action, not the command's
action.

Amends f98934ef73

Change-Id: I95394080e4446da0f11dc91bf759d032c64f3445
Reviewed-by: hjk <hjk@qt.io>
2023-12-11 11:19:49 +00:00
Cristian Adam
6846579266 CMakePM: Allow usage of custom output parsers for CMake output
Fixes: QTCREATORBUG-29992
Change-Id: Ia84871cc963263c34054d17742556b38a1f1934e
Reviewed-by: hjk <hjk@qt.io>
2023-12-11 10:58:21 +00:00
Alessandro Portale
d5b3366d55 Utils: Change UiElementCaptionStrong from Bold to DemiBold
The new font design suggests a slightly less caption font. This
has a visual impact on the mode bar labels.

Change-Id: I8d0714785b1e3f5b4c73493e0c9f45fcfc69b562
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2023-12-11 10:04:39 +00:00
Alessandro Portale
7a890f5e94 Utils: Add Qt Creator Color Tokens to QtC themes
The new design spec defines a generic palette of colors
which will first be used for the extension manager, then
the welcome Screen and eventually in all/most of QtC's
UI.

This change adds the new enum keys and the light and
dark variant as section to the respective creatorthemes.

Change-Id: Ifeb691cfe29914463b0e9f9af27b33341f316cdd
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2023-12-11 10:04:31 +00:00
Artem Sokolovskii
62ea85ee6a SyntaxHighlighter: Move SyntaxHighlighter to separate thread
This change involves the relocation of SyntaxHighlighter processing
to another thread. The core idea is to create a duplicate of the
original TextDocument using SyntaxHighlighterRunnerPrivate::cloneDocument.
A new SyntaxHighlighter is then instantiated by SyntaxHighLighterCreator
for the cloned document. The entire SyntaxHighLighterCreator class is
moved to a new thread, where it performs highlighting on the cloned
document. Upon completion of the highlighting process, the resultsReady
signal is emitted, and the updated highlighting data is applied to the
original document.

This shift of SyntaxHighlighter to another thread enhances the user
experience by preventing UI slowdowns during the highlighting process.

- Introduction of BaseSyntaxHighlighterRunner as an interface class for
future *SyntaxHighlighterRunner.
- Inclusion of DirectSyntaxHighlighterRunner class for performing
highlighting in the main thread, suitable for syntax highlighters
that cannot be moved to another thread.
- Introduction of ThreadedSyntaxHighlighterRunner class for highlighting
in a separate thread, preventing UI blocking during the process.
- Addition of Result data to the SyntaxHighlighter class to facilitate
data exchange between threads.

Task-number: QTCREATORBUG-28727
Change-Id: I4b6a38d15f5ec9b8828055d38d2a0c6f21a657b4
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-12-11 09:55:02 +00:00
David Schulz
d5ddf391c1 Python: optimize loading projects
Loading .pyprojects file now doesnt add a target for the default kit but
results in showing the target setup page which is filtered for usable
kits.

Change-Id: I4c407960a90a27457314281b79dc8878510eca80
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-12-11 09:33:26 +00:00