... by not actually creating the unused instances of the Id types.
Change-Id: Id6123d359d8b8af41794e41a61fc00b05a2291ed
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
It's effectively just one string and wasn't aspectified.
Change-Id: Ifdfabddbd3d9e089487eefd1591db267685a582b
Reviewed-by: David Schulz <david.schulz@qt.io>
When we checked for validity of recent projects, we used `isFile`, but
the path that is used for opening a workspace project is a directory.
Change-Id: Ie22c13c06c22d4584d1e198d5ab133025ea536c8
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
We missed to initialize the recent projects menu when initializing.
Amends 77d7106b3a
Change-Id: Icd394d8500c5853a6195ab1868e20caed3f5f323
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Make the overlay widget as small as possible, paint it opaque, and paint
only on the editor tool bar.
Change-Id: If48f8f7c4dd221cb605548449f5bbb1a30c25a76
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
The connectedDevices() constructs the full list of
AndroidDeviceInfo with details not needed by
getRunningAvdsSerialNumber(). These details were generated by
using 2 excessive process runs. Get rid of them, and deliver
result as soon as the matching device if found.
Change-Id: Idc3d9d3321e471f8eaa0d69287f5e748813fc427
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This updates the list delegate for ExtensionManager items to match the
latest Figma design.
Change-Id: I769026caa1e08feea4f71d901d1bda01d74ab0a2
Reviewed-by: hjk <hjk@qt.io>
... rather than accessing the aspects directly.
Task-number: QTCREATORBUG-30925
Change-Id: Id39b6226f6bbee75b93905747373513294deb29e
Reviewed-by: hjk <hjk@qt.io>
... into parent class implementation.
This way, the executable expansion will be done for all sub-classes, the
remote custom run configurations being the most relevant ones.
Task-number: QTCREATORBUG-30925
Change-Id: Id7715d9f60338767c0623fa33749ef18338ae479
Reviewed-by: hjk <hjk@qt.io>
This way you can have code completion for the constant literals and not
do any accidental typos.
Change-Id: I1f9dc36327052fcda9575dddec909db93c4b225c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
If a CMake preset has the CMAKE_CXX_FLAGS_INIT parameter defined, it
would override the QML debugging flag set before.
This patchset makes sure that both are present.
Change-Id: I2012567af04c2fa0b0097331c05d96770dd86503
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
The connectedDevices() constructs the full list of
AndroidDeviceInfo with details not needed by findAvd().
These details were generated by using 2 excessive
process runs. Get rid of them, and deliver result
as soon as the matching device if found.
Make getAvdName() public.
Change-Id: Ic58e2ee55f275e230c07631853225ca3fdefd730
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Before, the implementation used connectedDevices() function
which constructs the detailed info about each device
found, including running 3 extra processes for each device
in a loop. For the purpose of isConnected() - the detailed
info isn't really necessary - it's enough to parse the output
of the {adbToolPath(), {"devices"}} command and detect if
the requested serialNumber appears there. We skip executing
3 additional processes for each device found.
Change-Id: I34f79fb56b4aa4d52a284bc2c67ae01a3467b505
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Only print out additional information if the environment
does not match the expected one.
Change-Id: I9be1a90400a180a4cbd0381f54eea79409c007c7
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The item view was made read-only and this connect
only results in a warning on the command line when
double clicking an item.
Amends 8ef85e481a.
Change-Id: I32d6b9d38e2c554fb91f5cbd1f1f5fd1e6c1a394
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
In the edge case that the name of one variable starts with the name of
another followed by an underscore, we mistakenly stopped at the former
when searching for the latter in the text widget.
Fixes: QTCREATORBUG-30855
Change-Id: I6decf7805a937d52d25e6c62899ae062f636a2a1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This patch allows commenting environment changes or adding
comments to the batch edit widget.
To mark a line as comment prefix it with '##'.
Modifying the environment by using the batch edit mode
allows using '#' to disable variables.
Mis-using this to disable statements of the environment
items widget is tempting and other tools explicitly allow
it this way. But when doing so, the environment may get
some unforeseen modifications.
So, explicitly provide a mechanism for comments and be
more clear about this inside the documentation.
Change-Id: I6a58d0d00e996a3f886ec30e826cade324321818
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
On macOS we now (with Qt 6.7) get nice, high resolution pixmaps from
QIcon::fromTheme. That means that our wrong assumption that the pixmap
size == UI size leads to huge layout sizes for the indicator of the
current wizard page.
We need to take devicePixelRatio into account for determining the UI
size.
Fixes: QTCREATORBUG-31015
Change-Id: I6e9c77cf2f37fce60735e75c1fa694e4b4208b98
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Amends a25bbf23c6
The commit broke evironment variable usage in CMake presets. For example
"$env{HOME}" would have been expanded to "/home/user:/home/user" because
of code thinking it deals with paths.
Change-Id: I3ef34179e2ebaf55b25a42dcce87438c1a72b73e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Make it more conforming to the current Qt style:
1. Remove trailing semicolons after inlined functions.
2. Use Q_SIGNALS / Q_EMIT in headers.
3. Use QString::fromLatin1() where needed (as otherwise the string
c'tor is deprecated).
4. Use module names in Qt includes.
5. Simplify local asserts in barrier.cpp.
Change-Id: I13cadee6ff61a24d792efcf3b613f7cf5563076b
Reviewed-by: hjk <hjk@qt.io>
Before, the loop got finished after the very first
failure of the pid command. Fix it so that the loop
stops on the first successful execution of any child.
Make timeout task return error, so that the loop
continues executing after the timeout.
Simplify some commands' constructions.
Amends a7ece15f6e
Change-Id: I637002f0248ec69e61e058c7246471396aac1142
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
If a GCC compiler has platform codegen flags they will be set into
CMAKE_C_FLAGS_INIT or CMAKE_CXX_FLAGS_INIT initial CMake parameters.
The linker flags are set they will be set into
CMAKE_EXE_LINKER_FLAGS_INIT, CMAKE_MODULE_LINKER_FLAGS_INIT and
CMAKE_SHARED_LINKER_FLAGS_INIT initial CMake parameters.
If the kit has a Qt the CMAKE_CXX_FLAGS_INIT value will merge both GCC
C++ platform codegen flags and the QML Debugging flags.
Fixes: QTCREATORBUG-24420
Change-Id: I066d30b816ae8575f615654bb85bd82a394f9737
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
CMake can have custom build types. Qt Creator can rename existing build
types.
This changeset allows having a custom build type like for example:
* CMAKE_BUILD_TYPE=MyRelease
* CMAKE_CONFIGURATION_TYPES=MyDebug;MyRelease
Fixes: QTCREATORBUG-30014
Change-Id: I3d81d9ff867bfaab29aaf1741606f9c586da82e0
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Otherwise, a non-responsive device will freeze Qt Creator for ten
seconds (with no announcement, because the env call does not go through
the device shell).
Change-Id: I92ab847dd441494770dbe29cde1c726dd31f32fb
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
It needs an explicit constructor, otherwise it complains that it cannot
find a match to the Arg2{p1, p2} call (requires 1 argument, but 2 were
provided) etc.
Amends 6231213aa3
Change-Id: Ibe3b27b334b8abff5028a77372cf208bfda9d8c1
Reviewed-by: hjk <hjk@qt.io>
reduces the number of calls to ShortcutSettingsWidget::initialize while
the shortcut settings widget is open and actions get registered. For
example when searching the preferences dialog the shortcut settings
widget is alive and some setting page widgets create a text editor,
which again registers some actions.
Change-Id: Ieb3c3d1c7ce317c3407a9c97514f6cc4a4ce76c4
Reviewed-by: hjk <hjk@qt.io>
Copilot has changed the name of agent.js to language-server.js. This
patch adds the new name and changes the installation note without
changing the translation.
Change-Id: I585fe54c86029de32de806447ec3356999a99540
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
We normally use arm-none-eabi-gdb-py, but this doesn't come
with the new arm gcc version which ships with Qt for MCUs 2.8.0
To make sure the kit works, use this as a fallback.
Task-number: QTCREATORBUG-30699
Change-Id: I85c6c3ea1f7aae504e0aa1afb8a344d9bc3067d5
Reviewed-by: Kwangsub Kim <kwangsub.kim@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
