Query variable QTC_USER_FILE_PATH for the path and store .user files
there under a tree replicating the project path excluding root.
Use cases:
- Developers working with nightly, clean builds of Qt / Qt Creator.
- Keep the .user files out of the example directory when creating
examples for bug reports.
Change-Id: Ib80c5fab3cc943317ec080eba8a6b92c16fc1aed
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
If using the flat style also the TargetSettingsWidget should be flat.
Change-Id: I16147c9868e3e949a4d9aa0fedf85358504bde9e
Reviewed-by: Thorben Kroeger <thorbenkroeger@gmail.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Make the relevant member functions Q_INVOKABLE and properly notify
about the height change when data is loaded or cleared.
Change-Id: I7c1ee70942617af2045b84a2d8f0ab2adef72f52
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
This reduces the complexity involved in making the row count a
property. Empty models do have rows like this, but don't have a height.
It doesn't get much more consistent than that. Before empty models
didn't have rows but you could still query the row heights. Having
height == 0 is very helpful for assembling the UI, rows == 0 not so
much.
Change-Id: I38ee9f46751a4beb288578d5cd1f0a17ea08814a
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
That's where they belong. Having them in the view makes no sense.
Change-Id: Ia2a6c8b02804ed8a1e10b0731cd62b6fd6489b0c
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
This can be manually triggered by entering e.g 'tbreak file.cpp:1'
in the debugger input pane.
Change-Id: I8212e82d258bb488fc1848e7d7e3e9ff5a3cae88
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
After attempting to jump to an inaccessible location, the
engine was still expecting a ^running, while in fact GDB
was stopped. Add the right state transition.
Change-Id: I69aec785a1e9d2a23771f74ae35064ae61405fa5
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
If closeChannel() is called in between our channel open request to the
server and the corresponding reply, we cannot forward the close request
to the server, as we don't have its channel id yet. So wait until we do.
Our failure to correctly handle this sequence of events was the root cause
for the following user-visible errors:
- A (since-removed) Q_ASSERT in ~SshRemoteProcess() was hit.
- The server closed the connection because we referred to an invalid
channel ("Received ieof for nonexistent channel -1").
Commits 26920307f0 and 3027bcc952 are also related to this issue.
Change-Id: I4994d85f5b21a72682f75389cdf8769738bd6768
Reviewed-by: hjk <hjk121@nokiamail.com>
... and connect it using Qt5-style connects.
Change-Id: Ic7f36949b38d4773f5ac0f04853abf93bebcf467
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
TextDocument::open() sets a clean absolute path for the document, but
DocumentModel::documentForFilePath() did not normalize before comparing.
This resulted in the creation of multiple TextDocuments and Widgets for
the same path. Was re-producible with:
1. Open the locator
2. Type "f a.cpp" and Enter
3. Go to 1.
Point 2 lead to an EditorManager::openEditor() call with an unclean
path. The second iteration triggered an QTC_ASSERT in CppModelManager.
Regression introduced by:
commit 292cf6c9e8
Algorithms for DocumentModel
Change-Id: I82fbc39251e48c1c97d6933857de172818d73f13
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
The model factory only exists if there is a plugin providing it. Also,
it's a good idea to initialize it.
Change-Id: I904bae1e733c37699a99e84e79c67ab4e8aea805
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
We now use it in contexts that do not have access to a Project.
Change-Id: I96ebad60f5fc354b004092748033d83c766a305d
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
It's silly to force all callers in the chain to use a non-const pointer
for a Kit that is really const just because of the QList<T *> vs.
QList<const T *> problem. Instead, use a (safe) const_cast for the
list operations.
Change-Id: I929cb9e42957de48d7ad8e1e4b04a7739f9c22bf
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
We used to validate the displayname set before the last change,
which is not really useful:-)
Task-number: QTCREATORBUG-13424
Change-Id: Ia71f82d0ab0c8d6392be8dbd8fccad7fb9230b2d
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
- It is not an error if the server replies to one of our earlier
requests while we are in closing state. This can happen if we
close the channel shortly after sending the other request.
- Also change the message itself, which could be interpreted as
"packet corrupt" when we actually meant "packet unexpected".
Change-Id: I735c67b2a9b41af0c5e0b8d229369d94ec37277c
Reviewed-by: hjk <hjk121@nokiamail.com>
Use paths with native directory separator when comparing
application names. Also disable the "Continue on Attach"
combo box when a kit with a cdb is selected. The cdbengine
always continues after an attach.
Task-number: QTCREATORBUG-13517
Change-Id: I3dd9cca98f9b4255cafc318836377d802413eace
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
DetailedErrorDelegate::sizeHint() calls createDetailsWidget() even for
invalid indices, which does not make any sense.
With this change the following messages will not be displayed anymore
when switching to the the Clang Static Analyzer:
QWidget::setMinimumSize: (/QWidget) Negative sizes (636,-1) are not possible
QWidget::setMaximumSize: (/QWidget) Negative sizes (636,-1) are not possible
Task-number: QCE-28
Change-Id: I7d45b2625ad94ddccfbb2c22ff5c07ee0bdd1256
Reviewed-by: Robert Loehning <robert.loehning@theqtcompany.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
get simulator type and SDK version dynamically from the available ones,
and let the user choose which one to use.
This fixes the static solution that did break with Xcode 6
Change-Id: I5cb2be68b9ea8736fc880cf3dd9d39d77f030293
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@theqtcompany.com>
The revision markers are configured by the display
settings. There is no need to set them manually.
Task-number: QTCREATORBUG-13498
Change-Id: I99ee829d64dd23a7d24f13580a75c7c1666823f4
Reviewed-by: hjk <hjk121@nokiamail.com>
Warning which needs return value should be asynchronous because the event
loop of the blocking dialog leads to crashes.
Change-Id: Ie49c95d63ec3f2183378013c726c3b99680dc7b0
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
Private plugin are considered those whose name ends with "private".
Avoid being misleading, i.e. do not declare the plugin dump as successful.
Change-Id: Id181d3a09dc9c4895f6566e22ad670435bd5a7f8
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@theqtcompany.com>
updateProjectInfo did reset the ProjectInfo to the default one.
As now currentProjectChanged calls it at a different time, it did
give several issues.
Change-Id: Ia1eabc0ea83e89038a8f7d10cc6cda0544abfaea
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
builtins were always using qtimportPath, which is now being removed,
so prefer qtQmlPath.
Change-Id: I99d9214c2188507859f27b729c027aaf77eb579e
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@theqtcompany.com>
Obviously the patch removes too much.
This reverts commit 9a5f81d96f.
Change-Id: Id6f128a8d72b51d0d1701a0a82377b56e2a314b2
Reviewed-by: hjk <hjk121@nokiamail.com>
The MainWindow was not always the first window and active has to returned
instead of a nullptr. Using dialogParent should fix it.
Change-Id: If78edb5e9567111aa998bbe5da70b3f148a3fd16
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
There are no other copy related (menu) action, so it's clear that "Copy"
applies to the current selection.
Change-Id: I1042e6be2be79a7865fedeb0d84ea968ce4b41dd
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
qmltypes files were stored in the snapshot during scan, this is wrong
and bloats the memory usage.
Task-number: QTCREATORBUG-13369
Change-Id: Ie8c3970ad7a8d732230f3dc73a9ba65ab62ea4e9
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@theqtcompany.com>
Remove rarely used ones, add a currentTextEditorWidget()
Change-Id: I27b97c17927c71e07dc3b489785b7f2f76eb801e
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
