The dead store is not harmfull, but add noise when checking for dead
stores that are due to logic errors.
Change-Id: I244c57e3227d075cb625252e8246c22768bc275c
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
When the QTC_CHECK would fail, a nullptr deref would happen directly
after the check.
The dead stores are not harmfull, but add noise when checking for dead
stores that are due to logic errors.
Change-Id: I83db386e3f0de583469e1576e28955c25930b3b1
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Such build system files must be filtered out, as they do not appear on
the right-hand side of "files" properties and have completely different
remove semantics.
Change-Id: I3963aa853003f4d674392434529dab19749af25b
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
createConfigWidget() calls KitManagerConfigWidget() calls discard(),
which results in a signal unmanagedKitUpdated. In response to that
signal, the KitModel iterates over all kit nodes. The node we are
currently creating doesn't have a widget yet, and thus leads to a crash.
Prevent that by adding the node only after the widget has been fully set
up.
Change-Id: I5b14be1c7363e480e3dd938853ff06c595993fc2
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
The dead store is not harmfull, but add noise when checking for dead
stores that are due to logic errors.
Change-Id: I18084c357696311b6556c7bc60832a72b3318e92
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
The dead stores are not harmfull, but add noise when checking for dead
stores that are due to logic errors.
Change-Id: I8bf61c51207f0339911bc07fcfbc06f8066521e5
Reviewed-by: hjk <hjk121@nokiamail.com>
The divide by zero is intentional, so suppress the not-quite-so-false
positive from appearing.
Change-Id: Iba96682e5b584a7e4a8e5895af0ccfc68b73cc71
Reviewed-by: hjk <hjk121@nokiamail.com>
This reverts commit c228b36ccf.
There are multiple issues with the reverted patch:
* Infinite loop due to indirect recursion e.g. when opening projectmodels.cpp
* Crash when executing CppTools tests on Windows (no infinite loop)
Change-Id: I38f02132ca57d3d32085db6146d0df7d620d7618
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
The ast parameter cannot be null, because the only use checks for it not
to be null. However, if it would ever be re-used somewhere else, the
logic is plain wrong. Clarification by an assert makes it clear what the
intent is.
Pointed out by the clang static analyzer.
Change-Id: I2c8cba5e5847fc1f92c10021109c55ff8ccd58c4
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@digia.com>
Channel exit is completely normal if we closed the channel, so this must
not cause an error message.
Change-Id: I57f5165b339a52a25118ad5e357f41334dadebc4
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
“Move Component to Separate File” and “Wrap Component in Loader” did
work only for UiObjectDefinitions, extended them to UiObjectBindings.
Task-number: QTCREATORBUG-12904
Change-Id: I5216110c1edfc6e4536f83eba39e74919c918d50
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>
The statement in the RFC was misunderstood.
Task-number: QTCREATORBUG-12884
Change-Id: Icd533362ebf95d963cacc8d11da03360e742f070
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
Especially when this gets more complicated with additional fancy windows
mime types and custom mime type for opening a file at a specific
location (dropping from Outline, Type Hierarchy et al), we should not
create that complex mime data everywhere by hand.
Change-Id: I37f6ceb287b0cd055501fdd033ac29816434a020
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
When the check would fail, it would result in a nullptr deref 3 lines
down. As this is a constructor, doing a QTC_ASSERT(..., return) would
leave the object partially initialized, with some fields containing
random garbage.
Change-Id: I823d52d43d90eaf06cb7d7cd64fbee17e5fc889e
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Setting QTC_HELPVIEWER_BACKEND to "native" when the native backend is
not compiled in, would result in a nullptr deref.
Change-Id: I5618650e0c4ae1c986a54a46232e8f782e43f350
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
When the check would fail, it would result in an nullptr deref 4 lines
down. As this is a constructor, doing a QTC_ASSERT(..., return) would
leave the object partially initialized, with some fields containing
random garbage.
Change-Id: I7e504f16f3bd07e3669c02773434915bc817c8bd
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Fix capitalization, punctuation and typos, and remove
unnecessary text.
Change-Id: Iee39e465125d5d9eec099323fb7d75756c8d81df
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
This was a regression introduced during the editor setup refactoring.
Task-number: QTCREATORBUG-12982
Change-Id: I7b26b4105dfb50357dd2cf97d07153031d0b2dc0
Reviewed-by: Campbell Barton <ideasman42@gmail.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
Replaced the style sheet and sub-widget by plain painting code. At the
same time achieveing high-DPI support by adding the @2x variants of the
border images.
Change-Id: I09804e3349b4650c7c6cfc2341913079a51a52a7
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
If it is initialized too early, activities combo is empty.
Change-Id: I6ca34e7bcae5d9960b1f84cd3f95ce13ae45ccca
Reviewed-by: Knut Petter Svendsen <knutpett@pvv.org>
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
If we take longer than a frame for painting a pass we don't really gain
anything.
Change-Id: I6be5cc59116d3eb5d3ef6a863f4cf410333c7e91
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
The QML canvas is notoriously bad at keeping its context around. This
workaround gives us a valid context in many of these cases.
Change-Id: I6c23aa2b44c10a48cdb89c66a2861ab8d31bcfc8
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
This clarifies that the item height is not absolute but relative to the
row height, and it reduces the ambiguity of the various "height" methods.
Change-Id: I391441147c88b47a14e539fc3853702bb517d27b
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
Documents with those types do crash the qmlpuppet and confuse the users.
With this patch we give a clear error message and such files are not supported
anymore.
Change-Id: Iba19def2751d4dc81d90684c0c63c0274fdf49cf
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@digia.com>
This patch adds an option to configure the usage of qml(2)puppet.
By default the qml(2)puppet that comes together with Qt Creator is used.
Change-Id: Idada8457e81fa17d3290dc97ded303aab475a9f3
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>
Utils::WizardPage has a bit of helper code to the Utils::Wizard to
query registered fields later on. Without this code it will print
warnings whenever something tries to read a field that does not
exist.
Make the wizard pages defined in Utils export some fields.
Change-Id: I907be327a8b1b8691f90773470630582503d294a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
