...instead of sticking to the old one.
If a project is closed, the editor should reflect that. It also simplifies the code.
Change-Id: I9b8a94513d3b06a238cfc4ee60c11c0d0da3d93f
Reviewed-by: David Schulz <david.schulz@qt.io>
While at it, centralize the code for handling the info bars and actions.
Change-Id: Ied62e3db268aaff3ef87e246bfe2b50399341be3
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
while the fallback chain really *is* "Put" => Raw => Get => Src, this
implies that to get sane looking condensed qmake output with only the
plain and the /raw property variants, the /get and /src variants must be
lacking the sysroot, which is profoundly useless in the case of an
installed prefix build with sysroot and without extprefix.
so to get actually useful paths, we just drop Raw from the fallback
chain. qmake will be fixed later to actually conform with this much
saner interpretation.
amends 61419e7bf.
Change-Id: I76fced03c5774ad581df2bf6ccc92a908fa243ca
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The FlatModel is essentially a proxy model keeping expansion and
filter state per ProjectTree(View). Using a Utils::TreeModel makes
it fast enough to allow recreation of the proxy structure on
structural changes simplifying the parent/child logic significantly.
The {Session,Project,Folder,File}Node hierarchy still is still primary
information and shared by all views.
Change-Id: Ic08180a19bda37908280ff30e0737d188ed93e92
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
It is advantageous to mark move assignments noexcept. Some implementations
are already implementing it and with C++ 17 it will be standard. So we take
advantage of it and make it conditionally.
Change-Id: I7c6d77d09a02639096ce0fb43733c1fbf190c7c4
Reviewed-by: hjk <hjk@qt.io>
The code path is never taken, size == 4 only happens in conjunction
with isSigned == false.
Task-number: QTCREATORBUG-17632
Change-Id: I3fd5a08fd5e414690bccf487f9d3cfb704ab5e47
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
Changing the default and not checking for valid.
We want to check for these hints even if there is no model node.
Change-Id: Ic19056fa4c24dbf5a687bcf3d288fc9ac48c908c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Using a static creation function makes tpyical usage simpler.
Change-Id: I0cf9347693633e8ad5fb98be5b0ec86c15c5a61f
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
The NodeHints are not supposed to be used directly.
QmlItemNode should provide the necessary convenience functions.
Change-Id: Ie19b3dcc0452af9f6962ea50988a2dd33bfbd410
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Adding a couple of more functions
Adding an optional second ModelNode as argument
Change-Id: Ib38ec14a17d6d9cc2a55d417c2d43d6d3c4d8a95
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Apparently there is a limit to about 100 characters or so on some
versions of Unix (e.g. Darwin), and there is also the tendency to
point TMPDIR into places very far from '/' (e.g. Darwin), which
can result in the local socket path getting trunkated.
So make sure to put the local socket into /tmp on Unix. That works
on Linux and on Darwin.
Change-Id: I40bfaf932c5013cf72addb5621360e97c9583daa
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Language ids are exposed via the MacroExpander to the user. So remove the
prefix and only leave the bare essential (C and Cxx), so that
%{Compiler::Executable:Cxx} continues to work.
Add code to transition kits and toolchains to the new Ids.
Change-Id: I012e5fd405b09032418c90d2517aede21cfa1b47
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Only call defaultDisplayName after the toolchain is set up completely.
This is necessary since the defaultDisplayName uses a lot of information
on the toolchain by default, which was not there yet.
Change-Id: I79c8791b6a7faf3d5b72840322849e4a9fc88a87
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
... for the C++ code model. In particular, a file ending in ".h" must
not be unconditionally classified as an "ambiguous header", but only if
it has the "hpp" tag.
Change-Id: I33a463de78525fb965e781b4b75d1e088c055c3d
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Parse issues can have multiple reasons (invalid kit, not a project file,
actual parse issue) and we should be able to tell them apart. With this
change, we can distinguish between the fallback project part and a
ambiguous project part.
Follow up changes will use this to display more accurate diagnostics.
Change-Id: Icc8767607cc17dc14d6227b07f34e81ba5525a96
Reviewed-by: David Schulz <david.schulz@qt.io>
QString::lastIndexOf can return a -1 if the pattern was not found. Using
a QString that was created by QString::setRawData with a size of -1 will
result in a crash.
Change-Id: Ie02645f00db7e7150424ca367095a7ebc9051578
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
the fallback chain is "Put" => Raw => Get => Src.
formerly, everything fell back on "Put", which is plain wrong.
Change-Id: I13967120e381ddbb03ed6a877c2960f8e5bc4f7d
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
the property has been added to qmake a while ago. catch up with it.
Change-Id: I8fae79c6d593ee201b44172d14189ec6502bc61c
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
only qmakes from qt4 don't have QT_HOST_* properties. and as they don't
have _any_ of them, the fallback can be simplified.
Change-Id: Id2ccbc7c01a56b894841980b0bc45bd84d160c54
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
... instead of peeking into versionInfo().
in fact, make versionInfo() private, to avoid subsequent deterioration
as happened before (after 5e596e89d).
some other functions that use it in its interface also become private.
this fixes several breakages related to working with non-installed
prefix builds of qt.
Change-Id: Ib67de79323c9e38f3de48a09854b155de9eef5b2
Reviewed-by: James McDonnell <jmcdonnell@blackberry.com>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
- no behavior change
- use nullptr instead of 0
- use new connect syntax and use a lambda to react on zoomLevelChanged
- removing unused method adjustStatesForModelNodes
Change-Id: I6a289e6771765112b7ac9c292ce3c2073a22829a
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
- it makes more clrear that we use a here QTabWidget
Change-Id: I03d1b7572b73570aa07e002d8b2cd8099b086c0d
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This conceptually reverts part of a61b6dfc.
Task-number: QTCREATORBUG-17594
Change-Id: I9ff72a027838a20039f217ed0d669b6c45bc2acf
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
This allows plugins like Beautifier to interact with the document before
it's saved.
Change-Id: I74f9735214c0fa115635b1809dc467036170ae75
Reviewed-by: hjk <hjk@qt.io>
