feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity
70,032 Commits 108 Branches 368 Tags
d735d3238f4dc97f2858b799fa79b9ee66f4219d
Commit Graph

8 Commits

Author SHA1 Message Date
Christian Kandeler
014a57c764 Utils::Environment: Fix NameValueDictionary::diff() 
We missed the case where only the enabled/disabled status was different.

Change-Id: Ic23e15f6843015feff2242cb67444dfa17cc5f2d
Reviewed-by: hjk <hjk@qt.io>
 2020-07-20 08:34:27 +00:00
Christian Kandeler
567a0db6dd Utils::Environment: Consider target OS type when sorting 
That is, use case-insensitive sorting on Windows, so that e.g. "Path"
will not appear after "PROCESSOR_REVISION".

Fixes: QTCREATORBUG-22786
Change-Id: I42d469b6079037d1062dbd5b273f5aa8ade25e79
Reviewed-by: hjk <hjk@qt.io>
 2019-08-22 10:29:22 +00:00
Christian Kandeler
37a2bbe14e Utils::Environment: Remove another set of duplicate functions 
More clean-up after 4bae5de36b.

Change-Id: Ia60cb868c464627b42a94d502d301b175449aa17
Reviewed-by: hjk <hjk@qt.io>
 2019-08-19 13:11:01 +00:00
Christian Kandeler
83355540bf Utils::NameValueDictionary: Use the right path list separator 
The environment is not necessarily for the host OS.

Change-Id: Ib0b0d3b8447fbb83c3860fb941b5d2445b8585d0
Reviewed-by: hjk <hjk@qt.io>
 2019-07-30 11:44:27 +00:00
Christian Kandeler
6387be6f64 Utils: Fix invalid iterator access in NameValueDictionary 
Introduced by over-eager code optimization in 4d71c0f13e.

Fixes: QTCREATORBUG-22783
Change-Id: I2706061f59f5070f2bfa5ac61953b908527065ed
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
 2019-07-30 11:43:50 +00:00
Christian Kandeler
4d71c0f13e Let users disable environment entries 
It's helpful to be able to temporarily disable environment variables, as
opposed to having to remove (and then re-add) them entirely.

Fixes: QTCREATORBUG-20984
Change-Id: Ib0d287035b9357507c4c19faaf3a1517382506b5
Reviewed-by: hjk <hjk@qt.io>
 2019-07-22 14:31:01 +00:00
Christian Kandeler
375e4dee2b Utils: Remove NameValueDictionary::expandVariables() 
These functions were inadvertently copied from the Environment class in
4bae5de36b.

Change-Id: Iede8d4b43bd97e8d6d3a0641bd3224e5829fe4b0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2019-07-15 13:58:26 +00:00
Marco Bubke
4bae5de36b Enable macro editing for the Clang indexer 
Refactor much of the code from Environment* classes to NameValue* classes
to share it with the preprocessor macro settings.

Change-Id: Ica4ee817aa338230c422b30d91240d266248d226
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
 2019-06-13 16:51:48 +00:00