Commit Graph

86167 Commits

Author SHA1 Message Date
Marcus Tillmanns
fcb752ff9c Utils: Add async methods to CheckableMessageBox
Change-Id: I296cb34453f5c12f712afedfe35b8962be8d7eec
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-09 12:59:20 +00:00
Leena Miettinen
c01129828f Doc: Split up "Refactoring" and "Applying Refactoring Actions"
Replace "refactoring actions" with "quick fixes", as they are
called that in the UI.

Task-number: QTCREATORBUG-29361
Change-Id: I6952bb1b222c340a6bccb175733c611907885a47
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-09 12:54:34 +00:00
hjk
cca5f07d35 GlslEditor: Move some class definitions to .cpp
Also, de-Q_OBJECT-ify GlslHighlighter and a bit of code cosmetics.

Change-Id: I17469acc950fc77055f68918b1362f01e8a8c8a3
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-09 12:41:06 +00:00
Marcus Tillmanns
060d4faed7 Terminal: Fix nullopt access
Fixes: QTCREATORBUG-30144
Change-Id: I9479d4cbfd8f930f405409c1c3f5252d23cca2da
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-09 12:02:52 +00:00
Marcus Tillmanns
99078778cc Terminal: Fix selection warning
When quickly selection text via double-clicking and moving the mouse to the left
it is possible that a selection is created where the start == end.
This was incorrectly reported as a warning.

Task-number: QTCREATORBUG-30144
Change-Id: I37b22f4ee725e5085ce0090c123ccfd9980b8a59
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-09 12:02:43 +00:00
Leena Miettinen
32e6f73119 Doc: Split "Completing Code" into several topics
Task-number: QTCREATORBUG-29361
Change-Id: Icbface3923c3d56ed54d53dc1e614f02269c30b2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-09 11:48:09 +00:00
hjk
a0ea8d4283 Appman: Add a appmanagertr.h
To be used as Tr::tr()

Change-Id: I473a44e70cbe745a4d60ee750ebcf87b5051f4ee
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-09 11:42:26 +00:00
hjk
7942c36ace Debugger: Fix passing of solib search path
Amends 92f7da917e.

Also, set it in all branches, not just remote execution, even if this
is the primary and currently actively used way.

Change-Id: I35149bd29b49dab419f83ec0cb424ae9b23827ed
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-09 11:42:10 +00:00
Eike Ziller
07a0ced947 TreeModel: Remove unused function overload
9124833a63 introduced an optional
parameter to removeChildren to suppress signal emitting, and
a61f9162f1 reimplemented that in a ABI
compatible way with a new removeChildrenSilently method instead.

The code now uses removeChildrenSilently, so the parameter to
removeChildren is no longer needed.

Change-Id: I8411d80f90e83b8746c2553dddb41c3f40a2bfc7
Reviewed-by: David Faure <david.faure@kdab.com>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-09 11:14:26 +00:00
Jarek Kobus
33ef73daf9 QtVersionManager: Make qtVersionsChanged args default
Change-Id: Ifb420ebdeefe18114f82c48c2c4c49d808caef0c
Reviewed-by: hjk <hjk@qt.io>
2024-01-09 10:57:34 +00:00
Jarek Kobus
1c8e88651c Squish: Avoid using keys()
Instead, iterate directly over the container.

Change-Id: I3fd55988fd3351f738e07c3b0611872279d929b4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-09 10:44:04 +00:00
Alessandro Portale
c4e938b407 Android: Resuscitate the "Configure Android options" InfoBar entry
The restoring of Kits was moved to a later stage of the startup
sequence. That is too late to connect to ICore::coreOpened.

This change calls askUserAboutAndroidSetup directly instead of via
connection.

Fixes: QTCREATORBUG-30131
Change-Id: I9b33df42177de05f2f9132ff3126fe03ffb8df20
Reviewed-by: hjk <hjk@qt.io>
2024-01-09 10:33:48 +00:00
Christian Stenger
d358589004 LSP: Fix building with Qt less than 6.4
Change-Id: I25f8be3a256328443dd42d72d05ce5b6b717bded
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-09 09:35:38 +00:00
Jarek Kobus
7b32c47494 QMakeProjectManager: Avoid using keys()
Instead, iterate directly over the container.

Change-Id: I589e87b0ed86be778aec7679bedab28d709a7697
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-09 09:34:07 +00:00
Jarek Kobus
2d422e33f0 Dap: Avoid using keys()
Instead, iterate directly over the container.

Change-Id: I417b413b06211428ab83d695f30cd5b2b4428a4b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2024-01-09 09:33:52 +00:00
Leena Miettinen
0df0a756f8 Doc: Turn "Editing Markdown Files" into a how-to topic
Task-number: QTCREATORBUG-29361
Change-Id: I6414bc1593220684a27234ec705d1b948de0e6c8
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-09 08:37:34 +00:00
Leena Miettinen
77ad9a60da Doc: Split "Specifying Text Editor Settings"
- Move info into "Font & Colors" and "Behavior" reference topics
- Turn the step list into the "Change editor colors" how-to topic
- Fix the "Font & Colors" tab name in several places

Task-number: QTCREATORBUG-29361
Change-Id: I1495295764fdcaed346891e93880a78ab7ce655d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-09 08:37:16 +00:00
Ali Kianian
63f8ecd003 QmlDesigner: Read DataStore.qml before writing properties
The properties of DataStore.qml are read, So the property-name for
a collection name will not be changed if it's not like the
Collection-name.
* Unique names will be created only when a user adds a collection.
* Renaming a collection shouldn't affect the related property-name
of DataStore.

Fixes: QDS-11540
Change-Id: I797a29c116051f79cfa6680360e5b086154a1df6
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2024-01-09 08:32:08 +00:00
Jarek Kobus
6c8ef7153c CorePlugin: Avoid using keys()
Instead, iterate directly over the container.

Change-Id: I508126a6afc8f4354bc7810e09f57866d1d1d2ab
Reviewed-by: hjk <hjk@qt.io>
2024-01-09 08:28:15 +00:00
Jarek Kobus
1e7970ff0b Git: Avoid using keys()
Instead, iterate directly over the container.

Change-Id: I56242c5655977d199fa3d3cb2ed696a0aefbcaaf
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-09 07:40:04 +00:00
Dominik Holland
e33d6fe5dc CMake: Expose information about Appman packages as Project extraData
Change-Id: I54c449f5bc7211271cecbef05045dd1490066bd6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2024-01-08 15:38:12 +00:00
Thomas Hartmann
6fcb853b19 QmlDesigner: Add QTC_ASSERTS
This can prevent crashes, but is unexpected behaivour.

Change-Id: Ie0944652c230a25e18f5d740cf134bc3ef7e2f2f
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2024-01-08 15:35:18 +00:00
Leena Miettinen
f0fefbef06 Doc: Split up the To-Do Entries topic
Task-number: QTCREATORBUG-29361
Change-Id: I4de61d64eb1001be4c6cae917cb187e919d31e65
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-08 15:32:55 +00:00
Leena Miettinen
b0b58d6711 Doc: Split up "Using Clang Tools"
Task-number: QTCREATORBUG-29361
Change-Id: If33dbd417575b584836927ff866e2cd1ec20ba70
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-08 15:32:40 +00:00
hjk
e65dc8007b CMake: Remove ActionBuilder::setCommandDescription() calls
... where the default implementation via stripAccellerator(action()->text())
would yield the same result.

Change-Id: Ie921863d472e0592a8c97830d67873ccfb1b57da
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-08 15:18:18 +00:00
The Qt Project
9ff7ea3980 Merge "Merge remote-tracking branch 'origin/12.0'" 2024-01-08 15:14:50 +00:00
hjk
c56bd22afd Utils: Introduce a FilePath::chopped() convenience function
Change-Id: I5fd813af83d58e62e026b3764d3d4378429c2162
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Dominik Holland <dominik.holland@qt.io>
2024-01-08 15:07:19 +00:00
Eike Ziller
60d1838220 FancyMainWindow: Remove unused private member
Change-Id: I60b348e0712fc0e4443dc396b1656c31889d4f6b
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-01-08 15:03:56 +00:00
Eike Ziller
8e4b5e1109 FancyMainWindow: Restore dock sizes when hiding/showing areas
Since we cannot make multiple dock widgets invivsible and visible at
once, the individual setVisible calls sometimes mess up the relative
dock widget sizes. That seems to also depend on which dock widgets take
part in that process. For example, when putting the Breakpoints view
together with other views into the right dock area in Debug mode, hiding
and showing that area would give the Breakpoints view more size than
before (similar with Threads and Stack views).

Remember the dock widget sizes and explicitly restore them when re-
showing an area.

Change-Id: I3868549ac7362a67f47fcf59b8fc3025befc86d2
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-08 15:03:48 +00:00
hjk
8e653c60d6 ProjectExplorer: Don't burn step id into BuildStepFactory::m_creator
This can be re-used in a (augmented) copy of the factory via
BuildStepFactory::cloneStepCreator with the possibility to use
a new step id in the new factory. In that case the new factory
should create steps with the new id.

Change-Id: I661537408e32fdeda9c45bde1abb54d32b9cbac6
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-08 14:53:11 +00:00
Jarek Kobus
0c4701e45d CompilerExplorer: Avoid using keys()
Instead, iterate directly over the container.

Change-Id: I6a3cb7d623e083663a11389f15b8d51599f338a3
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-01-08 14:36:55 +00:00
Christian Stenger
e901167952 Utils: Tweak FilePath device handling
This allows using file scheme in certain contexts.
E.g. starting Qt Creator with

 qtcreator file:///tmp/dummy.txt:10

did not work before while just using the scheme-less
absolute path did.

Task-number: QTCREATORBUG-30143
Change-Id: I8f2b728e733792eb92295bff60b27aecb4b3b8ed
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-01-08 14:27:41 +00:00
hjk
58396a5da1 Terminal: Use new ActionBuilder syntax
Change-Id: I1d739ca80f41073a55755816468c47f743838f81
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-01-08 14:19:10 +00:00
Henning Gruendl
009b664b7b QmlDesigner: Avoid ScrollView flick deceleration
Slow down the deceleration of the HelperWidgets.ScrollView by setting
flickDeceleration to a high value.

Change-Id: Ib001968a545984d570f5ac1d9f242d5071bee867
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2024-01-08 14:11:29 +00:00
Eike Ziller
cf63b1884e Merge remote-tracking branch 'origin/12.0'
Conflicts:
	src/libs/utils/treemodel.cpp
	src/libs/utils/treemodel.h

Change-Id: I9c5e8ef77905745c201cfc647218c9e747d268d6
2024-01-08 14:56:54 +01:00
Artem Sokolovskii
f2cb979aa3 ClangFormat: Rename override checkbox
It improves the UX design of CodeStyle page.

Change-Id: I4458896d6787df462de18025d292bdb481d03c89
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-08 13:50:38 +00:00
hjk
2c8f15ba6c Core: Use ActionBuilder in ExternalToolManager
Change-Id: Id92e0d8788aabbe9fe7cfb93680835a2c3f55b99
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-08 13:36:11 +00:00
Leena Miettinen
4d91473c69 Doc: Create a group for supported platforms in Reference
Task-number: QTCREATORBUG-29361
Change-Id: I11f84b97e482c75c157ccec827f5214a9e8d7a7d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-08 13:27:48 +00:00
David Faure
a61f9162f1 Fix TreeModel emitting nested QAbstractItemModel signals
This led to an assert in QSFPM because it got confused by the
nested reset signals.

Detected by adding
new QAbstractItemModelTester(this,
QAbstractItemModelTester::FailureReportingMode::Fatal);
to the OutlineModel constructor, and just opening QtCreator on a small
qmake-based project.

Fixes: QTCREATORBUG-30035
Change-Id: I41dbc81b5a2275521ece6b865115e1428e07ecf7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
(cherry picked from commit 9124833a63)
Reviewed-by: David Faure <david.faure@kdab.com>
2024-01-08 12:50:17 +00:00
David Schulz
419eae839a TextEditor: improve line column button tooltip
Automatically hide the tooltip of the line column button in the editor
toolbar when the cursor leaves the widget.

Change-Id: Ia17f40029d0821584c8a804b44431a5d7e639066
Reviewed-by: hjk <hjk@qt.io>
2024-01-08 12:37:21 +00:00
Leena Miettinen
ab79d1f970 Doc: Split up "Parsing C++ Files with the Clang Code Model"
Turn "Use compilation databases" into a separate topic.

Task-number: QTCREATORBUG-29361
Change-Id: I022dcd1e0f59293be42b0f953084c63349d5600c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-08 12:09:04 +00:00
hjk
e982712ab0 PerfProfiler: Use ActionBuilder to create menu actions
Change-Id: Ice1775567ed15aa577e3ea7fe98ade65508b2486
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-08 11:23:32 +00:00
Eike Ziller
9954a285f2 Doc: Fix insource build
When implementing acknowledgments via the generated attributions file,
the complete `<qtc_build>/doc/` directory was added as a source
directory for qdoc. For insource builds the build directory is the same
as the source directory, so qdoc would suddenly include all
documentation from `<qtc_source>/doc/`, which mixes Design Studio and Qt
Creator documentation.

Move the generated attributions file into a subdirectory, and only add
that subdirectory. Also fix that attributions were not generated at all
anymore after trying to fix issues when qdoc is missing.

Amends 2ce9f9d97d and
13b48144a6

Change-Id: I689827dabca37c81d4351dec04f23f46503429f6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
2024-01-08 11:18:53 +00:00
Christian Stenger
f663f22fa0 ExtensionManager: Minor fixes
* re-order some includes
* avoid using *tr.h inside header
* typo

Change-Id: Iba8d46384410ff06b184f55d66c4e7afca4ab666
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-08 11:08:32 +00:00
Jarek Kobus
75e8d4767b Autotest: Avoid using keys()
Instead, iterate directly over the container.

Change-Id: I4a29d1e81f2cbb01f2c06bed4035cf45e51b9dd7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-08 10:53:12 +00:00
David Schulz
4f857711c2 Python: install lsp into tempdir for remote interpreters
Change-Id: I4b0b1a47c73742cc14f68d80b9116fcd51224bd1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-08 10:42:48 +00:00
hjk
7a0cae607e Core: Move details of shortcutsettings implementation to .cpp
Change-Id: I2ea2626142ad2e94d30c2dd88ef5a3a1aa06389e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-08 10:37:12 +00:00
Mathias Hasselmann
a213ce3875 TextEditor: Repair insertExtraToolBarWidget()
New extra widgets for the right side were wrongly inserted between the
buttons for line-ending text-encoding.

Task-number: QTCREATORBUG-30166
Change-Id: I0f55c44344f9586e6aa97da20f5e25c28adf964c
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-08 10:21:13 +00:00
hjk
f869b00163 Core: Use ActionBuilder for Expand/Collapse All in Search window
Change-Id: Iee86231107171cf2e64b3b3b934bc0dfd4390354
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-08 10:04:57 +00:00
hjk
fcffb4eba7 Core: Use ActionBuilder for Save All
Change-Id: Id3f288698d74997023d66f587e62b409497d7230
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-08 10:04:42 +00:00