Commit Graph

86167 Commits

Author SHA1 Message Date
hjk
d3b6140bce Todo: Remove Q_OBJECT and unused signal from TodoItemsProvider
Change-Id: Ideea1db5b58144b8038324e38b8ff066f729bc07
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-30 17:16:46 +00:00
hjk
2aa6eebf09 Todo: Rename todoprojectsettingswidget.{h,cpp} to todoprojectpanel.{h,cpp}
Change-Id: I6813321e85ab3f68cfd6503880f6cb0541f82fd4
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-30 17:16:39 +00:00
hjk
d769a811f4 Todo: Simplify TodoProjectPanelFactory setup
... and prepare renaming of the file pair.

Change-Id: I1024af6093502fa482ad1e266f3eb2cf4eed09fd
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-30 17:16:33 +00:00
hjk
e25b531b54 Todo: Remove plugin pimpl
Not needed anymore

Change-Id: Ia8f0d39a487b0defce81b18b67e0ee5115b71b90
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-30 17:11:13 +00:00
hjk
cfc4d96483 Todo: Simplify settings construction
The unusual callback is not needed anymore as the caller side can
access the globals directly now.

Change-Id: Ie3a2cb0c83cf9c773d8c042c222ec32903fbcc9f
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-30 17:11:07 +00:00
hjk
d4e44b920d Todo: Use free function to setup TodoOutputPane
Change-Id: Ifed2db897d80d1d95fd1cf2a67cf8531b9153bdc
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-30 17:06:16 +00:00
Jarek Kobus
8a94c7c758 Process: Fix runBlockingSignal() flakiness
It may happen that textOnStandardOutput() sends multi lines,
even when they were sent by two separate std::cout with std::endl.
Instead of checking whether the 2nd expected line starts with
the magic word, check whether the message contains it.

Limit timeouts so that the test should pass about 3 seconds faster.

Change-Id: Ie4e4df70b62854eb595d41272fe4fa9bdec606fc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-30 16:56:32 +00:00
Jarek Kobus
0df72f88c5 Process: Fix flushFinishedWhileWaitingForReadyRead() flakiness
The apparent reason for the flakiness was a time limit of the test.

Change-Id: Idddc8c161f9969522b2eed8317bbda4f59091dd9
Reviewed-by: hjk <hjk@qt.io>
2024-01-30 16:56:24 +00:00
Jarek Kobus
d6eec9ce2e ClangFormatWidget: Set the tooltip
Amends ac24b23ff8

Change-Id: I79ccca00b5b2c944979c255640809fdea7ba3eaa
Reviewed-by: hjk <hjk@qt.io>
2024-01-30 16:56:13 +00:00
hjk
4a5154a1a1 Todo: Use a free function to access the TodoItemsProvider
Change-Id: Ie91df09583b272b0fff41b2b3ae36b4e21f44e3d
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-30 16:46:55 +00:00
hjk
4026e55d3b Todo: Use a free function to access the global settings instance
... and avoid passing handles through the layers.

Change-Id: Idfbb84d1d9b696df80542cd58743ced7339bbd58
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-30 16:46:50 +00:00
Tim Jenssen
0bcc42f913 QmlDesigner: fix Nanotrace is not exported to tests
Change-Id: I375e29040667aedb6d36bf778d7f19c003f64681
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2024-01-30 16:12:46 +00:00
Dominik Holland
998ca3b598 AppMan: Remove TargetInformation copy constructor
Change-Id: I122d948dd24e6c7408a4a383f7ccead2968fb07c
Reviewed-by: hjk <hjk@qt.io>
2024-01-30 16:01:38 +00:00
hjk
3569dbd42e Meson: Fix crash
Amends 4cbdd443fe. The captured pointer died too early.

Change-Id: I82433bee4ee41d913e1cf47db5c9b9446f501520
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-30 15:43:15 +00:00
Jarek Kobus
208d57e943 LanguageClient: Introduce updateCapabilities() helper
Avoid using QHash::keys().
Iterate over m_openedDocument just once and update
different capabilities in each iteration.

Change-Id: Iec469b69bb7fbdd52dc176bb6d91dd4feb2357b6
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-30 14:55:20 +00:00
Miikka Heikkinen
1cf5b3bf57 QmlDesigner: Change 3D project template to use PrincipledMaterial
Change-Id: Ib7c13e7ca068024830cdf0fd0b1aea91df5b4990
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-01-30 14:46:44 +00:00
David Schulz
75f0b95397 LanguageClient: Offer to install the bash language server
... after opening a document with the x-shelscript mime type.

Change-Id: Ib98167fb4bbae144c359216f45aa22831079a12f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-30 14:35:50 +00:00
Thomas Hartmann
a72ebf1579 QmlDesigner: Add helpers for experimental features
Change-Id: Iff5849c592999f1e922b23ad845d659886b7307b
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2024-01-30 14:17:44 +00:00
hjk
3fad1a21e5 CMake: Use a setup function for kit aspects
Some connects() in the CMakeToolManager ctor triggered accesses
to the s_instance there before it was assigned. Solve the issue
by moving the triggering code (CMakeKitAspect setup) out of the
class.

Change-Id: Ied0fc6b0b0eb87c29503ecb20e337289edecd203
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-30 14:07:38 +00:00
Marcus Tillmanns
2f13651344 Debugger: Handle exception during output read
Fixes: QTCREATORBUG-30267
Change-Id: Iac45a532fc369ad410e78bb8c0516b97858b7af1
Reviewed-by: hjk <hjk@qt.io>
2024-01-30 14:00:21 +00:00
Marcus Tillmanns
9f7d9b9bf8 Debugger: Fix possible access violation
If the DebuggerPane is closed while the menu is open / inside exec()
the final delete can result in an access violation.

Change-Id: Ie2694e209018f5a15d7fca203809b879fe184d3f
Reviewed-by: hjk <hjk@qt.io>
2024-01-30 14:00:09 +00:00
hjk
4cbdd443fe Meson: Use ActionBuilder to set up actions
Change-Id: If84acd6cf89d9375714de703c2aed889bc2cb75b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-30 13:56:03 +00:00
Miikka Heikkinen
e617fc96db EffectComposer: Fix generated code for mipmap effects
Mipmap effects need layer.smooth and layer.mipmap to work correctly.

Fixes: QDS-11793
Change-Id: I8f04ca9f144f51d0032d995c2bafdcb0c95ad73d
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-01-30 13:49:21 +00:00
Jarek Kobus
4cc80b6cd0 Axivion: Use Core namespace in axivionplugin.cpp
Change-Id: I4f4fb678f03b486aa2c3d50c42625510e3a8c783
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-30 13:48:04 +00:00
Miikka Heikkinen
3ec2cd1f0b QmlDesigner: Restart puppet asynchronously when imports change
If imports are changed in transaction, the puppet restart should be
done after the transaction is completed, or the new types won't work
correctly until puppet is reset again.

Task-number: QDS-11811
Change-Id: Ie60945fbe9e7090b7fc27b55e1b6d23d5aa04a55
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2024-01-30 13:46:22 +00:00
Mahmoud Badri
217ff89827 EffectComposer: Disable effect composer on MCU projects
Fixes: QDS-11867
Change-Id: I2b405faf68623272fd674662b97cb3f0e50170e4
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-01-30 13:12:17 +00:00
Ali Kianian
58dd1405fe QmlDesigner: Use Int and Real types instead of Number in Model Editor
* If a column has both integer and real numbers, it will be considered
as a real type.
* The edit delegate for integer has no decimals, and it's limited to
integer range.
* Data types are ordered for the column editor dialog

Task-number: QDS-11675
Change-Id: I43364e8dddd3fc9c336723f4db337088ffdd97ed
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-01-30 12:38:50 +00:00
Thomas Hartmann
6c026c703f QmlDesigner: Add UI setting for experimental features
Change-Id: I58a7c2affad4f7762989b8009dfa90f78479fa6f
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2024-01-30 12:22:08 +00:00
Miikka Heikkinen
4704f1628c QmlDesigner: Add extended View3D component
The source template for this component uses ExtendedSceneEnvironment
instead of regular SceneEnvironment.

Task-number: QDS-11811
Change-Id: Id310f74b619d502e29d580b08c38e7bda70a4361
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-01-30 11:59:53 +00:00
Shrief Gabr
1a6c00865a QmlDesigner: Add vertical & horizontal scrollbars to model editor
Task-number: QDS-11664
Change-Id: Iac6c5340118f73c1bc3d45a15e0cd76b17d56877
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2024-01-30 10:53:27 +00:00
Leena Miettinen
76dcc5463a Doc: Turn Editing MIME Types into a how-to topic
Add subheadings and move content around.

Task-number: QTCREATORBUG-29361
Change-Id: I4c1d8c8c7065a3f306e2a4a341bc546c62828903
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-30 10:44:39 +00:00
Eike Ziller
2898e09bb4 iOS: Move app URL gathering from devicectl to a function
And add a test to document what we expect from devicectl.

Change-Id: I2f5312ebadef60239b77308acb7114f1d55143b4
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-30 10:06:29 +00:00
hjk
759ea7695f CMakeProjectManager: Fix action parameter order
Amends 8e071f6bd0.

Change-Id: Id8ef61f20891eac9b8a751aa8131ce6a9e83fadb
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-30 09:55:48 +00:00
Christian Kandeler
b2bf733783 CppEditor: Fix & simplify "extract function" quickfix
No need to fiddle with whitespace manually (and make potentially invalid
assumptions about previously inserted code).
RefactoringFile takes care of formatting these days.

Change-Id: I6e566e6e4cd2a90b73c29365483b92f94e8c58ce
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-30 09:17:49 +00:00
Christian Kandeler
02de46110e TextEditor: Insert clang-format removal blocker at the end
... of an "empty" line.
Otherwise previous leading whitespace will survive re-formatting.
Also reset the formatting cursors when setting a new change set.

Fixes: QTCREATORBUG-30244
Change-Id: I3fb8668b56c3823972d4acda8da9657fb0bbfe41
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-30 09:17:38 +00:00
Jarek Kobus
43221e4953 Qmljs: Replace QMap with QHash
The key is a pointer type, so use QHash. Avoid double lookup.

Change-Id: I6c1c8e11b89256b550cda96b9128f8329470c7cf
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-01-30 09:03:59 +00:00
David Schulz
f8e2b3535b LanguageClient: prepare supporting more npm servers
Change-Id: Ie2f5b9c2850f7487378a7822d347a9cf8624017e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-30 08:53:57 +00:00
Eike Ziller
15baf18911 iOS: Move info parsing from devicectl to a function
And add a test to document what we expect from devicectl.

Change-Id: I395171bb5316c21b461a01dce5c9ec87d81fb0c4
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-30 08:38:03 +00:00
hjk
0e531fa453 Meson: Use setup function for MesonActionsManager
Remove the now-empty MesonProjectPluginPrivate.

Change-Id: I58d9d9338a2ad96d574daa407e35cf8f26843719
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-30 08:33:49 +00:00
David Schulz
8b78eb2d22 CMake: report project issues if the CMakeKitAspect is irrelevant
This disables python kits when opening cmake projects in the target
setup page.

Change-Id: I205edd865c0eb6c499368f1d5e9f2c4b4bc8237a
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-30 08:27:16 +00:00
The Qt Project
c0a008957d Merge "Merge remote-tracking branch 'origin/12.0'" 2024-01-30 08:22:30 +00:00
Eike Ziller
30d048a256 Merge remote-tracking branch 'origin/12.0'
Conflicts:
	src/plugins/cppeditor/cppfilesettingspage.cpp
	src/plugins/haskell/haskellplugin.h

Change-Id: I880693c2e4986853b7aa600a5b7d6c09ad14634e
2024-01-30 09:19:06 +01:00
hjk
8adbb1ddab Debugger: Allow debugging of custom executables again
Amends c81efc39c.

Change-Id: I5f816371d8f08ffb127ba39891b2c5b8f7df7f20
Reviewed-by: Dominik Holland <dominik.holland@qt.io>
2024-01-30 08:16:45 +00:00
hjk
0ef72f3c6c Meson: Use setup functions for more plugin items
Change-Id: Ibbb2526d1db980389487e599ddf53e4785d97b5e
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-30 08:01:16 +00:00
hjk
9a44a543a5 Meson: Use setup functions for a few plugin items
Change-Id: I849698315cd8c03ab44317d90dd3754dcfe46146
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-30 08:00:30 +00:00
Eike Ziller
a9a5972a9f iOS: Add some autotests for devicectl error parsing
Change-Id: I641f0c86b30a11ca6321db88afbf2969b4863972
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-30 07:56:31 +00:00
Christian Stenger
7e8aac5f3c Axivion: Take versions into account
Change-Id: I7011549f8ce7d0017f156529792e91292183560f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-30 07:03:18 +00:00
Christian Stenger
2bc0572553 Debugger: Display length of quoted values
Reverts 6515f935d6 as this breaks
the dumper tests and moves the handling from the protocol to
the item, so this now only happens for the gui.

Change-Id: Ia15d5ead5c549585f4e90cc46d629961ea7d5974
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-30 07:03:07 +00:00
Orgad Shaneh
cf1a929916 CppEditor: Fix compilation without tests
Change-Id: I9a621871d9235652618fa2c295db7e39ca6118f1
Reviewed-by: hjk <hjk@qt.io>
2024-01-30 06:59:34 +00:00
hjk
8e071f6bd0 CMake: Use ActionBuilder for buildTargetContextAction
And remove now-empty CMakeProjectPluginPrivate class.

Change-Id: I2b0b28cddb84639a62f90ee1776674cc7808480f
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-29 17:19:10 +00:00