Commit Graph

86167 Commits

Author SHA1 Message Date
Christian Kandeler
78b9edd251 TextEditor: Rename class RefactoringChanges
... and remove outdated comment.

Change-Id: I6dcd0a38608192ccdd6734affd33e170d39e8299
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-20 14:37:19 +00:00
Christian Kandeler
e7073421cc TextEditor: Remove RefactoringChanges::createFile()
Dissolve into only caller.

Change-Id: I2eaac8bf31c0ecd2dfb863b7fae79af557ccad95
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-20 14:35:51 +00:00
hjk
fabef397f9 Haskell: Move plugin class definition to .cpp
... and simplify setup a bit.

Change-Id: Ic5a36c35c083232cb8df3c7a06aaac46bcef55e0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-20 14:06:46 +00:00
hjk
18bbffddb4 Proparser: Silence compiler warning
/data/dev/creator/src/shared/proparser/proitems.cpp:226:17: warning: variable 'totalLength' set but not used [-Wunused-but-set-variable]
            int totalLength = sz - startIdx;

Change-Id: I64028926c5af69d2692c977d60c233b5404712ed
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-20 13:49:13 +00:00
Mahmoud Badri
e740bc076c EffectMaker: Load effect nodes from share folder
Change-Id: Ie7b1c95d6eb277c01310d9badc1b755e0517385c
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-11-20 13:46:04 +00:00
David Schulz
d81d41032a TextEditor: do not collapse doc comments in the beginning of a file
The auto fold license header functionality also automatically folds
documentation comments. Automatically collapsing documentation comments
is never correct in the first place so just skip the fold when encounter
a documentation marker in the first comment.

Fixes: QTCREATORBUG-29900
Change-Id: If0dd7842804f3ff0bcd725b54413e9568d5b5ab3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-11-20 13:39:30 +00:00
David Schulz
b451019be1 Android: enable "Toggle Comment Selection" shortcut in manifest editor
Fixes: QTCREATORBUG-29818
Change-Id: I8434ea99d8f5c5dc3c0436f5313d42084aca4152
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-11-20 13:27:13 +00:00
Christian Kandeler
f163a4f9a1 TextEditor: Move more code out of RefactoringChanges
The only callers are in RefactoringFile, so put the functions there.

Change-Id: I94141d759d32c20a334804e98dfeb262e10c5e11
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-20 11:56:47 +00:00
hjk
1dafa53b3b ProjectExplorer: Fix a warning
er/dependenciespanel.cpp:260:14: warning: private field 'm_project' is not used [-Wunused-private-field]
    Project *m_project;
             ^

Amends 0de9d31e84.

Take the opportunity to make the model a proper member to save an
indirection.

Change-Id: I10b14d54571c6c3960b2ff74522afe2729930630
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-20 11:01:48 +00:00
hjk
01cecddce7 FakeVim: Fix warning about unused lambda capture
Change-Id: I136f52002e02611d41a309809408bcde57aceefe
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-20 10:22:59 +00:00
Christian Stenger
c5980a4872 CMakePM: Fix build
Avoid ambigous conversion, instead explicitly convert.

Change-Id: I1b62a8eb94cc2c353b33ec1a29a28385fdb92782
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-11-20 10:19:53 +00:00
Esa Törmänen
a3283587dd Doc: Update Creating UIs for MCUs page
Removed the references to 3D design tools (Blender, Maya) and 3D UI
design assets as the 3D view is not supported for developing MCU
projects.

Task-number: QDS-11231
Change-Id: Idfd2f2d5c513836aba802a7cfed8f8b66b3369f5
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-11-20 09:55:56 +00:00
Miikka Heikkinen
a2b195580b EffectMaker: Fix popup geometry
Effect Maker preview and node combo box popups will now stay within
the screen boundaries of the screen the parent combo box belongs to.

Fixes: QDS-10512
Change-Id: Ibbfb706499c4b17e27ff5ae471fef8bb9f7384cb
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-11-20 09:41:13 +00:00
Eike Ziller
458beb8582 QmlDesigner: Hot fix for settings crash
Change-Id: I05d27fb2dee65c50191e7dcd7c7bf8f195bb46e5
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-11-20 09:23:51 +00:00
The Qt Project
3e71f99dd6 Merge "Merge remote-tracking branch 'origin/12.0'" 2023-11-20 09:05:34 +00:00
Leena Miettinen
3f9f249c0d Doc: Add a readme.md for using recolordocsicons.py
In preparation of moving the instructions for taking screenshots
from the Extending Qt Creator Manual to a QUIP.

Change-Id: I034185e7ab4878cf36766db1e9a6b8de5d2b3fed
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-11-20 08:58:50 +00:00
Eike Ziller
1c4de485da Merge remote-tracking branch 'origin/12.0'
Change-Id: Ib09af70f157a6c7d6cbda4e3de678fd2bbceb229
2023-11-20 09:48:43 +01:00
Jarek Kobus
20d82c48b3 ScreenRecorder: Fix closing namespace comment
Change-Id: I078543dcf3e4ba005427988a0b74ee30ce751ee5
Reviewed-by: hjk <hjk@qt.io>
2023-11-20 08:27:53 +00:00
Jarek Kobus
9c5831dc80 TaskTree demo: Tweak the done result instead of nesting a Group
Tweak the return value of the TimeoutTask instead of nesting
a Group with conditional workflow policy.

Rename TaskWidget::isSuccess() into desiredResult().

Change-Id: I3d6f703427f13e8feb6d6db97c07b8b9f8b261a6
Reviewed-by: hjk <hjk@qt.io>
2023-11-20 08:27:17 +00:00
Jarek Kobus
39e39408b2 TaskTree: Get rid of StorageBase::isValid()
Not used and not needed.

Change-Id: I3ba4b86c57c1d3d6ecf5999e16d79142d50d8a07
Reviewed-by: hjk <hjk@qt.io>
2023-11-20 08:26:19 +00:00
Jarek Kobus
ce80a6dad5 TaskTree: Rename TreeStorage<> -> Storage<>
This addresses the 20th point in the master task below.

Task-number: QTCREATORBUG-28741
Change-Id: I696beda87430fbe637abba8054012fb77516e220
Reviewed-by: hjk <hjk@qt.io>
2023-11-20 08:25:50 +00:00
hjk
9800f1bdc4 Revert "ImageViewer: Fix build"
This reverts commit 9b429c7ebd.

There is a Q_OBJECT in line 12, the #include is needed.

Change-Id: Ia4d333b6419bb2bdcdcf124d22d0473f6fd91cb1
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-20 08:01:01 +00:00
Jarek Kobus
767bb30b11 TaskTree: Hide more internals inside StorageBase class
Rename storage internals.

This addresses the 20th point in the master task below.

Task-number: QTCREATORBUG-28741
Change-Id: I1ed42472060de6180d4665d6504598adb57828fe
Reviewed-by: hjk <hjk@qt.io>
2023-11-20 07:48:04 +00:00
Jarek Kobus
ced3052e7f TaskTree: Get rid of Storage subclass of GroupItem
Make the c'tor of the GroupItem taking the TreeStorageBase
public instead.

This addresses the 20th point in the master task below.

Task-number: QTCREATORBUG-28741
Change-Id: I78320ec24b4e4b915ab549135fb93b45c658b9f2
Reviewed-by: hjk <hjk@qt.io>
2023-11-20 07:47:54 +00:00
hjk
69aa92159c GitLab: Access GitlabParameter singleton more directly
Change-Id: Ib4d333b6419bb2bdcdcf124d22d0473f6fd91cb9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-20 07:28:11 +00:00
hjk
d9b8702d57 ImageViewer: Code cosmetics
Change-Id: I946d1f0ce9be10f1f31441ac7f0b7fa7216b70db
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-20 07:24:40 +00:00
hjk
11d5fbe04c ImageViewer: Move Viewer class definition to .cpp
And de-pimpl.

Change-Id: I2c4acc95a7d583b4bfbc98bee3c989425d9306c1
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-20 07:24:28 +00:00
hjk
8aa78b119a Fossil: Move plugin class definition to .cpp
And split out the tests into a separate class.

Change-Id: I908c4cec5d6a69850867cf2e51c050c8dd356a26
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-11-20 07:24:12 +00:00
Eike Ziller
fd256b57de German translation: IncrediBuild
Change-Id: I9b801fe83b681551b123ce167a34ec44249a8bd6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
2023-11-20 07:15:52 +00:00
hjk
d924d4e886 Fossil: Delay-create FossilClient
By three liens, the connect in the pluginprivate ctor
will create it.

Change-Id: I23c80884f293fae434de573b8684bde2c56bd45e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-11-20 07:13:39 +00:00
Eike Ziller
8116aaaab8 Fix missing wizard after loading CompilerExplorer without restart
Wizards should be reloaded after plugins are loaded. They might either
add wizard paths, or wizards that check for plugins might be loaded even
though they were not loaded before.
Emit PluginManager::pluginsChanged when plugins are loaded at runtime
too, and connect that to clearing the list of wizard factories.

Change-Id: I79e0fb4991074cba592296620f1758136d60b378
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-11-20 07:12:10 +00:00
Eike Ziller
b60fd77fc1 Fix clearing the list of wizard factories
Clearing the list of wizard factories did not result in updating the
available JSON wizards. The JSON wizard paths were scanned only once at
startup. Instead partially revert back to before
1cf6b031cf and let the JSON "factory
creator" parse the directories and return a list of wizard factories.

Change-Id: Ifc253479973be801c5323588800bb264610187b6
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-11-20 07:12:00 +00:00
Eike Ziller
4362318c14 WizardFactory: Early return in clearWizardFactories
Detect early if there is nothing to do

Change-Id: Ic2c27c2d265cbc245d383531ad7d844457ea8121
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-11-20 07:11:46 +00:00
hjk
34f374baec Todo: Move TodoPlugin class definition to .cpp
Change-Id: I5b82b14bf86655f0dab9379effb4ff156900b610
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-20 07:07:02 +00:00
Christian Stenger
9b429c7ebd ImageViewer: Fix build
Remove now superfluous moc include.

Change-Id: Id0d0a4110e4be9206bd09a4795ebc63b7b443221
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-20 06:37:50 +00:00
Jarek Kobus
c8541962a6 DeviceShell: Get rid of unused variable
Change-Id: I8f93364b347460b1daef1149d3ff5c28436b0754
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-20 06:31:25 +00:00
Cristian Adam
48a3a12b01 CMakePM: Add failure logging for add|rename|removeFiles
Task-number: QTCREATORBUG-29914
Change-Id: I404a3efb8cabafba6036eb1bc07d19f18af17cd8
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-11-17 21:09:31 +00:00
Alessandro Portale
8798ed1ace ProjectExplorer: Fix sorting of file names in subpaths in wizard summary
In the wizard summary page, on Windows, the sorting of files in sub
directories is not correct. The paths got converted to userOutput before
they were tested for '/' and then assigned to a FilePath (which caused a
QTC_CHEK warning in addition).

This is reproducible with the "QDS compatible" Qt Quick application
wizard.

Fixes: QTCREATORBUG-29921
Change-Id: I45b623409831b21467e33481dcc3ca557f0f9afc
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-11-17 20:08:38 +00:00
Henning Gruendl
5316586a0a QmlDesigner: Fix popover position
* Remove chevron

Change-Id: Icd27f26e75c09561b2ec5fb8cf1f80dad7dd5b86
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
2023-11-17 18:45:56 +00:00
Henning Gruendl
84cf414a1a QmlDesigner: Fix color editor details model
Task-number: QDS-11268
Change-Id: I043c5a4144778d29c54df9e448a86c855270f427
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-11-17 18:37:56 +00:00
Thomas Hartmann
48c1d9466c QmlDesigner: Use QML/Designer/UseExperimentalFeatures44 for EffectMaker
Change-Id: I233d1b39cc336beb18a837cbba26605528876e63
Reviewed-by: Amr Elsayed <amr.elsayed@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-11-17 18:09:56 +00:00
Thomas Hartmann
c09635e850 QmlDesigner: Use QML/Designer/UseExperimentalFeatures44 for ModelView
Change-Id: I4de7c2c0b64cbdda65d5258168b72fe13f6dbd07
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-11-17 18:09:34 +00:00
Jarek Kobus
9d44d1899d TaskTree: Fix Timeout activation
The activation of one timeout may cancel the other running
timeout. Don't remove all timeouts which are to be activated before
the activation loop. Remove and activate incrementally instead.

Change-Id: I6147fb63b6ef9d6ada034330d98d1c13419012b4
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-11-17 17:09:25 +00:00
Jarek Kobus
73bff6d497 TaskTree: Fix TimeoutTask ordering
Make ordering separate for each thread.
Add stress test for it.

Change-Id: Idb42ce2511b18c0e9dd4dcb216ca39b35b5c980e
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-11-17 17:09:19 +00:00
hjk
43f1281674 Qnx: Use new setup scheme for most factories
Change-Id: Ie6154d816fb9d77948d73416b43bb933a56f6bbb
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-17 17:08:35 +00:00
hjk
65dbc1eaf6 ImageViewer: Use new plugin setup system
Change-Id: Ie2178c6b38a0b122ab225bae30ea25e1c57b73ad
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-17 16:53:21 +00:00
hjk
3b05a6f58e FakeVim: Merge Plugin and PluginPrivate classes
There were different from the PluginPrivate-created-in-initialize
pattern anyway.

Change-Id: I690c9c0511203f3c4d6ec9eeca85c0a277330e2f
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-17 16:48:46 +00:00
hjk
bde92e035e FakeVim: Move plugin class definition to .cpp
Change-Id: Iac485bbd6cd00ddfae189a6f82c9f5f2c7e9aaf9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-17 16:47:38 +00:00
hjk
d1aaebc3b4 FakeVim: Move test declaration from plugin to separate object
Also ugly, but differently.

Change-Id: I832ac19c7d8a3457a40baaae60653a02a32dbd75
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-11-17 16:36:19 +00:00
Aleksei German
9a8fa56a66 QmlDesigner: Fix for Style ComboBox
Task-number: QDS-11257
Change-Id: Ie50b9f585914c8f6345d61a8e6c5347998b3fc63
Reviewed-by: Aleksei German <aleksei.german@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-11-17 15:10:18 +00:00