Commit Graph

86167 Commits

Author SHA1 Message Date
Artem Sokolovskii
9c4ba3ff21 QuickFix: Fix add definition for templated function
- Fix add definition for templated function in templated
class
- Fix "inline" placement for templated function

Fixes: QTCREATORBUG-29408
Change-Id: I15f7793c9ae1e49d8338c1120135ddd1afbca4ca
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-11-09 17:07:53 +00:00
hjk
ec99782105 Revert "ProjectExplorer: Use more Ids instead of Kit in KitModel"
This reverts commit 05e7308c08.

Currently kit cloning crashes, and the trivial fix loses re-foucssing
on the newly cloned kit.

Change-Id: Id34d4430f97ab5825d5203096fbd1551464f80cb
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-11-09 16:32:28 +00:00
Henning Gruendl
6b2963e678 QmlDesigner: Add color editor to StudioControls
* Add QML Window based popover to StudioControls
* Add color editor to StudioControls
* Move color editor modules to StudioControls
* Move IconIndicator to StudioControls
* Move ToolTipArea to StudioControls
* Add color backend to qmldesignerbase to allow control value binding
* Use popover in connections editor
* Add window manager to send focus changes to QML Windows
* Update ColorEditor UX
* Remove HelperWindow workaround for GradientPresetList (Qt 5 vs 6)
* Fix eye dropper for QWindow

Task-number: QDS-10926
Change-Id: Ia87b30543affde88faaef2ebdf120cb5d348c935
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-11-09 15:05:50 +00:00
Mahmoud Badri
44ce489ea3 EffectMaker: improve save dialog
Few fixes and tweaks

Change-Id: I4071b93a64f839c3f2e9ccdc8f648d907723610e
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Amr Elsayed <amr.elsayed@qt.io>
2023-11-09 14:35:52 +00:00
hjk
c26521aeb3 Core: Fix Action setters
In some cases the data needs to be forwarded to the command's action.

Change-Id: I3ae066cbac393d78808d697beb3df29cbdee3315
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-11-09 13:01:59 +00:00
Christian Kandeler
e3c1179abb CppEditor: Manually indent moved comments
Using the indenter yields unepected results in certain contexts.

Fixes: QTCREATORBUG-29786
Change-Id: Id15eff841d2aa54e7fff65c6bf728516e03f9fc6
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-11-09 12:51:10 +00:00
Olivier De Cannière
08546615f2 Qml Debugger: Do not focus the current frame when adding a watch
The other debuggers do not cause the view to jump to the current frame
when adding a watch. Make the Qml debugger also not do this.

This is done in a slightly hacky way by preventing the gotoLocation of
the next handleFrame call to be executed. Ideally, the logic to
retrieve the value of locals should be separated from the logic to jump
to a specific frame. Right now the jump is implicit when updating the
locals.

Fixes: QTCREATORBUG-29329
Change-Id: I4b8f5c99ae41c92c3394f86da481303d4765f897
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2023-11-09 12:24:52 +00:00
Eike Ziller
2f7bfd3ef8 TextEditorActionHandler: Reduce noise
By using namespace Core

Change-Id: I97f4f6c42d5e0e9487b174b6837dc4cbb3452f2b
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-09 12:10:33 +00:00
Christian Kandeler
09e495f01a ClangCodeModel: Fall back to built-in code model when following symbols
In normal interactive mode, users likely want fuzzy look-up, e.g. to a
non-matching overload if no exact match is present.

Fixes: QTCREATORBUG-29814
Change-Id: I55ca32c001e619d374cc015a7dd2f1564ed2a2c9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-09 11:50:22 +00:00
hjk
5334154ecb GenericProject: Use new Core::Action
Change-Id: I694b29565089baa14b316bca07a8ac29747ac32a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-11-09 11:33:59 +00:00
Yasser Grimes
8f57d1ec0e McuSupport: Add Shapes moudule include to qmlprojectexporter deploy step
Task-number: QDS-10814
Change-Id: I0453360a501a2cdb21522a6f257523899b36df95
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-11-09 10:14:40 +00:00
Alessandro Portale
fd1956a91c QmakeProjectManager: Remove unused functions
These project wizard related functions are unused remnants from when a
couple of wizards were still implemented in C++. The wizards have since
been reimplemented as .json wizards.

Change-Id: I4cef7ef26cb66e86ef968645c68f3234d4dc15b6
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-11-09 10:04:11 +00:00
Amr Essam
0cbda147a8 QmlDesigner: Export effect maker composition qep project into assets
Meanwhile, composition resources are not yet exported

Task-number: QDS-10500
Change-Id: I3687d1d62a64472c7ec84716c584dced5fbb6a85
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-11-09 10:02:19 +00:00
Shrief Gabr
a923d3ca4a QmlDesigner: Reset column data type when context menu is closed
Task-number: QDS-11101
Change-Id: I60c35ac01107c3ff79f2b637294997bfa62f4f5e
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-11-09 09:40:21 +00:00
The Qt Project
841d9d739e Merge "Merge remote-tracking branch 'origin/12.0' into qds/dev" into qds/dev 2023-11-09 09:24:26 +00:00
Henning Gruendl
b2c4dd6811 QmlDesigner: Remove vertical scroll bar gap
Since we have the transient scroll bars in place, we usually let them
overlap with the content as they will fade out when not in use.

Change-Id: I49c06468d467b7b1b3af954f3319b6bb0b36d324
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-11-09 09:08:14 +00:00
Henning Gruendl
17d386f25b QmlDesigner: Remove vertical scroll bar gap
Since we have the transient scroll bars in place, we usually let them
overlap with the content as they will fade out when not in use.

Change-Id: I686d7c374066063c7bce8eca35646d704c633e8f
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-11-09 09:08:09 +00:00
Thomas Hartmann
070022e9e2 TextEditor: Allow to programmatically highlight a block by cursor
This can be used in QmlDesigner to highlight the currently selected
QML object.

Change-Id: I9907d54f767c7d034739d4111a46cd994c961426
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-11-09 08:53:25 +00:00
Tim Jenßen
058fd820e5 Merge remote-tracking branch 'origin/12.0' into qds/dev
Change-Id: I1e38a9dc4402a4cf836c32a6b0e5f49a836574b7
2023-11-09 08:46:51 +00:00
Thomas Hartmann
ad49605ea9 QmlDesigner: Highlight selected node in code editor
We also highlight the drag target when using drag and drop.

Task-number: QDS-10869
Change-Id: Ic396848f93deaa3cce899c2cf431d5a7f5a940f5
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-11-09 08:46:33 +00:00
Leena Miettinen
266f9bc632 Doc: Turn "Specifying Environment Settings" into how-tos
Add a line drawing that describes the environment settings
hierarchy.

Task-number: QTCREATORBUG-29361
Change-Id: I7869797154c0e70263528a8635ea7f2dcee30f30
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-11-09 08:23:10 +00:00
hjk
792d88aa05 Core: Introduce Menu and Action classes
Idea is to have a bit more "object { propertySetter }" kind of pattern
for common cases and to couple actions and menus only via Ids, not
real objects.

In a LayoutBuilder context this might later look like

    Menu {
        id(BOOKMARKS_MENU),
        title(Tr::tr("&Bookmarks")),
        container(Core::Constants::M_TOOLS)
    }

in the end.

Overall line count increases but I claim it reduces complexity on the
user code side.

Change-Id: I166e0c8c6b3036430dc464fd652fb37ded21c09a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-11-09 08:00:37 +00:00
Christian Stenger
e5c4d20e2b LanguageClient: Reset maximum restart tries on explicit restart
If the user forces the language client to restart for whatever reason
the client may end up in not starting anymore depending on the
number of restarts that had been done already.
So, explicitly reset the counter in case the user triggers the
restart.

Change-Id: Ie5f33c8dc3d565b6126badc9708906fc14f4e743
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-09 07:58:13 +00:00
hjk
05e7308c08 ProjectExplorer: Use more Ids instead of Kit in KitModel
The idea is to slowly move towards a uniform approach to handle the
Kits/Qt Version/Debugger/Toolchain/... managers/settings.

Change-Id: I6ddba968a51d9468bb0dfec74b2fb8b902d11294
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-11-09 07:55:28 +00:00
Eike Ziller
7bd99104e0 Merge remote-tracking branch 'origin/12.0'
Change-Id: I2594f193260a103e1c4484fcab974213c881353d
2023-11-09 08:22:27 +01:00
Christian Stenger
4436e96f91 Debugger: Fix compile with Qt6.2
Amends 43f99cb53b.

Change-Id: Ia28b129f761e8cfe6dd3a908ccfcf50d043d1639
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-11-09 07:16:08 +00:00
Marcus Tillmanns
6e1d7fc961 CompilerExplorer: Fix crash on undo
We need to store the source text document so that when the editor
is remove and the user triggers undo/read, the pointer is still valid.

Change-Id: I571906db1c4424455172a42d72351cd9ba1e7c03
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-09 05:55:08 +00:00
Marcus Tillmanns
e4805b88c9 CMakePM: Use FilePath::fromUserInput
Change-Id: I748fc41ed380c907b6edcca3a1802a47f9f74436
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-11-09 05:53:36 +00:00
Jarek Kobus
9a8531c22f DockFocusController: Avoid using sender() in onFocusedDockAreaViewToggled
Since m_focusedArea is always a sender of the signal connected to the
onFocusedDockAreaViewToggled() slot, reuse it in place of sender().

Change-Id: I17b817132c8b74e825f0accb9c1d467bfdf24ac3
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-11-08 17:03:41 +00:00
Jarek Kobus
611bef47ce DockFocusController: Avoid using sender() for visibilityChanged()
Use Qt::SingleShotConnection connection instead and remove
disconnect.

Change-Id: If3ec082bb2341277bfeb781b13986492a88172e6
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-11-08 17:03:30 +00:00
Jarek Kobus
b75df9eb83 AdvancedDockingSystem: Avoid using sender()
Change-Id: Iabc97c99046e1ebabddf988c675a51a93875ddf5
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-11-08 17:03:22 +00:00
Thomas Hartmann
036963de02 QmlDesigner: Add signals of dynamic properties
We have to take into account that signal themselves
are considered dynamic properties, but do not require
the changed suffix.

Task-number: QDS-10977
Change-Id: I6af83586eee1b8f37e0510839baecee42972494c
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-11-08 15:44:40 +00:00
Shrief Gabr
e6733673fb QmlDesigner: Warn of possible data loss if column data type is changed
Task-number: QDS-11013
Change-Id: I388492480355fc5feb14ecc940aa54f9dfc8b2f6
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
2023-11-08 15:25:24 +00:00
Ali Kianian
9008894664 QmlDesigner: Remove HelperWidgets.RegExpValidator from CollectionEditor
Change-Id: I24f86c32f1e01e17b51c809da82e625b6a6d70c2
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-11-08 15:06:47 +00:00
Leena Miettinen
2f664c4c3d Doc: Add a note about iOS support being broken in version 12.0
Task-number: QTCREATORBUG-29392
Change-Id: Iede2437b370971c595df2ddca6a0cb544550b1c3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
v12.0.0-rc1
2023-11-08 15:03:24 +00:00
Eike Ziller
a02766431b Update change log for 12.0.0
Change-Id: Ia105b80002652f9f37b2e41cb13afe439713af9f
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-11-08 15:02:44 +00:00
Mahmoud Badri
d9ab8e8bef QmlDesigner: Update light baking and effect maker pause icons
Also hide the code icon from effect maker

Change-Id: I1045a0718b5b86ef13164e215e5f0f1420487497
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Amr Elsayed <amr.elsayed@qt.io>
2023-11-08 14:53:15 +00:00
Alessandro Portale
76dbc9e42b Utils: Remove handling of macOS < 10.14 in theme_mac.mm
Qt Creator should only be built and be running on macOS 10.14 or later.

This cleanup is in preparation for other following changes.

Task-number: QTCREATORBUG-29783
Change-Id: Idd549051b899726f2db8fed320a2ef15e948d2d7
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-11-08 14:44:56 +00:00
Mahmoud Badri
514b070a4c QmlDesigner: Update icon font
Added icons:
addGroup_medium.svg
assignTo.svg
bakeLights_medium.svg
listView_medium.svg
pause_medium.svg
tableView_medium.svg
warning_medium.svg

Change-Id: I17c39fdd771e3391ae6a37f171223fdea0e773fe
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-11-08 13:48:40 +00:00
Jarek Kobus
79421fd597 TaskTree: Rename StopOnFinished into StopOnSuccessOrError
In order to conform to CallDoneIf::SuccessOrError.

Amends 2c0a59384c

Change-Id: I2704667ca8d005c63c13b62786010ce430f0b550
Reviewed-by: hjk <hjk@qt.io>
2023-11-08 13:04:36 +00:00
Thomas Hartmann
d8465f7643 QmlDesigner: Add QML_IMPORT_PATH to cmake template
Task-number: QDS-11149
Change-Id: Ic54d10bf5e6dd0cf23ae646df8fbac69334c9728
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-11-08 13:00:44 +00:00
Knud Dollereder
578b66727a QmlProject: Add QML_IMPORT_PATH to the main cmakegen template
Change-Id: Idd55f372701c76f43869abfc3b493247e06ce8f5
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-11-08 12:53:16 +00:00
Thomas Hartmann
1b27dd383f QmlDesigner: Allow dropping components and assets to text editor
Task-number: QDS-10868
Change-Id: I8037fd0fdd6060bbf84f0b24a52f18304380dcd2
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-11-08 12:48:03 +00:00
hjk
16233c51cd ProjectExplorer: Don't internally chain KitManager signal emission
Rather, emit directly in sequence. Saves a few cycles in the
signal/slot machinery simplifies reasoning on the user side
which signals to expect.

Change-Id: Ib75f47a73e9731b506b9df3c713684a9cf59aa67
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-08 12:42:17 +00:00
Christian Kandeler
e48d365b19 ProjectExplorer: Normalize separators on HeaderPath construction
Fixes a Windows test failure in CompilationDatabaseProjectManager.

Change-Id: Ic373b7a50b1374be4cf028fc304442c3cf077735
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-08 12:27:57 +00:00
hjk
e2cc01d213 ProjectExplorer: Remove unused code from KitAreaWidget
Change-Id: Ic90d820f51a785967ba2d7a176ec14430119285b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-11-08 12:10:46 +00:00
Eike Ziller
ae2d429edb ClangTools: Use "Diagnostics" as view title
The tool is already shown in the perspective selector, and the view
shows the found diagnostics.

Change-Id: I0c9f7e1aa21801c176623ecb751412637ff6c025
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-11-08 11:49:18 +00:00
hjk
b8c7186a36 Core: Simplify system env setup code a bit
Change-Id: Ic25c4b1e9371f9c46a2d95a243964f0a3ef1f878
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-08 11:32:36 +00:00
Semih Yavuz
ffcbbecf27 reformatter: Do not remove type annotations
Type annotations were being removed by the reformat action. Write out
the relavant annotations in ast to fix it.

Add exclusion mechanism in tst_qml_reformatter test since it performs
line by line comparison which doesn't fit all reformatting cases.
Introduce char-by-char data tests.

Fixes: QTCREATORBUG-29061
Change-Id: Ia52b51e6d7d938bdec325c4f426b11c722f85f8e
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2023-11-08 11:09:02 +00:00
hjk
6685f0255d Utils/all: Move mime constants into a central place
They are reasonably standardized, and generally usable cross-plugin,
so this can help to avoid a few cross-plugin compiletime dependencies.

Change-Id: Icb2b010c3e12dee69df54ab16f6f8e90d9cffba6
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-11-08 09:59:26 +00:00