Commit Graph

86167 Commits

Author SHA1 Message Date
Tim Jenßen
ea8561db8d QmlDesigner: rename Qt5 only Default style to Basic
Task-number: QDS-9980
Change-Id: Id3d511adb5c1cd5f680f91705cb2f7a721c7ad12
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-25 13:36:47 +00:00
Leena Miettinen
9d4c31cb74 Doc: Describe using the locator to go to tabs in Preferences dialog
Change-Id: I9644cdc830494c4e02599b72c584eb02aed1f4f8
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-25 13:15:05 +00:00
Eike Ziller
52f45056f0 Projects tree: Fix collapsing behavior of Left key
Work around a Qt issue that the left key directly jumps to the parent if
the horizontal scroll bar is not left-most.

Task-number: QTBUG-118515
Change-Id: Icfc2a58863a3847a84bca05fc2de4b28e384106c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-25 12:56:40 +00:00
Thomas Hartmann
d0201ad998 QmlDesigner: Bump version in project template
Change-Id: Ic0c2e37d40d219b550f57e178ee282c1e9d55609
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-10-25 12:26:58 +00:00
David Schulz
59cb505dd0 Terminal: fix typo
Change-Id: I92ccb9cee06517d7be86e2393209096e1b47c36a
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-25 12:03:28 +00:00
Christian Kandeler
2ad3520e5a CppEditor/LanguageClient: Do not rename in generated files by default
Fixes: QTCREATORBUG-29778
Change-Id: I4e56b6bda4e22c71995ab19ac6469ea88d22ee11
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-10-25 11:49:01 +00:00
Christian Kandeler
8b2d676ae8 Designer: Ignore layout name changes from property editor
As it turns out, changes to "objectName" and "layoutName" both result in
the objectNameChanged() signal getting emitted. We must handle these the
same way.

Fixes: QTCREATORBUG-29644
Change-Id: I41ecc4867f3df8eedf325eda750b947a57c90c10
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-25 11:40:58 +00:00
Alessandro Portale
ea1a745813 Utils: Restore the prior edit-clear-locationbar icon direction
On left-to-right KDE systems, the clear icon on the right was originally
(up to QtC 11) pointing to the left. In Qt Creator 12 it started
pointing to the right.

Reproducible with KDE Plasma 5.27.

This change restores the prior mapping of "writing direction" to "clear
icon direction". It also restores the fall back to the freedesktop
standard name "clear-icon".

Amends: 67212a31ee

Change-Id: I3d1340195a82422ac310128b9e81982e0d57a6ca
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-10-25 11:31:33 +00:00
Leena Miettinen
d72fa04833 Doc: Update QML Language Server preferences docs
- Some labels changed
- "Use QML Language Server advanced features" was added

Task-number: QTCREATORBUG-29392
Change-Id: I2c4f4d43b8f8e9d74186439e31a9d8cf13ec4967
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-25 11:06:41 +00:00
Jarek Kobus
99c749043d SshProcessInterface: Ensure non-zero PID when destructing
Fixes: QTCREATORBUG-29788
Change-Id: Ia906469526ebeaea6421f1f27a74e66d59bcaea3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-25 10:36:13 +00:00
Eike Ziller
0bf69bc499 NavigationWidgets: Fix the side that shortcuts open
The activationsMap logs were a specific view was opened last.

We need to clear outdated information from the navigation widgets'
(left|right) settings (if a view was opened last in the left widget,
that was written to the left widget's settings, but it was not cleared
from the right widget's settings, so if it ever was opened last on the
right side, that information stuck).

When restoring the state of the left|right widgets, we may not overwrite
the previously restored activationsMap.

Fixes: QTCREATORBUG-29770
Change-Id: I14c85c24f279208fb94707514cc4a8cba184e03c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-25 10:30:05 +00:00
Knud Dollereder
73177f3184 Prevent assert from triggering when trying to edit a 3D component
Clicking on "Edit Component" of a 3D component in the Components view results in an assertion.
This patch attempts to resolve this.

Change-Id: I98ca474ee1c1ea4369ad9bc6c207a6c61e4e4e95
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-10-25 09:45:03 +00:00
Eike Ziller
0089d3cc3d ProjectTreeWidget: Remove unused event filter
The object that is installed as an event filter doesn't implement
eventFilter.

Change-Id: Icc51346e0c9eadf7448a4889df4c447d3bc3082c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-25 09:32:09 +00:00
Alessandro Portale
3d95bafdbb Axivion: Support building without ssl
Change-Id: I027317410321725e8e295d236243e50e1ea6019d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
v12.0.0-beta2
2023-10-25 07:31:09 +00:00
Leena Miettinen
22693e3281 Doc: Add links to documentation to the change log
Task-number: QTCREATORBUG-29392
Change-Id: Ic5233954320447e7ef3152e25f4ddce43936fbc6
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-25 07:22:42 +00:00
Thiago Macieira
6eca31c424 Add missing includes for QPointer
qtbase removed some indirect include somewhere.

Change-Id: I477e6dccebda4fbb81f6fffd179115840c67002f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-25 05:47:32 +00:00
Brook Cronin
5d7bfd67bd QmlDesigner: Add jump to code icons
Change-Id: Ied52b12c2a6855766819a9444b217b6386ffd28a
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-24 15:36:59 +00:00
Miikka Heikkinen
6bfca09b98 QmlDesigner: Clear selected material on model detach
Retaining ModelNodes from detached model causes issues down the line.

Change-Id: I2bd1969d014fef76210a727312eb8bb9da96ffa6
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
2023-10-24 14:23:04 +00:00
Miikka Heikkinen
8e033db46f QmlDesigner: Fix getNodeAtPos for 3D view when the view is split
Fixes: QDS-11019
Change-Id: If18404204f9fd550c79cfa1f22d7adec5fac2595
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-10-24 13:41:56 +00:00
Eike Ziller
df80454d26 Merge remote-tracking branch 'origin/12.0'
Change-Id: I04104ef638b28d99da11b9b7a22f31f8d0ddf460
2023-10-24 13:05:55 +02:00
Henning Gruendl
224a2564d6 QmlDesigner: Remove option from restart list
Change-Id: I3bb28e8b65beddd96d757673f375021207a83ca2
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-10-24 10:09:23 +00:00
Henning Gruendl
7613710727 ADS: Enable minimumSizeHint from content
* Fix minimumSizeHint handling
* Set DockWidget to not force scroll area
* Set background color on dock widgets
* Add setting to activate/deactivate minimumSizeHint handling
* Fix missing ADS changes from last merge
* Fix ADS comments

Task-number: QDS-10925
Change-Id: I7e8e0d2e7c3f9ee6636a2dc0796f6bd1fff3b2ee
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-24 10:09:11 +00:00
Miikka Heikkinen
3caac7bc67 QmlDesigner: Update icon gizmo positions on split toggle
Fixes: QDS-11021
Change-Id: I40472bd7c5766e5cf12782b760618371fddc3cc8
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-10-24 09:53:12 +00:00
Cristian Adam
5e3d14e2e9 CMakePM: Allow CMAKE_SYSROOT to be taken from the CMake preset probe
One could have a toolchainfile that sets the CMAKE_SYSROOT. We need to
be able to read the value later, and not just from the CMake Presets
cmakeCache array.

Task-number: QTCREATORBUG-29643
Change-Id: I63697219195b043813516c8214329ce583dc0676
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-24 09:13:50 +00:00
Riitta-Leena Miettinen
0fe891678a Doc: Use a link to "Find preferences" as value of \preferences
- Add the instructions for finding the Preferences menu to the
  "Find a particular preference" topic and rename it "Find preferences".
- Remove the "Find menu items on macOS" topic

Change-Id: I627e5c20d2c63efb4490d446608b923ac15a6aac
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-24 09:00:36 +00:00
Christian Stenger
ddffbe676d Help: Do not allow opening temporary in Help mode
In case we have no documentation for an "F1 help request"
we display some temporary with a small hint. Disallow opening
this inside the Help mode to avoid triggering an open request
which ends up in a system dialog trying to open the temporary
local file.

Fixes: QTCREATORBUG-29371
Change-Id: If61c37eb2576cf6f9dcc70b58527a66b284b30f0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-24 08:15:50 +00:00
Eike Ziller
f811edf4a2 Help: Fix text of View > Show Left Sidebar check item
The text should never be "Hide Left Sidebar", because it is a checked
item. Just set the tooltip, like done in coreplugin/navigationwidget.cpp

Task-number: QTCREATORBUG-27733
Change-Id: I0cda56712724a69cb08411e62be57b88909416fe
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-10-24 08:10:05 +00:00
Leena Miettinen
1d64d764ac Clangd: Edit tooltip text for "Header/source switch mode" field
Use the phrasing "tends to find false positives" instead of
"has some bugs".

Add </p> at the ends of paragraph elements.

Change-Id: Ie524f2615625b52bf2de5b66b8938f49e3d0255f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-24 08:01:13 +00:00
Eike Ziller
176be6a563 COIN/GitHub: Switch to Qt 6.6.0
Which we use for the packages

Change-Id: I7fa6c001f356ca23409444567d94246731d0fffe
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-10-24 07:52:02 +00:00
Eike Ziller
bed9ed55c4 EditorManager: Native dialogs on macOS can't change their buttons
In this case we try to add a menu to a button.
"Native" is the default, so explicitly request a non-native message
box.

This is the message box that pops up e.g. when trying to open an
empty file foo.ui (the widget designer rejects to open it, Qt Creator provides the option to open with a different editor in the error dialog).

Task-number: QTBUG-118419
Change-Id: Iab3ee14593a55c2056303cfa16b99cea25893522
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-24 07:51:01 +00:00
David Schulz
03acf2810d Utils: remove misleading comment from aspect changed signal
Change-Id: Ic1d3fb9c72326696899404514cab597a59f5fc89
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-24 07:38:51 +00:00
David Schulz
2e93051aaf TextEditor: improve sort selected lines
Try to get a sensible scope when there is no selection when sorting
lines.

Use the indent level of the current block and select all blocks that are
not empty with the same indent level around that block before sorting
the lines.

Change-Id: I68cbd95f95a0cc4425a0339b992225c3946a6858
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-24 07:38:38 +00:00
Christian Stenger
f401d51a66 McuSupport: Fix dependencies and tests
There is nowadays a hard dependency on QmlJSTools as there is
need to access its QmlJSModelManager.
Beside this adapt the tests to reflect the Key / QString changes
happened inside the settings to avoid crashing the tests.

Change-Id: I71cd0457e5f567da28cc089b514655418bd60b7d
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-24 05:18:54 +00:00
Jarek Kobus
4645c713d2 GenericDeployStep: Fix rsync step
Don't use a copy of m_files for mkdirTask(), as m_files is
modified by the running recipe. So, when the recipe is prepared,
the m_files doesn't contain the right data, yet.

This is going to be refactored in master, as it seems the
isDeploymentNecessary() operating on mutable internals
is confusing.

Fixes: QTCREATORBUG-29609
Change-Id: I3f34584ffd9486322e8b26f95ac72b96a9306f8b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-23 15:31:59 +00:00
Christian Kandeler
8da7d88e3a ProjectExplorer: Fix restoring project dependencies
Amends d6fe357d81.

Fixes: QTCREATORBUG-29796
Change-Id: I7788b4e5c2477bb3edf9764b08cfa344a5e9c9c0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-23 12:52:53 +00:00
Miikka Heikkinen
ea7aca28c7 QmlDesigner: Store 3D split view camera angles per split
Splits 1-3 default to axis oriented views.

Fixes: QDS-10996
Change-Id: I111c9b76ae335f8630eeae5e51bbefb2e702f6df
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-10-23 12:18:33 +00:00
Leena Miettinen
86e8676bec Doc: Describe setting DPI rounding policy
Task-number: QTCREATORBUG-29392
Change-Id: I45eef9d1282f7df3f75f08ff55745c4205f553d9
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-23 10:40:00 +00:00
David Schulz
30ef90c322 Terminal: add finished signal
Change-Id: I9d560d1f1bbaa94ae75420002744073a1e8fad1a
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-23 10:24:48 +00:00
Alessandro Portale
76bcd85f21 WebAssembly: Avoid soft assert on toolchain auto detection
Windows only: When toolchains get restored on startup,
WebAssemblyToolChain would try to add MinGW to an environment. That
env is used for querying the compiler version. In order to find MinGW,
the MinGW toolchain is queried from ToolChainManager. But since the
ToolChainManager is not yet loaded at this moment, we get a QTC_CHEK
assert from ToolChainManager::toolChain.

This change prevents querying the ToolChainManager before it is loaded.
The compiler version can successfully be determined without MinGW in
path.

Whether we really need to query compiler versions that early is another
question outside the scope of this change.

Change-Id: I46edbb80edc58d7465e90e99f7f8381708f704a1
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-23 10:12:50 +00:00
David Schulz
6f4b9639ce TextEditor: highlight selected text
Change-Id: Ib46908decef51d478f6954a116108c48e4a07ed3
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-23 07:33:45 +00:00
Leena Miettinen
e454dc0f1f Doc: Describe setting default C++ file name extensions for a project
Task-number: QTCREATORBUG-29392
Change-Id: I2bba1d26dc6177a1f6b3f78483e669244fa15ff1
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-23 06:49:34 +00:00
Tim Jenßen
09f13dea04 QrCodeGenerator: enable by default
BUILD_DESIGNSTUDIO was introduced to have all
commercial plugins as a developer while
programming.
In packages its depending on which plugin goes
to which license and we did not had that for
libraries.

Change-Id: Ib02b166ea756c939e19f625c76207c07729f38bc
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-10-21 07:27:07 +00:00
Cristian Adam
423315178a CMakePM: Fix display of header / source files
Qt Creator will display the header / source files based on the
sourceDirectory of the target as base directory.

The source_group(TREE <dir>) will result CMake in making a source group
named "TREE" which should not be displayed in the project view.

Amends 9280f7f757

Fixes: QTCREATORBUG-23942
Fixes: QTCREATORBUG-29105
Change-Id: Ib71ffcc559376ea1596a5b21cb7e7fa779bd8d79
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-20 17:15:43 +00:00
Leena Miettinen
61088bba69 Fix UI text capitalization, punctuation, and phrasing
Change-Id: I41951660a464601063e5cedd417db2cb7cd37e44
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-20 14:55:38 +00:00
Alessandro Portale
76f082186e Android: Fix build dir for Qt6/CMake + changed LIBRARY_OUTPUT_DIRECTORY
The "proper" build directory is required during different stages of the
Android application deployment. For example in order to determine the
input .json file for the androiddeployqt launch.

If the CMake target has a modified LIBRARY_OUTPUT_DIRECTORY property, an
incorrect build directory was determined. This change adds a hack which
in such case (and only for Qt6 + CMake) tries to find the right build
directory, which also contains the .json file.

Fixes: QTCREATORBUG-26479
Change-Id: I24342f696aed7a322030eb9310d3ca71bcada81c
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2023-10-20 14:08:56 +00:00
Cristian Adam
aef415a25d CMakePM: clang-tidy fix for 'move-const-arg'
See https://releases.llvm.org/17.0.1/tools/clang/tools/extra/docs/clang-
tidy/checks/performance/move-const-arg.html

Change-Id: Ic20445321286fdcb8b02e1b2cf170e0fe60fd1fd
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-20 13:57:40 +00:00
Cristian Adam
55cccfa59e CMakePM: clang-tidy fix for 'no-automatic-move'
See https://releases.llvm.org/17.0.1/tools/clang/tools/extra/docs/clang-
tidy/checks/performance/no-automatic-move.html

Change-Id: If265c9b0e2aea49e5923f079cd621e10bb958286
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-20 13:57:34 +00:00
Cristian Adam
69815af272 CMakePM: clang-tidy fix for 'performance-implicit-conversion-in-loop'
Change-Id: I67e5adad19a3454986381c5548bbe96cf1cc1e6a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-20 13:57:28 +00:00
Cristian Adam
43121fa574 CMakePM: clang-tidy fix for 'perf*-unnecessary-copy-initialization'
Change-Id: I9c407f7254328e7278096239f6f3946c34e873d5
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-20 13:57:20 +00:00
Cristian Adam
60de12efd2 CMakePM: clang-tidy fix for "performance-unnecessary-value-param"
Change-Id: Ia22d7c3fe6c29a5e0999145b6c4b281818dd72bf
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-20 13:57:15 +00:00