Work around a Qt issue that the left key directly jumps to the parent if
the horizontal scroll bar is not left-most.
Task-number: QTBUG-118515
Change-Id: Icfc2a58863a3847a84bca05fc2de4b28e384106c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
As it turns out, changes to "objectName" and "layoutName" both result in
the objectNameChanged() signal getting emitted. We must handle these the
same way.
Fixes: QTCREATORBUG-29644
Change-Id: I41ecc4867f3df8eedf325eda750b947a57c90c10
Reviewed-by: David Schulz <david.schulz@qt.io>
On left-to-right KDE systems, the clear icon on the right was originally
(up to QtC 11) pointing to the left. In Qt Creator 12 it started
pointing to the right.
Reproducible with KDE Plasma 5.27.
This change restores the prior mapping of "writing direction" to "clear
icon direction". It also restores the fall back to the freedesktop
standard name "clear-icon".
Amends: 67212a31ee
Change-Id: I3d1340195a82422ac310128b9e81982e0d57a6ca
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
- Some labels changed
- "Use QML Language Server advanced features" was added
Task-number: QTCREATORBUG-29392
Change-Id: I2c4f4d43b8f8e9d74186439e31a9d8cf13ec4967
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
The activationsMap logs were a specific view was opened last.
We need to clear outdated information from the navigation widgets'
(left|right) settings (if a view was opened last in the left widget,
that was written to the left widget's settings, but it was not cleared
from the right widget's settings, so if it ever was opened last on the
right side, that information stuck).
When restoring the state of the left|right widgets, we may not overwrite
the previously restored activationsMap.
Fixes: QTCREATORBUG-29770
Change-Id: I14c85c24f279208fb94707514cc4a8cba184e03c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The object that is installed as an event filter doesn't implement
eventFilter.
Change-Id: Icc51346e0c9eadf7448a4889df4c447d3bc3082c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
qtbase removed some indirect include somewhere.
Change-Id: I477e6dccebda4fbb81f6fffd179115840c67002f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Retaining ModelNodes from detached model causes issues down the line.
Change-Id: I2bd1969d014fef76210a727312eb8bb9da96ffa6
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
* Fix minimumSizeHint handling
* Set DockWidget to not force scroll area
* Set background color on dock widgets
* Add setting to activate/deactivate minimumSizeHint handling
* Fix missing ADS changes from last merge
* Fix ADS comments
Task-number: QDS-10925
Change-Id: I7e8e0d2e7c3f9ee6636a2dc0796f6bd1fff3b2ee
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
One could have a toolchainfile that sets the CMAKE_SYSROOT. We need to
be able to read the value later, and not just from the CMake Presets
cmakeCache array.
Task-number: QTCREATORBUG-29643
Change-Id: I63697219195b043813516c8214329ce583dc0676
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
- Add the instructions for finding the Preferences menu to the
"Find a particular preference" topic and rename it "Find preferences".
- Remove the "Find menu items on macOS" topic
Change-Id: I627e5c20d2c63efb4490d446608b923ac15a6aac
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
In case we have no documentation for an "F1 help request"
we display some temporary with a small hint. Disallow opening
this inside the Help mode to avoid triggering an open request
which ends up in a system dialog trying to open the temporary
local file.
Fixes: QTCREATORBUG-29371
Change-Id: If61c37eb2576cf6f9dcc70b58527a66b284b30f0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The text should never be "Hide Left Sidebar", because it is a checked
item. Just set the tooltip, like done in coreplugin/navigationwidget.cpp
Task-number: QTCREATORBUG-27733
Change-Id: I0cda56712724a69cb08411e62be57b88909416fe
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Use the phrasing "tends to find false positives" instead of
"has some bugs".
Add </p> at the ends of paragraph elements.
Change-Id: Ie524f2615625b52bf2de5b66b8938f49e3d0255f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
In this case we try to add a menu to a button.
"Native" is the default, so explicitly request a non-native message
box.
This is the message box that pops up e.g. when trying to open an
empty file foo.ui (the widget designer rejects to open it, Qt Creator provides the option to open with a different editor in the error dialog).
Task-number: QTBUG-118419
Change-Id: Iab3ee14593a55c2056303cfa16b99cea25893522
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Try to get a sensible scope when there is no selection when sorting
lines.
Use the indent level of the current block and select all blocks that are
not empty with the same indent level around that block before sorting
the lines.
Change-Id: I68cbd95f95a0cc4425a0339b992225c3946a6858
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
There is nowadays a hard dependency on QmlJSTools as there is
need to access its QmlJSModelManager.
Beside this adapt the tests to reflect the Key / QString changes
happened inside the settings to avoid crashing the tests.
Change-Id: I71cd0457e5f567da28cc089b514655418bd60b7d
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Don't use a copy of m_files for mkdirTask(), as m_files is
modified by the running recipe. So, when the recipe is prepared,
the m_files doesn't contain the right data, yet.
This is going to be refactored in master, as it seems the
isDeploymentNecessary() operating on mutable internals
is confusing.
Fixes: QTCREATORBUG-29609
Change-Id: I3f34584ffd9486322e8b26f95ac72b96a9306f8b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Windows only: When toolchains get restored on startup,
WebAssemblyToolChain would try to add MinGW to an environment. That
env is used for querying the compiler version. In order to find MinGW,
the MinGW toolchain is queried from ToolChainManager. But since the
ToolChainManager is not yet loaded at this moment, we get a QTC_CHEK
assert from ToolChainManager::toolChain.
This change prevents querying the ToolChainManager before it is loaded.
The compiler version can successfully be determined without MinGW in
path.
Whether we really need to query compiler versions that early is another
question outside the scope of this change.
Change-Id: I46edbb80edc58d7465e90e99f7f8381708f704a1
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
BUILD_DESIGNSTUDIO was introduced to have all
commercial plugins as a developer while
programming.
In packages its depending on which plugin goes
to which license and we did not had that for
libraries.
Change-Id: Ib02b166ea756c939e19f625c76207c07729f38bc
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Qt Creator will display the header / source files based on the
sourceDirectory of the target as base directory.
The source_group(TREE <dir>) will result CMake in making a source group
named "TREE" which should not be displayed in the project view.
Amends 9280f7f757
Fixes: QTCREATORBUG-23942
Fixes: QTCREATORBUG-29105
Change-Id: Ib71ffcc559376ea1596a5b21cb7e7fa779bd8d79
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
The "proper" build directory is required during different stages of the
Android application deployment. For example in order to determine the
input .json file for the androiddeployqt launch.
If the CMake target has a modified LIBRARY_OUTPUT_DIRECTORY property, an
incorrect build directory was determined. This change adds a hack which
in such case (and only for Qt6 + CMake) tries to find the right build
directory, which also contains the .json file.
Fixes: QTCREATORBUG-26479
Change-Id: I24342f696aed7a322030eb9310d3ca71bcada81c
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>