UI preparation which may change when adding the functionality
of retrieving respective information from the dashboard.
Change-Id: I9ec8069d780f925b00ba63982af6b410ddec9a5a
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This patch updates the old image to include lock the views features
in the document screenshot. Also it updates the text description to match
the change.
Fixes: QDS-11565
Change-Id: I262be3392552920607725becda6e21d3e571c122
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
You should either use begin() and end(), or data() and size(), and
either way you shouldn't dereference the first iterator if the size is
zero.
Roberto's parser in 3rdparty/cplusplus assumes you've passed at least
one character (I'm guessing the null terminator) and does pointer
manipulation there:
void Lexer::setSource(const char *firstChar, const char *lastChar)
{
_firstChar = firstChar;
_lastChar = lastChar;
_currentChar = _firstChar - 1;
_currentCharUtf16 = ~0;
_tokenStart = _currentChar;
_yychar = '\n';
}
Note the _firstChar - 1 math is technically UB if firstChar is the
actual first character of any buffer allocation or string.
Fixes: QTCREATORBUG-30044
Change-Id: I76ffba14ece04f24b43efffd17abcb8102497813
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* If all of the columns are deleted, all of the objects will be deleted
and a single column, with one empty row will be created.
* A bug is fixed for the cases that we have invalid selected column.
Task-number: QDS-11649
Fixes: QDS-11678
Change-Id: I8bdbd0176ad76dd761e98b5030cdc77379a8642b
Reviewed-by: Shrief Gabr <shrief.gabr@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
In practice this applied only to "Mipmap Drop Shadow"
Fixes: QDS-11717
Change-Id: Ia731370a1101a9bce17ae558ae8761b99afcd896
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Files with same name but different path will now be removed from
UrlChooser combobox on the assumption that they are in fact copies of
the same file.
Fixes: QDS-11471
Change-Id: Ic65153a1a65865982ee1c11e4e20171d66221b76
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Editing in the item view was cumbersome and did not generally allow one
variable to refer to another, as there was no defined order on the
assignments.
Therefore, we make the item view read-only and promote the batch editing
widget to be the standard input method. User changes are not sorted
anymore, except in the summary text of the details widget.
Fixes: QTCREATORBUG-28480
Change-Id: I225cf86fff7b001a57d663e1fd267a4645e695c4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Since the context menu is defined inside the horizontal header view,
it didn't close by clicking on another column. The reason is that the
close policy works when we click outside the parent.
To resolve this, we can simply close the menu when the user clicks
on the header scope.
For right clicks, it's not mandatory to close the menu, since it will
be moved and opened again.
Fixes: QDS-11731
Change-Id: I5e0bb4c88dafdc54d0900a4c9e3bb584243373e4
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Shrief Gabr <shrief.gabr@qt.io>
Change the last arg to std::chrono::milliseconds type.
Change-Id: Ifb818f76ee33e03997cb5b1dd17336248f401238
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Add an extra arg to runBlocking() function instead.
Use std::chrono::seconds for timeout.
Change-Id: I7c3c21e8f26a2ccbed157d15083d6ef0b4cd2f7e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Rename ProcessResult::Hang into Canceled.
Change the behavior of the Process:
Whenever the terminate() or kill() is called, including
indirect calls through stop() or runBlocking()'s timeout,
mark the process result as Canceled.
In this way the Process running by a call to start()
may also finish with Canceled state. Before it was only
happening for processes started via runBlocking().
Adapt the runBlockingStdOut_data() test accordingly.
Get rid of ProcessInterface::m_canceledByUser field.
Use ProcessResult::Canceled state instead.
Fix existing 3 usages of m_canceledByUser field.
Use standarized exitMessage() method for them.
Add automatic measurement of process execution.
Introduce processDuration() getter.
Use it for reporting exitMessage() instead of timeoutS().
Change-Id: I1a68559ce844caef863a97a6b0577b0238011f70
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* The minimum size for the collection editor is modified.
* Layouts of the top toolbar are modified to show the buttons when
there is adequate space.
* A text display warning is fixed.
Fixes: QDS-11646
Fixes: QDS-11725
Change-Id: I7fe1aaf75abe13bb71f216cef13ea2b8f2cf9a9b
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Extract the common part of handling the timeout into the
handleTimeout lambda.
Change-Id: I3c55c76cbc3d1217322c1b2a7002285bf2e649d3
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
1x warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
2x warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class]
Change-Id: I762fbe935156de9600064512bc405c6f4b2b1477
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Effect maker effects consist of .qep file under project content and
an imported module under asset_imports containing effect resources.
Now the resources module is also deleted when .qep file is deleted.
Fixes: QDS-11365
Change-Id: If3a91419970f6b26c4fc4df6d6d891b591ebedd3
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
It is more descriptive than an int.
Change-Id: I6add6a74850a9976c92509c404edb0c9fc403d21
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
And enable its availability for startup performance measurement.
Makes it possible to run with `-trace <filepath>`, creating a CTF for
startup performance, without requiring a special QtC build.
Usage in QmlDesigner/DesignStudio is guarded by an additional
DESIGNSTUDIO_USE_NANOTRACE CMake option (default off), since that adds a
menu item that should usually not be shown.
Change-Id: I87200745cc32f256bcaaba21f139b4104459e49a
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
Fix ColorPalette Connections being triggered on all previously opened
ColorEditorPopups.
Task-number: QDS-11569
Change-Id: I2a6e44b631f4ff1187f9fbcd0afb8295b708f626
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
E.g. MultiEffect doesn't provide default sampler image for mask, so
we need to properly support empty values for samplers.
Change-Id: I3e000127305b79bfa04e0a661ab45137f4dec237
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Do not always call deactivateDocument for all
Core::EditorManager::documentClosed emits containing textDocuments.
Change-Id: I5d9bf4c0d634837167fced4202f7edf34952c46d
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
