Remove registerProfilerStateManager() and connect to
state manager's signal directly from the start() function.
Remove Q_OBJECT macro.
Change-Id: Id03486f077c81909fbe0889bb342ee7595631e9d
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Do it temporarily. In a followup patch the LocalPerfRecordWorker is going
to be replaced by ProcessRunner.
Change-Id: I88dc0624b19aa105efce6b0d36d530296214c132
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: hjk <hjk@qt.io>
When using a dark QtC theme on "light" environment and or when using a
light QtC theme on a "dark" environment, the application palette is set
accordingly.
After switching to Qt::ColorScheme-based API, the palette got also set
for environments reporting Qt::ColorScheme::Unknown. This change avoids
it.
Amends: eb4648004f
Change-Id: Ibb5dcd02aff6e665a59fd4f67407f00a9ff6e9b0
Reviewed-by: hjk <hjk@qt.io>
Replace the main cursor with a block selection instead of a normal
selection when using alt+shift+LMB. This is more in line with other IDEs
and also feels more natural.
Change-Id: Id4dba7cec65ddeb34ab525d90a41aebf78457d0d
Reviewed-by: Andrii Semkiv <andrii.semkiv@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Translations can be different depending on context.
Give each usage a disambiguation text.
Task-number: QTCREATORBUG-31978
Change-Id: I5fe854f96ce285943ff47993cd6d56db603d1c27
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Translations can be different depending on context.
Give each usage a disambiguation text.
Task-number: QTCREATORBUG-31978
Change-Id: I44ac524d7448787360e825fad1d430ded3f07659
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
There is no need to enclose a container inside the std::optional,
as if the container is empty, it indicates that no values are in.
Holding optional for a container class may lead to the confusing
behavior, that the optional itself isn't empty, but holding an
empty container.
Instead, introduce a m_callStackDetected flag.
Task-number: QTCREATORBUG-29965
Change-Id: If8d43e0633286c076e3da436eb61114aa68f4c35
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Calling `BreakpointItem::setEnabled` from `BreakpointMarker::clicked` is
wrong and dangerous. It never actually enables a global breakpoint,
just updates the marker. While doing so, it calls
`BreakpointItem::adjustMarker`, which in turn calls
`BreakpointItem::destroyMarker`, which destroys the original marker,
hence the dangerous part.
What we actually want is simply enable the corresponding global
breakpoint instead.
Amends 8f3a0ebabb.
Change-Id: I423752be4e4f51198e9e2968a978b57bce43a3ec
Reviewed-by: hjk <hjk@qt.io>
And replace a FilePath::toString() by .path()
Change-Id: I5e4c36f8fd9cc0494cf76f274f259d97231b2dc0
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Some were using ICore::dialogParent() directly and the 'nullptr' users
were using that implicitly, but quite a few actually effectively changed
now from some local widget to (implicit) ICore::dialogParent().
Change-Id: Ibb2767b1289221dd26757361235ee88df4a1695e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Add the executable path of qmlls after its name, so that it is actually
displayed to the user which version of qmlls it is currently using. This
should help us when/if users will report more bugs with qmlls in the
future.
Task-number: QTCREATORBUG-31897
Change-Id: I5fded78cd5c0c2a3a2f4b40128d3668c5720709e
Reviewed-by: David Schulz <david.schulz@qt.io>
Make the qmlls client invalid if it can't find the latest qmlls version
(if there is no qmlls version installed for example).
Task-number: QTCREATORBUG-31897
Change-Id: I74fa72bd2a95126a2a091f88c64dfa60155e4508
Reviewed-by: David Schulz <david.schulz@qt.io>
Add a missing braces to avoid passing import path to qmlls versions that
don't support it.
Task-number: QTCREATORBUG-31897
Change-Id: Ia247ebe34790a2b5cf93ffd6080e0784ee317ee7
Reviewed-by: David Schulz <david.schulz@qt.io>
Add a missing Tr::tr() to make the warning translatable.
Amends c783ac4f81.
Task-number: QTCREATORBUG-31897
Change-Id: Iaf86dbae222fc355ba78b5c7637c3f319634a810
Reviewed-by: David Schulz <david.schulz@qt.io>
The variations were renamed in Figma. Follow suit here in order to stay
aligned.
Change-Id: I797e00a3dfcdee4302e8b0b06d13392a1c0979bd
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
The components partially looked enabled while being disabled.
Fixes: QTCREATORBUG-32281
Change-Id: Ifa267e8bc9bc77c4a38a214acf71530f2122425a
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Avoid returning the same BaseSettings* multiple times in the list
returned by sortedSettingsForDocument(). This leads to duplicate work
later on.
Amends 2e96194681.
Change-Id: I27e530a8cdd1cd13153236a651636511b2f0603d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Some source were not used anymore and others were not listed in
CMakelists.txt.
Change-Id: Icfb6ef4302fb0cd712ab6db46e982e0fb2596310
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Add the import paths used by the old codemodel to qmlls via "-I"
commandline parameter. This includes import paths passed from the
QML_IMPORT_PATH CMake variable.
The downside of passing the import paths as commandline parameters to
qmlls is that all QML module end up using the same import path. In
general, this is not the case, QML Modules with "DEPENDENCIES TARGET" or
"IMPORT_PATH" in their qt_add_qml_module()-call might have extra import
paths that other modules don't have.
An example for this is a QML Module linking to another static QML
module. It builds fine but qmlls can't find the static QML module
if its outside the Qml import path.
This scenario works fine when using QT_QML_GENERATE_QMLLS_INI.
Add a manual test project with such a QML_IMPORT_PATH CMake variable,
where qmlls should not warn about importing MyModule in Main.qml.
Task-number: QTCREATORBUG-31897
Change-Id: Ic4c048dfdacfc2de11db8973dcbdca83989af320
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Warn the user that qmlls can't start when using an invalid Qt kit,
instead of trying to start an empty CommandLine.
Task-number: QTCREATORBUG-31897
Change-Id: I7bb7a473b1ffad34dd6c77a23fd700d829ea2216
Reviewed-by: David Schulz <david.schulz@qt.io>
Add a method to BaseSettings that allow language clients to tell whether
they can be used on a certain project. This allows BaseSettings to be
disabled on certain projects, for example qmlls can't be enabled on a
project that has an invalid Qt version.
Task-number: QTCREATORBUG-31897
Change-Id: Id8d6c05bc31c8596f685852ff20179d7f728feda
Reviewed-by: David Schulz <david.schulz@qt.io>
The OS specific handling of light/dark system theming in Qt Creator was
implemented by passing around bool values. Qt 6.5 comes with a new enum
Qt::ColorScheme and respecive themeing API.
This change replaces some of the legacy code with the new Qt API.
"System Information" displays the color schemes of the current theme and
the one of the system.
Change-Id: Id39af399dd54ea239bd750c45ea74a48be5efbd2
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Amends d7f44cdd24
By having CMAKE_COLOR_DIAGNOSTICS in initial parameters we make sure
that imported projects will not get rebuild.
Having CMAKE_COLOR_DIAGNOSTICS as an environment variable will cause
CMake to set CMAKE_COLOR_DIAGNOSTICS as parameter, and in combination
with CLICOLOR_FORCE would cause on gcc/clang the modification of the
compiler command lines.
See https://cmake.org/cmake/help/latest/variable/
CMAKE_COLOR_DIAGNOSTICS.html for details.
Fixes: QTCREATORBUG-32196
Change-Id: Ia5aa72695ecf7b605bc99caf5b46b2d2f9c6ed20
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
In particular, include <QRect> in the header, as moc needs the complete
definition of Q_INVOKABLE return types.
Change-Id: Ied1b0df4b32d4a1f6fe37f672deca80976ab00f3
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Otherwise, remote Linux paths are displayed with backslashes on Windows.
Change-Id: I2c918364200a3420836328ee3d81a4bbd32bbc90
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
These are the widgets at the bottom of the run config settings that
share the ability to switch between a global and per-target setting.
There is nothing inherently debugger specific here, except for the
common history.
Change-Id: I4c57c138bb05c2a505f1bac13161352417bd8fe4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
