We give the implementors of the IDevice subclasses a litte more freedom
by not assuming a modal dialog.
Change-Id: I629a3ab7fc50a73229e6439af53f1bae0cf0259e
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
We had a mixed style until now (mostly using const refs). Use value
semantics everywhere for consistency and hope that the class never gets
heavier.
Change-Id: Ic9536f87b01a76252bd8643c8681b3dc9067a266
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
Now that we have a polymorphic device class, we don't need to
attach all the virtual functions to the factory anymore.
In addition, the isUserEditable() function is gone, because it is
no longer needed in the presence of device-specific widgets.
Change-Id: Ie8f0be95653cb83e1618885b08cdd2aacf5dda59
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
The current implementation "forgets" auto-detected devices when
they've been disconnected or Creator has been closed.
This has the drawback that potential changes by users to the connection
parameters cannot become persistent. This is overcome by introducing a
device fingerprint and keeping removed auto-connected devices in a
special list from which they can later be retrieved, typically when the
device gets connected again.
Change-Id: I98cfd25c677e6a2a46891a0facf3a28f0a0c3465
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@nokia.com>
The idea is that all kinds of devices inherit from one abstract
base class and that they are all managed by one device manager,
who does not know about their specifics.
For now, the only concrete subclass is the LinuxDeviceConguration.
Change-Id: I31ff5586a0fdd6bcf8dcc0554bb2b91fe65b2f3f
Reviewed-by: Kai Koehne <kai.koehne@nokia.com>
- Introduce clone() method.
- Rename "osType" to "type" and "deviceType" to "machineType".
- Move machine type display out of generic settings widget.
- Put only immutable attributes into the device constructor and set the
others via setters. As part of this, also give the
SshConnectionParameters a default proxy type. The necessity to give one
to the constructor explicitly was for historical reasons.
Change-Id: I84757b1b2d6371544b9ab1f3290973e5498176ce
Reviewed-by: Kai Koehne <kai.koehne@nokia.com>
One more step towards extracting an abstract base device class.
Note that the device settings now go into a dedicated file, like
the Qt version and toolchain information, and no longer into the
QtCreator.ini file. Reading the "old style" settings is still
supported.
Change-Id: Ic4766420930c1ab650d72068d3f6d188aa9c203b
Reviewed-by: Kai Koehne <kai.koehne@nokia.com>
The information about which device is the default one is by definition
"global" and therefore does not belong into the device configurations
themselves.
Change-Id: Ib7349aac4663a674fac5bf35c4d128aeb53fbec2
Reviewed-by: Kai Koehne <kai.koehne@nokia.com>
We will soon have non-Linux devices in there as well. Consequently, the
whole device configuration infrastructure should be refactored and a
base class be moved to the core plugin in a follow-up commit.
Change-Id: I35cfa9e020dd42856fd3c25308cdff7a65d3887b
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
The LinuxConfigFactory has now a new pure virtual method to create the widget for
the device specific settings. It allows new device to create their own settings page.
Change-Id: Ie14df043fdef088b0e6e3b1e08b5d0d1863f76e5
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
Getting the #include directives ready for Qt5. This includes the
new-project wizards.
Change-Id: Ia9261f1e8faec06b9285b694d2b7e9a095978d2b
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
Can be used by specialized plugins to store additional information.
Change-Id: I28cd28920aab9f0029a192f58437467fcf7ea395
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
We use displayName for user visible names everywhere, so we should
also do that here.
Change-Id: I3d976c06fa04733ff82ea208efc0a17f86cc0d79
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
Specialized plug-ins might want to manipulate the device list
themselves, e.g. to add auto-detected devices.
Change-Id: I29b9bfd70c03bc83be86fc55c2023aed90f8ed62
Reviewed-on: http://codereview.qt.nokia.com/2944
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
Mostly Q_DISABLE_COPY that were covered by the un-copy-ability of the
respective base classes. Includes a few "stylistic" whitespace changes.
Change-Id: I31ca0e7bada5ed0f34776976efe22ddc444a5bf2
Reviewed-on: http://codereview.qt.nokia.com/1609
Reviewed-by: hjk <qthjk@ovi.com>
- Make key deployment a device type dependent action.
- Split up monolithic device configuration wizard.
- Split up run configurations, run controls and the associated
factories.
Change-Id: Ib2ef9d405e6b7eaae89fc27c56e3c327829a88f7
Reviewed-on: http://codereview.qt.nokia.com/486
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
The list of per-device actions now comes from a factory and can
be different for different OS types.
This is a step towards moving knowledge about devices from the
RemoteLinux plugin into specialized plugins.
Change-Id: Ia46e0199d8d8c1a3891c73a4936ac53fb1063313
Reviewed-on: http://codereview.qt.nokia.com/439
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
Other plugins are expected to build on the RemoteLinux infrastructure
in the future, providing OS types of their own. A string-based
identifier is much better suited for that than the currently used
enum approach.
Change-Id: I702a1ed7628d908d9c68ae0910ad1a6f1b92786f
Reviewed-on: http://codereview.qt.nokia.com/357
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
This is needed in the short term to reverse the direction of
the dependency between this plugin and the analyzer.
It is expected that there'll be more users in the future.
Change-Id: I9603e8dfa70e442394ba5e8671c6353b65c46374
Reviewed-on: http://codereview.qt.nokia.com/266
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
