It looks very much as though the original author simply forgot to add
that return statement.
Fixes: QTCREATORBUG-23881
Change-Id: Ie93d2451bf1b491d01137285f983d657133c81c3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Single chunks exceeding the limit were truncated and then shown
in a single line, potentially resulting in only a few chars if there
was a newline close to the cut-off point.
Now, don't restrict to a single line in that csae.
Additionally elide in the middle, assuming this is a better compromise
than truncating at either end.
Also, make the truncation more obvious, and mention the amount of
elided characters.
Change-Id: I850e2833e7f1f8be0f584d8e4439dd1a64f851d0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The youtube video demonstrates how
to develop your first app on NXP
i.MX RT1050 device.
Change-Id: Ie706a6ff6a5395816a5ec9daef13c0baad1daf2d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
We did not notice because the JS array was auto-converted into a string.
Amends bcc2b5e08d.
Change-Id: I06ee43f78cb3081bdff0a02f8d446326a01bc2d1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
On Linux and macOS, clazy-standalone links against some dynamic
libraries which we need to ship.
Fixes: QTCREATORBUG-24344
Change-Id: I4946d2ae22fc9363445e6a3eecb8d9e40be5ef0e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
... between semantic re-highlighting and document visibility update.
Make semanticRehighlight() a no-op if the document is not currently
visible, and call it explicitly on an editor change.
Fixes: QTCREATORBUG-24290
Change-Id: Ife61f61d3fb82e8b283bf93ab77d16517f6c6f9c
Reviewed-by: David Schulz <david.schulz@qt.io>
This interferes with the general theming of the output pane
and the purpose is no more obvious.
This patch fixes using a wrong scrollbar style on the
QML Debugger Console.
Change-Id: I4dfeecb77746b345f35809dd5e1bcb27a0fcd604
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
Reviewed-by: hjk <hjk@qt.io>
We may add items that have sub-items already, so apply
the expansion to them as well if necessary.
Change-Id: Ibff4433c5a7c0a110461e46998cd39864f4ec929
Reviewed-by: David Schulz <david.schulz@qt.io>
This triggered a soft assert in DebuggerEngine::showMessage()
and cleaning up the status bar is not necessary at all.
Change-Id: I12d3d5cbc79f178af58ecb0a5c7a3130c880bdad
Reviewed-by: hjk <hjk@qt.io>
Otherwise search results in modified files will get wrong line texts.
Change-Id: I7be4b27ebc5b250da3a3a0050de8646bcfcd010b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Since collecting the qml stack relies on calling functions it has a high
risk of getting stuck in that call at least with Qt 5.15. Never the less
I added the correct function in the cdbextension so when the action
get's re-enabled in the future we already start with an updated
extension.
Task-number: QTCREATORBUG-22209
Change-Id: I535f8db5a64ae48b4163d9b67e133cc3de338432
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Avoid calling PyValue::childCount as it expands the values in front of the
partial variable recursively. This outdates scopeEnd as it is fetched
before the items are expanded, which again results in a too early return
from that function.
Fixes: QTCREATORBUG-24108
Change-Id: I0848cde88c6ff8019a4ab22ac1153598c20e563d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Show iOS device name, identifier, OS version and cpu architecture.
Task-number: QTCREATORBUG-23016
Change-Id: I5fff2986a173800dabc585f17830cc242e436457
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
We need to pass the path to the device symbols, that Xcode downloaded
for the device's OS version, as the sysroot to the debugger. Otherwise
debugger startup is very slow.
We already tried to do that, but it looks like, depending on the
devices, this path can contain an architecture specific part, e.g.
"iOS DeviceSupport/13.5.1 (17F80) arm64e" instead of just "iOS
DeviceSupport/13.5.1 (17F80)". It can still be just the latter, so we
get the devices architecture information, try the architecture specific
directory first, and fall back to the architecture agnostic name as
before if the former doesn't exist.
Fixes: QTCREATORBUG-21682
Change-Id: I2efdbfda0282f1cf0f8d10bd4e5217a298027fcf
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The function took a const reference to a std::function. When passing
some other callable object, this leads to a copy, which is bad if the
callable is supposed to carry along state.
Change-Id: Iedc22644fb0f314b15de0eaaa7c0b2e73dd30f38
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
Make it easier to switch between projects and restore
the former check states of the found test items if
we have these information.
Change-Id: I99a5357388c36aa8cce6f5f82184d6ab2a8bf6e8
Reviewed-by: David Schulz <david.schulz@qt.io>
* Move the zoom all and zoom selection button to the FormEditorWidget
taskbar
* Add zoom in and zoom out actions/buttons
* Fix ZoomAction in and out direction
* Add update icon font
Change-Id: I9addba5652cafa5884450bc633a1e16087aae8dd
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
* Add a change type name dialog showing all incompatible properties
* Fix ExpressionTextField triggering twice on pressing enter
* Fix compare operator
Task-number: QDS-1946
Change-Id: Ic384f6dcce44297b43839c17874108b39af909da
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Ensure all possible project parts are taken into account
when gathering build system targets.
When having multiple possible build system targets for a
test - which may easily happen e.g. when defining tests
beside the main application inside a big top-level
CMakeLists.txt - let the user decide which one to run.
Fixes: QTCREATORBUG-24268
Change-Id: Ia7b7e4148fe8e8dab55832c435f12cc78f5c2f7a
Reviewed-by: David Schulz <david.schulz@qt.io>
The text layout must get recalculated also when the width
of the underlying model index has changed.
Fixes: QTCREATORBUG-24236
Change-Id: I4ded56832c765320b6845cf35ad61453875dad50
Reviewed-by: David Schulz <david.schulz@qt.io>
Prevent mingw from trying to #include_next a private header from a path
we cannot add to our list of includes.
Fixes: QTCREATORBUG-24251
Task-number: QTCREATORBUG-24027
Change-Id: I18a9db130b9c2265cd208c3506d08d2e1c4cee45
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
This is not required and looks ugly.
Change-Id: Id0e5adabaff2cd16fb8e457e93a2ee71fb323416
Reviewed-by: Aleksei German <aleksei.german@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
contains() expects a regular expression as value, so using
a bare windows path may be a bad idea.
Beside this fix the LLVM_INCLUDEPATH which is reported wrong
already by llvm-config.
Change-Id: I95aa3e461541099aac6607c4a8db8a38f9b2b0f6
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Apparently, the MSVC linker gets confused if an input library
("clangFormat.lib") has the (almost) same file name as an output library
("ClangFormat.lib"), even though the latter is specified with an
absolute path.
Change-Id: Ia76e60fd10e16ce8daff880f4005d40d7f20d08c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
D clashes with "Datei".
E clashes with "Erstellen".
B clashes with "Bearbeiten".
U clashes with "Auswahl in Kleinschreibung wandeln".
G clashes with git shortcuts
Change-Id: I2d13eb45f73847526b896420510bdba196949787
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
We override the Q_PROPERTY macro in our own header. This appears to have
two effects:
1) The macro arguments are properly highlighted.
2) There is no completion from libclang for Q_PROPERTY, meaning our
own helpful snippet is the only completion candidate.
I don't understand the reason for either of these; they seem to be more
or less random effects of parsing peculiarities.
As it turns out, our macro redefinition breaks if the type of the
property is based on a template class, leading to false errors in the
code model. Removing our macro redefinition fixes the code model, but
also removes the aforementioned effects. Turning the macro into a
variadic macro fixes the code model and keeps effect 1), but not effect
2). Therefore, we also update the snippet to provide an extra string
that makes it clear this it's a helpful snippt, rather than just a
normal completion.
Fixes: QTCREATORBUG-24243
Change-Id: I4044d5e633af3ebdba36032d5efd3333b5a36214
Reviewed-by: David Schulz <david.schulz@qt.io>
