Commit Graph

6116 Commits

Author SHA1 Message Date
Christian Kandeler
3d718d3dae qbs build: Fix valgrind test failure
Change-Id: I563d9b61e0e281058dac46ed913b3102f70c4d90
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-27 14:25:07 +00:00
Christian Kandeler
e34ff64196 qbs build: Add convenience properties for sanitizers
Change-Id: I8c0908ed482127712c1cf4052d7b792be5ba79ae
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-27 13:56:34 +00:00
Christian Kandeler
b484d770cd QML code model test: Show unexpected messages
The failure output is not very helpful without them.

Change-Id: I827876336c3ffdebb0b071f6d1a743c6766d92fb
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-24 11:01:43 +00:00
Cristian Adam
3b8f51391b UnitTests: Re-enable CMake unittests
Ammeds 327bec26bf

Change-Id: I34b62532da424b3b4fb0290049150f6ba444283b
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-07-24 10:05:45 +00:00
hjk
13d0930575 Debugger: Fix QVariant2 autotest
Amends eb52982c9d.

Change-Id: I8ca2e2b03d0d5755c97523292fa6b4fbe0882cb7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-24 08:15:47 +00:00
Christian Stenger
e17ebc7a6e Squish: Stabilize menuVisibleAtEditor() even more
If the machine fails to correctly initialize the desktop
environment we end up with a rather small resolution which
in turn makes the condition useless.

Change-Id: Idcea7f4e2a5dd265442b5c9d98bf42ed7f01c8af
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
2020-07-22 10:24:11 +00:00
Robert Loehning
05cdce2fc9 Squish: Update expected completion proposal
Change-Id: I89f44690bdda5a12776f39efb7b1872ff5e9cc93
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-21 10:03:23 +00:00
Christian Stenger
eb52982c9d Tests: Replace QRegExp by QRegularExpression
Task-number: QTCREATORBUG-24098
Change-Id: I8649423fc69faadad324bc3bb51004633fa7cc4d
Reviewed-by: hjk <hjk@qt.io>
2020-07-20 10:22:56 +00:00
Christian Kandeler
fed5a85110 Debugger: Remove name demangler
Never been used, completely outdated, fails autotest.

Change-Id: I2c1808b4a66e9abdb839670eeae3e5226c7246ba
Reviewed-by: hjk <hjk@qt.io>
2020-07-20 08:34:52 +00:00
hjk
4eaacced6d Debugger: Fix QV4 dumper test name
Change-Id: I561e088c7b789903b0fb6867a2a2b5edf8eef63f
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-07-17 04:59:26 +00:00
Christian Kandeler
56de884159 unittest: Fix build
Amends 2915ee0832.

Change-Id: Iea6c76d33046e9c671a9bfb71ad752b1f2501ec4
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-07-13 11:23:50 +00:00
Christian Kandeler
4aba3da7bd CompilationDatabase: Fix unit test
Amends be97943372.

Change-Id: Ic840f5eca8a83b5bdf3e3864e8859234472911b7
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2020-07-10 12:57:45 +00:00
Eike Ziller
d400dce35d Require GCC 7 and enable C++17
Fix MSVC2019
- result type of conditional expression is ambiguous:
  types 'const char [1]' and 'QByteArray' can be converted
  to multiple common types

Fix MinGW 8.1
- undefined reference to SemanticHighlightNotification::methodName

Fix Utils::transform with std::vector for GCC & MSVC

Unfortunately we cannot get rid of the special variant and optional
implementations, because Apple Clang requires deployment target >= 10.14
for the functions that can throw std::bad_optional_access.

Fixes: QTCREATORBUG-20520
Change-Id: I5c36a70f21f8b0215d2f4fc5c0653a022778d928
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-07-10 11:52:24 +00:00
Eike Ziller
10fd921e26 Merge remote-tracking branch 'origin/4.13'
Change-Id: I4240608a7a0529bb2f6612ba84abae46166458f5
2020-07-10 08:02:27 +02:00
Christian Kandeler
782ca5d8d8 Clang: Fix error when including float.h with mingw
Prevent mingw from trying to #include_next a private header from a path
we cannot add to our list of includes.

Fixes: QTCREATORBUG-24251
Task-number: QTCREATORBUG-24027
Change-Id: I18a9db130b9c2265cd208c3506d08d2e1c4cee45
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
2020-07-09 17:24:16 +00:00
Marco Bubke
b73ce9eccf QmlDesigner: Add row move up and move down buttons
Task-number: QDS-2294
Change-Id: Ia1e64d0811f55151dfe529db4868821840a8fba9
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-07-08 09:17:41 +00:00
Marco Bubke
7504c966bf QmlDesigner: Move code from list editor dialog to model
And add tests to the code.

Change-Id: I9fb183729c716a50bbab861d207a212ff704ee7b
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-07-08 09:17:26 +00:00
Eike Ziller
770b07f71c Merge remote-tracking branch 'origin/4.13'
Change-Id: I0125351c7c6fa33f9fc7171469493e4fa53e87c4
2020-07-06 16:43:39 +02:00
The Qt Project
5671b3a7be Merge "Merge remote-tracking branch 'origin/4.12' into 4.13" into 4.13 2020-07-06 14:24:55 +00:00
Eike Ziller
b18711da91 Merge remote-tracking branch 'origin/4.12' into 4.13
Conflicts:
	share/qtcreator/debugger/lldbbridge.py

Change-Id: Ia444f6424fb35b9a539e157afcee868161535272
2020-07-06 16:23:13 +02:00
Christian Kandeler
8bc01aee75 qbs build: Fix sdktool autotest
Change-Id: I069d9b3eaea295efa8d78d4d96b52b61cecbb783
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-06 14:10:46 +00:00
hjk
20be1f5ddf Debugger: Set WITH_DEBUGGER_DUMPERS to ON by default
The option went in with the initial CMale port, presumably because
the test itself created and compile qmake projects at the time.

I do not think it makes sense to leave out existing tests by default,
even if they run for some time.

Change-Id: I7ff055a2a432b9d8f6af16f7da63ebc56995c31e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-07-06 11:15:34 +00:00
hjk
e1c88116b3 Core/Utils: Migrate further to Utils::Id
The coreplugin/id.h header is kept for downstream for now.

Change-Id: I8c44590f7b988b3770ecdc177c40783e12353e66
(cherry picked from commit 430a33dcd9)
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-07-06 11:15:18 +00:00
Robert Loehning
d35cf4b846 Squish: Stabilize tst_HELP02
Depending on the sizes of the treeview and its contents, the
click might hit the scroll bar and result in a script error.

Change-Id: Ic3658b1f180d1aa5a792d6664d2d7f56d8d0c353
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-06 10:48:25 +00:00
Eike Ziller
1de74cceab Merge remote-tracking branch 'origin/4.13'
Change-Id: I015bac0cccdf466a923c706abdedd8bd8800b0cd
2020-07-06 10:30:54 +02:00
Christian Kandeler
15a1266d50 clangbackend: Do not handle built-in types specially
... when collecing tooltips. The more general functions provide more
information, such as constness.

Fixes: QTCREATORBUG-14950
Change-Id: I6d0a890a695e19e9754b5538ba092a188a3bbbb0
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2020-07-06 06:32:33 +00:00
hjk
a2bf75bb55 Debugger: Add test for char * display
Change-Id: I7319ab6c12aab30e58c5b9fd9223534745fa741c
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-07-06 06:20:18 +00:00
hjk
430a33dcd9 Core/Utils: Migrate further to Utils::Id
The coreplugin/id.h header is kept for downstream for now.

Change-Id: I8c44590f7b988b3770ecdc177c40783e12353e66
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-06 06:07:13 +00:00
Christian Kandeler
4c2938a366 Fix qbs build
Change-Id: Ic19d1f42d98a0bec31f2f5788063f6b2e7d61cef
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-03 14:49:01 +00:00
Robert Loehning
9c7a1577a5 Squish: Don't try to "Save All" when there are no unsaved files
Change-Id: I431c9754d84d36f0c09e45e6c43fe67f173da59f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-02 11:16:09 +00:00
Robert Loehning
ef4bc4432a Squish: Update expected output
Change-Id: If5fdc09ee57ab476e7d434f084fffceb82df23cf
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-02 11:15:40 +00:00
Robert Loehning
cc63b3b47a Squish: Update menu items
Change-Id: Ibbca07fb02092ce829246e99b2365b513b1fa4e0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-02 11:15:13 +00:00
Tim Jenssen
6c59ceb6e0 Merge remote-tracking branch 'origin/qds-1.59' into 4.13
Change-Id: Ia5756102fa014a8376c8b277e9a50a112c594d35
2020-07-02 02:05:28 +02:00
The Qt Project
fa81549844 Merge "Merge remote-tracking branch 'origin/qds-1.59' into 4.13" into 4.13 2020-07-01 16:21:30 +00:00
David Schulz
2915ee0832 Core: remove impractical offset member of text position
It is just accessed when getting the length of multiline ranges and in
that case we can pass the string that range is used on to calculate the
real length.

Change-Id: I3fe95ac0cd4b05a08924a5285a75ebc5eed2423b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-07-01 10:51:44 +00:00
Christian Stenger
f5f684a609 Squish: Fix expectation when canceling a clone
Change-Id: I674324a4a98e4329c4445de69ceddeffba607ff3
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
2020-07-01 09:59:40 +00:00
Marco Bubke
327bec26bf UnitTests: Temporary disable the tests
I added QmlDesigner to the unit tests but I have no clue have this can work
with CMake. We only want some source files and are preloading some other
header.

Change-Id: Iadf8ca09b7e63055d1e2ff231a15ef7be2891204
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-07-01 09:09:57 +00:00
Thomas Hartmann
a97ea2e3b3 QmlDesigner: Fix test build
Change-Id: Ib24054b9caa1a2b1404c8af7af7f85bc3de1e6b2
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-07-01 08:16:36 +00:00
Tim Jenssen
0c6231d7ec Merge remote-tracking branch 'origin/qds-1.59' into 4.13
Conflicts:
	src/tools/clangpchmanagerbackend/source/pchtaskqueue.h

Change-Id: Ibe8ac2fa0eafcbcc86ac445f0be035839e06ff40
2020-07-01 09:40:01 +02:00
Thomas Hartmann
f9df5b445a QmlDesigner: Fix tests
Change-Id: I74442bf004a462d5d310f128b64f8bc82073d822
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-06-30 18:47:17 +00:00
Eike Ziller
6a095d6c9a CMake build: Make option to include dumper tests discoverable
Change-Id: I9828f362561b8392d31a56f8a60fe9531accf4ce
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2020-06-30 11:39:44 +00:00
Eike Ziller
7f44d8582b CMake build: Remove timeout for dumper tests
They take much longer, but are also optional.
Makes it possible to run via e.g. "ctest -V -R tst_debugger_dumpers"

Change-Id: I8bbda6ca36e25cd896b1f3be5d1696a27b8acc53
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-06-30 11:39:24 +00:00
Marco Bubke
1e6807c680 QmlDesigner: Add listmodeleditor
Task-number: QDS-2294
Change-Id: I66cae3a0d4265ab112eaf6b04e3a5972d185ff43
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-06-30 10:28:07 +00:00
Marco Bubke
32e181f5ce ClangRefactoring: Remove not used pch files
Because we use UUID for pch files every time we rebuild a pch we get
a new file. This patch is collecting and removing this pch files.

Change-Id: Ia8688e7215ee7b41f39b2285323eaa345056bda3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-06-30 09:52:50 +00:00
Marco Bubke
c924a45fb2 Refactoring: Fix unit tests
One if the LLVM 10 hot fixes was not working.

Change-Id: I1e6cab39ffd5c52f55fb83ff777f6eca457dea35
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-06-30 09:52:42 +00:00
Marco Bubke
36b72e2bab QmlDesigner: Break dependencies
To get the model under unit tests we have to break every depenedency to
code outside of the unit test scope.

Change-Id: Ib613c3308e48990c55b2ed0cd42bc4b0e1041a01
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-06-30 09:52:34 +00:00
Tim Jenssen
b8cd87dea0 Merge remote-tracking branch 'origin/qds-1.59' into 4.13
Conflicts:
	src/plugins/clangformat/clangformatplugin.cpp
	src/plugins/qmldesigner/designercore/model/qmlitemnode.cpp
	src/plugins/qmldesigner/qmldesigner.qbs

Change-Id: Ie4a0beeb9fd32ac9683f4e8769988a9c3f3e369a
2020-06-26 16:51:22 +02:00
Christian Kandeler
22830fd5e2 Tests: Fix deprecation warning
Task-number: QTCREATORBUG-24098
Change-Id: Icea21e446173537d8fdb8113f1eff7d7176c34b3
Reviewed-by: hjk <hjk@qt.io>
2020-06-26 10:31:18 +00:00
Artur Shepilko
f3c2f68c39 Sqlite: Fix a compiler warning about unhandled switch-case
Change-Id: Id9cb6ebd6db7f718f8aa3e25d56581f953ad182e
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2020-06-24 15:04:20 +00:00
Volodymyr Zibarov
40173ad4ab C++: Fix auto variable resolving for template class constructor call
Code snippet:
template<class T> struct MyStruct { int value; };
int main() {
    auto s = MyStruct<int>();
    s.value;  // "value" is not found
}

This fixes find usages for unique_ptr declared as auto like this:
auto ptr = std::unique_ptr<MyStruct>(new MyStruct());
ptr->value;

Also fixes in-place constructors:
std::unique_ptr<MyStruct>(new MyStruct())->value;

Fixes: QTCREATORBUG-15364
Change-Id: I8d452a77fe85e63665ec8d4c4afbcf8aad063121
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-06-22 14:27:49 +00:00