Commit Graph

61956 Commits

Author SHA1 Message Date
Eike Ziller
e16876df0c Merge remote-tracking branch 'origin/4.11'
Change-Id: Ieb0bb1ebab9a5efb42d15bbeac2cd4c46a6de962
2019-12-18 09:14:14 +01:00
hjk
ef680f547c ProjectExplorer: Remove special handling
... of qmake runconfig's workingdirectory pathchooser base file name.

Even setting a fixed bogus value never shows up in the gui.

Change-Id: If22e2d9bed120717a5980bca11b33503c95b32ba
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-12-18 07:44:01 +00:00
Alessandro Portale
4d3fd8706b Autotest: Use correct Icon for "Run Test Under Cursor" action
The "TOOLBAR" version is too bright and has a shadow (in non-dark
modes).

Change-Id: Ic7e8500fd9ecad4465bf2d9dfba53c0bf6538a66
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-12-18 07:14:01 +00:00
David Schulz
546d4a3b1a WinRT: Move some device detection output into a logging category
This hides the detection failing in the case when no winrtrunner.exe can
be found, which is given as soon as you do not have a UWP Qt installed.
So moving this output to logging category makes it still accessible, but
it doesn't confuse non UWP developer.

Change-Id: Ie1434f75086d435f8f033b58c010e35fe64658b0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-12-18 07:11:53 +00:00
Eike Ziller
6d4223c5d6 Do not show line ending option in read-only editors
This avoids showing the option for example in git log or blame views.
The user also should not be able to actually change the line ending
style of read-only editors.

Fixes: QTCREATORBUG-23276
Change-Id: Ifa5cc9f663539928b4d5422b020e348b439684fa
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Marius Sincovici <smaryus@gmail.com>
2019-12-18 06:42:10 +00:00
Christian Stenger
019e384495 Rename pro file back to its old name
Partially revert for 3edfced05f.

Change-Id: I7eba8d709cf148bcba9c70162cdfc8bfd09375fc
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2019-12-18 06:23:57 +00:00
Alessandro Portale
b7acfc37b5 Android: Remove "qtlive" support
Productization of Qt Live preview for Android didn't happen.

Change-Id: Ie69d8193afec9b59d859bc65c45d36028247e2b9
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2019-12-18 05:46:53 +00:00
Christian Kandeler
290dcb555b LayoutBuilder: Fix assert
Let's add an explicit QLabel in the BaseBoolAspect, as the layout
builder does not expect an empty string in the middle of a row.

Change-Id: I19ef80d31ad1f2527af7e5677751922ae4d5fcff
Reviewed-by: hjk <hjk@qt.io>
2019-12-17 17:22:08 +00:00
hjk
b1474dc5ef ProjectExplorer: Replace RunConfiguration::doAdditionalSetup
... by an explicit update() call. This is what effectively done in
most cases, and should be harmless and reasonably cheap in most other
cases.

Change-Id: I323112ec7cdbccf19050ac54466d8e1d97a0516e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-12-17 16:29:45 +00:00
hjk
23b076fcd0 ProjectExplorer: Remove special initial runconfig default display name
... handling for qbs.

Change-Id: Id07a2cfe7fd46f73605ddd80c4d842ffa9a41f7f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-12-17 15:18:08 +00:00
Alessandro Portale
3edfced05f CMake build system: Add manual tests
With tst_manual_widgets_crumblepath as first candidate.

Change-Id: If66b53a459865903b2028966ac2d6d9357356aed
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2019-12-17 14:59:20 +00:00
Tim Jenssen
ba7545f2ff fix missing comma in source include patterns
Task-number: QDS-1403
Change-Id: I907462f0978c1610ba2e7af10f386380f8ea18c7
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2019-12-17 13:33:35 +00:00
Andre Hartmann
6d0336f223 CheckableMessageBox: Forbid focus for text and pixmap
That allows changing between the buttons with the
cursor Left and Right keys, without loosing focus
from one of the buttons.

Before, that was impossible without intermediate
tab key pressing. E.g. when pressing Ctrl+W
to close the git commit editor, the focus was
outside the buttons. To select one of them,
Tab had to be pressed first, but after some
Key Right presses, the focus got away from the
buttons again and the game had to be repeated.

That behavior was different from QMessageBox,
where one of the buttons always has focus.

Change-Id: I9b12f794e8ba4aef1a68aaf249ba6dd6789cae4d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
qds/v1.4.0-rc2
2019-12-17 13:33:03 +00:00
Eike Ziller
17f47d6fa4 UpdateInfo: Do not show multiple update notfications
Remove existing notification before showing a new one.
Otherwise checking for updates multiple times results in multiple
stacked notifications.

Change-Id: I1af07c005e88b297fbaebec7f5358fa46c09a84c
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-12-17 13:10:35 +00:00
Christian Kandeler
141d5e2412 Fix build with namespaced Qt
Fixes: QTCREATORBUG-23368
Change-Id: I3887b08587becd46bc203bb0bc4069521247498f
Reviewed-by: hjk <hjk@qt.io>
2019-12-17 10:51:10 +00:00
Thomas Hartmann
166afd6521 QmlDesigner: Increase the puppet timeout to 30s
The puppet timeout creates issues with the 3D view.
At the moment we do not know any case in which the puppet
timeout is strictly required.
Increasing the timeout to 30s should be safe.
In the worst case users have to add the option to reduce
the timeout again.

Change-Id: I3a4b2b145f42b3fcabfdfaa97bc23ae10d6c1648
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-12-17 10:14:19 +00:00
Thomas Hartmann
2f2787c4a8 QmlDesigner: Add workaround for QVector3D
For some reason the Qt meta system does not work reliable
for QVector3D. It does work "rotation", but not for "pivot",
despite the fact that both properties are defined in exactly the
same way.
This patch works around the main issue.
There are still a few issues left, but at least the default is
correct now.

Task-number: QDS-1355
Change-Id: I75e2d3adff6967e89c6ce031d744baa12b5e8061
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-12-17 10:08:00 +00:00
Mahmoud Badri
e5d4224fe4 Prevent the Edit View 3D restart upon closing
Also the 2D/3D action updates correctly according to Edit View 3D state.

Task-number: QDS-1385
Change-Id: I95d0994e9c56df25a2988eb9d27994268dd1903d
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-12-17 09:48:05 +00:00
Christian Kandeler
77126dc4b8 QmakeProjectManager: Extend Qt examples deployment hack
E.g. for Qnx, QT_INSTALL_PREFIX is not a prefix of QT_INSTALL_EXAMPLES.

Fixes: QTCREATORBUG-22592
Change-Id: I3092cd76af01519783e1162ab8e79caaf0836f00
Reviewed-by: hjk <hjk@qt.io>
2019-12-17 09:42:40 +00:00
Tim Jenssen
be9cad77d2 Add another QDS doc image file path
Task-number: QDS-1403
Change-Id: I104480405033838a565f5a596ab43404db5f40dc
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-12-17 09:39:07 +00:00
hjk
88b037a600 iOS: Call deviceTypeAspect->update from any update
While triggering unncessarily in some cases now, the function
is cheap and moving the call out of the way will allow for
removing RunConfiguration::doAdditionalSetup() later.

Change-Id: I06961ca43e6e56ebd16bf3c04e8ce0a4478494ba
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-12-17 09:00:11 +00:00
hjk
0cdea40606 Debugger: Fix std::string dumper for GCC 9
Fixes: QTCREATORBUG-22753
Fixes: QTCREATORBUG-22680
Change-Id: I75e2855d27bc2b83880379fee2364586b9d4a90e
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-12-17 08:44:14 +00:00
hjk
466764146c Debugger: Rename some GdbServer* to DebugServer*
This is mimicking a bit what has been done on the baremetal side,
and is formally more correct when the gdbserver is not a real
gdbserver, but e.g. a probe speaking the gdb remote protocol.

Change-Id: I1b42624b94071b34c009bd0650095792a5b2fcb7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-12-17 08:23:06 +00:00
Christian Stenger
e3338f2e8a Debugger: Avoid accessing nullptr
If the context menu is spawned while stepping
the user may be able to trigger some actions
that try to access an item that had been present
before, but after the stepping the items inside
the tree view usually got completely re-created.

Change-Id: I80029bc1272cfc8b78fe0ed5b1e0f36f29920631
Reviewed-by: hjk <hjk@qt.io>
2019-12-17 08:10:03 +00:00
The Qt Project
13b64f3735 Merge "Merge remote-tracking branch 'origin/4.11'" 2019-12-17 07:22:13 +00:00
Eike Ziller
267946d100 Merge remote-tracking branch 'origin/4.11'
Conflicts:
	cmake/QtCreatorIDEBranding.cmake
	qbs/modules/qtc/qtc.qbs
	qtcreator_ide_branding.pri
	src/plugins/boot2qt/qdbrunconfiguration.cpp
	src/plugins/boot2qt/qdbrunconfiguration.h
	src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp
	src/plugins/qnx/qnxrunconfiguration.cpp
	src/plugins/remotelinux/remotelinuxrunconfiguration.h

Change-Id: I17c8e1bf300bb75d7317ccf7749dd3cc07709c21
2019-12-16 16:19:44 +01:00
Christian Kandeler
9feabb7ba3 QmakeKitAspect: Leave the toolchains alone
The QmakeKitAspect's purpose is to let the user force a specific mkspec
when building with qmake. It is unexpected that it silently changes the
kit's toolchains.
The code that automatically sets up a Qt version for a given toolchain
already exists in QtKitAspect and appears to work just fine these days.

Fixes: QTCREATORBUG-23191
Change-Id: I2727a4faa2285738d0e81e8558ca02e97ef319d3
Reviewed-by: hjk <hjk@qt.io>
2019-12-16 15:15:38 +00:00
hjk
9c5798fec9 BareMetal: Centralize IDebugServerProviderFactory::canRestore()
All re-implementations are effectively the same.

Change-Id: I580be05f8b9dea963b472dccf82b3aa8c9305807
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-12-16 14:37:59 +00:00
hjk
78c126bff2 BareMetal: Centralize IDebugServerProviderFactory::restore()
With the new m_creator() all re-implementations are effectively the same.

Change-Id: I714b5022d7aded5ea1992058ab7db8aa4d8a9a65
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-12-16 14:37:34 +00:00
hjk
5ebeff642a BareMetal: De-virtualize IDebugServerProviderFactory::create()
Change-Id: I09a1953cf542f6c2cd68d05bb0f171b327d56cae
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-12-16 14:36:24 +00:00
Andre Hartmann
7e4cd9b368 FancyLineEdit: Fix camel case navigation with shift modifier
Fixes: QTCREATORBUG-23370
Change-Id: Ie96f642f0b964499ded830ae6eabfc86ef31fabd
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-12-16 14:05:42 +00:00
Eike Ziller
0d005b7057 Version bump to 4.11.1
Change-Id: I31c53f92acd02c380e44ecea534b178a3fb5458c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-12-16 12:20:53 +00:00
hjk
78a5b42942 FakeVim: Fix goto next/previous split
Fixes: QTCREATORBUG-22397
Change-Id: Ibdae1d53d9d77dd982b871aa22585bdf0354d84f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-12-16 11:32:58 +00:00
Eike Ziller
3dfa188182 Help: Add option to only register highest versioned Qt documentation
In Options > Kits > Qt Versions. And make it the default.
It registers each documentation file only for the highest registered Qt
version. If you have Qt 5.12 and Qt 5.13 registered, but only installed
QtWebEngine for Qt 5.12, you'll get QtWebEngine documentation for Qt
5.12, but the other documentation is from Qt 5.13.
That is usually sufficient, since the documentation still contains "old"
API, and new API is flagged with "since".

This avoids registering a lot of documentation, which creates a startup
performance issue, and also leads to usually unneeded popups for which
Qt version some documentation should be shown.

The option also allows going back to registering all documentation,
and no Qt documentation at all.

Fixes: QTCREATORBUG-21482
Fixes: QTCREATORBUG-22799
Task-number: QTCREATORBUG-10004
Change-Id: I1c7bc73982d48d8e53f5083e2fa851b6c5f60f80
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-12-16 11:03:31 +00:00
Aleksei German
ec43ac0481 QmlDesigner Connection View signals fixes
Bug: QDS-1333
Change-Id: Ic0d4206888bd8c5bd3d5cef29225441f19efa59d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-12-16 09:16:07 +00:00
Tim Jenssen
f265257d55 QmlProject: use qobject_cast instead of static_cast
Change-Id: I0a75c18eec64404b8689ad27ad35a8d65d69711f
Reviewed-by: hjk <hjk@qt.io>
2019-12-16 09:08:03 +00:00
Christian Stenger
6b492866af QmlJS: Add check for duplicated import
Add a soft check for duplicated Qml/JS imports which
adds a warning when a file contains imports that
duplicate the same URI / version or file path.

Change-Id: Ib9a1f8a90dd3cf469d90e83abc1d748901b1e353
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2019-12-16 06:28:20 +00:00
Christian Stenger
a57bfda5d8 AutoTest: Handle gtest internal logging
One may use gtest internal logging inside the tests.
Handle its output correctly if needed.

Fixes: QTCREATORBUG-23354
Change-Id: If7b56b7eddf266600dcd815a145cf3b29f8581b3
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-12-16 06:27:57 +00:00
Christian Stenger
e87088f3e9 AutoTest: Add error as test result type
Task-number: QTCREATORBUG-23354
Change-Id: Iaeabfc6eedf18c52dc9bdc59833e213a09458617
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-12-16 06:27:48 +00:00
Cristian Adam
5675169e56 CppTools: Suppress the c++98-compatibility warnings
Fixes: QTCREATORBUG-23118
Change-Id: I3c29faa05cb77841b22201dce01b341e565ca32d
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2019-12-13 14:45:48 +00:00
Miikka Heikkinen
82f2667ab3 QmlDesigner: Fix minor edit 3D view ui issues in mac
Change-Id: Ia86b5f828d147ca0c3593da7f7dcb77696fdeead
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-12-13 14:44:23 +00:00
Mahmoud Badri
f97de35dd4 Improve edit view 3D "on top" logic
- Proxy dialog removed
- When the QDS window is minimized/maximized, the edit view 3D follows.
  The opposite is not true (edit view 3D can be minimized separately).
- Edit view 3D is always on top of QDS window. Only exception is when
  a popup is shown (so that the user can handle the popup).
- External apps go normally on top of the edit view 3D.

Known (non critical) issues:
- Activating the edit view 3D doesn't raise() the QDS window, so if an
external app is on top of the edit view 3D then the view is clicked,
the external app will be in between the view and the QDS window.
- Closing the edit view 3D from the x button doesnt work (causes a
  restart). This is not in the scope of this commit.

Task-number: QDS-1179
Change-Id: I1dd72590037be295b94735de96772307ba14c59c
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
qds/v1.4.0-rc1
2019-12-13 12:40:43 +00:00
Christian Kandeler
c2bfdff70b WebAssembly: Ensure that the device is created after the kits are loaded
That way, the device of the WebAssembly Kit is correctly set if device
type and device of the kit were previously wrong.

Task-number: QTCREATORBUG-23360
Change-Id: I40b6650ede2e632fe5cc7cb27b576de8d1bfd066
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2019-12-13 09:29:05 +00:00
Miikka Heikkinen
49da199b10 Fix rotation resulting in NaN angle sometimes
Change-Id: I88f866c6649f7ec25bc96a7393d0930685e5382b
Fixes: QDS-1341
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-12-13 09:27:59 +00:00
Miikka Heikkinen
eb09e814db QmlDesigner: Properly update 3D edit view cameras and lights
Now edit view will create and remove cameras and light gizmos properly
when cameras and lights are added or deleted.

Change-Id: I858752c1410f3a40ea2adaf538c281aaee94ec58
Fixes: QDS-1267
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-12-13 09:27:44 +00:00
hjk
4bd26c3e4b Debugger: Add ability to hide view columns
Not perfect, e.g. one would probably expect the items to
appear in the context menu of the header views, too, not
just on the main background of the view, but better than
nothing.

Task-number: QTCREATORBUG-23342
Change-Id: Ifdc44dcfd390112faa7b15bb8a51d809e42d7b29
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-12-13 08:07:31 +00:00
hjk
a1c5ca052b Debugger: Avoid a bogus warning
op.dock can legitimately be valid for 'Raise' operations.

Change-Id: Ic59dbf102302bb3f38da56fb0e8d46f18e26cf8b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-12-13 08:07:06 +00:00
hjk
3690d15965 Core: Fix some 0 as nullptr warnings
Change-Id: Ie8018b72c68bd8e14021bb63140c9e4c0a6deb94
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-12-12 16:45:03 +00:00
Christian Kandeler
6e0d44b0ff ProjectExplorer: Let users provide project-specific environment
Add a new project panel where users can set environment variables for
the current project in all configurations.

Fixes: QTCREATORBUG-21862
Change-Id: Id98c7f1cf579927a8004a63172f193f943556f44
Reviewed-by: hjk <hjk@qt.io>
2019-12-12 16:34:22 +00:00
Tobias Hunger
0dbe6f8e3c CMake: Add heuristics to set "Run in Terminal" flag
For CMake file-api, flag all applications not linking to "QtXGui"
as "Run in Terminal".

Task-number: QTCREATORBUG-21451
Change-Id: I29f086c546d3d8a9f56257e423602f787db42ccd
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2019-12-12 14:55:17 +00:00