Commit Graph

77129 Commits

Author SHA1 Message Date
Christian Kandeler
2f8e962f83 Debugger: Do not force cdb when no toolchain is configured
... in the kit settings widget.

Fixes: QTCREATORBUG-28458
Change-Id: I75907bfeeff56173fb9d92045345ba0ca15584b4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-11-29 12:11:37 +00:00
Miikka Heikkinen
34b966c21d QmlDesigner: Show informative message when texture library is not found
Fixes: QDS-8444
Change-Id: Ief36595fda27b075ef3362d6f393655c56fd9940
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-11-29 12:03:28 +00:00
Miikka Heikkinen
26c1747ae6 QmlDesigner: Fix issues with adding texture as light probe
Changed resolving the currently active scene environment to be done
on demand instead of trying to track it realtime, since resolving it
is relatively cheap operation, so it doesn't cause noticeable delay
at context menu opening. The alternative would be to implement multiple
different notification handlers in ContentLibraryView, which would slow
down all operations and would be much more complex to ensure all edge
cases are covered.

Fixes: QDS-8437
Change-Id: Ib33cd1ad549d836b9d780f9b0f92e70d223e2a25
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-11-29 11:06:54 +00:00
Aleksei German
86ed12e729 QmlDesigner: Add StateGroups to Connections
Task-number: QDS-8027
Change-Id: I72ce5bfd2505269ad750ee5fbd5b13669891290f
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-29 10:54:17 +00:00
Marcus Tillmanns
452e1ca232 Docker: Ensure workdir for processes is reachable
When starting a process, make sure that the working directory is
reachable.

Change-Id: I911239d03afd916411d7fb03da806211349ff7e4
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-11-29 10:03:34 +00:00
Riitta-Leena Miettinen
49546c4f48 Doc: Add M401 and M402 code syntax error and warning messages
Fixes: QTCREATORBUG-28482
Change-Id: I3a8976c0c96c102c9f745a1643d3a02e062658ac
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-29 09:50:58 +00:00
Eike Ziller
c3b05f1ef1 German translation: CMake
Change-Id: Ied82a653d6e1cc6336e501c79728ceb085c7d49d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-29 09:13:57 +00:00
Thomas Hartmann
5705194bc7 QmlDesigner: Fix build for tests
Updating the NodeMetaInfo mock.

Change-Id: Ia3a87095413bb58430d978bb831ed8b808596093
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-11-28 15:56:16 +00:00
Mahmoud Badri
397e5f3022 QmlDesigner: Prevent content lib scroll when context-menu is open
Fixes: QDS-8441
Change-Id: Idfc3400fac43668d14cd5ff85cb42d745ef97dfe
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-11-28 15:42:45 +00:00
Cristian Adam
d852ec53a1 GitHub Actions / COIN: Update Qt to 6.4.0
Amends 169f2c4af6 due to the task
number QTBUG-108593.

Change-Id: Id3ab685632e32fad953d837d2f7ab357b034d739
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-28 13:53:25 +00:00
Henning Gruendl
5b19c034ed QmlDesigner: Remove error states editor
Remove the error "Unable to assign [undefined] to QUrl" thrown by the
states editor.

Change-Id: Ic48deddbe698f161f486003ccaf9eb22d0ee65a9
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-28 11:46:24 +00:00
Henning Gruendl
4b72ac3022 QmlDesigner: Fix states editor dialog not closing
Task-number: QDS-8439
Change-Id: Idf633b345de6e4f124b2f621699615ac6d764ceb
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-28 11:45:57 +00:00
Thomas Hartmann
84104499b7 QmlDesigner: Add missing ItemLibraryItem property
Change-Id: Iab3a50ac67002e4a2f3807ee920bce892cd087cc
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-11-28 11:32:13 +00:00
Christian Kandeler
ed06978830 ClangCodeModel: Switch off clangd persistently
... after failed machine suitability check.

Fixes: QTCREATORBUG-28441
Change-Id: Ic0fb956168204d8023ff96f92ae3fcd7cea8b0e9
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-28 10:43:43 +00:00
Thomas Hartmann
ee10ba1909 QmlDesigner: Add support for tooltip in item library
This allows to define tool tips in the .metainfo files.

Change-Id: I3236c6e9f374a052e99b18d8c3983bfd0f072162
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-11-28 10:35:25 +00:00
Miikka Heikkinen
5544cdc276 QmlDesigner: Don't create duplicate default texture instance
Whenever an operation involving an asset image would result in
creation of a new texture node, it now checks first if
a matching texture node already exists and uses that instead.

Fixes: QDS-8435
Change-Id: I3d091aafcd09afdec897bc4da79789c1d84056e8
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-11-28 10:20:44 +00:00
Henning Gruendl
7d13c82750 QmlDesigner: Expose realValue from SpinBox
Task-number: QDS-8191
Change-Id: I265c4a95e84f6ef10a4c69f9a0089970f16f4bbf
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-28 10:06:25 +00:00
Henning Gruendl
62d86837e9 QmlDesigner: Fix states editor none visual items
When using any none visual item as root (e.g. Window) which don't have
a state property the support for adding a state on the root item needs
to be deactivated otherwise QtDS is crashing. The new states editor was
missing that.
On the other hand the use of StatesGroup with none visual items is
supported.

Change-Id: I194913719a13099ce8ac7cde5f78083ef84dc37f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-28 10:06:08 +00:00
Mahmoud Badri
ea55e01051 QmlDesigner: Focus material browser's sections separately
Focus is shown by a thicker selection border for material and
texture items. Delete shortcut works on the selected focused item.

Fixes: QDS-8401
Change-Id: I1ddbbd595a0da3f0e2b7cf2bb9e611532770bc3c
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-11-28 09:32:58 +00:00
Tim Jenssen
98a40b3690 CMake build: Make errors of execute_process fail the build
Instead of silenty failing and resulting in broken builds/packages.

The property is only available since CMake 3.19, so limit the feature to
that.

Change-Id: I82b06e78540e81a809f7fdfe130648becfc9672e
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-11-28 08:29:42 +00:00
Miikka Heikkinen
ddecd338a8 QmlDesigner: Unify texture image providers
Texture editor, material browser, and UrlChooser all had separate
texture providers that served nearly identical purpose.
Unified all use cases to use same PropertyEditorImageProvider.
This provider is asynchronous, which combined with enabling caching on
Image elements, significantly improves responsiveness of the material
browser UI when there are many textures shown in the browser.

Fixes: QDS-8387
Change-Id: I2888aee2f4320dba9456fa046c9ede319673a3d9
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-11-25 15:31:04 +00:00
Eike Ziller
e24ad7ac55 JSON wizards: Print parsing issues only with -customwizard-verbose
Some wizards will miss required components when corresponding plugins
are disabled. That is fine, and not an error per se. When actually
developing a wizard, these kind of errors should of course be posted,
but that is what -customwizard-verbose is for.

Fixes: QTCREATORBUG-28502
Change-Id: I3647d37ef7ca4dace7592c5443bdd13720290016
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-25 15:04:52 +00:00
Miikka Heikkinen
3a899b34c7 QmlDesigner: Skip imported files that already exist and are the same
When importing files to project, if the target file already exists
and has the same modified timestamp, silently skip copying the file
instead of asking if it should be overwritten.

Fixes: QDS-8402
Change-Id: If963e997c6bcfb3e46db6e74c46081784bdddc7e
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-11-25 14:54:22 +00:00
Miikka Heikkinen
674ad1ead1 QmlDesigner: Fix compiler warnings
Removed unused code.

Change-Id: I40f94b6be1f9a1700c4024e78bae5df67513c839
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-25 14:51:42 +00:00
Christian Stenger
c210ffb2d6 AutoTest: Fix debugging of gtest based tests
Amends 6ae6390661.

Fixes: QTCREATORBUG-28504
Change-Id: I7617b080f4ac872c1f806a8e89fa9084a0ac948f
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-11-25 14:47:25 +00:00
Tim Jenssen
c071547aa5 qmljs: fix warning
Change-Id: I69714d6626d9135c5489258346f79b1c4bfbcd19
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-25 14:47:20 +00:00
Samuel Ghinet
907a64ac32 Fix bug: drag state remain on after dragging asset to texture
Task-number: QDS-8341
Change-Id: If9bc7c0e3f2e017df4fde2cf94e7ffc168644eef
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-11-25 14:27:03 +00:00
Eike Ziller
cb8742ccab Make it possible to select default session from menu
when we are in the limbo state where no session has been loaded, and the
default session has not been explicitly created or loaded yet.

Fixes: QTCREATORBUG-28393
Change-Id: I66d69561e18b5073a477d90c1926074e3cd97cee
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-11-25 12:37:40 +00:00
David Schulz
3cd3bba720 Debugger: update thread selector after setting current thread manually
The issue is only reproducible when interrupting a running inferior with
cdb.

Change-Id: I336413d7f36aad28108623eb1bf8015b42f3dbb4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-25 12:13:45 +00:00
Thomas Hartmann
21c659400a StudioPlugin: Use custom openOpenProjectDialog() to only allow qmlproject
Task-number: QDS-2549
Change-Id: I7393877b5f0306eafc6dbd5b5919e6592e664c16
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2022-11-25 11:59:40 +00:00
Thomas Hartmann
caccbe8377 QmlDesigner: Rename setting to avoid any interference
Rename setting to avoid any interference
with old installations.

Change-Id: Id8cb3ad4a3be6e416c4ad935856c57fc29c07503
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2022-11-25 11:59:25 +00:00
Orgad Shaneh
4225f475a4 FilePath: Do not strip macros when normalizing path
Fixes: QTCREATORBUG-28484
Change-Id: Id6bcd2aef048bd355c196013c54799e4944135bd
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2022-11-25 11:57:04 +00:00
Samuel Ghinet
056165d071 Use double underscores instead of single ones in QML
Also, fixed some QML errors -- they didn't have any real consequence,
so they could be considered warnings. Also, AssetsView._modelIndex()
was being called with two arguments instead of one -- this didn't
result in any warnings.

Change-Id: I08274a49531a4082fa94fb89e4230fdac5b1b658
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-11-25 11:57:02 +00:00
David Schulz
ead1b7aa4a Editor: extend visual whitespace documentation
Tell users where the color of the visual whitespace can be configured.

Task-number: QTCREATORBUG-28501
Change-Id: I9c12cbe9d7be61dd96ad27c1eaa1a2daf69cf31d
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-11-25 11:51:44 +00:00
Samuel Ghinet
afc7cd2c98 QmlDesigner: Use a vertical scrollbar for "Confirm Delete Files"
Also, replaced the widgets code with QML.

Task-number: QDS-8033
Change-Id: I29f4e0bc02294e839e352096c3d4394a764cfe76
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-11-25 11:50:42 +00:00
Mahmoud Badri
6747e666b9 QmlDesigner: Open TextureEditor by double-clicking a texture
Change-Id: I58645f31f244cf4e5909b35f1cae224a55f4e9a4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
2022-11-25 11:02:42 +00:00
Samuel Ghinet
45c7a6b8e6 Implement drag-and-drop from Assets View to Texture Editor
The asset (i.e. image) can now be dragged to the "Source" property of
the Texture Editor.

Task-number: QDS-8341
Change-Id: I2d30bdf245a8328a864c116c727d3faaaad347cc
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-25 10:57:55 +00:00
Christian Kandeler
0f202ea724 ClangCodeModel: Restrict opening non-project files to headers
We cannot tell clangd to opt out of indexing for certain files, so we
must prevent "foreign" sources from ever getting opened, or we will have
strange effects in the case of non-unique symbols.
Note that there are more (upstream) problems in this area, but this
patch limits the damage at least.
Amends 8ad7ab2d2a.

Fixes: QTCREATORBUG-28452
Change-Id: I131be699a35da8eacea6415c630e9012cc905a47
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-11-25 10:21:21 +00:00
Leena Miettinen
1966591c7f Doc: Use fixed links to Qt 5 Graphical Effects
To suppress qdoc errors.

Change-Id: I48556e98c7f58d9f0b59ad47051bf166edf50387
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-25 10:02:52 +00:00
Eike Ziller
a0e74ce3e0 UpdateInfo: Fix wrong properties for progress info
It was no longer showing "No updates found." in the status bar if the
progress details are off, and the progress details were no longer
directly hidden if updates were found.

Amends 93401c9c81

Change-Id: I53c441a990c9cbda1a49969f57eb76128ab020c1
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-11-25 09:40:19 +00:00
Eike Ziller
2605639144 German translation: Clang*
Change-Id: I7712ea38738448d9e017fb805d7adba11ae13c04
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-25 09:39:26 +00:00
Henning Gruendl
3321261cf3 QmlDesigner: Fix DragHandler being disabled
The blockDragHandler property got broken when a menu item triggered a
model reset as the popup close signal wasn't triggered from the delegate
anymore.

Task-number: QDS-8133
Change-Id: If135b12a127f5fea8f3f392e0fd6475c4e188e67
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-25 08:59:30 +00:00
Henning Gruendl
dd2c4cc6ea QmlDesigner: Fix cloning of extended states
* When cloning an extended state add the new state after the extended
  group
* When cloning a state that extends another one also copy the extends
  property
* Fix two "call to a temporary is a no-op" clang warnings

Task-number: QDS-8412
Change-Id: I1e8595ddc69f210a27c04fc91869df3beb4ba980
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-25 08:52:34 +00:00
Henning Gruendl
fd1864d678 QmlDesigner: Fix disappearing plus states editor
* Fix issue the plus (Canvas) in the states editor is not drawn when
  the view was hidden before and comes back on
* Improve paint method

Task-number: QDS-8419
Change-Id: I959b4b6a418deba95380d8f5cafc7af09a0362e8
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-25 08:52:02 +00:00
Henning Gruendl
ccbda4655e QmlDesigner: Fix wrong initial render type quality
Task-number: QDS-8334
Change-Id: I3b79093c67fbde94504277a669448c19911ce97b
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-25 08:51:40 +00:00
Henning Gruendl
2388caa544 QmlDesigner: Fix wrong state group shown
Fix an issue were the wrong state group is shown when switching modes
e.g. Design > Edit > Design. It is caused by the model being attached
and the indices not forwarded to QML.

Task-number: QDS-8418
Change-Id: Ie9a99182b0230757a043397d9b906ba1bb15bed9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-25 08:51:13 +00:00
Tim Jenssen
02c65495d1 Merge remote-tracking branch 'origin/9.0' into qds/dev
Change-Id: I5e66666644fd16de60a0158e5e884706622ae3ba
2022-11-24 19:01:47 +01:00
Christian Kandeler
ea3e227944 CPlusPlus tools: Fix build
Catch up to recent refactorings.

Change-Id: I14e8fa03a50ea4169ccdd41ed0d147d6ecb8af8b
Reviewed-by: hjk <hjk@qt.io>
2022-11-24 15:42:41 +00:00
Eike Ziller
2ff5f18bff Transform doc.qt.io/qt-creator links to internal qthelp links, for links
that are found locally in the documentation. That opens such links in Qt
Creator, instead of in the web, if possible.

Change-Id: I2270c6947db22f4aeb4968bf5b7245de57521c92
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-11-24 15:10:05 +00:00
Eike Ziller
7a2901d502 JSON wizards: Read additional paths from settings
Opens possibilities like the installers writings some.

Change-Id: Ie8c87731fb6bb9c7129032f64878e42e9bcf4cf0
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-11-24 14:03:33 +00:00