Commit Graph

37 Commits

Author SHA1 Message Date
David Schulz
ad703e108b LanguageClient: move current settings to manager
In preparation to have relationship between clients, settings and
project to one another in the manager.

Change-Id: I00ae15abe03c54b4a58e429d67d6ff939662cce6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-04-23 06:44:12 +00:00
Alessandro Portale
da84dd1b6d LanguageClient: Select server entry in settings after "Add"
Indicates what to do after adding a server.

Change-Id: Ia68e2944fa18d031c1b7e2fa93723bd861bfded9
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-04-11 13:26:29 +00:00
David Schulz
d1fd3ea667 LanguageClient: only use BaseSettings in the settings API
Change-Id: Ie2ccda8fe4349f495f31a5d46254b68f6074ac6d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-04-04 08:18:48 +00:00
David Schulz
dac8262aeb LanguageClient: show icon with assigned server names in toolbar
Change-Id: I44ceeb184812a4c48f042a19197c7f0ffd4299f8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-04-03 07:09:59 +00:00
David Schulz
7f348c1878 LanguageClient: Compare expanded arguments for stdio clients
Change-Id: I6b33aa6b3ddb03a1965dbda4e7e1e1724299eba1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-04-02 11:29:47 +00:00
David Schulz
e618b158f8 LanguageClient: return actual settings instead of fallback settings
Change-Id: Ia0734c07ae5894d6c5c3e1f9c78e213f9422b6d8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-04-02 10:53:43 +00:00
David Schulz
a6f0e564d4 LanguageClient: Add option to start server when needed
Until now all servers where startet on creator startup. Change this
default to start server when first file that matches the configured
filter is opened. Additionally add an option that restores the old
behavior of always on servers.

Change-Id: I595e0ede1cf136cc803181377155bcd58ca1a83c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-03-15 11:31:53 +00:00
Eike Ziller
c53ccceff1 Merge remote-tracking branch 'origin/4.9'
Conflicts:
	qbs/modules/qtc/qtc.qbs
	qtcreator.pri
	src/plugins/debugger/debuggerkitinformation.cpp
	src/plugins/languageclient/languageclientmanager.cpp
	src/plugins/plugins.pro
	src/plugins/projectexplorer/kit.cpp
	src/plugins/projectexplorer/kitmanager.cpp

Change-Id: I66fb941202991f35f7d7761430b21e42dfc678a8
2019-03-14 15:51:15 +01:00
David Schulz
bc7134dce5 LanguageClient: Allow macro usage in client settings
Add the macro variable chooser to the name and the arguments of a
server in the settings and expand those values on server startup.

Change-Id: I61b031b8952fff7743e88f1523ed69844a5325d9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-03-14 09:17:34 +00:00
David Schulz
89335266ba LanguageClient: move match function to language filter
Change-Id: I9081d441fa2f48e5a1c5273e2de2620e0b88c4e0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-03-13 12:24:18 +00:00
David Schulz
34de118ee3 LanguageClient: make current settings accessible
Change-Id: Ie56272067a56475b1a61006432dc1fbee4192c9c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-03-13 11:34:02 +00:00
David Schulz
bbbf727272 LanguageClient: fix restart check for stdio clients
Change-Id: I4acb61b48b7ac18423b2e106f1f9ea9b3f7ccb70
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-03-12 13:07:11 +00:00
David Schulz
4420190192 LSP: Visualize server capabilities in settings page
Change-Id: Ib83b8580e9758313285a6145b0925e051268f34b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-02-12 07:12:58 +00:00
David Schulz
93ea656821 LSP: rename BaseClient -> Client
Since BaseClient isn't part of an inheritance hirarchie any more the
Base doesn't make sense now.

Change-Id: I69200b19a22e5a04079e5289a02234af4f56a1bd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-02-04 09:43:22 +00:00
David Schulz
eac1b6059c LSP: separate communication interface and client logic
Change-Id: I7d35fa634287b5f858c4a87aa10f99bf18d1ad07
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-02-04 09:43:11 +00:00
Alessandro Portale
616e19ff9e Fix warning: "Missing emit keyword on signal call"
[-Wclazy-incorrect-emit]

Change-Id: I93bdc6e23cdaccf35c9899ae16870ccc65a54f80
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-01-17 15:54:56 +00:00
Alessandro Portale
d9c05d3d20 Fix warning: "Unused non-trivial variable"
[-Wclazy-unused-non-trivial-variable]

Change-Id: Ia99c3de31fd92205f25624ab60e60370c1aa4538
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: hjk <hjk@qt.io>
2019-01-17 10:55:33 +00:00
Alessandro Portale
b2cea9474c LanguageClient: Modernize
modernize-*

Change-Id: I966de09934b9ba3b0497d1df5744c8c3f826240f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-11-14 08:52:21 +00:00
Eike Ziller
7d3686359a Fix missing translation contexts
Change-Id: I4402157e7991ad0050333a34394b87ff3d6f4a1b
Reviewed-by: Sergey Belyashov <Sergey.Belyashov@gmail.com>
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-10-25 11:46:57 +00:00
Alessandro Portale
5c114a046d LanguageClient: Use FancyLineEdit in MimeTypeDialog
Adds "Filter" as place holder text and a clear icon.

Change-Id: I24641f4f575cb9af059257b7d8806fd8c843d423
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-10-22 05:48:58 +00:00
Christian Stenger
49e65ad582 LSP: Sort available MIME types
Makes it easier to find what you are looking for.

Change-Id: I98d083e908c7144ad6aa81cde888ba531ff0be33
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-10-19 09:01:08 +00:00
David Schulz
170e599a11 LSP: support file pattern filter and multiple mime types for lsp clients
Change-Id: I6d1b6c38d41dfd247c8883e765e5e432dbe53a9e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-10-18 12:00:40 +00:00
David Schulz
77635c0ec9 LSP: warn on non existing language client executables
Change-Id: Ie996f80f4c4d836970f62f1a174bb92967dfb281
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-10-17 10:38:20 +00:00
David Schulz
468dcc67cb LSP: remove unused LanguageChooseDelegate
Change-Id: I1003d96e603789a9c627d5ecffb6051722c0862a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-10-16 08:52:27 +00:00
David Schulz
4a7051213b LSP: Create settings widget based on settings type
Change-Id: I4ecdfa386a33114a9d36d21e02ac5eecd9d8f3b7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-10-16 08:43:48 +00:00
David Schulz
c37bedfb02 LSP: split out settings specific for std io clients
Change-Id: I25eebfc15a9d0d5665e57137f016e54a069ca849
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-10-15 11:51:10 +00:00
Christian Stenger
b30f82d3fb LanguageClient: Sync settings on plugin initialization
Otherwise we might end up starting a second language server
when opening options page of Language Client plugin and
closing again with 'Ok' without modifying any setting.

Change-Id: I2b16436b92a0d622dc7df1b5fbdaf9f9f8e717a2
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-10-15 08:23:01 +00:00
David Schulz
df08e1ee3d LSP: Store settings in the settingspage
... and keep just a copy of it in the model. This way we
can easily reset the setting model content to a preedit state
without rereading it from the user settings file.

Change-Id: Id2f094caade7c56eff48fd9abce00d687e607a39
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-10-11 13:15:04 +00:00
Alessandro Portale
e8f28dbef3 LanguageClient: Add an options icon
Server "can" with speech bubble saying "<>".

Change-Id: I7eca0109aa5917f341f6310c8f175b1833ff9c00
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-10-05 07:42:22 +00:00
David Schulz
f5843a29bc LSP: make fromMap() a non static member function
Change-Id: I24844cae784921e0128f475b792453fa65c566ce
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-09-21 07:36:12 +00:00
David Schulz
dc155b407d LSP: rename LanguageClientSettings -> BaseSettings
And move the static init function to a separate class.

Change-Id: I7c924ce72ad74047e6bfdb04fa04a6132050a360
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-09-20 13:08:16 +00:00
David Schulz
d7b4f3fcf2 LSP: store settings on the heap
In preperation for specialized settings other than the stdio client

Change-Id: I20ca33fd1d714e4e0ca527de86261c0a58740d15
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-09-20 13:08:05 +00:00
David Schulz
1b2ad0e989 LSP: let the settings generate the client
In preperation for settings other than the stdio client.

Change-Id: I11635119db9165163947d822e911ee26ce8548f1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-09-20 13:04:54 +00:00
David Schulz
ba5f93003e LSP: correctly shutdown client that is currently being restarted
Change-Id: I9fb0ccd9aa181515efc9368b0b369dfc39dffcd1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-09-19 10:44:58 +00:00
David Schulz
87381bbf90 LSP: use QtcProcess::splitArgs for language server arguments
Also store the executable and arguments in the stdio client to get a
more accurate comparison of clients.

Change-Id: I84fdd4ea5f32b17198d3f08e7f5d494f7fbe67dc
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-09-11 10:04:52 +00:00
David Schulz
51e3613057 LSP: Use MimeType file filter for language servers
Change-Id: I13e06b5513c64e20590ab4caf15093a201025b94
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-09-10 10:49:48 +00:00
David Schulz
d61d29cf16 Introduce a basic client for the language server protocol
The language server protocol is used to transport language specific
information needed to efficiently edit source files. For example
completion, go to operations and symbol information. These information
are transferred via JSON-RPC. The complete definition can be found under
https://microsoft.github.io/language-server-protocol/specification.

This language server protocol support consists of two major parts, the
C++ representation of the language server protocol, and the client part
for the communication with an external language server.

The TypeScript definitions of the protocol interfaces are transferred to
C++ classes. Those classes have getter and setter for every interface
value. Optional values from the protocol are represented by
Utils::optional<ValueType>. The JSON objects that are used to transfer
the data between client and server are hidden by a specialized
JsonObject class derived from QJsonObject. Additionally this JsonObject
provides a validity check that is capable of creating a detailed error
message for malformed, or at least unexpected JSON representation of the
protocol.

The client is the interface between Qt Creator and language server
functionality, like completion, diagnostics, document and workspace
synchronization. The base client converts the data that is sent from/to
the server between the raw byte array and the corresponding C++ objects.
The transportat layer is defined in a specialized base client (this
initial change will only support stdio language server). The running
clients are handled inside the language client manager, which is also
used to connect global and exclusive Qt Creator functionality to the
clients.

Task-number: QTCREATORBUG-20284
Change-Id: I8e123e20c3f14ff7055c505319696d5096fe1704
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-09-03 08:00:46 +00:00