Commit Graph

37558 Commits

Author SHA1 Message Date
hjk
e20152017c Welcome: Remove one unneeded usage of global object pool
Change-Id: Iaf94a26eb49c49648ac89f7e463b8849e86cba9e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-02-06 13:01:58 +00:00
hjk
713b8636ea Vcs/Text search: Remove a few addAutoReleaseObject uses
Using a QObject parent suffices here.

Change-Id: I4dc5448511d55bf14fbd8f810e91336a49e94094
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-02-06 11:58:15 +00:00
Mitch Curtis
baceadc0fb Position environment variables at the top of the environment widget
This ensures that the user doesn't have to scroll down when they've
added a new environment variable and are editing its value; they'll
be able to see its value as they're typing it.

This improves the situation for most cases, but variables whose names
start with letters later in the alphabet cause them fall within the
"end" of the view's range, making it impossible to position them at
the top of the view.

Task-number: QTCREATORBUG-19715
Change-Id: I1f4b5bd311fa2a45770676ba2af3e254ae936f06
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-02-06 09:06:50 +00:00
Tobias Hunger
e1409ae50f IRunConfiguration: Remove BuildTargetInfo from the RC factory APIs
Change-Id: I1d77d22a1c1ce1cbcfca8af7855ae7b935ac1c2c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2018-02-06 09:01:32 +00:00
hjk
a2d6dc65ff GenericProject: Pimpl and remove uses of global object pool
Change-Id: I2020ab5a72af9dfce5393fa3f91755f914a9e021
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-02-06 07:59:57 +00:00
hjk
6cfde4c2ed RemoteLinux: Pimple and avoid unneeded use of global object pool
Following the now-canonical HelpPlugin pattern...

Change-Id: I2c02b3dee7238da9fb1e3a9b29afb4cd32424cb8
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-02-06 07:54:24 +00:00
hjk
d3eb585db9 Help: Pimpl plugin and avoid use of global object pool
Create a HelpPluginPrivate class, move all previously private
HelpPlugin data and code there.

Make it live from HelpPlugin::initialize() to HelpPlugin destruction,
so it can be used to handle life time of data members automatically,
making use of IPlugin::addAutoRemovedObject unneeded.

Change-Id: I9e381ca20b98f4d9c06687c11b81a64e69ceeb96
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-02-05 12:42:27 +00:00
hjk
126674429f Valgrind: Remove unneeded use of global object pool
Change-Id: If1412703d04e63bf08caaabc83f6a4b9999c5e29
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-02-05 11:09:34 +00:00
hjk
9b3a074438 Nim: Avoid using the global object pool
Use the pattern that's currently being established.

Change-Id: Ib716b35473fe5060b9ba5beea240ed46cfb1c5c7
Reviewed-by: Filippo Cucchetto <filippocucchetto@gmail.com>
Reviewed-by: hjk <hjk@qt.io>
2018-02-05 08:27:45 +00:00
hjk
204d8d141e WinRt: Avoid use of global object pool
Change-Id: I875122569f4e78750993caa11b8635b68d0fc8da
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-02-05 08:05:19 +00:00
hjk
3d79d80557 Macros: Avoid use of global object pool
Change-Id: I84eb19e3e081fd63d390b7ae065c138bb483201f
Reviewed-by: Nicolas Arnaud-Cormos <nicolas@kdab.com>
Reviewed-by: hjk <hjk@qt.io>
2018-02-02 16:39:06 +00:00
hjk
93a5aa9821 BinEditor: Remove the concept of a current editor
Scales better to multiple views with even less bookkeeping.

Change-Id: Iaa91e614466a59af6f2e567e72e59efe14b7612f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2018-02-02 14:40:47 +00:00
hjk
75e71d5997 QmlProfiler: Remove a few uses of ActionManager::instance()
The used functions are static nowadays.

Change-Id: I1c7ce9765fba111fd3104cf151a519fd89818081
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2018-02-02 13:18:27 +00:00
David Schulz
0eb7bab20c Core: make useMacShortcut constexpr
Change-Id: I293b96428784b6efecac6dae4f2f9690af0027da
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-02-02 13:15:55 +00:00
hjk
1611d016a1 Bookmarks: Avoid use of global object pool
Modernize a bit in the process.

Change-Id: I34e71c154b38ede29fc36a25762a515ea6596fb9
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-02-02 12:37:53 +00:00
hjk
289f2b170a CppEditor: Do not add QuickFixFactories to object pool anymore
Not needed anymore.

Also some cleanup, no 'using' in headers etc.

Change-Id: I8c4547d80d0c0ffd989d1efbc74687c9f56096a4
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2018-02-02 12:26:32 +00:00
hjk
c4b3779b42 QbsProjectManager: Cut down visible QbsManager interface a bit
Change-Id: I2c2d50f1ec0c7fdb5e9a629728f8db90cdb43b75
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-02-02 11:27:40 +00:00
hjk
59d2505441 Remove two unneeded uses of ICore::instance()
The functions are static nowadays.

Change-Id: Ic6f6cb9c58319f3b33d8201aefb630b9381b2af3
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-02 07:23:23 +00:00
Ivan Donchevskii
d81580b7a3 Clang: extra clangbackend job to collect full token info
Limit document annotations job to only highlighting data
collection and move more expensive calls into separate job
that runs after it.

Change-Id: Ie792a3f741ac45c81033dd5b3a20ed061604f927
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2018-02-02 07:01:59 +00:00
Ivan Donchevskii
bdd5066665 Clang: introduce more data in TokenInfo
Data added:
- return type spelling for functions
- parent spelling
- access specifier for class fields and methods
- storage class

New highlighting types are added, therefore
types are now categorized by class, struct, etc.

Change-Id: I1739b94a6f777045fde655060d8b9a12b6e0889b
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2018-02-02 07:01:28 +00:00
hjk
730a8186af Core: Compile fix after 974022c77b
Change-Id: Idd26b1da785deec81772dff3134c4c23e63762bb
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2018-02-01 17:07:04 +00:00
Marco Bubke
8b85b095b2 Clang: Rename defineName in macroName
Change-Id: Iaf8da991032e5ed4726384c051290a77887351fa
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-01 14:57:34 +00:00
Marco Bubke
22b5bbbff3 Clang: Add defineName to ProjectPart
We need them later to find out if the defines have changes.

Change-Id: Iaaa14df3dc6f50cb286c2dac37db13c975063c1e
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-01 14:54:49 +00:00
hjk
effa4d830f Core: Remove the now-unused ICore::optionsDialogRequested() signal
Change-Id: I5b712c8f01170d406b2a1e5cb969ff2e4ffe16d4
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-02-01 14:17:30 +00:00
hjk
e712c8b7e2 Core: Replace an in-Core connection by a direct call
Change-Id: Ic219a992658e080467a18d38121a41990cc377ce
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-02-01 13:31:04 +00:00
hjk
974022c77b Core: Reduce code path ping-pong between ICore and MainWindow
Public entry points for displaying settings dialog were in ICore,
diverting to MainWindow, and back in some cases.

Move implementation to icore.cpp instead.

Change-Id: I02cbf1dcfe6241c665d7d701b4b4af1a8a242af5
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-02-01 13:29:58 +00:00
David Schulz
9d8abd9352 Update examples after documentation has changed
Change-Id: I33f944240ccc1618d2fb9f88d133d67b7d77c20e
Reviewed-by: hjk <hjk@qt.io>
2018-02-01 12:20:03 +00:00
hjk
5405fc98e7 ProjectExplorer: Remove a use of ActionManager::instance()
The used function is static nowadays.

Change-Id: I12ccd3429b1b377f004d56585b48ed286ab0edeb
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-02-01 12:07:53 +00:00
Christian Stenger
b039026214 Debugger: Handle double click of sub break points
Double clicking on a child break point (e.g. multi location
break point) now jumps to the respective parent break point.

Change-Id: I93497f8eec78408909dddd159002e171805814d7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2018-02-01 11:30:17 +00:00
hjk
1b87d19a64 Debugger: Modernize
Mostly nullptr instead of 0, but also a few bits of collateral damage.

Change-Id: I921991272aca921dcdecf302dfff3716e79dfc24
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-02-01 10:28:54 +00:00
hjk
7c41720479 Debugger: Allow disabling individual breakpoint locations
... for breakpoints that resolve to multiple locations, like templates.

Toggling is done via the the breakpoint view context menu, for now
only available with GDB and not persistent.

Change-Id: I098ae13a5518e9f671c647680f8bd4413e7e5ccc
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-02-01 10:20:33 +00:00
Eike Ziller
46ad21a796 Merge "Merge remote-tracking branch 'origin/4.6'" 2018-02-01 10:13:42 +00:00
hjk
ae28c1bd67 Debugger: Avoid using addAutoReleasedObject
Not needed anymore for normal operation.

Change-Id: I9e167d28bb45afd8f98d8b0fed6fce183fea32ad
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-02-01 09:59:15 +00:00
Christian Stenger
0bd6f712f0 AutoTest: Access plugin singleton through static functions
It's the more common pattern nowadays, and cheaper.

Change-Id: If6217b2a820fbfa6f088fd9349225f5f8488f593
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-02-01 09:51:54 +00:00
Christian Stenger
56fbeb8a68 AutoTest: Avoid global object pool
Instead of adding internal objects to the global
object pool keep them to handle their destruction.

Change-Id: Ie6217b2a820fbfa6f088fd9349225f5f8488f593
Reviewed-by: hjk <hjk@qt.io>
2018-02-01 09:23:14 +00:00
Eike Ziller
ecb9fae785 Merge remote-tracking branch 'origin/4.6'
Conflicts:
	share/qtcreator/qml-type-descriptions/qmlproject.qmltypes
	src/plugins/clangcodemodel/clangeditordocumentprocessor.cpp

Change-Id: I35fb652f29a98a798be7c8b4b4c2e581eb175fb6
2018-02-01 09:58:36 +01:00
Eike Ziller
88d65af7d3 ModelEditor: Do not needlessly add objects to the global pool
Change-Id: I27e0d0fbab934ba8effe78c8617c6f2305b4047f
Reviewed-by: hjk <hjk@qt.io>
2018-01-31 19:06:37 +00:00
Thomas Hartmann
f2e6fc9560 QmlDesigner: Add keyframe support to property editor
This patch allows to insert key frames if a timeline is present.

Change-Id: I39c8281e5e559a838ad61939d3f2db7c6abcf76b
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-01-31 16:42:05 +00:00
Tim Jenssen
e61ec82b09 QmlDesigner: improve setupContext calls
There was a massive slow down if the clippboard
contained a complex qml element.

Change-Id: I7b17cc9eab39bade6f2a0ec2f66c2dd2a6279e2d
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2018-01-31 16:20:01 +00:00
Christian Kandeler
6b29198874 SerialTerminal: Add qbs project file
Change-Id: Ic9b65d09424f0f28f58181d3da526127800c4d45
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-01-31 14:57:36 +00:00
hjk
a728b790ad Debugger: Allow breakpoint items to be collapsed
Change-Id: Ia525e0c0259d6ea9578734c6ce12ed4178685ddf
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-01-31 14:53:30 +00:00
Vikas Pachdha
61511cd06b Android: Fix crash when creating new project
enableChanged is redundant for updating gradle settings.

Task-number: QTCREATORBUG-19652
Change-Id: I3352d3b56caf742f7f034b3bf106cfb361c1f869
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-31 07:54:38 +00:00
hjk
4c52129ea7 Make serialterminal plugin compilation depend on QtSerialPort presence
Change-Id: I49b7efba96f220924d493a45fd076f12a9465e31
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-01-31 07:35:30 +00:00
hjk
406f964993 Debugger: Fix typo leading to wrong settings behavior
Change-Id: I352346c5b1c644ccba46fd573e31f3f03877de26
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-01-31 07:19:52 +00:00
Christian Stenger
b0b2859fe8 SerialTerminal: Fix compile for Qt less than 5.8
Change-Id: Icaa48d92d75bdd669bc6e4184568bfcf92cc768c
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2018-01-31 06:33:04 +00:00
hjk
4c285f957b Core: Move left navigation view toggle button back to the left
Change-Id: I3f2070c6f6633b851c88d9179a4a97be1c944a7a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-01-30 15:30:14 +00:00
hjk
be3f5123d6 Core: Use a ModeManagerPrivate::appendMode(IMode *)
... instead of adding-by-index. This amends 3d2db474.

Also, simplify the shortcut setting, the loop is not needed
anymore as the mode order is fixed now.

Change-Id: I87959f8b5bc5c3a0cd0ca240fb8709db75aed105
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-01-30 13:39:51 +00:00
Benjamin Balga
b386eae888 Plugins: new serial terminal plugin
Plugin adding serial terminals in the output pane.

Change-Id: I75d0f69f8d90268ff774e4eae30e36eda022d3aa
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2018-01-30 13:35:19 +00:00
David Schulz
43f02573df Debugger: Use shared TerminalRunner also for CDB
Task-number: QTCREATORBUG-19633
Change-Id: Ic16335de1c5e57da7d9253772bad9e4ade1db926
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-01-30 11:20:45 +00:00
hjk
7ab872ce6a Android: Remove dependency on plugin object pool
Change-Id: Ic6908cca581a0d6155c8c43c86163347ca578a4c
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2018-01-30 10:21:18 +00:00