This still fixes the parsing issue when switching build configurations,
but the code is simpler.
Change-Id: I5748788224c5b49399550c33bcef592f193cfa8a
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
If one enables the plugin it would be most likely to have the
parsing (and related short cuts) enabled as well without the
need to open the navigation widget or results pane.
Change-Id: Ie0624713677bcae67492ac99d25519cc5cfab4a9
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
This avoids displaying the progress indicator if reparsing the
current document while editing in _most_ cases.
Change-Id: I6b6181e5bda1644367b8dc7576c152d5d6962a71
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
Similar variables don't contain "Configuration" in their names. For
example: CurrentBuild:Name.
+ make it available globally.
Change-Id: Ie094e2f7afc449d678cf0afec1548350f03ead77
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
If the document gets updated while typing we can get different
results when fetching the content and using positions inside the
content which might have updated milliseconds later.
Beside fetching only once ensure valid parse results by adding an
additional check for the used visitor.
Change-Id: Id1ba4a139a4dc497be0fbb5cf1f81004f3f8676c
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
This way the help viewers can coexist and the building against a
version of Qt that has both webkit and webengine available doesn't
fail anymore.
Change-Id: I2de00b03fc7b127899cbf90b91fc2cfb090a47a5
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
Broke after 0a89b89065
Correct fix seems to me to avoid the whole menu.
Change-Id: I59f1eb859c9045fc5ae9ac1b377b7e69b29af7ae
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
We will update them, so having them sorted is better for finding
duplicates.
Change-Id: I1159ed1f1fce1275d630935a297e85787947ba61
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Braces all over the place since the tool does not respect the coding
style and cppdoxygen.cpp was changed with regard to the braces coding
style in the meantime:
commit 29a93998df
Remove braces for single lines of conditions
Next step is to use the tool for updating the qdoc/doxygen keywords.
Change-Id: Ib95b5991ebd794d144848ae052fa7f28a6d10850
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
...as src/tools/cplusplus-keywordgen so it will not get lost. Taken from
[1] in its current revision (e7831d6).
The utility generates code that classifies identifers/keywords. Most
probably the following files from Qt Creator were generated by it or are
at least based on its output:
src/libs/3rdparty/cplusplus/Keywords.cpp
src/libs/3rdparty/cplusplus/ObjectiveCTypeQualifiers.cpp
src/libs/glsl/glslkeywords.cpp
src/plugins/cpptools/cppdoxygen.cpp
We will use the utility to update the known qdoc/doxygen keywords. The
clang code model will also profits from this.
[1] https://github.com/robertoraggi/cplusplus/blob/master/tools/kwgen.cpp
Change-Id: I604f2028d32fd9a48bd6f84bef7264b6d2beed7d
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
This change makes arrows in e.g. ComboBoxes themable. This also improves
the clear distinction between enabled and disabled state.
Change-Id: If40dcd3e162ad71d1bc6507c047203aa60e09ee6
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
Creator can't be built with Qt 5.4 anymore.
Change-Id: Ic3c014e8384c72c10a48c65117c53daecaa683ab
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
This spells trouble as dock widgets which have a native window will
assume they should be positioned relative to the outermost native
window then.
Change-Id: I5a8ce5870afacaabe26d4a2d7ac53ffee09328ed
Task-number: QTCREATORBUG-15844
Reviewed-by: hjk <hjk@theqtcompany.com>
There are two versions of startOfOperator:
* InternalCppCompletionAssistProcessor::startOfOperator
* ClangCompletionAssistProcessor::startOfOperator
The latter started as a copy of the former, but the former got some bug
fixes in the meantime. Adjust both versions to each other, so it's easy
to diff them and to extract the duplication in a follow-up change.
Change-Id: Icf48386bf1ad0fa473bec476c5412be9b1890139
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
For assist processors that run in a worker thread, the QTextDocument is
recreated with AssistInterface::prepareForAsyncUse and
AssistInterface::recreateTextDocument.
Since some assist processors (C++, QmlJS) rely on the user states of the
QTextBlocks, these must be recreated, too.
In the referenced bug report the lexer state (user state) of the
previous QTextBlock was invalid and thus the "Doxygen tag completion"
failed.
Task-number: QTCREATORBUG-9373
Change-Id: If668e98aa6f9fe9fc107c7476fc831e92a0d7572
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
There are three cases that must be handled:
1. Completion in C++ style comment
2. Completion in first line of a C style comment
3. Completion in non-first line of a C style comment
This change fixes case 1 + 2. Case 3 will be addressed in a follow-up
change, same goes for the duplication.
Task-number: QTCREATORBUG-15143
Change-Id: I449711f965ddcbbe6158870a8a5ae33218e0d238
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
...for "flat" themes.
Also, a small HighDPI fix for the non-flat variant.
Change-Id: I5ae401bd59627a957f621e1111b2ab277127b2b5
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
It makes no sense to not parse if we never parsed before. This got
broken when I tried to reduce the number of cmake runs.
Change-Id: Id70a6550faf248cc983b61f6d2456a93d8454a50
Task-number: QTCREATORBUG-15927
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
CMake will silently ignore all but the last target (or fail to build
anything). This allows to simplify our code.
Change-Id: Ieee3931aca0788307107e2021d507073ef42a21f
Task-number: QTCREATORBUG-15928
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
Only default to first entry when the pattern was never set.
Change-Id: I4d2a76218347adb4aa28ef3e8fd0e81485faf184
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
...otherwise we might run into the following assertion:
Assertion failed: (IncludeBriefComments ==
this->IncludeBriefCommentsInCodeCompletion), function CodeComplete, file
ASTUnit.cpp, line 2411.
Change-Id: I4723b600c7ac5aa2b4c1cb1827f51156afb492b8
Reviewed-by: Erik Verbruggen <erik.verbruggen@theqtcompany.com>
The default target of clang.exe might be unfavorable since it depends on
e.g. the tool chain used to build clang.exe:
default target
clang build with msvc: i686-pc-windows-msvc
clang build with mingw: i686-pc-windows-gnu
The correct target is important since it not only has implications on
the built-in macros and include paths, but also on parsing options. For
example, the msvc target silently adds the following parsing options
-fms-extensions
-fms-compatibility
-fms-compatibility-version=17.00
-fdelayed-template-parsing
...as can be seen by the output of
$ clang.exe -### empty.cpp
Change-Id: Icd8aaf11016e59f37025cbf1c97da81511ff249b
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
The target triple will be used by the Clang Static Analyzer.
Change-Id: Ibf33fef286a4d3ad3f40be4d6d5c9f35881d3d46
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
- Add and remove screen shots
- Remove info about an obsolete wizard
- Add information about using wizards to create CMake projects
- Describe new fields in the Kits tab
- Describe the new build settings
Change-Id: I156e3b1a6cb35a284da5e25eabb134cc52b4d84e
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
With Qt 5.7 the currentChanged() callback is called immediately on
QTreeView::setModel(), which leads to the label text being set. That
crashes if the label hasn't been created, yet.
Change-Id: I73763e1ac1c86215090a8f4b0118bc0cd286cf47
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Since StyleHelper::baseColor now returns a themed color and
QColor::lighter() lightens up dark colors relatively little, we should
to use a themed color for the background instead.
Task-number: QTCREATORBUG-15930
Change-Id: I256ddcf946a14af6937c324a76e3f3a24919ae3b
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
